Francesco Romani has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38766
To unsubscribe, visit https://gerrit.ov
Francesco Romani has posted comments on this change.
Change subject: ceph: Validate network disk parameters
..
Patch Set 2: Code-Review-1
(1 comment)
fine with the concept, but one c/p error slipped inside. -1 for visibility.
Francesco Romani has posted comments on this change.
Change subject: ceph: Support hotunplug of network disks
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38804
To unsubscribe, visit https://gerrit.
Francesco Romani has posted comments on this change.
Change subject: virt: Use Drive.diskType instead of networkDev and blockDev
..
Patch Set 4: Code-Review+1
(1 comment)
the patch looks good. I have concerns about disks being
Ido Barkan has posted comments on this change.
Change subject: network: wait for udev after configuring SRIOV
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/40400/6/vdsm/network/api.py
File vdsm/network/api.py:
Line
Francesco Romani has posted comments on this change.
Change subject: ceph: Support authentication using libvirt secrets
..
Patch Set 2:
(1 comment)
looks ok except for one typo inside
https://gerrit.ovirt.org/#/c/40505/2/vdsm
automat...@ovirt.org has posted comments on this change.
Change subject: network: wait for udev after configuring SRIOV
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
mooli tayer has posted comments on this change.
Change subject: python3: fix forgotten python2-ish syntax
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40511
To unsubscribe, visit https://gerrit.ovir
Nir Soffer has posted comments on this change.
Change subject: ceph: Validate network disk parameters
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/40477/2/tests/vmStorageTests.py
File tests/vmStorageTests.py:
Line
Federico Simoncelli has posted comments on this change.
Change subject: spec: Require libvirt-python supporting blockCopy
..
Patch Set 7:
They're not hidden, they're attached to the code that actually needs that new
requiremen
Nir Soffer has posted comments on this change.
Change subject: ceph: Support authentication using libvirt secrets
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/40505/2/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vds
Nir Soffer has posted comments on this change.
Change subject: virt: Use Drive.diskType instead of networkDev and blockDev
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/40472/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Yaniv Bronhaim has posted comments on this change.
Change subject: netlink: fix PEP8 missing line in netlink memory leak patch
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40488
To unsubscribe, visi
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: netlink: fix PEP8 missing line in netlink memory leak patch
..
netlink: fix PEP8 missing line in netlink memory leak patch
Change-Id: I659123c9e1f18e6e
automat...@ovirt.org has posted comments on this change.
Change subject: netlink: fix PEP8 missing line in netlink memory leak patch
..
Patch Set 2:
* Update tracker::#1158108::OK
* Check TR::#1158108::OK
* Set MODIFIED::bug 11
Martin Polednik has posted comments on this change.
Change subject: vmdevices: move storage methods to storage module
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/40133/4/vdsm/virt/vmdevices/storage.py
File vdsm/vi
Federico Simoncelli has posted comments on this change.
Change subject: storage: Make Image.__chainSizeCalc public
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38995
To unsubscribe, visit https://ge
automat...@ovirt.org has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 2:
* Update tracker::#970711::OK
* Check Bug-Url::OK
* Check Public Bug::#970711::OK, public bug
Francesco Romani has posted comments on this change.
Change subject: vmdevices: move storage methods to storage module
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/40133/4/vdsm/virt/vmdevices/storage.py
File vdsm/
Shahar Havivi has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/40103
To unsubscribe, visit https://gerrit.ov
Ondřej Svoboda has posted comments on this change.
Change subject: models, configurators: replace the internal 'async' flag with
blockingdhcp
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/40456/3/vdsm/network/confi
Federico Simoncelli has posted comments on this change.
Change subject: storage: Make Image.__chainSizeCalc public
..
Patch Set 5: -Code-Review
Actually now that I think of it... how can you reuse this in SDM if it uses the
ol
Federico Simoncelli has posted comments on this change.
Change subject: storage: Make StorageDomain._getRepoPath public
..
Patch Set 4:
Also this one implies that from SDM you would use the old objects. We probably
need to dis
automat...@ovirt.org has posted comments on this change.
Change subject: migration: split update from getStat
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has uploaded a new change for review.
Change subject: virt: use only SourceThread.stop()
..
virt: use only SourceThread.stop()
the migration orchestration code used
to change the SourceThread.status from the out
Francesco Romani has uploaded a new change for review.
Change subject: migration: split update from getStat
..
migration: split update from getStat
Currently, migration.SourceThread.getStat() does two different, although
related
automat...@ovirt.org has posted comments on this change.
Change subject: migration: make stop() update internal status
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Francesco Romani has uploaded a new change for review.
Change subject: migration: make SourceThread.status private
..
migration: make SourceThread.status private
The status field should never be accessed directly anymore,
the ge
automat...@ovirt.org has posted comments on this change.
Change subject: virt: do not use status after getStat()
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
automat...@ovirt.org has posted comments on this change.
Change subject: migration: return a copy of the internal status
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
Francesco Romani has uploaded a new change for review.
Change subject: migration: fix spacing
..
migration: fix spacing
Change-Id: I8daf550fb1241872e2a0e5e7e8f0582402e03c04
Signed-off-by: Francesco Romani
---
M vdsm/virt/migrat
automat...@ovirt.org has posted comments on this change.
Change subject: lib: add the response.success() helper
..
Patch Set 17:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
Francesco Romani has uploaded a new change for review.
Change subject: migration: return a copy of the internal status
..
migration: return a copy of the internal status
migration.SourceThread.getStat() used to return a referenc
Francesco Romani has uploaded a new change for review.
Change subject: virt: do not use status after getStat()
..
virt: do not use status after getStat()
the getStat() method already provide an up to date status of the
migration
Francesco Romani has uploaded a new change for review.
Change subject: migration: make stop() update internal status
..
migration: make stop() update internal status
The SourceThread.stop() operation should update
the internal s
automat...@ovirt.org has posted comments on this change.
Change subject: migration: fix spacing
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U
automat...@ovirt.org has posted comments on this change.
Change subject: migration: make SourceThread.status private
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: virt: use only SourceThread.stop()
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
automat...@ovirt.org has posted comments on this change.
Change subject: migration: use the response module
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
Ondřej Svoboda has posted comments on this change.
Change subject: models, configurators: replace the internal 'async' flag with
blockingdhcp
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/40456/3/vdsm/network/confi
automat...@ovirt.org has posted comments on this change.
Change subject: migration: add MIGRATION_STATUS enumeration
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has uploaded a new change for review.
Change subject: migration: add MIGRATION_STATUS enumeration
..
migration: add MIGRATION_STATUS enumeration
Use constants for migration status messages.
Change-Id: I0c311e91
Martin Sivák has posted comments on this change.
Change subject: Fix the CPU quota MOM policy computations
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40311
To unsubscribe, visit https://gerrit.ovirt.
Francesco Romani has posted comments on this change.
Change subject: migration: split update from getStat
..
Patch Set 1: Code-Review-1
may not be a good idea after all.
--
To view, visit https://gerrit.ovirt.org/40524
To uns
Ramesh N has posted comments on this change.
Change subject: gluster: Adds a new element 'additionalFeatures' to getVdsCaps.
..
Patch Set 5: Code-Review-1
Please don't merge until engine patch is getting to a conclusion.
--
T
Martin Polednik has uploaded a new change for review.
Change subject: storage: remove direct path legacy drive detection
..
storage: remove direct path legacy drive detection
The comment in code stated:
Backward compatibility fo
automat...@ovirt.org has posted comments on this change.
Change subject: storage: remove direct path legacy drive detection
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
Francesco Romani has posted comments on this change.
Change subject: storage: remove direct path legacy drive detection
..
Patch Set 1: Code-Review+1
let's make some enemies.
--
To view, visit https://gerrit.ovirt.org/40528
T
Dan Kenigsberg has posted comments on this change.
Change subject: models, configurators: replace the internal 'async' flag with
blockingdhcp
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/40456/3/vdsm
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: Add systemd_run command modifier
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40239
To unsubscribe, visit https://gerrit.ovi
automat...@ovirt.org has posted comments on this change.
Change subject: periodic: simplify per_vm_operation
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, vis
Dan Kenigsberg has submitted this change and it was merged.
Change subject: periodic: simplify per_vm_operation
..
periodic: simplify per_vm_operation
per_vm_operation was added, as helper, together with
_dispatched_operation,
Dan Kenigsberg has posted comments on this change.
Change subject: periodic: simplify per_vm_operation
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40327
To unsubscribe, visit https://gerrit.ovirt.o
Dan Kenigsberg has submitted this change and it was merged.
Change subject: periodic: improve isolation in VM dispatching
..
periodic: improve isolation in VM dispatching
Make VmDispatcher more robust:
1. add try/except block
Dan Kenigsberg has posted comments on this change.
Change subject: periodic: improve isolation in VM dispatching
..
Patch Set 6: Code-Review+2
Unhappily approving - I hope customers would not ignore these ERRORs in the log.
--
automat...@ovirt.org has posted comments on this change.
Change subject: periodic: improve isolation in VM dispatching
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
automat...@ovirt.org has posted comments on this change.
Change subject: vm: disappeared domain are not ready for commands
..
Patch Set 33:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
-
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: disappeared domain are not ready for commands
..
vm: disappeared domain are not ready for commands
It is possible that isDomainReadyForCommands rac
Dan Kenigsberg has posted comments on this change.
Change subject: vm: disappeared domain are not ready for commands
..
Patch Set 32: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/39370
To unsubscribe, visit https:/
Martin Polednik has posted comments on this change.
Change subject: virt: rename SampleVMs for clarity
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40370
To unsubscribe, visit https://gerrit.ovirt.o
Dan Kenigsberg has posted comments on this change.
Change subject: virt: rename SampleVMs for clarity
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40370
To unsubscribe, visit https://gerrit.ovirt.or
Ido Barkan has posted comments on this change.
Change subject: api: support multiple 'ipv6addrs' per network
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39307
To unsubscribe, visit https://gerrit.o
Ido Barkan has posted comments on this change.
Change subject: api: support multiple 'ipv6addrs' per network
..
Patch Set 3: -Code-Review
--
To view, visit https://gerrit.ovirt.org/39307
To unsubscribe, visit https://gerrit.ov
Sandro Bonazzola has posted comments on this change.
Change subject: utils: Add systemd_run command modifier
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40239
To unsubscribe, visit https://gerrit.ovir
Sandro Bonazzola has posted comments on this change.
Change subject: storageServer: Run glusterfs in its own cgroup
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/40240
To unsubscribe, visit https://gerr
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: statscache: more robust remove()
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
Sandro Bonazzola has posted comments on this change.
Change subject: gluster: fix volume name parsing in getVmVolumeInfo
..
Patch Set 1: Verified+1 Code-Review+1
--
To view, visit https://gerrit.ovirt.org/36237
To unsubscribe,
Sandro Bonazzola has posted comments on this change.
Change subject: virt: enable libgfapi with snapshot support
..
Patch Set 3: Verified+1 Code-Review+1
--
To view, visit https://gerrit.ovirt.org/33768
To unsubscribe, visit h
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: statscache: more robust remove()
..
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/40439/6/vdsm/virt/sampling.py
File vdsm/virt/
automat...@ovirt.org has posted comments on this change.
Change subject: virt: rename SampleVMs for clarity
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: rename SampleVMs for clarity
..
virt: rename SampleVMs for clarity
SampleVMs is a bad name. Change it
to VMBulkSampler, which is a bit more expli
Martin Polednik has posted comments on this change.
Change subject: storage: remove direct path legacy drive detection
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40528
To unsubscribe, visit https://g
Dan Kenigsberg has posted comments on this change.
Change subject: vmdevices: move storage methods to storage module
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/40133/4/vdsm/virt/vmdevices/storage.py
File vdsm/vi
Francesco Romani has abandoned this change.
Change subject: vm: move stats_cache cleaning in Vm._cleanup()
..
Abandoned
merged in 40439
--
To view, visit https://gerrit.ovirt.org/40398
To unsubscribe, visit https://gerrit.ovi
automat...@ovirt.org has posted comments on this change.
Change subject: vm: move stats_cache cleaning in Vm._cleanup()
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/403
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: statscache: more robust remove()
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
automat...@ovirt.org has posted comments on this change.
Change subject: periodic: virt: do not poll storage in migrations
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: more detailed stale sampling reporting
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Shahar Havivi has uploaded a new change for review.
Change subject: v2v: Add allocation type for disk conversion
..
v2v: Add allocation type for disk conversion
Change-Id: Ibd3ca2983455adbb51f11957e0ce042b0cfc5ef1
Signed-off-by:
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: Add allocation type for disk conversion
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Dan Kenigsberg has posted comments on this change.
Change subject: vmdevices: move storage methods to storage module
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40133
To unsubscribe, visit https://
automat...@ovirt.org has posted comments on this change.
Change subject: storage: remove direct path legacy drive detection
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org
Martin Polednik has abandoned this change.
Change subject: storage: remove direct path legacy drive detection
..
Abandoned
Not possible, we still need to support this.
--
To view, visit https://gerrit.ovirt.org/40528
To unsub
automat...@ovirt.org has posted comments on this change.
Change subject: vm payload: Add Joliet FS support
..
Patch Set 1:
* Update tracker::#1205058::OK
* Check Bug-Url::OK
* Check Public Bug::#1205058::OK, public bug
* Check
Eldan Shachar has uploaded a new change for review.
Change subject: vm payload: Add Joliet FS support
..
vm payload: Add Joliet FS support
Current payload ISO only uses Rock Ridge extension, as a result
Windows VMs can't use pay
automat...@ovirt.org has posted comments on this change.
Change subject: network: no need to log when network persistence path doesn't
exist.
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no
Ido Barkan has abandoned this change.
Change subject: network: better logging on network restoration.
..
Abandoned
restore-net-cleanup is a better direction
--
To view, visit https://gerrit.ovirt.org/39214
To unsubscribe, vis
Ido Barkan has abandoned this change.
Change subject: rename variables to be consistent in vdsm-restore-net-config
..
Abandoned
restore-net-cleanup is a better direction
--
To view, visit https://gerrit.ovirt.org/39215
To uns
automat...@ovirt.org has posted comments on this change.
Change subject: rename variables to be consistent in vdsm-restore-net-config
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit
automat...@ovirt.org has posted comments on this change.
Change subject: network: better logging on network restoration.
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/39
automat...@ovirt.org has posted comments on this change.
Change subject: net: simplify _find_nets_with_available_devices algorithm.
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fo
Ido Barkan has uploaded a new change for review.
Change subject: network: move NET_LOGICALNET_CONF_BACK_DIR to ifcfg
..
network: move NET_LOGICALNET_CONF_BACK_DIR to ifcfg
It is not used elsewhere.
Change-Id: Ic9da7203d319879ab
automat...@ovirt.org has posted comments on this change.
Change subject: net: clearer log for unavailable bonds
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
automat...@ovirt.org has posted comments on this change.
Change subject: network: factor out method from unified restoration logic.
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fo
Ido Barkan has uploaded a new change for review.
Change subject: net: factor out _find_bonds_with_available_nics
..
net: factor out _find_bonds_with_available_nics
Aiming to break _filter_nets_bonds apart so it will be simpler a
automat...@ovirt.org has posted comments on this change.
Change subject: net: factor out _find_bonds_with_available_nics
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
Dima Kuznetsov has posted comments on this change.
Change subject: utils: Add systemd_run command modifier
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40239
To unsubscribe, visit https://gerrit.ovi
automat...@ovirt.org has posted comments on this change.
Change subject: net: factor out _find_nets_with_available_devices.
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
Ido Barkan has uploaded a new change for review.
Change subject: net: simplify _find_nets_with_available_devices algorithm.
..
net: simplify _find_nets_with_available_devices algorithm.
Continue statements mad this algorithm a b
automat...@ovirt.org has posted comments on this change.
Change subject: network: move NET_LOGICALNET_CONF_BACK_DIR to ifcfg
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, ma
1 - 100 of 236 matches
Mail list logo
