Dan Kenigsberg has posted comments on this change.
Change subject: spec: Require libvirt-python supporting blockCopy
..
Patch Set 7:
please introduce this change in the spec with the code that actually needs it.
--
To view, v
Nir Soffer has posted comments on this change.
Change subject: python3: avoid python3-inconsistent syntax
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/40215/3/Makefile.am
File Makefile.am:
Line 134: if [ -x
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: statscache: more robust remove()
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40439
To unsubscribe, visit https://gerrit.
Eldan Shachar has posted comments on this change.
Change subject: vm payload: Add Joliet FS support
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40534
To unsubscribe, visit https://gerrit.ovirt.org/set
Eldan Shachar has posted comments on this change.
Change subject: vm payload: Add Joliet FS support
..
Patch Set 2:
verified by 1. sanity - use a payload with a long file name and make sure it's
not displayed properly on windo
Dan Kenigsberg has posted comments on this change.
Change subject: python3: avoid python3-inconsistent syntax
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/40215/3/Makefile.am
File Makefile.am:
Line 134: if [
Dan Kenigsberg has posted comments on this change.
Change subject: python3: avoid python3-inconsistent syntax
..
Patch Set 4: Code-Review-1
marking with -1 for visibility
--
To view, visit https://gerrit.ovirt.org/40215
To un
Ido Barkan has posted comments on this change.
Change subject: network: restore sriov devices number of vfs
..
Patch Set 12: Code-Review-1
we need to write only to runningConfig and drop the checkConnectivity behavior.
setSafe
Dan Kenigsberg has posted comments on this change.
Change subject: network: wait for udev after configuring SRIOV
..
Patch Set 7: Code-Review+1
horrible sleep, but reasonable as a stop-gap.
--
To view, visit https://gerrit.ov
Nir Soffer has posted comments on this change.
Change subject: vmdevices: move storage methods to storage module
..
Patch Set 4: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/40133/4/vdsm/virt/vmdevices/storage.py
Fi
Francesco Romani has posted comments on this change.
Change subject: v2v: Add allocation type for disk conversion
..
Patch Set 1: Code-Review+1
scrap my previous comment.
--
To view, visit https://gerrit.ovirt.org/40533
To un
Francesco Romani has posted comments on this change.
Change subject: v2v: add format for disk conversion
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40343
To unsubscribe, visit https://gerrit.ovirt
Francesco Romani has posted comments on this change.
Change subject: v2v: Add allocation type for disk conversion
..
Patch Set 1:
(1 comment)
codewise looks fine, we just need a bit more context
https://gerrit.ovirt.org/#/c/4
Francesco Romani has posted comments on this change.
Change subject: v2v: cleanup v2v directory leftovers
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39789
To unsubscribe, visit https://gerrit.ovi
Darshan N has posted comments on this change.
Change subject: gluster: verbs to enable/disable snapshot scheduling.
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/40141
To unsubscribe, visit https://gerr
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: verbs to enable/disable snapshot scheduling.
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: verbs to enable/disable snapshot scheduling.
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Dan Kenigsberg has abandoned this change.
Change subject: netconfpersistence: refactor _getConfig and _clearDisk
..
Abandoned
https://gerrit.ovirt.org/40415
--
To view, visit https://gerrit.ovirt.org/37418
To unsubscribe, vis
automat...@ovirt.org has posted comments on this change.
Change subject: netconfpersistence: refactor _getConfig and _clearDisk
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: no need to log when network persistence path doesn't
exist.
..
network: no need to log when network persistence path doesn't exist.
When Runn
automat...@ovirt.org has posted comments on this change.
Change subject: network: no need to log when network persistence path doesn't
exist.
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, n
automat...@ovirt.org has posted comments on this change.
Change subject: network: no need to log when network persistence path doesn't
exist.
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no
Dan Kenigsberg has posted comments on this change.
Change subject: network: no need to log when network persistence path doesn't
exist.
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40415
To unsubsc
Dan Kenigsberg has posted comments on this change.
Change subject: network: no need to log when network persistence path doesn't
exist.
..
Patch Set 2:
I must remind you of your own comment to
https://gerrit.ovirt.org/#/c/374
Darshan N has posted comments on this change.
Change subject: gluster: revamp in geo-replication status and list verbs.
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/39910
To unsubscribe, visit https://
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: revamp in geo-replication status and list verbs.
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fou
automat...@ovirt.org has posted comments on this change.
Change subject: utils: Add systemd_run command modifier
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: Add systemd_run command modifier
..
utils: Add systemd_run command modifier
Using new cmdutils.systemd_run, you can modify a command so it will
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Add systemd_run command modifier
..
Patch Set 1: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/40239
To unsubscribe, visit https://g
Federico Simoncelli has posted comments on this change.
Change subject: monitor: return whether the reported status is actual
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38874
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: monitor: return whether the reported status is actual
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38874
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: network: do not try to clean running configuration
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
Ido Barkan has uploaded a new change for review.
Change subject: net: factor out _find_nets_with_available_devices.
..
net: factor out _find_nets_with_available_devices.
Aiming to simplify _filter_nets_bonds.
Change-Id: I4e1ea8
automat...@ovirt.org has posted comments on this change.
Change subject: net: factor out _find_nets_with_available_devices.
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
Ido Barkan has uploaded a new change for review.
Change subject: net: simplify _find_nets_with_available_devices algorithm.
..
net: simplify _find_nets_with_available_devices algorithm.
Continue statements mad this algorithm a b
automat...@ovirt.org has posted comments on this change.
Change subject: network: move NET_LOGICALNET_CONF_BACK_DIR to ifcfg
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, ma
Ido Barkan has uploaded a new change for review.
Change subject: net: clearer log for unavailable bonds
..
net: clearer log for unavailable bonds
Change-Id: If246adb72fca1e1dc8415dfa528c8b158773a2f8
Signed-off-by: Ido Barkan
--
Ido Barkan has uploaded a new change for review.
Change subject: net: factor out _find_bonds_with_available_nics
..
net: factor out _find_bonds_with_available_nics
Aiming to break _filter_nets_bonds apart so it will be simpler a
automat...@ovirt.org has posted comments on this change.
Change subject: net: factor out _find_bonds_with_available_nics
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
Dima Kuznetsov has posted comments on this change.
Change subject: utils: Add systemd_run command modifier
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40239
To unsubscribe, visit https://gerrit.ovi
Ido Barkan has uploaded a new change for review.
Change subject: network: factor out method from unified restoration logic.
..
network: factor out method from unified restoration logic.
Change-Id: Iecc95718ac1755799884c7b124a832
Ido Barkan has uploaded a new change for review.
Change subject: network: do not try to clean running configuration
..
network: do not try to clean running configuration
This small optimization was also the behavior before this
automat...@ovirt.org has posted comments on this change.
Change subject: net: clearer log for unavailable bonds
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
automat...@ovirt.org has posted comments on this change.
Change subject: network: factor out method from unified restoration logic.
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fo
automat...@ovirt.org has posted comments on this change.
Change subject: net: simplify _find_nets_with_available_devices algorithm.
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fo
Ido Barkan has uploaded a new change for review.
Change subject: network: move NET_LOGICALNET_CONF_BACK_DIR to ifcfg
..
network: move NET_LOGICALNET_CONF_BACK_DIR to ifcfg
It is not used elsewhere.
Change-Id: Ic9da7203d319879ab
Ido Barkan has abandoned this change.
Change subject: network: better logging on network restoration.
..
Abandoned
restore-net-cleanup is a better direction
--
To view, visit https://gerrit.ovirt.org/39214
To unsubscribe, vis
Ido Barkan has abandoned this change.
Change subject: rename variables to be consistent in vdsm-restore-net-config
..
Abandoned
restore-net-cleanup is a better direction
--
To view, visit https://gerrit.ovirt.org/39215
To uns
automat...@ovirt.org has posted comments on this change.
Change subject: rename variables to be consistent in vdsm-restore-net-config
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit
automat...@ovirt.org has posted comments on this change.
Change subject: network: better logging on network restoration.
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/39
automat...@ovirt.org has posted comments on this change.
Change subject: network: no need to log when network persistence path doesn't
exist.
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no
Eldan Shachar has uploaded a new change for review.
Change subject: vm payload: Add Joliet FS support
..
vm payload: Add Joliet FS support
Current payload ISO only uses Rock Ridge extension, as a result
Windows VMs can't use pay
automat...@ovirt.org has posted comments on this change.
Change subject: vm payload: Add Joliet FS support
..
Patch Set 1:
* Update tracker::#1205058::OK
* Check Bug-Url::OK
* Check Public Bug::#1205058::OK, public bug
* Check
Martin Polednik has abandoned this change.
Change subject: storage: remove direct path legacy drive detection
..
Abandoned
Not possible, we still need to support this.
--
To view, visit https://gerrit.ovirt.org/40528
To unsub
automat...@ovirt.org has posted comments on this change.
Change subject: storage: remove direct path legacy drive detection
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org
Dan Kenigsberg has posted comments on this change.
Change subject: vmdevices: move storage methods to storage module
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40133
To unsubscribe, visit https://
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: Add allocation type for disk conversion
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Shahar Havivi has uploaded a new change for review.
Change subject: v2v: Add allocation type for disk conversion
..
v2v: Add allocation type for disk conversion
Change-Id: Ibd3ca2983455adbb51f11957e0ce042b0cfc5ef1
Signed-off-by:
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: more detailed stale sampling reporting
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: periodic: virt: do not poll storage in migrations
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: statscache: more robust remove()
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
Francesco Romani has abandoned this change.
Change subject: vm: move stats_cache cleaning in Vm._cleanup()
..
Abandoned
merged in 40439
--
To view, visit https://gerrit.ovirt.org/40398
To unsubscribe, visit https://gerrit.ovi
automat...@ovirt.org has posted comments on this change.
Change subject: vm: move stats_cache cleaning in Vm._cleanup()
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/403
Dan Kenigsberg has posted comments on this change.
Change subject: vmdevices: move storage methods to storage module
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/40133/4/vdsm/virt/vmdevices/storage.py
File vdsm/vi
Martin Polednik has posted comments on this change.
Change subject: storage: remove direct path legacy drive detection
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40528
To unsubscribe, visit https://g
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: rename SampleVMs for clarity
..
virt: rename SampleVMs for clarity
SampleVMs is a bad name. Change it
to VMBulkSampler, which is a bit more expli
automat...@ovirt.org has posted comments on this change.
Change subject: virt: rename SampleVMs for clarity
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visi
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: statscache: more robust remove()
..
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/40439/6/vdsm/virt/sampling.py
File vdsm/virt/
Sandro Bonazzola has posted comments on this change.
Change subject: virt: enable libgfapi with snapshot support
..
Patch Set 3: Verified+1 Code-Review+1
--
To view, visit https://gerrit.ovirt.org/33768
To unsubscribe, visit h
Sandro Bonazzola has posted comments on this change.
Change subject: gluster: fix volume name parsing in getVmVolumeInfo
..
Patch Set 1: Verified+1 Code-Review+1
--
To view, visit https://gerrit.ovirt.org/36237
To unsubscribe,
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: statscache: more robust remove()
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
Sandro Bonazzola has posted comments on this change.
Change subject: storageServer: Run glusterfs in its own cgroup
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/40240
To unsubscribe, visit https://gerr
Sandro Bonazzola has posted comments on this change.
Change subject: utils: Add systemd_run command modifier
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40239
To unsubscribe, visit https://gerrit.ovir
Ido Barkan has posted comments on this change.
Change subject: api: support multiple 'ipv6addrs' per network
..
Patch Set 3: -Code-Review
--
To view, visit https://gerrit.ovirt.org/39307
To unsubscribe, visit https://gerrit.ov
Ido Barkan has posted comments on this change.
Change subject: api: support multiple 'ipv6addrs' per network
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39307
To unsubscribe, visit https://gerrit.o
Dan Kenigsberg has posted comments on this change.
Change subject: virt: rename SampleVMs for clarity
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40370
To unsubscribe, visit https://gerrit.ovirt.or
Martin Polednik has posted comments on this change.
Change subject: virt: rename SampleVMs for clarity
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40370
To unsubscribe, visit https://gerrit.ovirt.o
Dan Kenigsberg has posted comments on this change.
Change subject: vm: disappeared domain are not ready for commands
..
Patch Set 32: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/39370
To unsubscribe, visit https:/
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: disappeared domain are not ready for commands
..
vm: disappeared domain are not ready for commands
It is possible that isDomainReadyForCommands rac
automat...@ovirt.org has posted comments on this change.
Change subject: vm: disappeared domain are not ready for commands
..
Patch Set 33:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
-
Dan Kenigsberg has posted comments on this change.
Change subject: periodic: improve isolation in VM dispatching
..
Patch Set 6: Code-Review+2
Unhappily approving - I hope customers would not ignore these ERRORs in the log.
--
automat...@ovirt.org has posted comments on this change.
Change subject: periodic: improve isolation in VM dispatching
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: periodic: improve isolation in VM dispatching
..
periodic: improve isolation in VM dispatching
Make VmDispatcher more robust:
1. add try/except block
Dan Kenigsberg has posted comments on this change.
Change subject: periodic: simplify per_vm_operation
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40327
To unsubscribe, visit https://gerrit.ovirt.o
Dan Kenigsberg has submitted this change and it was merged.
Change subject: periodic: simplify per_vm_operation
..
periodic: simplify per_vm_operation
per_vm_operation was added, as helper, together with
_dispatched_operation,
automat...@ovirt.org has posted comments on this change.
Change subject: periodic: simplify per_vm_operation
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, vis
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: Add systemd_run command modifier
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40239
To unsubscribe, visit https://gerrit.ovi
Dan Kenigsberg has posted comments on this change.
Change subject: models, configurators: replace the internal 'async' flag with
blockingdhcp
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/40456/3/vdsm
Francesco Romani has posted comments on this change.
Change subject: storage: remove direct path legacy drive detection
..
Patch Set 1: Code-Review+1
let's make some enemies.
--
To view, visit https://gerrit.ovirt.org/40528
T
automat...@ovirt.org has posted comments on this change.
Change subject: storage: remove direct path legacy drive detection
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
Martin Polednik has uploaded a new change for review.
Change subject: storage: remove direct path legacy drive detection
..
storage: remove direct path legacy drive detection
The comment in code stated:
Backward compatibility fo
Ramesh N has posted comments on this change.
Change subject: gluster: Adds a new element 'additionalFeatures' to getVdsCaps.
..
Patch Set 5: Code-Review-1
Please don't merge until engine patch is getting to a conclusion.
--
T
Martin Sivák has posted comments on this change.
Change subject: Fix the CPU quota MOM policy computations
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40311
To unsubscribe, visit https://gerrit.ovirt.
Francesco Romani has posted comments on this change.
Change subject: migration: split update from getStat
..
Patch Set 1: Code-Review-1
may not be a good idea after all.
--
To view, visit https://gerrit.ovirt.org/40524
To uns
Francesco Romani has uploaded a new change for review.
Change subject: migration: add MIGRATION_STATUS enumeration
..
migration: add MIGRATION_STATUS enumeration
Use constants for migration status messages.
Change-Id: I0c311e91
automat...@ovirt.org has posted comments on this change.
Change subject: migration: add MIGRATION_STATUS enumeration
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Ondřej Svoboda has posted comments on this change.
Change subject: models, configurators: replace the internal 'async' flag with
blockingdhcp
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/40456/3/vdsm/network/confi
Francesco Romani has uploaded a new change for review.
Change subject: migration: return a copy of the internal status
..
migration: return a copy of the internal status
migration.SourceThread.getStat() used to return a referenc
Francesco Romani has uploaded a new change for review.
Change subject: virt: do not use status after getStat()
..
virt: do not use status after getStat()
the getStat() method already provide an up to date status of the
migration
Francesco Romani has uploaded a new change for review.
Change subject: migration: make stop() update internal status
..
migration: make stop() update internal status
The SourceThread.stop() operation should update
the internal s
101 - 200 of 236 matches
Mail list logo
