Piotr Kliczewski has posted comments on this change.
Change subject: stomp: make sure that subscriptions use uniqe id
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/46656/2/lib/yajsonrpc/stompreactor.py
File lib/yajs
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/46625/2/lib/yajsonrpc/betterAsyncore.py
File lib/y
Nir Soffer has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/6/vdsm/virt/sampling.py
File vdsm/virt/sampling
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: always hold confLock when updating pauseCode
..
vm: always hold confLock when updating pauseCode
An update of pauseCode can create a new field in V
Dan Kenigsberg has posted comments on this change.
Change subject: vm: always hold confLock when updating pauseCode
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46005
To unsubscribe, visit https://g
automat...@ovirt.org has posted comments on this change.
Change subject: vm: always hold confLock when updating pauseCode
..
Patch Set 4:
* Update tracker::#1261918::OK
* Set MODIFIED::bug 1261918#1261918IGNORE, not oVi
automat...@ovirt.org has posted comments on this change.
Change subject: net: reuse running config instance in netinfo.
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
T
Dan Kenigsberg has posted comments on this change.
Change subject: net: reuse running config instance in netinfo.
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46648
To unsubscribe, visit https://ger
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: reuse running config instance in netinfo.
..
net: reuse running config instance in netinfo.
running config is already read from the disk once duri
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Generalize sdm_indirection_tests
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Generalize sdm_indirection_tests
..
tests: Generalize sdm_indirection_tests
The infrastructure in sdm_indirection_tests is useful for testing th
automat...@ovirt.org has posted comments on this change.
Change subject: Raise python-cpopen requirement to 1.4
..
Patch Set 1:
* Update tracker::#1264667::OK
* Check Bug-Url::OK
* Check Public Bug::#1264667::OK, public bug
* C
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Raise python-cpopen requirement to 1.4
..
Raise python-cpopen requirement to 1.4
Change-Id: I4c5d62281cfba20eed51f9960065b192f7a209d3
Bug-Url: https://bugzilla
Francesco Romani has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/6//COMMIT_MSG
Commit Message:
Line 26:
Francesco Romani has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/6/vdsm/virt/sampling.py
File vdsm/virt/sa
Francesco Romani has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 4: Verified+1
changes since last verification in debian packaging, or about whitespaces.
Restoring V+1
automat...@ovirt.org has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 4:
* Update tracker::#1265205::OK
* Check Bug-Url::OK
* Check Public Bug::#1265205::OK, public bug
Nir Soffer has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46522
To unsubscribe, visit https://gerrit.ovirt
Francesco Romani has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/46522/3/debian/vdsm-python.install
File debian/vdsm-pytho
Nir Soffer has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 3: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/46522/3/debian/vdsm-python.install
File debian/vd
Nir Soffer has posted comments on this change.
Change subject: tests: Improve utils.retry tests
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/46399/1/tests/utilsTests.py
File tests/utilsTests.py:
Line 58: def
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
Francesco Romani has posted comments on this change.
Change subject: tests: Improve utils.retry tests
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46399
To unsubscribe, visit https://gerrit.ovirt.or
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/6/vdsm/virt/sampling.py
File vdsm/virt/sampling
Nir Soffer has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/46625/2/lib/yajsonrpc/betterAsyncore.py
Fi
Francesco Romani has posted comments on this change.
Change subject: stomp: make sure that subscriptions use uniqe id
..
Patch Set 2:
(1 comment)
fine with the concept, we can simplify a bit.
https://gerrit.ovirt.org/#/c/4665
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/6//COMMIT_MSG
Commit Message:
Line 26:
Piotr Kliczewski has posted comments on this change.
Change subject: tests: JsonRpcClient tests suite
..
Patch Set 4: Verified+1
Rebased only.
--
To view, visit https://gerrit.ovirt.org/43582
To unsubscribe, visit https://ger
Piotr Kliczewski has posted comments on this change.
Change subject: tests: JsonRpcServer tests suite
..
Patch Set 4: Verified+1
Rebased only.
--
To view, visit https://gerrit.ovirt.org/43581
To unsubscribe, visit https://ger
Piotr Kliczewski has posted comments on this change.
Change subject: tests: AsyncDispatcher tests suite
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/43394
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: tests: AsyncDispatcher tests suite
..
Patch Set 5:
Rebased only.
--
To view, visit https://gerrit.ovirt.org/43394
To unsubscribe, visit https://gerrit.ovirt
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: allow to mock monotonic_time method
..
Patch Set 3: Verified+1
Fixed comments. Verified by building locally on my machine.
--
To view, visit https://
Piotr Kliczewski has posted comments on this change.
Change subject: tests: AsyncClient test suite
..
Patch Set 5: Verified+1
Rebased only.
--
To view, visit https://gerrit.ovirt.org/43393
To unsubscribe, visit https://gerrit
Piotr Kliczewski has posted comments on this change.
Change subject: tests: StompAdapter test suite
..
Patch Set 7:
Verified by building locally. Rebased only.
--
To view, visit https://gerrit.ovirt.org/43342
To unsubscribe,
Piotr Kliczewski has posted comments on this change.
Change subject: tests: StompAdapter test suite
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/43342
To unsubscribe, visit https://gerrit.ovirt.org/set
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: make sure to send error message when no subscription
..
Patch Set 4:
Yaniv do you still have some comments to this patch.
Patch rebased only.
--
To
automat...@ovirt.org has posted comments on this change.
Change subject: stomp: send unsubscribed frame only if there was subscription
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Nir Soffer has posted comments on this change.
Change subject: host stats: Add cpusStatus to vdsStats
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/46270/6//COMMIT_MSG
Commit Message:
Line 25: [...]
Line 26: 'c
automat...@ovirt.org has posted comments on this change.
Change subject: tests: JsonRpcClient tests suite
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
automat...@ovirt.org has posted comments on this change.
Change subject: tests: AsyncDispatcher tests suite
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
automat...@ovirt.org has posted comments on this change.
Change subject: stomp: make sure to send error message when no subscription
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url f
automat...@ovirt.org has posted comments on this change.
Change subject: tests: StompAdapter test suite
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: ignore unknown message id
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
automat...@ovirt.org has posted comments on this change.
Change subject: tests: AsyncClient test suite
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: stomp: allow to mock monotonic_time method
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
automat...@ovirt.org has posted comments on this change.
Change subject: tests: JsonRpcServer tests suite
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Nir Soffer has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/46269/6//COMMIT_MSG
Commit Message:
Line 26:
Francesco Romani has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 2: Code-Review+1
after reading the comments in v1, this seems indeed a good fix.
--
To view,
Francesco Romani has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 6:
(3 comments)
https://gerrit.ovirt.org/#/c/46269/6//COMMIT_MSG
Commit Message:
Line 29:
Francesco Romani has posted comments on this change.
Change subject: host stats: Add cpusStatus to vdsStats
..
Patch Set 6: Code-Review+1
(1 comment)
at first glance looks OK. Typo in the commit message. Preliminary ACK.
http
Petr Horáček has posted comments on this change.
Change subject: hook: after_network_setup_failture
..
Patch Set 6: Verified+1
Verified with a simple hook: http://fpaste.org/271464/31903981/
--
To view, visit https://gerrit.o
automat...@ovirt.org has posted comments on this change.
Change subject: hook: after_network_setup_failture
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
Francesco Romani has posted comments on this change.
Change subject: host stats: Add cpusStatus to vdsStats
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/46270/4/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-s
automat...@ovirt.org has posted comments on this change.
Change subject: hook: after_network_setup_failed
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Francesco Romani has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 3: Verified+1
v3 works as expected on RHEL/CentOS 6.x; known issue about ioprocess, but
tracked ina di
Petr Horáček has posted comments on this change.
Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks
..
Patch Set 4: Verified+1
No regressions in networkTestsOVS.py. test_remove_initial_network_nic_ip
automat...@ovirt.org has posted comments on this change.
Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug ur
Petr Horáček has posted comments on this change.
Change subject: net: tests: test if setupNetworks drops/keeps initial nics IP
..
Patch Set 4: Verified+1
Passed with ifcfg configurator, failed with iproute2, pyroute2, OVS.
--
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: test if setupNetworks drops/keeps initial nics IP
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Fix unsafe monkeypatching
..
Patch Set 3: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/46388
To unsubscribe, visit https://gerrit.o
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Fix unsafe monkeypatching
..
tests: Fix unsafe monkeypatching
mkimage module could be left in bad state if setup failed after it was
patched, or
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Fix unsafe monkeypatching
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: Skip vm if XMLDesc() fails
..
Patch Set 4:
* Update tracker::#1266088::OK
* Set MODIFIED::bug 1266088#1266088IGNORE, not oVirt prod but vdsm
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: Skip vm if XMLDesc() fails
..
v2v: Skip vm if XMLDesc() fails
The current code assumes that XMLDesc() always succeeds when dealing
foreign vms, wh
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: Fix getExternalVMs if getting disk size failed
..
Patch Set 5:
* Update tracker::#1265556::OK
* Set MODIFIED::bug 1265556#1265556IGNORE, not
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: Fix getExternalVMs if getting disk size failed
..
v2v: Fix getExternalVMs if getting disk size failed
In getExternalVMs we try to report the disk
automat...@ovirt.org has posted comments on this change.
Change subject: net: multicast snooping is not supported by ovs until 2.4.0
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: multicast snooping is not supported by ovs until 2.4.0
..
net: multicast snooping is not supported by ovs until 2.4.0
Change-Id: Ie1b5a2987fb71b8e
Dan Kenigsberg has posted comments on this change.
Change subject: net: multicast snooping is not supported by ovs until 2.4.0
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46633
To unsubscribe, visi
Petr Horáček has posted comments on this change.
Change subject: net: multicast snooping is not supported by ovs until 2.4.0
..
Patch Set 1: Verified+1
Just a readme. Source:
http://openvswitch.org/pipermail/announce/2015-Augu
Roman Mohr has posted comments on this change.
Change subject: host stats: Add cpusStatus to vdsStats
..
Patch Set 4:
(9 comments)
https://gerrit.ovirt.org/#/c/46270/4/tests/samplingTests.py
File tests/samplingTests.py:
Line
automat...@ovirt.org has posted comments on this change.
Change subject: host stats: Add cpusStatus to vdsStats
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
automat...@ovirt.org has posted comments on this change.
Change subject: host stats: Add cpusStatus to vdsStats
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
Francesco Romani has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 3:
v3 deals with the fact that on CentOS/RHEL 6.x, still supported by oVirt 3.5.x,
taskset does not ha
automat...@ovirt.org has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 3:
* Update tracker::#1265205::OK
* Check Bug-Url::OK
* Check Public Bug::#1265205::OK, public bug
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/46269
To unsubscribe, visit https://gerr
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 4:
(5 comments)
https://gerrit.ovirt.org/#/c/46269/4//COMMIT_MSG
Commit Message:
Line 12: When v
automat...@ovirt.org has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, m
automat...@ovirt.org has posted comments on this change.
Change subject: virt: devices: initial support for device updates with etree's
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug ur
Francesco Romani has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/4/vdsm/virt/sampling.py
File vdsm/virt/sa
Francesco Romani has posted comments on this change.
Change subject: host stats: Add onlineCpus to vdsStats
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/46270/4/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Li
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: increase call timeout to allow valid response
..
Patch Set 1:
Can you please give more information about the issues you are seeing? Changing
timeout
83 matches
Mail list logo