Shahar Havivi has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/48402
To unsubscribe, visit ht
Nir Soffer has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 4:
Thanks Idan!
--
To view, visit https://gerrit.ovirt.org/31162
To unsubscribe, visit https://gerrit.ovirt.o
Nir Soffer has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/31162
To unsubscribe, visit https://gerrit.ovirt.o
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 1:
* #1277879::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#127787
Shahar Havivi has uploaded a new change for review.
Change subject: v2v: ova should support zip and extracted directory formats
..
v2v: ova should support zip and extracted directory formats
Change-Id: I494b88709c4c23fd39690b589
Idan Shaby has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 4:
Sure:
I had an environment of three hosts.
I blocked the outgoing packets from one of the hosts (id=3) to th
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: rework reporting of DHCPv4/6 on network devices
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/48399/1//COMMIT_MSG
Commit Mess
Dan Kenigsberg has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 4: Continuous-Integration+1
unrelated failure
17:26:54 Last metadata expiration check performed 0:00:02 a
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding functional tests to check-patch
..
Patch Set 2: Verified-1
we can abandon this try - we continue with https://gerrit.ovirt.org/#/c/48268/
--
To view, v
Hello Ido Barkan, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/48399
to review the following change.
Change subject: netinfo: rework reporting of DHCPv4/6 on network devices
..
n
automat...@ovirt.org has posted comments on this change.
Change subject: netinfo: rework reporting of DHCPv4/6 on network devices
..
Patch Set 1: Verified-1
* #1184497::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug:
Nir Soffer has posted comments on this change.
Change subject: gluster: Fixing connection when server is not one of the bricks
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48308
To unsubscribe, visi
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 6:
* #1277879::Update tracker: OK
* Set MODIFIED::bug 1277879#1277879IGNO
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: ova should support zip and extracted directory formats
..
v2v: ova should support zip and extracted directory formats
Change-Id: I494b88709c4c23fd
automat...@ovirt.org has posted comments on this change.
Change subject: tests: FakeLVM add lvPath test
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit ht
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: FakeLVM add lvPath test
..
tests: FakeLVM add lvPath test
Test the lvPath function. Allow FakeLVM to be created without a
temporary directory w
Ala Hino has posted comments on this change.
Change subject: gluster: Fixing connection when server is not one of the bricks
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/48308/8//COMMIT_MSG
Commit Message:
Line 3:
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Fixing connection when server is not one of the bricks
..
Patch Set 9:
* #1278880::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#12
Nir Soffer has posted comments on this change.
Change subject: tests: FakeLVM add lvPath test
..
Patch Set 8: Code-Review+2 Verified+1
Removed unintended whitespace change.
--
To view, visit https://gerrit.ovirt.org/47863
To
automat...@ovirt.org has posted comments on this change.
Change subject: tests: FakeLVM add lvPath test
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Nir Soffer has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 8: -Code-Review
(1 comment)
One more thing - the title needs update as well.
https://gerrit.ovir
Nir Soffer has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 8: Code-Review+1
Thanks Ala!
Waiting for Sahina review before approving.
--
To view, visit http
Ala Hino has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/48308/7/vdsm/storage/storageServer.py
File vdsm/storage
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 8:
* #1278880::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1278880::OK,
Nir Soffer has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 7: Code-Review-1
(1 comment)
Nice, just one space missing.
https://gerrit.ovirt.org/#/c/48308/7/
Dan Kenigsberg has submitted this change and it was merged.
Change subject: networkTests: ensure that the 'primary' bonding option is
recognized
..
networkTests: ensure that the 'primary' bonding option is recognized
Change-Id
Dan Kenigsberg has posted comments on this change.
Change subject: networkTests: ensure that the 'primary' bonding option is
recognized
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48389
To unsubsc
automat...@ovirt.org has posted comments on this change.
Change subject: networkTests: ensure that the 'primary' bonding option is
recognized
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, n
Ondřej Svoboda has posted comments on this change.
Change subject: networkTests: ensure that the 'primary' bonding option is
recognized
..
Patch Set 1: Verified+1
As promised.
--
To view, visit https://gerrit.ovirt.org/48389
automat...@ovirt.org has posted comments on this change.
Change subject: networkTests: ensure that the 'primary' bonding option is
recognized
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no
Ondřej Svoboda has uploaded a new change for review.
Change subject: networkTests: ensure that the 'primary' bonding option is
recognized
..
networkTests: ensure that the 'primary' bonding option is recognized
Change-Id: I5f268
automat...@ovirt.org has posted comments on this change.
Change subject: hooks: ovs: set OVS devices UP
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Francesco Romani has posted comments on this change.
Change subject: migration added migrateChangeParams verb
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46934
To unsubscribe, visit https://gerrit.
Francesco Romani has posted comments on this change.
Change subject: migration: Add support for max migration bandwidth setting
..
Patch Set 9: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/46846/9//COMMIT_MSG
Commit
automat...@ovirt.org has posted comments on this change.
Change subject: hooks: ovs: set OVS devices UP
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Francesco Romani has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 5: Code-Review+2
thanks for the updates!
--
To view, visit https://gerrit.ovirt.org
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 2: Code-Review-1
(1 comment)
I'm fine with the concept, but I found an unexpected change. Could be
inten
Francesco Romani has posted comments on this change.
Change subject: executor: Fix thread-unsafe call
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48197
To unsubscribe, visit https://gerrit.ovirt.or
Francesco Romani has posted comments on this change.
Change subject: schedule: Introduce scheduling library
..
Patch Set 2: Code-Review+2
looks fine. New code, well covered by tests, very little chance to break
something :)
-
Francesco Romani has posted comments on this change.
Change subject: executor: introduce the executor library
..
Patch Set 2: Code-Review+2
looks fine. New code, well covered by tests, very little chance to break
something :)
automat...@ovirt.org has posted comments on this change.
Change subject: hooks: ovs: set OVS devices UP
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Petr Horáček has uploaded a new change for review.
Change subject: hooks: ovs: set OVS devices UP
..
hooks: ovs: set OVS devices UP
Set all attached and created devices explicitly UP.
Change-Id: Ia8af77c136a8f27d980f94647f78570
Ala Hino has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/48308/6//COMMIT_MSG
Commit Message:
Line 9: There are
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 7:
* #1278880::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1278880::OK,
Nir Soffer has posted comments on this change.
Change subject: Moving cpopen import to compat to allow working with python 3
..
Patch Set 1: Code-Review-1
(1 comment)
Nice, but we are not ready for this yet.
https://gerrit.ov
automat...@ovirt.org has posted comments on this change.
Change subject: Adding toolTests.py to python3 check modules
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: Moving cpopen import to compat to allow working with python 3
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
automat...@ovirt.org has posted comments on this change.
Change subject: Adding python3 run for nosetests
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Moving cpopen import to compat to allow working with python 3
..
Moving cpopen import to compat to allow working with python 3
Once python3-copen will be avail
automat...@ovirt.org has posted comments on this change.
Change subject: Remove usage of deathSignal
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
Francesco Romani has abandoned this change.
Change subject: lib: executor: pack items in a Task tuple
..
Abandoned
no longer needed after the new direction took on 48191
--
To view, visit https://gerrit.ovirt.org/48192
To uns
automat...@ovirt.org has posted comments on this change.
Change subject: lib: executor: pack items in a Task tuple
..
Patch Set 5:
* #1250839::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/48192
To unsubscribe
Nir Soffer has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 6: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/48308/6//COMMIT_MSG
Commit Message:
L
Ala Hino has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/48308/5/vdsm/storage/storageServer.py
File vdsm/storag
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 6:
* #1278880::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1278880::OK,
Sandro Bonazzola has posted comments on this change.
Change subject: automation: fix missing dep ethtool
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/48379
To unsubscribe, visit https://gerrit.ovirt.or
automat...@ovirt.org has posted comments on this change.
Change subject: automation: fix missing dep ethtool
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is
Sandro Bonazzola has uploaded a new change for review.
Change subject: automation: fix missing dep ethtool
..
automation: fix missing dep ethtool
Fix
http://jenkins.ovirt.org/job/vdsm_3.5_build-artifacts-el6-x86_64/1/console
by
Petr Horáček has posted comments on this change.
Change subject: net: tests: support iperf3 for performance tests
..
Patch Set 23: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/46448/23/lib/vdsm/ipwrapper.py
File lib
Sandro Bonazzola has posted comments on this change.
Change subject: Added fc23 repos to the automation scripts
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/48180/3/automation/build-artifacts.repos.fc23
File automa
Sandro Bonazzola has posted comments on this change.
Change subject: Added fc23 repos to the automation scripts
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/48180
To unsubscribe, visit https://gerrit.o
automat...@ovirt.org has posted comments on this change.
Change subject: Added fc23 repos to the automation scripts
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
automat...@ovirt.org has posted comments on this change.
Change subject: Adding to vdsm automation lago env setup for functional tests
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug ur
Nir Soffer has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 5: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/48308/5/vdsm/storage/storageServer.py
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: improve functional network tests duration time
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/48356/1/tests/functional/networkTests.
Allon Mureinik has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/31162
To unsubscribe, visit https://gerrit.ovi
Ala Hino has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/48308/4/tests/storageServerTests.py
File tests/storage
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 2: Verified+1
Verified by performance team.
--
To view, visit https://gerrit.ovirt.org/48198
To unsubscr
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 5:
* #1278880::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1278880::OK,
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 2:
* #1279950::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279950::OK, public bug
* C
Piotr Kliczewski has uploaded a new change for review.
Change subject: jsonrpc: executor based thread factory
..
jsonrpc: executor based thread factory
Creating new thread for every request is not efficient so we introduce
usage
automat...@ovirt.org has posted comments on this change.
Change subject: Adding to vdsm automation lago env setup for functional tests
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug ur
Hello Dan Kenigsberg, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/48197
to review the following change.
Change subject: executor: Fix thread-unsafe call
..
executor: Fix threa
automat...@ovirt.org has posted comments on this change.
Change subject: executor: Fix thread-unsafe call
..
Patch Set 2: -Verified
* #1279950::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279950::OK, public bug
Nir Soffer has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 4: Code-Review+1 -Verified
Idan, can you describe (in details) how you verified this patch?
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: executor: Fix thread-unsafe call
..
Patch Set 2: Verified+1
Verified by performance team
--
To view, visit https://gerrit.ovirt.org/48197
To unsubscribe, vi
Hello Dan Kenigsberg, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/48195
to review the following change.
Change subject: schedule: Introduce scheduling library
..
schedule: Int
automat...@ovirt.org has posted comments on this change.
Change subject: schedule: Introduce scheduling library
..
Patch Set 2: -Verified
* #1279950::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279950::OK, publ
Idan Shaby has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/31162
To unsubscribe, visit https://gerrit.ovirt.org/
automat...@ovirt.org has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 4:
* #1131192::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1131192::OK, public bug
*
Piotr Kliczewski has posted comments on this change.
Change subject: executor: introduce the executor library
..
Patch Set 2: Verified+1
Verified by performance team.
--
To view, visit https://gerrit.ovirt.org/48196
To unsubs
Piotr Kliczewski has posted comments on this change.
Change subject: schedule: Introduce scheduling library
..
Patch Set 2: Verified+1
Verified be performance team.
--
To view, visit https://gerrit.ovirt.org/48195
To unsubscr
automat...@ovirt.org has posted comments on this change.
Change subject: executor: introduce the executor library
..
Patch Set 2: -Verified
* #1279950::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279950::OK, pu
Hello Dan Kenigsberg, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/48196
to review the following change.
Change subject: executor: introduce the executor library
..
executor: i
automat...@ovirt.org has posted comments on this change.
Change subject: asyncore: remove misleading log entry
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Piotr Kliczewski has uploaded a new change for review.
Change subject: asyncore: remove misleading log entry
..
asyncore: remove misleading log entry
From time to time I can see misleading warning in the logs:
betterAsyncore::1
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpcvdscli: improve functional network tests duration time
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/48356/1/tests/functional/networkTests.py
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: improve functional network tests duration time
..
Patch Set 1: Verified-1
After testing both invocation it seems that there is still place for
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: test network's iface
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: test if network's iface
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
Petr Horáček has uploaded a new change for review.
Change subject: net: tests: test if network's iface
..
net: tests: test if network's iface
Change-Id: If45fb63247b5e5b21721a23d8781a4ed80e58932
Signed-off-by: Petr Horáček
---
automat...@ovirt.org has posted comments on this change.
Change subject: net: ifup ignores invalid gateway settings
..
Patch Set 1:
* #1270688::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270688::OK, public bug
Petr Horáček has uploaded a new change for review.
Change subject: net: ifup ignores invalid gateway settings
..
net: ifup ignores invalid gateway settings
When we try to set address and gateway on different subnets, ifup
just w
Nir Soffer has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 4: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/48308/4/tests/storageServerTests.py
Fi
Shahar Havivi has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/48129
To unsubscribe, visit ht
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 5:
* #1277879::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#127787
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpcvdscli: improve functional network tests duration time
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Piotr Kliczewski has uploaded a new change for review.
Change subject: jsonrpcvdscli: improve functional network tests duration time
..
jsonrpcvdscli: improve functional network tests duration time
The tests were creating new js
Shahar Havivi has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/48129/4/vdsm/v2v.py
File vdsm/v2v.py:
Line
Francesco Romani has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 4: Code-Review-1
(1 comment)
one question inside, -1 for visibility.
https://gerrit
1 - 100 of 202 matches
Mail list logo
