Change in vdsm[master]: vm: renaming device unplug related function

Marcin Mirecki has abandoned this change. Change subject: vm: renaming device unplug related function .. Abandoned Squashed into https://gerrit.ovirt.org/#/c/48473 -- To view, visit https://gerrit.ovirt.org/49038 To unsubscri

Change in vdsm[master]: vm: renaming device unplug related function

gerrit-hooks has posted comments on this change. Change subject: vm: renaming device unplug related function .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/49038 To unsub

Change in vdsm[master]: automation: Eliminate unneeded variables

Francesco Romani has posted comments on this change. Change subject: automation: Eliminate unneeded variables .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49283 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: automation: Improve whitespace

Francesco Romani has posted comments on this change. Change subject: automation: Improve whitespace .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49281 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: automation: Limit coverage report to vdsm code

Francesco Romani has posted comments on this change. Change subject: automation: Limit coverage report to vdsm code .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49280 To unsubscribe, visit https://g

Change in vdsm[master]: automation: Generate coverage report in one step

Francesco Romani has posted comments on this change. Change subject: automation: Generate coverage report in one step .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49282 To unsubscribe, visit https:/

Change in vdsm[master]: guest-agent: desktopLock exception on EBADF should be ignored

Vinzenz Feenstra has posted comments on this change. Change subject: guest-agent: desktopLock exception on EBADF should be ignored .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/47404 To unsubscribe, vis

Change in vdsm[master]: guest-agent: desktopLock exception on EBADF should be ignored

Vinzenz Feenstra has posted comments on this change. Change subject: guest-agent: desktopLock exception on EBADF should be ignored .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/47404 To unsubscribe, vis

Change in vdsm[master]: guest-agent: desktopLock exception on EBADF should be ignored

gerrit-hooks has posted comments on this change. Change subject: guest-agent: desktopLock exception on EBADF should be ignored .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: guest-agent: desktopLock exception on EBADF should be ignored

Vinzenz Feenstra has posted comments on this change. Change subject: guest-agent: desktopLock exception on EBADF should be ignored .. Patch Set 4: -Verified -- To view, visit https://gerrit.ovirt.org/47404 To unsubscribe, visi

Change in vdsm[master]: guest-agent: desktopLock exception on EBADF should be ignored

Vinzenz Feenstra has posted comments on this change. Change subject: guest-agent: desktopLock exception on EBADF should be ignored .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/47404/4/vdsm/virt/guestagent.py File v

Change in vdsm[master]: VolumeMetadata: Move the getParent API

Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: Move the getParent API .. Patch Set 19: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/41848 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[master]: VolumeMetadata: Move the getParent API

Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: Move the getParent API .. Patch Set 18: (1 comment) https://gerrit.ovirt.org/#/c/41848/18/vdsm/storage/blockVolume.py File vdsm/storage/blockVolume

Change in vdsm[master]: VolumeMetadata: metadata write utils

Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: metadata write utils .. Patch Set 19: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/41847/19/vdsm/storage/blockVolume.py File vdsm/storag

Change in vdsm[master]: VolumeMetadata: metadata write utils

Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: metadata write utils .. Patch Set 19: Fred, use -1 when you add comment, otherwise Adam will never see your comment. -- To view, visit https://ger

Change in vdsm[master]: VolumeMetadata: Metadata read utils

Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: Metadata read utils .. Patch Set 19: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/41846 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: net: move network library under lib/vdsm

Petr Horáček has posted comments on this change. Change subject: net: move network library under lib/vdsm .. Patch Set 2: -Verified Code-Review-1 sorry -- To view, visit https://gerrit.ovirt.org/49239 To unsubscribe, visit ht

Change in vdsm[master]: net: move network library under lib/vdsm

Petr Horáček has posted comments on this change. Change subject: net: move network library under lib/vdsm .. Patch Set 2: Verified-1 just to get attention -- To view, visit https://gerrit.ovirt.org/49239 To unsubscribe, visit

Change in vdsm[master]: vm: renaming device unplug related function

Nir Soffer has posted comments on this change. Change subject: vm: renaming device unplug related function .. Patch Set 5: This was squashed into another patch, you can abandon it now. -- To view, visit https://gerrit.ovirt.o

Change in vdsm[master]: vm: add test for nic unplug wait

Nir Soffer has posted comments on this change. Change subject: vm: add test for nic unplug wait .. Patch Set 7: Code-Review+2 Continuous-Integration+1 The jenkins failure is not relevant. Nice! -- To view, visit https://gerr

Change in vdsm[master]: vm: move device attached check to device itself

Nir Soffer has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 11: Code-Review+2 Thanks Marcin, excellent work -- To view, visit https://gerrit.ovirt.org/48881 To u

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

Nir Soffer has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 15: Code-Review-1 (2 comments) Tow minor issues. https://gerrit.ovirt.org/#/c/48473/15/vdsm/virt/vmde

Change in vdsm[master]: automation: Eliminate unneeded variables

Nir Soffer has posted comments on this change. Change subject: automation: Eliminate unneeded variables .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/49283 To unsubscribe, visit https://gerrit.ovirt.org

Change in vdsm[master]: automation: Generate coverage report in one step

Nir Soffer has posted comments on this change. Change subject: automation: Generate coverage report in one step .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/49282 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: automation: Improve whitespace

Nir Soffer has posted comments on this change. Change subject: automation: Improve whitespace .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/49281 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: automation: Limit coverage report to vdsm code

Nir Soffer has posted comments on this change. Change subject: automation: Limit coverage report to vdsm code .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/49280 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[master]: coverage: Enable coverage using config value

gerrit-hooks has posted comments on this change. Change subject: coverage: Enable coverage using config value .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/45261 To unsu

Change in vdsm[master]: coverage: Enable coverage using config value

Nir Soffer has abandoned this change. Change subject: coverage: Enable coverage using config value .. Abandoned Replaced by https://gerrit.ovirt.org/49168 -- To view, visit https://gerrit.ovirt.org/45261 To unsubscribe, visit

Change in vdsm[master]: automation: Improve whitespace

gerrit-hooks has posted comments on this change. Change subject: automation: Improve whitespace .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U

Change in vdsm[master]: automation: Generate coverage report in one step

gerrit-hooks has posted comments on this change. Change subject: automation: Generate coverage report in one step .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: automation: Eliminate unneeded variables

gerrit-hooks has posted comments on this change. Change subject: automation: Eliminate unneeded variables .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: automation: Improve whitespace

Nir Soffer has uploaded a new change for review. Change subject: automation: Improve whitespace .. automation: Improve whitespace Empty line between commands make the script easier to read. Change-Id: Ifdd0ac349f75e76e79d923e7c

Change in vdsm[master]: automation: Generate coverage report in one step

Nir Soffer has uploaded a new change for review. Change subject: automation: Generate coverage report in one step .. automation: Generate coverage report in one step Instead of generating the report in the test directory and mov

Change in vdsm[master]: automation: Limit coverage report to vdsm code

Nir Soffer has uploaded a new change for review. Change subject: automation: Limit coverage report to vdsm code .. automation: Limit coverage report to vdsm code Current coverage report includes the tests, test helpers, 3rd part

Change in vdsm[master]: automation: Limit coverage report to vdsm code

gerrit-hooks has posted comments on this change. Change subject: automation: Limit coverage report to vdsm code .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

Change in vdsm[master]: automation: Eliminate unneeded variables

Nir Soffer has uploaded a new change for review. Change subject: automation: Eliminate unneeded variables .. automation: Eliminate unneeded variables There is no point in variables which are used once and are expected to change

Change in vdsm[master]: build: contrib script to build for rhev with the required flags

Sandro Bonazzola has posted comments on this change. Change subject: build: contrib script to build for rhev with the required flags .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/49001/5/contrib/rhev_build.sh File c

Change in vdsm[master]: Added fc23 packages to the automation scripts

Sandro Bonazzola has posted comments on this change. Change subject: Added fc23 packages to the automation scripts .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48180 To unsubscribe, visit https://ge

Change in vdsm[master]: Added fc23 packages to the automation scripts

Sandro Bonazzola has posted comments on this change. Change subject: Added fc23 packages to the automation scripts .. Patch Set 5: Rebased, updated commit message accordingly. -- To view, visit https://gerrit.ovirt.org/48180

Change in vdsm[master]: Added fc23 packages to the automation scripts

gerrit-hooks has posted comments on this change. Change subject: Added fc23 packages to the automation scripts .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: vm: move device attached check to device itself

gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: vm: add test for nic unplug wait

gerrit-hooks has posted comments on this change. Change subject: vm: add test for nic unplug wait .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

gerrit-hooks has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 15: * #1134256::Update tracker: OK * #1199782::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: vm: move device attached check to device itself

Marcin Mirecki has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 10: (2 comments) https://gerrit.ovirt.org/#/c/48881/10/vdsm/virt/vmdevices/storage.py File vdsm/vi

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

Marcin Mirecki has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/48473/13/vdsm/virt/vmdevices/network.py File vdsm/vir

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

gerrit-hooks has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 14: * #1134256::Update tracker: OK * #1199782::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

Marcin Mirecki has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/48473/9/vdsm/virt/vmdevices/network.py File vdsm/virt

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

Marcin Mirecki has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 13: (2 comments) https://gerrit.ovirt.org/#/c/48473/13/vdsm/virt/vmdevices/network.py File vdsm/vi

Change in vdsm[master]: sp: Allow attaching hosted engine sd

Roy Golan has posted comments on this change. Change subject: sp: Allow attaching hosted engine sd .. Patch Set 1: Nir I didn't understand our comment. -- To view, visit https://gerrit.ovirt.org/48217 To unsubscribe, visit ht

Change in vdsm[master]: startup: Change system default encoding to utf8

Nir Soffer has posted comments on this change. Change subject: startup: Change system default encoding to utf8 .. Patch Set 5: Dan? -- To view, visit https://gerrit.ovirt.org/48661 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[master]: net: remove editNetwork old API

Nir Soffer has posted comments on this change. Change subject: net: remove editNetwork old API .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/48910/8//COMMIT_MSG Commit Message: Line 6: Line 7: net: remove editNetw

Change in vdsm[master]: vm: move device attached check to device itself

Nir Soffer has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/48881/10/vdsm/virt/vmdevices/storage.py File vdsm/virt/vm

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

Nir Soffer has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/48473/13/vdsm/virt/vmdevices/storage.py File vdsm/virt/vm

Change in vdsm[master]: daemon: reduce severity of message

Nir Soffer has posted comments on this change. Change subject: daemon: reduce severity of message .. Patch Set 2: Code-Review+1 Piotr, would you ack this? -- To view, visit https://gerrit.ovirt.org/49096 To unsubscribe, visit

Change in vdsm[master]: daemon: avoid contradicting logs about affinity

Nir Soffer has posted comments on this change. Change subject: daemon: avoid contradicting logs about affinity .. Patch Set 1: Code-Review+1 Piotr, would you ack this? -- To view, visit https://gerrit.ovirt.org/49271 To unsub

Change in vdsm[master]: config: Trivial typo fix in option description

gerrit-hooks has posted comments on this change. Change subject: config: Trivial typo fix in option description .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: config: Trivial typo fix in option description

Nir Soffer has submitted this change and it was merged. Change subject: config: Trivial typo fix in option description .. config: Trivial typo fix in option description Change-Id: I527f3f64601d1845e5cca2c73b44d69f957df78f Signe

Change in vdsm[master]: config: Trivial typo fix in option description

Nir Soffer has posted comments on this change. Change subject: config: Trivial typo fix in option description .. Patch Set 1: Verified+1 Trivial change. -- To view, visit https://gerrit.ovirt.org/48820 To unsubscribe, visit h

Change in vdsm[master]: config: Trivial typo fix in option description

Nir Soffer has posted comments on this change. Change subject: config: Trivial typo fix in option description .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48820 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: stomp: make sure that subscriptions use uniqe id

Nir Soffer has posted comments on this change. Change subject: stomp: make sure that subscriptions use uniqe id .. Patch Set 3: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/46656/3/lib/yajsonrpc/stompreactor.py File

Change in vdsm[master]: vm: move device attached check to device itself

Nir Soffer has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 10: Code-Review-1 (1 comment) Just need to remove the unneeded changes in storage.py https://gerrit.o

Change in vdsm[master]: code coverage: change approach how to enable it

Nir Soffer has posted comments on this change. Change subject: code coverage: change approach how to enable it .. Patch Set 3: Edward, running vmdsm via coverage is not good enough for QE, they want an easy way to enable or di

Change in vdsm[master]: code coverage: change approach how to enable it

Nir Soffer has posted comments on this change. Change subject: code coverage: change approach how to enable it .. Patch Set 3: Verified+1 Based on Petr description, marking as verified. -- To view, visit https://gerrit.ovirt.

Change in vdsm[master]: code coverage: change approach how to enable it

Nir Soffer has posted comments on this change. Change subject: code coverage: change approach how to enable it .. Patch Set 3: Petr, yes, adding vdsm-coverage means modifying vdsm.spec.in, and adding the needed files that this

Change in vdsm[master]: code coverage: change approach how to enable it

Petr Balogh has posted comments on this change. Change subject: code coverage: change approach how to enable it .. Patch Set 2: I tested it on my engine(10.34.63.122) and host(10.34.63.123). There are standard passwords (if yo

Change in vdsm[master]: daemon: avoid contradicting logs about affinity

gerrit-hooks has posted comments on this change. Change subject: daemon: avoid contradicting logs about affinity .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: tests: proper cleanup in periodic tests

gerrit-hooks has posted comments on this change. Change subject: tests: proper cleanup in periodic tests .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header match

Change in vdsm[master]: daemon: reduce severity of message

gerrit-hooks has posted comments on this change. Change subject: daemon: reduce severity of message .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'B

Change in vdsm[master]: daemon: avoid contradicting logs about affinity

Francesco Romani has uploaded a new change for review. Change subject: daemon: avoid contradicting logs about affinity .. daemon: avoid contradicting logs about affinity Vdsm can autodisable the affinity if it detects just one c

Change in vdsm[master]: mkimage: setup right permissions before mkisofs

gerrit-hooks has posted comments on this change. Change subject: mkimage: setup right permissions before mkisofs .. Patch Set 7: * #1278414::Update tracker: OK * Set MODIFIED::bug 1278414#1278414OK -- To view, visit h

Change in vdsm[master]: mkimage: setup right permissions before mkisofs

Dan Kenigsberg has submitted this change and it was merged. Change subject: mkimage: setup right permissions before mkisofs .. mkimage: setup right permissions before mkisofs We don't want to depend on the 'childUmask' argument

Change in vdsm[master]: mkimage: setup right permissions before mkisofs

Nir Soffer has posted comments on this change. Change subject: mkimage: setup right permissions before mkisofs .. Patch Set 6: Francesco, do we have a test for the image permissions? -- To view, visit https://gerrit.ovirt.org

Change in vdsm[master]: mkimage: check image attributes after creation

Nir Soffer has posted comments on this change. Change subject: mkimage: check image attributes after creation .. Patch Set 6: Francesco, maybe write simple test for _check_attributes? We would like to have 100% coverage anyway

Change in vdsm[master]: tests: proper cleanup in periodic tests

Francesco Romani has posted comments on this change. Change subject: tests: proper cleanup in periodic tests .. Patch Set 4: Nir: sure thing, will nag few teammates ;) -- To view, visit https://gerrit.ovirt.org/47249 To unsub

Change in vdsm[master]: daemon: reduce severity of message

Francesco Romani has posted comments on this change. Change subject: daemon: reduce severity of message .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/49096/1/vdsm/vdsm File vdsm/vdsm: Line 229: log.info('VD

Change in vdsm[master]: tests: proper cleanup in periodic tests

Nir Soffer has posted comments on this change. Change subject: tests: proper cleanup in periodic tests .. Patch Set 4: Code-Review+1 Waiting for more reviews. -- To view, visit https://gerrit.ovirt.org/47249 To unsubscribe, v

Change in vdsm[master]: tests: proper cleanup in periodic tests

Nir Soffer has posted comments on this change. Change subject: tests: proper cleanup in periodic tests .. Patch Set 4: Francesco, can you get some reviewes from your team? -- To view, visit https://gerrit.ovirt.org/47249 To u

Change in vdsm[master]: daemon: reduce severity of message

Nir Soffer has posted comments on this change. Change subject: daemon: reduce severity of message .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/49096/1/vdsm/vdsm File vdsm/vdsm: Line 229: log.

Change in vdsm[master]: tests: proper cleanup in periodic tests

gerrit-hooks has posted comments on this change. Change subject: tests: proper cleanup in periodic tests .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header match

Change in vdsm[master]: tests: proper cleanup in periodic tests

Francesco Romani has posted comments on this change. Change subject: tests: proper cleanup in periodic tests .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/47249/3/tests/periodicTests.py File tests/periodicTests.py:

Change in vdsm[master]: vmstats: reformat to make the code nicer

Nir Soffer has submitted this change and it was merged. Change subject: vmstats: reformat to make the code nicer .. vmstats: reformat to make the code nicer Silly reformat-only patch to make the code look nicer. Change-Id: I87

Change in vdsm[master]: vmstats: reformat to make the code nicer

gerrit-hooks has posted comments on this change. Change subject: vmstats: reformat to make the code nicer .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: daemon: reduce severity of message

Francesco Romani has posted comments on this change. Change subject: daemon: reduce severity of message .. Patch Set 1: Verified+1 verified offlining all but one cpu cores, and checking the vdsm log: MainThread::INFO::2015-11-

Change in vdsm[master]: vmstats: reformat to make the code nicer

Nir Soffer has posted comments on this change. Change subject: vmstats: reformat to make the code nicer .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48492 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[master]: vmstats: rewrite disk stats to handle missing data

Francesco Romani has posted comments on this change. Change subject: vmstats: rewrite disk stats to handle missing data .. Patch Set 3: Code-Review-1 needs more work. -- To view, visit https://gerrit.ovirt.org/48493 To unsubs

Change in vdsm[master]: vmstats: reformat to make the code nicer

Francesco Romani has posted comments on this change. Change subject: vmstats: reformat to make the code nicer .. Patch Set 3: Additional verification: Run patched vdsm, run one vm. Checked using vdsClient that the affected keys

Change in vdsm[ovirt-3.6]: spec: Require newer qemu version for el7

Nir Soffer has posted comments on this change. Change subject: spec: Require newer qemu version for el7 .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/49205/1/vdsm.spec.in File vdsm.spec.in: Line 229: Requires: qemu

Change in vdsm[master]: mkimage: check image attributes after creation

Francesco Romani has posted comments on this change. Change subject: mkimage: check image attributes after creation .. Patch Set 6: verified only the happy path. I don't know a good way to trigger the new code. Maybe some jugg

Change in vdsm[master]: mkimage: check image attributes after creation

Francesco Romani has posted comments on this change. Change subject: mkimage: check image attributes after creation .. Patch Set 6: Verified+1 verified with 48538 -- To view, visit https://gerrit.ovirt.org/48540 To unsubscrib

Change in vdsm[master]: virt: vm: Update time on VM after resume

Nir Soffer has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/48860/4//COMMIT_MSG Commit Message: Line 20: This change asks li

Change in vdsm[master]: vm: move device attached check to device itself

Marcin Mirecki has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/48881/7/vdsm/virt/vmdevices/storage.py File vdsm/virt/

Change in vdsm[master]: vm: add test for nic unplug wait

gerrit-hooks has posted comments on this change. Change subject: vm: add test for nic unplug wait .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug

Change in vdsm[master]: mkimage: check image attributes after creation

Nir Soffer has posted comments on this change. Change subject: mkimage: check image attributes after creation .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48540 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: mkimage: setup right permissions before mkisofs

Nir Soffer has posted comments on this change. Change subject: mkimage: setup right permissions before mkisofs .. Patch Set 6: Code-Review+2 Pitor, do you want to ack this? -- To view, visit https://gerrit.ovirt.org/48538 To

Change in vdsm[master]: mkimage: setup right permissions before mkisofs

Nir Soffer has posted comments on this change. Change subject: mkimage: setup right permissions before mkisofs .. Patch Set 6: Thanks for describing how you verified it, this should be our standard. -- To view, visit https://

Change in vdsm[master]: vm: move device attached check to device itself

gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

Nir Soffer has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 13: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/48473/13/vdsm/virt/vmdevices/network.py Fil

Change in vdsm[master]: mkimage: setup right permissions before mkisofs

Francesco Romani has posted comments on this change. Change subject: mkimage: setup right permissions before mkisofs .. Patch Set 6: Verified+1 verified running patched VDSM, and booted a VM using cloud-init, which is a easy w

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

Francesco Romani has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 9: Code-Review+2 impressive work, big thanks! -- To view, visit https://gerrit.ovirt.org/48880 To uns

Change in vdsm[master]: mkimage: setup right permissions before mkisofs

gerrit-hooks has posted comments on this change. Change subject: mkimage: setup right permissions before mkisofs .. Patch Set 6: * #1278414::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1278414::OK, public bug *

  1   2   3   >