Change in vdsm[master]: hsm: Prevent stop monitoring of a pool domain

gerrit-hooks has posted comments on this change. Change subject: hsm: Prevent stop monitoring of a pool domain .. Patch Set 6: * #1282187::Update tracker: OK * Set MODIFIED::bug 1282187#1282187FAILED, illegal change

Change in vdsm[master]: sp: Allow attaching of monitored domain

gerrit-hooks has posted comments on this change. Change subject: sp: Allow attaching of monitored domain .. Patch Set 6: * #1269768::Update tracker: OK * Set MODIFIED::bug 1269768#1269768OK -- To view, visit

Change in vdsm[master]: hsm: Prevent stop monitoring of a pool domain

Nir Soffer has submitted this change and it was merged. Change subject: hsm: Prevent stop monitoring of a pool domain .. hsm: Prevent stop monitoring of a pool domain When hosted engine agent is entering local maintenance, it

Change in vdsm[master]: sp: Allow attaching of monitored domain

Nir Soffer has submitted this change and it was merged. Change subject: sp: Allow attaching of monitored domain .. sp: Allow attaching of monitored domain When attaching a storage domain to the pool, the storage domain may be

Change in vdsm[master]: Adding python3 run for nosetests

gerrit-hooks has posted comments on this change. Change subject: Adding python3 run for nosetests .. Patch Set 21: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: hsm: Prevent stop monitoring of a pool domain

Martin Sivák has posted comments on this change. Change subject: hsm: Prevent stop monitoring of a pool domain .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/49387/5/vdsm/storage/hsm.py File vdsm/storage/hsm.py:

Change in vdsm[master]: Adding compatibility for ovirt-engine 4.0 support

Oved Ourfali has posted comments on this change. Change subject: Adding compatibility for ovirt-engine 4.0 support .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49060 To unsubscribe, visit

Change in vdsm[master]: automation: Eliminate unneeded variables

Dan Kenigsberg has posted comments on this change. Change subject: automation: Eliminate unneeded variables .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49283 To unsubscribe, visit

Change in vdsm[master]: automation: Eliminate unneeded variables

gerrit-hooks has posted comments on this change. Change subject: automation: Eliminate unneeded variables .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: v2v: add try/except to get_external_vms

Milan Zamazal has posted comments on this change. Change subject: v2v: add try/except to get_external_vms .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/49507/2/vdsm/v2v.py File vdsm/v2v.py: Line 175:

Change in vdsm[master]: vm: enabling memory snapshot without disks

Daniel Erez has posted comments on this change. Change subject: vm: enabling memory snapshot without disks .. Patch Set 2: Thanks Michal and Arik. @Nir/Francesco - can we move forward with this then? -- To view, visit

Change in vdsm[master]: Always propagate bonding mode to engine

Sagi Shnaidman has posted comments on this change. Change subject: Always propagate bonding mode to engine .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/49580 To unsubscribe, visit

Change in vdsm[master]: Adding to vdsm automation lago env setup for functional tests

gerrit-hooks has posted comments on this change. Change subject: Adding to vdsm automation lago env setup for functional tests .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: schema: introduce HostJobs basic types

Nir Soffer has posted comments on this change. Change subject: schema: introduce HostJobs basic types .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/49450/1/lib/api/vdsmapi-schema.json File

Change in vdsm[master]: Adding compatibility for ovirt-engine 4.0 support

gerrit-hooks has posted comments on this change. Change subject: Adding compatibility for ovirt-engine 4.0 support .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: sp: Allow attaching of monitored domain

Adam Litke has posted comments on this change. Change subject: sp: Allow attaching of monitored domain .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48217 To unsubscribe, visit

Change in vdsm[master]: lvm: Allow multiple initial tags when creating an LV

Nir Soffer has posted comments on this change. Change subject: lvm: Allow multiple initial tags when creating an LV .. Patch Set 6: Code-Review-1 (2 comments) Partial review.

Change in vdsm[master]: Adding compatibility for ovirt-engine 4.0 support

Oved Ourfali has posted comments on this change. Change subject: Adding compatibility for ovirt-engine 4.0 support .. Patch Set 2: the test issue is with: 14:51:28 FAIL: testEnablePromisc (ipwrapperTests.TestDrvinfo) 14:51:28

Change in vdsm[master]: Always propagate bonding mode to engine

Sagi Shnaidman has posted comments on this change. Change subject: Always propagate bonding mode to engine .. Patch Set 1: -Verified -- To view, visit https://gerrit.ovirt.org/49580 To unsubscribe, visit

Change in vdsm[master]: net: Compare kernel vs running bond config opt vals

Edward Haas has uploaded a new change for review. Change subject: net: Compare kernel vs running bond config opt vals .. net: Compare kernel vs running bond config opt vals Comparing between the bond running config and the bond

Change in vdsm[master]: net: Compare kernel vs running bond config opt vals

gerrit-hooks has posted comments on this change. Change subject: net: Compare kernel vs running bond config opt vals .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: Adding compatibility for ovirt-engine 4.0 support

Yaniv Bronhaim has posted comments on this change. Change subject: Adding compatibility for ovirt-engine 4.0 support .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/49060 To unsubscribe, visit

Change in vdsm[master]: Always propagate bonding mode to engine

gerrit-hooks has posted comments on this change. Change subject: Always propagate bonding mode to engine .. Patch Set 1: * #1276445::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1276445::OK, public bug * Check

Change in vdsm[master]: Always propagate bonding mode to engine

Sagi Shnaidman has uploaded a new change for review. Change subject: Always propagate bonding mode to engine .. Always propagate bonding mode to engine Now the mode is not propagated if it's not equal to 0 (default) although

Change in vdsm[master]: virt: add run_async helper

Milan Zamazal has posted comments on this change. Change subject: virt: add run_async helper .. Patch Set 1: (2 comments) Looks nice to me. Just docstrings are missing and see my comments on tests.

Change in vdsm[master]: Always propagate bonding mode to engine

gerrit-hooks has posted comments on this change. Change subject: Always propagate bonding mode to engine .. Patch Set 2: * #1276445::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1276445::OK, public bug * Check

Change in vdsm[master]: monitor: Do not release host id during shutdown

Nir Soffer has submitted this change and it was merged. Change subject: monitor: Do not release host id during shutdown .. monitor: Do not release host id during shutdown When shutting down, all domain monitors are stopped and

Change in vdsm[master]: monitor: Do not release host id during shutdown

Nir Soffer has posted comments on this change. Change subject: monitor: Do not release host id during shutdown .. Patch Set 3: I discussed this with Dan, and we agreed to take this is the best solution. -- To view, visit

Change in vdsm[master]: monitor: Do not release host id during shutdown

gerrit-hooks has posted comments on this change. Change subject: monitor: Do not release host id during shutdown .. Patch Set 4: * #1269768::Update tracker: OK * Set MODIFIED::bug 1269768#1269768IGNORE, not all related

Change in vdsm[master]: automation: Eliminate unneeded variables

Dan Kenigsberg has submitted this change and it was merged. Change subject: automation: Eliminate unneeded variables .. automation: Eliminate unneeded variables There is no point in variables which are used once and are not

Change in vdsm[master]: vm: move device attached check to device itself

Marcin Mirecki has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 15: Verified+1 -- To view, visit https://gerrit.ovirt.org/48881 To unsubscribe, visit

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

Marcin Mirecki has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 12: Verified+1 -- To view, visit https://gerrit.ovirt.org/48880 To unsubscribe, visit

Change in vdsm[master]: vm: adding xpath property to device Base class

Marcin Mirecki has posted comments on this change. Change subject: vm: adding xpath property to device Base class .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/49554 To unsubscribe, visit

Change in vdsm[master]: vm: add test for nic unplug wait

Marcin Mirecki has posted comments on this change. Change subject: vm: add test for nic unplug wait .. Patch Set 11: Verified+1 -- To view, visit https://gerrit.ovirt.org/49104 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: hsm: Prevent stop monitoring of a pool domain

Nir Soffer has posted comments on this change. Change subject: hsm: Prevent stop monitoring of a pool domain .. Patch Set 1: Verified+1 Tested together with other patches on setup with 2 hosts, did several storage and virt

Change in vdsm[ovirt-3.6]: monitor: Do not release host id during shutdown

Nir Soffer has posted comments on this change. Change subject: monitor: Do not release host id during shutdown .. Patch Set 1: Verified+1 Tested together with other patches on setup with 2 hosts, did several storage and virt

Change in vdsm[ovirt-3.6]: sp: Allow attaching of monitored domain

Nir Soffer has posted comments on this change. Change subject: sp: Allow attaching of monitored domain .. Patch Set 1: Verified+1 Tested together with other patches on setup with 2 hosts, did several storage and virt flows.

Change in vdsm[ovirt-3.6]: hsm: Prevent stop monitoring of a pool domain

Hello Adam Litke, Yaniv Bronhaim, Freddy Rolland, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/49598 to review the following change. Change subject: hsm: Prevent stop monitoring of a pool domain

Change in vdsm[ovirt-3.6]: sp: Allow attaching of monitored domain

Hello Adam Litke, Freddy Rolland, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/49597 to review the following change. Change subject: sp: Allow attaching of monitored domain .. sp: Allow

Change in vdsm[master]: v2v: add try/except to get_external_vms

Shahar Havivi has posted comments on this change. Change subject: v2v: add try/except to get_external_vms .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/49507/2/vdsm/v2v.py File vdsm/v2v.py: Line 175:

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

Nir Soffer has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 20: Francesco, can you approve this? I don't think we need the change your requested, but we have a

Change in vdsm[ovirt-3.6]: sp: Allow attaching of monitored domain

gerrit-hooks has posted comments on this change. Change subject: sp: Allow attaching of monitored domain .. Patch Set 1: * #1269768::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1269768::OK, public bug * Check

Change in vdsm[ovirt-3.6]: hsm: Prevent stop monitoring of a pool domain

gerrit-hooks has posted comments on this change. Change subject: hsm: Prevent stop monitoring of a pool domain .. Patch Set 1: * #1282187::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1282187::OK, public bug *

Change in vdsm[ovirt-3.6]: monitor: Do not release host id during shutdown

Nir Soffer has posted comments on this change. Change subject: monitor: Do not release host id during shutdown .. Patch Set 1: Continuous-Integration+1 Test failure is not relevant: 17:32:47 FAIL: testEnablePromisc

Change in vdsm[ovirt-3.6]: monitor: Do not release host id during shutdown

Hello Adam Litke, Sandro Bonazzola, Martin Sivák, Roy Golan, Freddy Rolland, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/49596 to review the following change. Change subject: monitor: Do not release host id during shutdown

Change in vdsm[ovirt-3.6]: monitor: Do not release host id during shutdown

gerrit-hooks has posted comments on this change. Change subject: monitor: Do not release host id during shutdown .. Patch Set 1: * #1269768::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1269768::OK, public bug *

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

Nir Soffer has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 12: Code-Review+2 Thanks Marcin! -- To view, visit https://gerrit.ovirt.org/48880 To unsubscribe, visit

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

Nir Soffer has submitted this change and it was merged. Change subject: vm: unit test for vm._waitForDriveRemoval .. vm: unit test for vm._waitForDriveRemoval Added unit tests for vm._waitForDriveRemoval, in preparation to

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

gerrit-hooks has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 13: * #1134256::Update tracker: OK * Set MODIFIED::bug 1134256#1134256IGNORE, not oVirt

Change in vdsm[master]: lib: daemon: autodetect online cpus for affinity

Nir Soffer has posted comments on this change. Change subject: lib: daemon: autodetect online cpus for affinity .. Patch Set 11: Waiting for Dan -- To view, visit https://gerrit.ovirt.org/49402 To unsubscribe, visit

Change in vdsm[master]: daemon: keep running without affinity.

Nir Soffer has posted comments on this change. Change subject: daemon: keep running without affinity. .. Patch Set 2: Waiting for Dan -- To view, visit https://gerrit.ovirt.org/49562 To unsubscribe, visit

Change in vdsm[master]: daemon: reformat __set_cpu_affinity

Nir Soffer has posted comments on this change. Change subject: daemon: reformat __set_cpu_affinity .. Patch Set 2: Waiting for Dan -- To view, visit https://gerrit.ovirt.org/49561 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: ifcfg: remove files properly on the node

Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: remove files properly on the node .. Patch Set 1: Continuous-Integration+1 unrelated failure: 14:47:24 FAIL: testFakeNics (netinfoTests.TestNetinfo)

Change in vdsm[ovirt-3.5]: ifcfg: remove files properly on the node

Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: remove files properly on the node .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49575 To unsubscribe, visit

Change in vdsm[master]: tests: modprobe validation handle failure

Dan Kenigsberg has posted comments on this change. Change subject: tests: modprobe validation handle failure .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/49538/1/tests/modprobe.py File

Change in vdsm[master]: Include vmfex-dev-hook in vdsm install

Dan Kenigsberg has posted comments on this change. Change subject: Include vmfex-dev-hook in vdsm install .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/49566/2/vdsm.spec.in File vdsm.spec.in: Line

Change in vdsm[master]: Adding to vdsm automation lago env setup for functional tests

David Caro has posted comments on this change. Change subject: Adding to vdsm automation lago env setup for functional tests .. Patch Set 14: @yaniv: This now is able to run the tests, but the tests are failing with: ERROR:

Change in vdsm[master]: Adding to vdsm automation lago env setup for functional tests

gerrit-hooks has posted comments on this change. Change subject: Adding to vdsm automation lago env setup for functional tests .. Patch Set 14: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: hsm: Prevent stop monitoring of a pool domain

gerrit-hooks has posted comments on this change. Change subject: hsm: Prevent stop monitoring of a pool domain .. Patch Set 5: * #1282187::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1282187::OK, public bug *

Change in vdsm[master]: sp: Allow attaching of monitored domain

gerrit-hooks has posted comments on this change. Change subject: sp: Allow attaching of monitored domain .. Patch Set 5: * #1269768::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1269768::OK, public bug * Check

Change in vdsm[master]: sp: Allow attaching of monitored domain

Nir Soffer has posted comments on this change. Change subject: sp: Allow attaching of monitored domain .. Patch Set 5: This version fixes typo on the comment. -- To view, visit https://gerrit.ovirt.org/48217 To unsubscribe,

Change in vdsm[master]: v2v: support for importing Xen VMs via libvirt on RHEL hosts

Shahar Havivi has posted comments on this change. Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts .. Patch Set 2: Verified-1 no need to review, this patch will be changed -- To view, visit

Change in vdsm[master]: sp: Allow attaching of monitored domain

Nir Soffer has posted comments on this change. Change subject: sp: Allow attaching of monitored domain .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/48217/4/vdsm/storage/monitor.py File vdsm/storage/monitor.py:

Change in vdsm[master]: v2v: support for importing Xen VMs via libvirt on RHEL hosts

gerrit-hooks has posted comments on this change. Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: monitor: Do not release host id during shutdown

Nir Soffer has posted comments on this change. Change subject: monitor: Do not release host id during shutdown .. Patch Set 3: Verified+1 Tested vdsm stop/start/restart: - When running as spm - When running as non-spm - When

Change in vdsm[master]: netinfo: assess DHCP on devices from cmdlines of dhclients

Ido Barkan has posted comments on this change. Change subject: netinfo: assess DHCP on devices from cmdlines of dhclients .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49097 To unsubscribe, visit

Change in vdsm[master]: net: Mapping bonding option value names to numerics

Edward Haas has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 10: Verified+1 -- To view, visit https://gerrit.ovirt.org/49390 To unsubscribe, visit

Change in vdsm[master]: v2v: add try/except to get_external_vms

Francesco Romani has posted comments on this change. Change subject: v2v: add try/except to get_external_vms .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/49507/1/vdsm/v2v.py File vdsm/v2v.py: Line 172:

Change in vdsm[master]: vm: add test for nic unplug wait

gerrit-hooks has posted comments on this change. Change subject: vm: add test for nic unplug wait .. Patch Set 11: * #1134256::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1134256::OK, public bug * Check

Change in vdsm[master]: vm: adding xpath property to device Base class

Marcin Mirecki has uploaded a new change for review. Change subject: vm: adding xpath property to device Base class .. vm: adding xpath property to device Base class Change-Id: I29a7989cde44da0f756d48ae139fba47e524a40b Bug-Url:

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

gerrit-hooks has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 12: * #1134256::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1134256::OK, public bug *

Change in vdsm[master]: vm: adding xpath property to device Base class

gerrit-hooks has posted comments on this change. Change subject: vm: adding xpath property to device Base class .. Patch Set 1: * #1134256::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1134256::OK, public bug *

Change in vdsm[master]: vm: move device attached check to device itself

gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 15: * #1134256::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1134256::OK, public bug

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

gerrit-hooks has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 20: * #1134256::Update tracker: OK * #1199782::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

Marcin Mirecki has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 20: xpath property added to base class in: https://gerrit.ovirt.org/49554 -- To view, visit

Change in vdsm[master]: vm: always return bond mode in Host.getCapabilities

Marcin Mirecki has posted comments on this change. Change subject: vm: always return bond mode in Host.getCapabilities .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/49550 To unsubscribe, visit

Change in vdsm[master]: vm: always return bond mode in Host.getCapabilities

Marcin Mirecki has posted comments on this change. Change subject: vm: always return bond mode in Host.getCapabilities .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/49550/1/lib/vdsm/netinfo.py File

Change in vdsm[master]: vm: adding xpath property to device Base class

Nir Soffer has posted comments on this change. Change subject: vm: adding xpath property to device Base class .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/49554/1/vdsm/virt/vmdevices/core.py File

Change in vdsm[master]: vm: adding xpath property to device Base class

Marcin Mirecki has posted comments on this change. Change subject: vm: adding xpath property to device Base class .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/49554/1/vdsm/virt/vmdevices/core.py File

Change in vdsm[master]: net: Mapping bonding option value names to numerics

Ido Barkan has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 10: Code-Review-1 (6 comments) only minor stuff

Change in vdsm[master]: daemon: keep running without affinity.

gerrit-hooks has posted comments on this change. Change subject: daemon: keep running without affinity. .. Patch Set 3: * #1279431::Update tracker: OK * Set MODIFIED::bug 1279431#1279431OK -- To view, visit

Change in vdsm[master]: daemon: keep running without affinity.

Dan Kenigsberg has submitted this change and it was merged. Change subject: daemon: keep running without affinity. .. daemon: keep running without affinity. The cpu affinity is one (important) performance setting, but Vdsm

Change in vdsm[master]: daemon: reformat __set_cpu_affinity

gerrit-hooks has posted comments on this change. Change subject: daemon: reformat __set_cpu_affinity .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: lib: daemon: autodetect online cpus for affinity

gerrit-hooks has posted comments on this change. Change subject: lib: daemon: autodetect online cpus for affinity .. Patch Set 12: * #1286462::Update tracker: OK * #1279431::Update tracker: OK * Set MODIFIED::bug

Change in vdsm[ovirt-3.6]: hsm: Prevent stop monitoring of a pool domain

Francesco Romani has posted comments on this change. Change subject: hsm: Prevent stop monitoring of a pool domain .. Patch Set 1: Code-Review+1 waiting for more reviews from HE devs -- To view, visit

Change in vdsm[master]: v2v: add try/except to get_external_vms

Milan Zamazal has posted comments on this change. Change subject: v2v: add try/except to get_external_vms .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/49507/2/vdsm/v2v.py File vdsm/v2v.py: Line 175:

Change in vdsm[ovirt-3.6]: sp: Allow attaching of monitored domain

Francesco Romani has posted comments on this change. Change subject: sp: Allow attaching of monitored domain .. Patch Set 1: Code-Review+1 waiting for more reviews from HE devs -- To view, visit

Change in vdsm[master]: Always propagate bonding mode to engine

Ido Barkan has posted comments on this change. Change subject: Always propagate bonding mode to engine .. Patch Set 2: (1 comment) Alona, can you please confirm the engine exception?

Change in vdsm[master]: net: split netinfo module

Ido Barkan has posted comments on this change. Change subject: net: split netinfo module .. Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/49198/12/vdsm.spec.in File vdsm.spec.in: Line 1098:

Change in vdsm[ovirt-3.6]: spec: remove leftover directories on host

gerrit-hooks has posted comments on this change. Change subject: spec: remove leftover directories on host .. Patch Set 1: * #1255114::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1255114::OK, public bug * Check

Change in vdsm[ovirt-3.6]: monitor: Do not release host id during shutdown

Sandro Bonazzola has posted comments on this change. Change subject: monitor: Do not release host id during shutdown .. Patch Set 1: Code-Review+1 CI failed on FAIL: testEnablePromisc (ipwrapperTests.TestDrvinfo) which doesn't

Change in vdsm[master]: tests: modprobe validation handle failure

Ido Barkan has posted comments on this change. Change subject: tests: modprobe validation handle failure .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/49538/1/tests/modprobe.py File tests/modprobe.py: Line 38:

Change in vdsm[master]: virt: add run_async helper

Francesco Romani has posted comments on this change. Change subject: virt: add run_async helper .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/49570/1/tests/vmUtilsTests.py File tests/vmUtilsTests.py: Line 169:

Change in vdsm[ovirt-3.6]: monitor: Do not release host id during shutdown

Francesco Romani has posted comments on this change. Change subject: monitor: Do not release host id during shutdown .. Patch Set 1: waiting for more reviews from HE devs -- To view, visit https://gerrit.ovirt.org/49596 To

Change in vdsm[ovirt-3.6]: monitor: Do not release host id during shutdown

Francesco Romani has posted comments on this change. Change subject: monitor: Do not release host id during shutdown .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49596 To unsubscribe, visit

Change in vdsm[master]: net: Mapping bonding option value names to numerics

Ido Barkan has posted comments on this change. Change subject: net: Mapping bonding option value names to numerics .. Patch Set 12: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49390 To unsubscribe, visit

Change in vdsm[master]: daemon: reformat __set_cpu_affinity

Dan Kenigsberg has submitted this change and it was merged. Change subject: daemon: reformat __set_cpu_affinity .. daemon: reformat __set_cpu_affinity Reformat the code to use the 'early return' idiom. No intended changes in

Change in vdsm[master]: lib: daemon: autodetect online cpus for affinity

Dan Kenigsberg has submitted this change and it was merged. Change subject: lib: daemon: autodetect online cpus for affinity .. lib: daemon: autodetect online cpus for affinity In commit a1d4e23 we enabled by default the cpu

Change in vdsm[ovirt-3.6]: spec: remove leftover directories on host

Hello Piotr Kliczewski, Yaniv Bronhaim, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/49607 to review the following change. Change subject: spec: remove leftover directories on host

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

gerrit-hooks has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 21: * #1134256::Update tracker: OK * #1199782::Update tracker: OK * Set MODIFIED::bug

  1   2   >