Change in vdsm[master]: storage: Move constants module to site-packages

Yaniv Bronhaim has posted comments on this change. Change subject: storage: Move constants module to site-packages .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54404 To unsubscribe, visit https://ge

Change in vdsm[master]: storage: Move securable module to site-packages

Freddy Rolland has posted comments on this change. Change subject: storage: Move securable module to site-packages .. Patch Set 2: (10 comments) https://gerrit.ovirt.org/#/c/54424/2/lib/vdsm/storage/Makefile.am File lib/vdsm/s

Change in vdsm[master]: storage: Move securable module to site-packages

gerrit-hooks has posted comments on this change. Change subject: storage: Move securable module to site-packages .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: spec: add virt and netinfo dir in spec

gerrit-hooks has posted comments on this change. Change subject: spec: add virt and netinfo dir in spec .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matche

Change in vdsm[master]: storage: Move constants module to site-packages

gerrit-hooks has posted comments on this change. Change subject: storage: Move constants module to site-packages .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: storage: Move constants module to site-packages

Freddy Rolland has posted comments on this change. Change subject: storage: Move constants module to site-packages .. Patch Set 2: (12 comments) https://gerrit.ovirt.org/#/c/54404/2/lib/vdsm/storage/Makefile.am File lib/vdsm/s

Change in vdsm[master]: vm: devices: fix behaviour with balloon model=none

Martin Polednik has posted comments on this change. Change subject: vm: devices: fix behaviour with balloon model=none .. Patch Set 1: That seems dangerous as alias is generated by libvirt - why is it missing in this case? --

Change in vdsm[master]: virt: Add the missing tests for Drive.getLeasesXML

Freddy Rolland has posted comments on this change. Change subject: virt: Add the missing tests for Drive.getLeasesXML .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54324 To unsubscribe, visit https:/

Change in vdsm[master]: contrib: schema converter

Edward Haas has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 17: (1 comment) https://gerrit.ovirt.org/#/c/52864/17/lib/api/vdsm-api.yaml File lib/api/vdsm-api.yaml: Line 4869: default

Change in vdsm[master]: numa: move cpu_topology to namedtuple

gerrit-hooks has posted comments on this change. Change subject: numa: move cpu_topology to namedtuple .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit htt

Change in vdsm[master]: numa: move cpu_topology to namedtuple

Dan Kenigsberg has submitted this change and it was merged. Change subject: numa: move cpu_topology to namedtuple .. numa: move cpu_topology to namedtuple CPU topology should be returned as immutable object that provides access

Change in vdsm[master]: numa: reorganize module

gerrit-hooks has posted comments on this change. Change subject: numa: reorganize module .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ov

Change in vdsm[master]: numa: add docstrings for public methods

Dan Kenigsberg has submitted this change and it was merged. Change subject: numa: add docstrings for public methods .. numa: add docstrings for public methods Change-Id: Id84872556a3f0699a738071ca7d3f9809bea305b Signed-off-by:

Change in vdsm[master]: numa: add docstrings for public methods

gerrit-hooks has posted comments on this change. Change subject: numa: add docstrings for public methods .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit h

Change in vdsm[master]: numa: reorganize module

Dan Kenigsberg has submitted this change and it was merged. Change subject: numa: reorganize module .. numa: reorganize module As code is pushed into the module, it has became quite disorganized. This patch reorders it, keeping

Change in vdsm[master]: net schema: Add IPv6 networking caps attributes

gerrit-hooks has posted comments on this change. Change subject: net schema: Add IPv6 networking caps attributes .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: net schema: Add IPv6 networking caps attributes

Dan Kenigsberg has submitted this change and it was merged. Change subject: net schema: Add IPv6 networking caps attributes .. net schema: Add IPv6 networking caps attributes Although IPv6 attributes have been handled by VDSM f

Change in vdsm[master]: net: api: keep names and quotes consistent

Dan Kenigsberg has posted comments on this change. Change subject: net: api: keep names and quotes consistent .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/54351/8/lib/vdsm/network/api.py File lib/vdsm/network/api.p

Change in vdsm[master]: net: api: use logger as modules' variable

Dan Kenigsberg has posted comments on this change. Change subject: net: api: use logger as modules' variable .. Patch Set 3: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/54350/3//COMMIT_MSG Commit Message: Line 6:

Change in vdsm[master]: net schema: Add IPv6 setupNetworks attributes

gerrit-hooks has posted comments on this change. Change subject: net schema: Add IPv6 setupNetworks attributes .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, v

Change in vdsm[master]: net schema: Add IPv6 setupNetworks attributes

Dan Kenigsberg has submitted this change and it was merged. Change subject: net schema: Add IPv6 setupNetworks attributes .. net schema: Add IPv6 setupNetworks attributes Although IPv6 attributes have been handled by VDSM for s

Change in vdsm[master]: storage: Move constants module to site-packages

Dan Kenigsberg has posted comments on this change. Change subject: storage: Move constants module to site-packages .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/54404/2/vdsm/storage/hsm.py File vdsm/storage/hsm.py:

Change in vdsm[master]: Remove sparsify from vdsm

Shahar Havivi has posted comments on this change. Change subject: Remove sparsify from vdsm .. Patch Set 1: > (1 comment) > > Can we just drop a method from schema? Seems too easy to be true... Engine doesn't use it, It was

Change in vdsm[master]: storage: Move securable module to site-packages

Nir Soffer has posted comments on this change. Change subject: storage: Move securable module to site-packages .. Patch Set 2: (10 comments) https://gerrit.ovirt.org/#/c/54424/2/lib/vdsm/storage/Makefile.am File lib/vdsm/stora

Change in vdsm[master]: storage: Move constants module to site-packages

Nir Soffer has posted comments on this change. Change subject: storage: Move constants module to site-packages .. Patch Set 2: (5 comments) https://gerrit.ovirt.org/#/c/54404/2/vdsm/storage/Makefile.am File vdsm/storage/Makefi

Change in vdsm[master]: storage: Move constants module to site-packages

Nir Soffer has posted comments on this change. Change subject: storage: Move constants module to site-packages .. Patch Set 2: (6 comments) https://gerrit.ovirt.org/#/c/54404/2/lib/vdsm/storage/Makefile.am File lib/vdsm/storag

Change in vdsm[master]: storage: add storage folder to spec

gerrit-hooks has posted comments on this change. Change subject: storage: add storage folder to spec .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https

Change in vdsm[master]: net: ifcfg: use unified rollback

Edward Haas has posted comments on this change. Change subject: net: ifcfg: use unified rollback .. Patch Set 7: (2 comments) IMO we need a design document for such a change. Based on our last discussion on this, there are sev

Change in vdsm[master]: storage: add storage folder to spec

Nir Soffer has submitted this change and it was merged. Change subject: storage: add storage folder to spec .. storage: add storage folder to spec Add lib storage folder to vdsm.spec.in Change-Id: I378707fb57b9b05cf9439794fd9f

Change in vdsm[master]: schema: add Rng and Tpm device to the device list

Nir Soffer has posted comments on this change. Change subject: schema: add Rng and Tpm device to the device list .. Patch Set 3: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/54425/3/lib/api/vdsmapi-schema.json File

Change in vdsm[master]: net: api: keep names and quotes consistent

Edward Haas has posted comments on this change. Change subject: net: api: keep names and quotes consistent .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/54351/8/lib/vdsm/network/api.py File lib/vdsm/network/api.py:

Change in vdsm[ovirt-3.6]: net schema: Add IPv6 networking caps attributes

Piotr Kliczewski has posted comments on this change. Change subject: net schema: Add IPv6 networking caps attributes .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54445 To unsubscribe, visit https://

Change in vdsm[master]: net schema: Add IPv6 networking caps attributes

Piotr Kliczewski has posted comments on this change. Change subject: net schema: Add IPv6 networking caps attributes .. Patch Set 2: Code-Review+2 OK, let's have it in. -- To view, visit https://gerrit.ovirt.org/54385 To unsu

Change in vdsm[master]: vdsm.host.uuid: eliminate obsoleted argument "legacy"

Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm.host.uuid: eliminate obsoleted argument "legacy" .. Patch Set 2: just for records +1 -- To view, visit https://gerrit.ovirt.org/54384 To unsu

Change in vdsm[master]: net: api: use logger as modules' variable

Edward Haas has posted comments on this change. Change subject: net: api: use logger as modules' variable .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/54350/3/lib/vdsm/network/legacy_switch.py File li

Change in vdsm[master]: net: api: use logger as modules' variable

gerrit-hooks has posted comments on this change. Change subject: net: api: use logger as modules' variable .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: net: ifcfg: use unified rollback

gerrit-hooks has posted comments on this change. Change subject: net: ifcfg: use unified rollback .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug

Change in vdsm[master]: net: api: keep names and quotes consistent

gerrit-hooks has posted comments on this change. Change subject: net: api: keep names and quotes consistent .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header ma

Change in vdsm[master]: net: api: move rollback to network/api.py level

gerrit-hooks has posted comments on this change. Change subject: net: api: move rollback to network/api.py level .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: schema: add Rng and Tpm device to the device list

Piotr Kliczewski has posted comments on this change. Change subject: schema: add Rng and Tpm device to the device list .. Patch Set 3: Code-Review+2 Verified+1 I verified by running my unit tests and schema validation. I was no

Change in vdsm[master]: net schema: Add IPv6 networking caps attributes

Edward Haas has posted comments on this change. Change subject: net schema: Add IPv6 networking caps attributes .. Patch Set 2: Backported to 3.6 per your recommendation. Known to work with Engine 3.5 & 3.6 (the IPv6 fields ha

Change in vdsm[ovirt-3.6]: net schema: Add IPv6 networking caps attributes

Edward Haas has posted comments on this change. Change subject: net schema: Add IPv6 networking caps attributes .. Patch Set 1: Verified+1 Operates fine with Engine 3.5 & 3.6, as these fields are ignored. -- To view, visit ht

Change in vdsm[ovirt-3.6]: net schema: Add IPv6 networking caps attributes

gerrit-hooks has posted comments on this change. Change subject: net schema: Add IPv6 networking caps attributes .. Patch Set 1: Verified-1 * #1315449::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1315449::OK, pu

Change in vdsm[ovirt-3.6]: net schema: Add IPv6 networking caps attributes

Edward Haas has uploaded a new change for review. Change subject: net schema: Add IPv6 networking caps attributes .. net schema: Add IPv6 networking caps attributes Although IPv6 attributes have been handled by VDSM for some tim

Change in vdsm[master]: schema: add Rng and Tpm device to the device list

gerrit-hooks has posted comments on this change. Change subject: schema: add Rng and Tpm device to the device list .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: schema: add Rng and Tpm device to the device list

Francesco Romani has posted comments on this change. Change subject: schema: add Rng and Tpm device to the device list .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/54425/2/lib/api/vdsmapi-schema.json File lib/api/v

Change in vdsm[master]: virt: Move Vm._getUnderlyingDriveInfo() out of Vm

Milan Zamazal has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/53677/7/tests/devices/data/testComplexVm.xml File tes

Change in vdsm[master]: machinetype: split and slightly cpu_models function

Francesco Romani has posted comments on this change. Change subject: machinetype: split and slightly cpu_models function .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/54301/1/lib/vdsm/machinetype.py Fi

Change in vdsm[master]: machinetype: reorganize and rename private functions

Francesco Romani has posted comments on this change. Change subject: machinetype: reorganize and rename private functions .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54300 To unsubscribe, visit htt

Change in vdsm[master]: machinetype: pep8tify the module

Francesco Romani has posted comments on this change. Change subject: machinetype: pep8tify the module .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54299 To unsubscribe, visit https://gerrit.ovirt.or

Change in vdsm[master]: machinetype: update naming

Francesco Romani has posted comments on this change. Change subject: machinetype: update naming .. Patch Set 1: Code-Review+2 nice! -- To view, visit https://gerrit.ovirt.org/54298 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[master]: caps/machinetype: move machine-type related code to new module

Francesco Romani has posted comments on this change. Change subject: caps/machinetype: move machine-type related code to new module .. Patch Set 4: Code-Review+2 since my style comments are addressed by later patches, and since

Change in vdsm[master]: virt: Add the missing tests for Drive.getLeasesXML

Francesco Romani has posted comments on this change. Change subject: virt: Add the missing tests for Drive.getLeasesXML .. Patch Set 2: Code-Review+2 thanks, seems fine -- To view, visit https://gerrit.ovirt.org/54324 To unsu

Change in vdsm[master]: vm: devices: fix behaviour with balloon model=none

Francesco Romani has posted comments on this change. Change subject: vm: devices: fix behaviour with balloon model=none .. Patch Set 1: Right after the start, the balloon has the alias. The very first investigation suggests th

Change in vdsm[master]: spec: add virt and netinfo dir in spec

Piotr Kliczewski has posted comments on this change. Change subject: spec: add virt and netinfo dir in spec .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54439 To unsubscribe, visit https://gerrit.ov

Change in vdsm[master]: spec: add virt and netinfo dir in spec

Yaniv Bronhaim has posted comments on this change. Change subject: spec: add virt and netinfo dir in spec .. Patch Set 1: Code-Review+1 thanks! -- To view, visit https://gerrit.ovirt.org/54439 To unsubscribe, visit https://ge

Change in vdsm[master]: storage: Move securable module to site-packages

Yaniv Bronhaim has posted comments on this change. Change subject: storage: Move securable module to site-packages .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54424 To unsubscribe, visit https://ge

Change in vdsm[master]: storage: Move constants module to site-packages

Yaniv Bronhaim has posted comments on this change. Change subject: storage: Move constants module to site-packages .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54404 To unsubscribe, visit https://ge

Change in vdsm[master]: storage: add storage folder to spec

Yaniv Bronhaim has posted comments on this change. Change subject: storage: add storage folder to spec .. Patch Set 1: Code-Review+1 thnx -- To view, visit https://gerrit.ovirt.org/54431 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: Remove sparsify from vdsm

Francesco Romani has posted comments on this change. Change subject: Remove sparsify from vdsm .. Patch Set 1: Code-Review-1 (1 comment) Can we just drop a method from schema? Seems too easy to be true... https://gerrit.ovirt

Change in vdsm[master]: spec: add virt and netinfo dir in spec

Francesco Romani has posted comments on this change. Change subject: spec: add virt and netinfo dir in spec .. Patch Set 1: Code-Review+1 ops, I think I forgot the virt part -- To view, visit https://gerrit.ovirt.org/54439 To

Change in vdsm[master]: Remove sparsify from vdsm

Francesco Romani has posted comments on this change. Change subject: Remove sparsify from vdsm .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/54426/1//COMMIT_MSG Commit Message: Line 6: Line 7: Remove sparsify from

Change in vdsm[master]: storage: Move constants module to site-packages

Freddy Rolland has posted comments on this change. Change subject: storage: Move constants module to site-packages .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/54404 To unsubscribe, visit https://gerri

Change in vdsm[master]: storage: Move securable module to site-packages

Freddy Rolland has posted comments on this change. Change subject: storage: Move securable module to site-packages .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/54424 To unsubscribe, visit https://gerri

Change in vdsm[master]: storage: add storage folder to spec

Freddy Rolland has posted comments on this change. Change subject: storage: add storage folder to spec .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/54431 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: spec: add virt and netinfo dir in spec

Hello Fred Rolland, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/54439 to review the following change. Change subject: spec: add virt and netinfo dir in spec .. spec: add virt and netinfo dir in

Change in vdsm[master]: vm: devices: fix behaviour with balloon model=none

Francesco Romani has uploaded a new change for review. Change subject: vm: devices: fix behaviour with balloon model=none .. vm: devices: fix behaviour with balloon model=none In the recovery flow, should Vdsm recover a VM confi

Change in vdsm[master]: vm: devices: fix behaviour with balloon model=none

gerrit-hooks has posted comments on this change. Change subject: vm: devices: fix behaviour with balloon model=none .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure h

Change in vdsm[master]: spec: add virt and netinfo dir in spec

gerrit-hooks has posted comments on this change. Change subject: spec: add virt and netinfo dir in spec .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matche

Change in vdsm[master]: storage: add storage folder to spec

Piotr Kliczewski has posted comments on this change. Change subject: storage: add storage folder to spec .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54431 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: virt: more moving under site-packages

Francesco Romani has posted comments on this change. Change subject: virt: more moving under site-packages .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/54366 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[master]: virt: more moving under site-packages

Francesco Romani has posted comments on this change. Change subject: virt: more moving under site-packages .. Patch Set 4: verified creation and recovery flow, sufficient to trigger all the imports here. Let the VM run for few

Change in vdsm[master]: storage: Move constants module to site-packages

Freddy Rolland has posted comments on this change. Change subject: storage: Move constants module to site-packages .. Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/54404/1/vdsm/storage/fileSD.py File vdsm/storage/file

Change in vdsm[master]: virt: more moving under site-packages

gerrit-hooks has posted comments on this change. Change subject: virt: more moving under site-packages .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED

Francesco Romani has posted comments on this change. Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED .. Patch Set 13: Code-Review-1 need to properly understand why this is returned. Otherwise this may hide some

Change in vdsm[master]: storage: add storage folder to spec

gerrit-hooks has posted comments on this change. Change subject: storage: add storage folder to spec .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches '

Change in vdsm[master]: vmstats: avoid NameError

Francesco Romani has posted comments on this change. Change subject: vmstats: avoid NameError .. Patch Set 5: Verified+1 copying score -- To view, visit https://gerrit.ovirt.org/54247 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: storage: Move securable module to site-packages

gerrit-hooks has posted comments on this change. Change subject: storage: Move securable module to site-packages .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: vmstats: avoid NameError

gerrit-hooks has posted comments on this change. Change subject: vmstats: avoid NameError .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: schema: add Rng and Tpm device to the device list

Piotr Kliczewski has posted comments on this change. Change subject: schema: add Rng and Tpm device to the device list .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/54425/2/lib/api/vdsmapi-schema.json File lib/api/v

Change in vdsm[master]: storage: Move constants module to site-packages

gerrit-hooks has posted comments on this change. Change subject: storage: Move constants module to site-packages .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: storage: add storage folder to spec

Hello Fred Rolland, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/54431 to review the following change. Change subject: storage: add storage folder to spec .. storage: add storage folder to spec

Change in vdsm[master]: vmstats: reorder the calculations

gerrit-hooks has posted comments on this change. Change subject: vmstats: reorder the calculations .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu

Change in vdsm[master]: virt: vmstats: do not report bogus stats values.

gerrit-hooks has posted comments on this change. Change subject: virt: vmstats: do not report bogus stats values. .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: vmstats: avoid NameError

Francesco Romani has posted comments on this change. Change subject: vmstats: avoid NameError .. Patch Set 4: Martin: an early return would simplify the code, but will go against the direction bulk stats have established: - ga

Change in vdsm[master]: schema: add Rng and Tpm device to the device list

gerrit-hooks has posted comments on this change. Change subject: schema: add Rng and Tpm device to the device list .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: schema: add Rng and Tpm device to the device list

Piotr Kliczewski has posted comments on this change. Change subject: schema: add Rng and Tpm device to the device list .. Patch Set 1: They look the same from schema definition perspective. We can leave them as they are (both

Change in vdsm[master]: schema: add Rng and Tpm device to the device list

Francesco Romani has posted comments on this change. Change subject: schema: add Rng and Tpm device to the device list .. Patch Set 1: I'd love to kill either one of VmRngDeviceModel or VmRngDeviceType. They are confusing and m

Change in vdsm[master]: schema: add Rng and Tpm device to the device list

Piotr Kliczewski has posted comments on this change. Change subject: schema: add Rng and Tpm device to the device list .. Patch Set 1: I will perform conversion and run unit tests that I created and later will verify in run ti

Change in vdsm[ovirt-3.6]: vmstats: from EAFP to LBYL

gerrit-hooks has posted comments on this change. Change subject: vmstats: from EAFP to LBYL .. Patch Set 6: * #1299480::Update tracker: OK * Set MODIFIED::bug 1299480#1299480IGNORE, not all related patches are closed,

Change in vdsm[master]: vmstats: avoid NameError

Francesco Romani has posted comments on this change. Change subject: vmstats: avoid NameError .. Patch Set 4: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/54247/4//COMMIT_MSG Commit Message: Line 14: vairables (Iron

Change in vdsm[ovirt-3.6]: vmstats: from EAFP to LBYL

Francesco Romani has posted comments on this change. Change subject: vmstats: from EAFP to LBYL .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54001 To unsubscribe, visit https://gerrit.ovirt.org/sett

Change in vdsm[ovirt-3.6]: vmstats: from EAFP to LBYL

Francesco Romani has submitted this change and it was merged. Change subject: vmstats: from EAFP to LBYL .. vmstats: from EAFP to LBYL libvirt bulk stats' API allows to return partial result. Hence, seems better to Look Before

Change in vdsm[ovirt-3.6]: vmstats: remove _diff helper

gerrit-hooks has posted comments on this change. Change subject: vmstats: remove _diff helper .. Patch Set 6: * #1299480::Update tracker: OK * Set MODIFIED::bug 1299480#1299480IGNORE, not all related patches are closed

Change in vdsm[ovirt-3.6]: lib: executor: report worker status in __repr__

gerrit-hooks has posted comments on this change. Change subject: lib: executor: report worker status in __repr__ .. Patch Set 6: * #1250839::Update tracker: OK * Set MODIFIED::bug 1250839#1250839FAILED, illegal change f

Change in vdsm[ovirt-3.6]: vmstats: remove _diff helper

Francesco Romani has posted comments on this change. Change subject: vmstats: remove _diff helper .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54000 To unsubscribe, visit https://gerrit.ovirt.org/se

Change in vdsm[ovirt-3.6]: lib: executor: report worker status in __repr__

Francesco Romani has posted comments on this change. Change subject: lib: executor: report worker status in __repr__ .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/53998 To unsubscribe, visit https://

Change in vdsm[ovirt-3.6]: vmstats: remove _diff helper

Francesco Romani has submitted this change and it was merged. Change subject: vmstats: remove _diff helper .. vmstats: remove _diff helper the _diff helper is pretty pointless: makes the code harder to follow, not easier. This

Change in vdsm[ovirt-3.6]: lib: executor: report worker status in __repr__

Francesco Romani has submitted this change and it was merged. Change subject: lib: executor: report worker status in __repr__ .. lib: executor: report worker status in __repr__ To make the troubleshooting of stuck workers easie

Change in vdsm[master]: schema: add Rng and Tpm device to the device list

Francesco Romani has posted comments on this change. Change subject: schema: add Rng and Tpm device to the device list .. Patch Set 1: Piotr, suggestions for a meaningful verification? Maybe I can rebase on top of some patch o

  1   2   3   >