Change in vdsm[master]: tests: Skip test if veth_pair cannot be created

Edward Haas has posted comments on this change. Change subject: tests: Skip test if veth_pair cannot be created .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54977 To unsubscribe, visit

Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...

gerrit-hooks has posted comments on this change. Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no

Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...

Ondřej Svoboda has posted comments on this change. Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards .. Patch Set 5: (6 comments)

Change in vdsm[master]: network: inherit DUID from a bridge's port with no restriction

Ondřej Svoboda has posted comments on this change. Change subject: network: inherit DUID from a bridge's port with no restriction .. Patch Set 3: Verified+1 testDhcpReplaceNicWithBridge now passes. -- To view, visit

Change in vdsm[master]: hooks:checkips: add checkips hook

Artyom Lukianov has posted comments on this change. Change subject: hooks:checkips: add checkips hook .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/54102/5/vdsm_hooks/checkips/README File

Change in vdsm[master]: network: inherit DUID from a bridge's port with no restriction

Dan Kenigsberg has posted comments on this change. Change subject: network: inherit DUID from a bridge's port with no restriction .. Patch Set 3: -Code-Review -- To view, visit https://gerrit.ovirt.org/54130 To unsubscribe,

Change in vdsm[master]: tests: Skip test if veth_pair cannot be created

Dan Kenigsberg has posted comments on this change. Change subject: tests: Skip test if veth_pair cannot be created .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54977 To unsubscribe, visit

Change in vdsm[master]: network: inherit DUID from a bridge's port with no restriction

Ondřej Svoboda has posted comments on this change. Change subject: network: inherit DUID from a bridge's port with no restriction .. Patch Set 3: (1 comment)

Change in vdsm[master]: directio: Add failing test for DirectFile.readlines()

Nir Soffer has posted comments on this change. Change subject: directio: Add failing test for DirectFile.readlines() .. Patch Set 5: Verified+1 This version use more elegant way to generate the test data. -- To view, visit

Change in vdsm[master]: directio: Remove useless DirectFile.writelines()

gerrit-hooks has posted comments on this change. Change subject: directio: Remove useless DirectFile.writelines() .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: directio: Port to Python 3

gerrit-hooks has posted comments on this change. Change subject: directio: Port to Python 3 .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: directio: Require full blocks

gerrit-hooks has posted comments on this change. Change subject: directio: Require full blocks .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: Modernize test names

gerrit-hooks has posted comments on this change. Change subject: tests: Modernize test names .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: fileUtils: Remove open_ex

gerrit-hooks has posted comments on this change. Change subject: fileUtils: Remove open_ex .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: directio: Add failing test for DirectFile.readlines()

gerrit-hooks has posted comments on this change. Change subject: directio: Add failing test for DirectFile.readlines() .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: tests: Replace magic number with constant

gerrit-hooks has posted comments on this change. Change subject: tests: Replace magic number with constant .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: fileUtils: Remove the redundant "d" mode

gerrit-hooks has posted comments on this change. Change subject: fileUtils: Remove the redundant "d" mode .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: directio: Keep line terminators in readlines()

gerrit-hooks has posted comments on this change. Change subject: directio: Keep line terminators in readlines() .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: directio: Add test for reading entire file

gerrit-hooks has posted comments on this change. Change subject: directio: Add test for reading entire file .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: Simplify DirectFile tests

gerrit-hooks has posted comments on this change. Change subject: tests: Simplify DirectFile tests .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: directio: Introduce vdsm.storage.directio module

gerrit-hooks has posted comments on this change. Change subject: directio: Introduce vdsm.storage.directio module .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: Skip test if veth_pair cannot be created

Nir Soffer has posted comments on this change. Change subject: tests: Skip test if veth_pair cannot be created .. Patch Set 1: Verified+1 Broken test that use this pass now. -- To view, visit https://gerrit.ovirt.org/54977

Change in vdsm[master]: tests: Skip test if veth_pair cannot be created

Nir Soffer has uploaded a new change for review. Change subject: tests: Skip test if veth_pair cannot be created .. tests: Skip test if veth_pair cannot be created The context manager used try-except-finally in the wrong way,

Change in vdsm[master]: tests: Skip test if veth_pair cannot be created

gerrit-hooks has posted comments on this change. Change subject: tests: Skip test if veth_pair cannot be created .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: dsaversion: Remove 3.4 support

Dan Kenigsberg has submitted this change and it was merged. Change subject: dsaversion: Remove 3.4 support .. dsaversion: Remove 3.4 support The current VDSM no longer supports 3.4 clusters (see, e.g., commit 1f21f1c). This

Change in vdsm[master]: dsaversion: Remove 3.4 support

gerrit-hooks has posted comments on this change. Change subject: dsaversion: Remove 3.4 support .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: el7: require newly available python34-nose

Dan Kenigsberg has posted comments on this change. Change subject: el7: require newly available python34-nose .. Patch Set 5: retriggering tell me nothing, as it runs only on f23 :-/ -- To view, visit

Change in vdsm[master]: directio: Add failing test for DirectFile.readlines()

Dan Kenigsberg has posted comments on this change. Change subject: directio: Add failing test for DirectFile.readlines() .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54694 To unsubscribe, visit

Change in vdsm[master]: storage: move persistent to lib

Nir Soffer has posted comments on this change. Change subject: storage: move persistent to lib .. Patch Set 2: Can you verify? -- To view, visit https://gerrit.ovirt.org/54582 To unsubscribe, visit

Change in vdsm[master]: storage: move persistent to lib

Nir Soffer has posted comments on this change. Change subject: storage: move persistent to lib .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54582 To unsubscribe, visit

Change in vdsm[master]: directio: Introduce vdsm.storage.directio module

Dan Kenigsberg has posted comments on this change. Change subject: directio: Introduce vdsm.storage.directio module .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54690 To unsubscribe, visit

Change in vdsm[master]: tests: Simplify DirectFile tests

Dan Kenigsberg has posted comments on this change. Change subject: tests: Simplify DirectFile tests .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54678 To unsubscribe, visit

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

Nir Soffer has posted comments on this change. Change subject: storage: Remove legacy get[Iso|Floppy]List .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54900 To unsubscribe, visit

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

Nir Soffer has posted comments on this change. Change subject: tests: Run unit tests using travis-ci and docker .. Patch Set 5: (4 comments) https://gerrit.ovirt.org/#/c/54856/5/.travis.yml File .travis.yml: Line 4: -

Change in vdsm[master]: hooks:checkips: add checkips hook

Dan Kenigsberg has posted comments on this change. Change subject: hooks:checkips: add checkips hook .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/54102/5/vdsm_hooks/checkips/README File vdsm_hooks/checkips/README:

Change in vdsm[master]: el7: require newly available python34-nose

gerrit-hooks has posted comments on this change. Change subject: el7: require newly available python34-nose .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: el7: require newly available python34-nose

Dan Kenigsberg has posted comments on this change. Change subject: el7: require newly available python34-nose .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/54685/4/automation/check-merged.packages.el7 File

Change in vdsm[master]: network: inherit DUID from a bridge's port with no restriction

Dan Kenigsberg has posted comments on this change. Change subject: network: inherit DUID from a bridge's port with no restriction .. Patch Set 3: Code-Review-1 (1 comment)

Change in vdsm[master]: network: inherit DUID from a bridge's port with no restriction

gerrit-hooks has posted comments on this change. Change subject: network: inherit DUID from a bridge's port with no restriction .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: guest-agent: Fix API version negotiation

Francesco Romani has posted comments on this change. Change subject: guest-agent: Fix API version negotiation .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/54871/1/lib/vdsm/virt/guestagent.py File

Change in vdsm[master]: net: native ovs [2], fake bridgeless

gerrit-hooks has posted comments on this change. Change subject: net: native ovs [2], fake bridgeless .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: response: Add support for specific error checking in is_error

Dan Kenigsberg has submitted this change and it was merged. Change subject: response: Add support for specific error checking in is_error .. response: Add support for specific error checking in is_error response.is_error can

Change in vdsm[master]: vm: conf: proper locking in migration path

Dan Kenigsberg has posted comments on this change. Change subject: vm: conf: proper locking in migration path .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/54905/1//COMMIT_MSG Commit Message: Line 3: AuthorDate:

Change in vdsm[master]: vm: Move saveState() out of constructor

Martin Betak has posted comments on this change. Change subject: vm: Move saveState() out of constructor .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/53950/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 686:

Change in vdsm[master]: WIP: vm: skip domDependentInit for containers

gerrit-hooks has posted comments on this change. Change subject: WIP: vm: skip domDependentInit for containers .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

Edward Haas has posted comments on this change. Change subject: tests: Run unit tests using travis-ci and docker .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/54856/5/.travis.yml File .travis.yml: Line 11: -

Change in vdsm[master]: net: native ovs [3], ip handling

gerrit-hooks has posted comments on this change. Change subject: net: native ovs [3], ip handling .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: net: native ovs [2], fake bridgeless

gerrit-hooks has posted comments on this change. Change subject: net: native ovs [2], fake bridgeless .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: net: native ovs [2], fake bridgeless

Petr Horáček has posted comments on this change. Change subject: net: native ovs [2], fake bridgeless .. Patch Set 6: Verified+1 Passed most of OVS test OK (except IP and MTU ones). All networks are shown in caps-networks

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

Edward Haas has posted comments on this change. Change subject: tests: Run unit tests using travis-ci and docker .. Patch Set 5: (4 comments) https://gerrit.ovirt.org/#/c/54856/5/.travis.yml File .travis.yml: Line 4: -

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

Allon Mureinik has posted comments on this change. Change subject: storage: Remove legacy get[Iso|Floppy]List .. Patch Set 5: Verified+1 And now with the typo actually fixed. -- To view, visit https://gerrit.ovirt.org/54900

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

gerrit-hooks has posted comments on this change. Change subject: storage: Remove legacy get[Iso|Floppy]List .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: pool: Remove refreshStoragePool verb

gerrit-hooks has posted comments on this change. Change subject: pool: Remove refreshStoragePool verb .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: net: native ovs [1]

Petr Horáček has posted comments on this change. Change subject: net: native ovs [1] .. Patch Set 20: Verified+1 Most of OVS tests passed (except IP and MTU ones) -- To view, visit https://gerrit.ovirt.org/54890 To

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

Allon Mureinik has posted comments on this change. Change subject: storage: Remove legacy get[Iso|Floppy]List .. Patch Set 3: Verified+1 Fixed typo in comment as noticed in Nir's review -- To view, visit

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

Nir Soffer has posted comments on this change. Change subject: storage: Remove legacy get[Iso|Floppy]List .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/54900/3/lib/vdsm/storage/exception.py File

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

Allon Mureinik has posted comments on this change. Change subject: storage: Remove legacy get[Iso|Floppy]List .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/54900/3/lib/vdsm/storage/exception.py File

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

Nir Soffer has posted comments on this change. Change subject: tests: Run unit tests using travis-ci and docker .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/54856/5/.travis.yml File .travis.yml: Line 11: -

Change in vdsm[master]: net: native ovs [2], fake bridgeless

gerrit-hooks has posted comments on this change. Change subject: net: native ovs [2], fake bridgeless .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

Nir Soffer has posted comments on this change. Change subject: tests: Run unit tests using travis-ci and docker .. Patch Set 5: (4 comments) https://gerrit.ovirt.org/#/c/54856/5/.travis.yml File .travis.yml: Line 4: -

Change in vdsm[master]: net: native ovs [1]

gerrit-hooks has posted comments on this change. Change subject: net: native ovs [1] .. Patch Set 20: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: vm: do not call before_vm_start in dehibernation

gerrit-hooks has posted comments on this change. Change subject: vm: do not call before_vm_start in dehibernation .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: virt: recovery: refactor entry points

gerrit-hooks has posted comments on this change. Change subject: virt: recovery: refactor entry points .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: net tests: TestIPv6Addresses should run as root

Edward Haas has uploaded a new change for review. Change subject: net tests: TestIPv6Addresses should run as root .. net tests: TestIPv6Addresses should run as root In addition, it is marked as an integration test. Change-Id:

Change in vdsm[master]: net: native ovs [3], ip handling

gerrit-hooks has posted comments on this change. Change subject: net: native ovs [3], ip handling .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: hooks:checkips: add checkips hook

Artyom Lukianov has posted comments on this change. Change subject: hooks:checkips: add checkips hook .. Patch Set 5: (7 comments) https://gerrit.ovirt.org/#/c/54102/5/vdsm_hooks/checkips/README File

Change in vdsm[ovirt-3.6]: virt: migration: initialize SourceThread._destServer on __in...

Nir Soffer has posted comments on this change. Change subject: virt: migration: initialize SourceThread._destServer on __init__ .. Patch Set 1: Francesco, Yaniv, I think this is ready for merge. -- To view, visit

Change in vdsm[ovirt-3.6]: virt: migration: initialize SourceThread._destServer on __in...

Anonymous Coward #1001177 has posted comments on this change. Change subject: virt: migration: initialize SourceThread._destServer on __init__ .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/54949 To

Change in vdsm[master]: rfh: Remove legacy remoteFileHandler

Freddy Rolland has posted comments on this change. Change subject: rfh: Remove legacy remoteFileHandler .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54703 To unsubscribe, visit

Change in vdsm[master]: tests: Replace magic number with constant

Freddy Rolland has posted comments on this change. Change subject: tests: Replace magic number with constant .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54954 To unsubscribe, visit

Change in vdsm[master]: storage: move persistent to lib

Freddy Rolland has posted comments on this change. Change subject: storage: move persistent to lib .. Patch Set 1: (5 comments) https://gerrit.ovirt.org/#/c/54582/1/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line

Change in vdsm[master]: storage: move persistent to lib

gerrit-hooks has posted comments on this change. Change subject: storage: move persistent to lib .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: pool: Remove refreshStoragePool verb

gerrit-hooks has posted comments on this change. Change subject: pool: Remove refreshStoragePool verb .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

gerrit-hooks has posted comments on this change. Change subject: tests: Run unit tests using travis-ci and docker .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

Edward Haas has posted comments on this change. Change subject: tests: Run unit tests using travis-ci and docker .. Patch Set 4: Verified+1 Tested on Travis CI: https://travis-ci.org/EdDev/vdsm/builds/117228402 Runs now on

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

gerrit-hooks has posted comments on this change. Change subject: tests: Run unit tests using travis-ci and docker .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: ovs: mock setupNetworks in OVSNetworkTests class

gerrit-hooks has posted comments on this change. Change subject: tests: ovs: mock setupNetworks in OVSNetworkTests class .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: containers: initial support

gerrit-hooks has posted comments on this change. Change subject: containers: initial support .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: hostdev: decode XML string when parsing devices

Martin Polednik has posted comments on this change. Change subject: hostdev: decode XML string when parsing devices .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/54802/1/lib/vdsm/hostdev.py File

Change in vdsm[master]: hostdev: add vdsClient hotunplug command

Martin Polednik has uploaded a new change for review. Change subject: hostdev: add vdsClient hotunplug command .. hostdev: add vdsClient hotunplug command Change-Id: Ie00e5510b5306d689536b24091411332c8b80e75 Signed-off-by:

Change in vdsm[master]: pool: Remove refreshStoragePool verb

gerrit-hooks has posted comments on this change. Change subject: pool: Remove refreshStoragePool verb .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

gerrit-hooks has posted comments on this change. Change subject: storage: Remove legacy get[Iso|Floppy]List .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header