Nir Soffer has posted comments on this change.
Change subject: verify_untrusted_volume: Check compatibility version
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/59411/14/vdsm/storage/hsm.py
File vdsm/storage/hsm.p
Nir Soffer has posted comments on this change.
Change subject: verify_untrusted_volume: Only allow compat designated by config
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60113/1/vdsm/storage/hsm.py
File vdsm/stor
Adam Litke has posted comments on this change.
Change subject: verify_untrusted_volume: Check compatibility version
..
Patch Set 14: Verified+1
--
To view, visit https://gerrit.ovirt.org/59411
To unsubscribe, visit https://ger
Adam Litke has posted comments on this change.
Change subject: verify_untrusted_volume: Only allow compat designated by config
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/60113
To unsubscribe, visit h
Adam Litke has uploaded a new change for review.
Change subject: verify_untrusted_volume: Only allow compat designated by config
..
verify_untrusted_volume: Only allow compat designated by config
Currently each host sets which q
Nir Soffer has posted comments on this change.
Change subject: tests: Add tests for verify_untrusted_volume
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60060
To unsubscribe, visit https://gerrit.ov
Adam Litke has posted comments on this change.
Change subject: tests: Add tests for verify_untrusted_volume
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/60060
To unsubscribe, visit https://gerrit.ovirt
Adam Litke has abandoned this change.
Change subject: tests: Refactor hsm import in storage_hsm_test.py
..
Abandoned
squashed
--
To view, visit https://gerrit.ovirt.org/60112
To unsubscribe, visit https://gerrit.ovirt.org/set
Nir Soffer has posted comments on this change.
Change subject: tests: Refactor hsm import in storage_hsm_test.py
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60112/1//COMMIT_MSG
Commit Message:
Line 7: tests: Refa
Nir Soffer has posted comments on this change.
Change subject: tests: Refactor hsm import in storage_hsm_test.py
..
Patch Set 1: Code-Review-1
(1 comment)
Why not squash this patch into the original patch?
https://gerrit.ovir
Nir Soffer has posted comments on this change.
Change subject: verify_untrusted_volume: Check compatibility version
..
Patch Set 12: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/59411/12/vdsm/storage/hsm.py
File vdsm
Adam Litke has posted comments on this change.
Change subject: verify_untrusted_volume: Check compatibility version
..
Patch Set 12: Verified+1
This version also validates the compat value against the vdsm config file as is
re
Adam Litke has posted comments on this change.
Change subject: qemuimg: Introduce supports_compat helper
..
Patch Set 12:
Amit, I still think this patch is correct. See the top patch in this topic for
how we can validate agai
Adam Litke has posted comments on this change.
Change subject: tests: Refactor hsm import in storage_hsm_test.py
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/60112
To unsubscribe, visit https://gerrit.
Adam Litke has uploaded a new change for review.
Change subject: tests: Refactor hsm import in storage_hsm_test.py
..
tests: Refactor hsm import in storage_hsm_test.py
We currently import HSM from storage.hsm but a future patch
Nir Soffer has posted comments on this change.
Change subject: tests: Add tests for verify_untrusted_volume
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/60060/3/tests/storage_hsm_test.py
File tests/storage_hsm_test
Adam Litke has posted comments on this change.
Change subject: tests: Add tests for verify_untrusted_volume
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/60060
To unsubscribe, visit https://gerrit.ovirt
Adam Litke has abandoned this change.
Change subject: Refactor verify_untrusted_volume
..
Abandoned
We're keeping all the logic in the hsm verb.
--
To view, visit https://gerrit.ovirt.org/59409
To unsubscribe, visit https://g
Adam Litke has posted comments on this change.
Change subject: tests: Add tests for verify_untrusted_volume
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/60060/1/tests/Makefile.am
File tests/Makefile.am:
Line 155
Nir Soffer has submitted this change and it was merged.
Change subject: hsm: Use manifest in verify_untrusted_volume
..
hsm: Use manifest in verify_untrusted_volume
New users of storage objects should generally use the new *Man
Nir Soffer has posted comments on this change.
Change subject: tests: Add tests for verify_untrusted_volume
..
Patch Set 2: Code-Review-1
Please check my comments in version 1:
https://gerrit.ovirt.org/#/c/60060/1/tests/storage
Nir Soffer has posted comments on this change.
Change subject: xmlrpc: Hide fenceNode password in the log
..
Patch Set 1:
Are you sure you want to backport these patches to 3.6?
This is risky, and the patches do not fix any cr
Nir Soffer has posted comments on this change.
Change subject: tests: Add tests for verify_untrusted_volume
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60060/1/tests/Makefile.am
File tests/Makefile.am:
Line 155
L
Francesco Romani has posted comments on this change.
Change subject: xmlrpc: Hide fenceNode password in the log
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60096
To unsubscribe, visit https://gerri
Nir Soffer has posted comments on this change.
Change subject: test: Introduce mock module for testing
..
Patch Set 2:
Edward, in which channel the package is available? Did you test it on rhel
machine configured with the prop
Hello Nir Soffer, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60101
to review the following change.
Change subject: rpc: Log important info from VM stats
..
rpc: Log important
Hello Piotr Kliczewski, Nir Soffer, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60100
to review the following change.
Change subject: logging: Introduce throttledlog
..
loggin
Hello Nir Soffer, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60099
to review the following change.
Change subject: rpc: Use Suppressed class instead of logging workarounds
..
Hello Piotr Kliczewski, Nir Soffer, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60102
to review the following change.
Change subject: rpc: Log RPC call summary on info level
..
Hello Piotr Kliczewski, Nir Soffer, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60103
to review the following change.
Change subject: rpc: Log also error codes of RPC calls
..
Hello Nir Soffer, Francesco Romani, Michal Skrivanek,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60098
to review the following change.
Change subject: rpc: Log calls of API methods with possibly large results
Hello Piotr Kliczewski, Nir Soffer, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60096
to review the following change.
Change subject: xmlrpc: Hide fenceNode password in the log
...
Hello Piotr Kliczewski, Nir Soffer, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60097
to review the following change.
Change subject: rpc: Lower logging priority just for getAllVmStats
...
Edward Haas has posted comments on this change.
Change subject: test: Introduce mock module for testing
..
Patch Set 2:
Nir, please check the first comment on this gerrit patch, it has all the
references.
--
To view, visit h
Francesco Romani has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/59834/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 811:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 7:
OK, let me check hard coding the path. It should simplify bunch of code we have.
--
To view, visit h
Nir Soffer has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/52354/7/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:
Line 103
Line
Nir Soffer has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/52354/7/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:
Line 263
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/59834/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 811:
Piotr Kliczewski has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 7:
(4 comments)
https://gerrit.ovirt.org/#/c/52354/7/lib/vdsm/constants.py.in
File lib/vdsm/constants.py
Tomas Jelinek has posted comments on this change.
Change subject: migration: wait properly for migration to begin
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/60073/3/vdsm/virt/migration.py
File vdsm/virt/migration
Nir Soffer has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 7:
(3 comments)
I think that the issue is trying to support dynamic pki dir, while some of the
code is using
Nir Soffer has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/52354/7/lib/vdsm/constants.py.in
File lib/vdsm/constants.py.in:
L
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Introduce supports_compat helper
..
Patch Set 10:
Please rebase this bellow the last patch, so we can take the patches above
easily.
--
To view, visit h
Nir Soffer has posted comments on this change.
Change subject: verify_untrusted_volume: Check compatibility version
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/59411/9/tests/storage_hsm_test.py
File tests/storage_
Nir Soffer has posted comments on this change.
Change subject: tests: Add tests for verify_untrusted_volume
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60060/1/tests/storage_hsm_test.py
File tests/storage_hsm_test
Simone Tiraboschi has posted comments on this change.
Change subject: jsonrpcvdscli: add additional verbs
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/60054
To unsubscribe, visit https://gerrit.ovirt.o
Adam Litke has posted comments on this change.
Change subject: hsm: Use manifest in verify_untrusted_volume
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/60059
To unsubscribe, visit https://gerrit.ovirt
Milan Zamazal has posted comments on this change.
Change subject: hostdev: move scsi device code to separate class
..
Patch Set 8:
(1 comment)
With the exception of the comment below it looks OK to me.
https://gerrit.ovirt.or
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for Host.hostdevListByCaps
..
Patch Set 2:
(4 comments)
https://gerrit.ovirt.org/#/c/59703/2/lib/api/vdsm-api.yml
File lib/api/vdsm-ap
Milan Zamazal has posted comments on this change.
Change subject: hostdev: move usb device code to separate class
..
Patch Set 8:
(1 comment)
With the exception of the comment below it looks OK to me.
https://gerrit.ovirt.org
Francesco Romani has posted comments on this change.
Change subject: hostdev: use specific device classes in HostDevice
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/57963/8/vdsm/virt/vmdevices/hostdevice.py
File vd
Milan Zamazal has posted comments on this change.
Change subject: hostdev: move pci device code to separate class
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/57956/8/vdsm/virt/vmdevices/hostdevice.py
File vdsm/vir
Nir Soffer has posted comments on this change.
Change subject: test: Introduce mock module for testing
..
Patch Set 2:
Edward, we reverted this last time because the package was not available on
rhel. Is it available now?
Not
Milan Zamazal has posted comments on this change.
Change subject: hostdev: use specific device classes in HostDevice
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/57963/8/vdsm/virt/vmdevices/hostdevice.py
File vdsm
Francesco Romani has posted comments on this change.
Change subject: migration: wait properly for migration to begin
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/60073/3/vdsm/virt/migration.py
File vdsm/virt/migrat
Nir Soffer has posted comments on this change.
Change subject: tox: fail make process if required tox version isn't installed.
..
Patch Set 16:
(1 comment)
https://gerrit.ovirt.org/#/c/59306/16/build-aux/vercmp
File build-aux/
Martin Polednik has posted comments on this change.
Change subject: yml: return type fixes for Host.hostdevListByCaps
..
Patch Set 2: Code-Review-1
(4 comments)
I have a feeling that some of the values are missing (correct me
Milan Zamazal has posted comments on this change.
Change subject: hostdev: move pci device code to separate class
..
Patch Set 8: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/57956/8/vdsm/virt/vmdevices/hostdevice.py
Martin Polednik has posted comments on this change.
Change subject: hostdev: use specific device classes in HostDevice
..
Patch Set 8: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/57963/8/vdsm/virt/vmdevices/hostdevi
Piotr Kliczewski has posted comments on this change.
Change subject: tests: missing dispatch in jsonrpc integration tests
..
Patch Set 4:
ping
--
To view, visit https://gerrit.ovirt.org/58523
To unsubscribe, visit https://ger
Piotr Kliczewski has abandoned this change.
Change subject: schema: restore still used types
..
Abandoned
We do not need this patch any more.
--
To view, visit https://gerrit.ovirt.org/55574
To unsubscribe, visit https://gerr
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: simplified client
..
Patch Set 4: Verified+1
Removed comment. No code changes. Verified in previous patch set.
--
To view, visit https://gerrit.ovirt
Milan Zamazal has posted comments on this change.
Change subject: hostdev: move pci device code to separate class
..
Patch Set 8: Code-Review+1
I'm not particularly fond of the code duplication, but it's better than the
origin
Piotr Kliczewski has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 7: Verified+1
Verified by updating vdsm and running a vm.
--
To view, visit https://gerrit.ovirt.org/52
Francesco Romani has posted comments on this change.
Change subject: test: Introduce mock module for testing
..
Patch Set 2: Code-Review+1
let's use modern tools
--
To view, visit https://gerrit.ovirt.org/59797
To unsubscribe
Francesco Romani has posted comments on this change.
Change subject: yml: return type fixes for Host.hostdevListByCaps
..
Patch Set 2: Code-Review+1
looks OK, but I'd like to have Martin's ack as well
--
To view, visit https:
Francesco Romani has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/59834/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 383:
Tomas Jelinek has posted comments on this change.
Change subject: migration: wait properly for migration to begin
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/60073/3/vdsm/virt/migration.py
File vdsm/virt/migration
Milan Zamazal has posted comments on this change.
Change subject: hostdev: improve robustness of libvirt SCSI access
..
Patch Set 7: Code-Review+1
AFAICT I can't see any obvious problem.
--
To view, visit https://gerrit.ovirt
Francesco Romani has posted comments on this change.
Change subject: migration: wait properly for migration to begin
..
Patch Set 3: Code-Review-1
(1 comment)
-1 for visibility only, please check the inline comment
https://ge
Martin Polednik has posted comments on this change.
Change subject: hostdev: use specific device classes in HostDevice
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/57963/8/vdsm/virt/vmdevices/hostdevice.py
File vds
Martin Polednik has posted comments on this change.
Change subject: hostdev: use specific device classes in HostDevice
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/57963/8/vdsm/virt/vmdevices/hostdevice.py
File vds
Francesco Romani has posted comments on this change.
Change subject: hostdev: use specific device classes in HostDevice
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/57963/8/vdsm/virt/vmdevices/hostdevice.py
File vd
Milan Zamazal has posted comments on this change.
Change subject: hostdev: use specific device classes in HostDevice
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/57963/8/vdsm/virt/vmdevices/hostdevice.py
File vdsm/
Milan Zamazal has posted comments on this change.
Change subject: migration: wait properly for migration to begin
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60073
To unsubscribe, visit https://ger
Tomas Jelinek has posted comments on this change.
Change subject: migration: wait properly for migration to begin
..
Patch Set 3:
(4 comments)
https://gerrit.ovirt.org/#/c/60073/2//COMMIT_MSG
Commit Message:
PS2, Line 13: eve
Milan Zamazal has posted comments on this change.
Change subject: migration: wait properly for migration to begin
..
Patch Set 2:
(4 comments)
https://gerrit.ovirt.org/#/c/60073/2//COMMIT_MSG
Commit Message:
PS2, Line 13: eve
Francesco Romani has submitted this change and it was merged.
Change subject: migration: fix typo
..
migration: fix typo
A typo sneaked in during the review of commit 1e7d561
Change-Id: I421a7ba0d0ffedc2a90a79aab37712fabbddebc
Francesco Romani has posted comments on this change.
Change subject: migration: fix typo
..
Patch Set 2:
raising score
--
To view, visit https://gerrit.ovirt.org/60037
To unsubscribe, visit https://gerrit.ovirt.org/settings
Francesco Romani has posted comments on this change.
Change subject: migration: fix typo
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60037
To unsubscribe, visit https://gerrit.ovirt.org/settings
G
Tomas Jelinek has uploaded a new change for review.
Change subject: migration: wait properly for migration to begin
..
migration: wait properly for migration to begin
If the time it takes the migration to begin is longer than th
Piotr Kliczewski has posted comments on this change.
Change subject: test: Introduce mock module for testing
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59797
To unsubscribe, visit https://gerrit.o
Piotr Kliczewski has posted comments on this change.
Change subject: automation: Increase timeout for make check
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60051
To unsubscribe, visit https://gerr
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: add additional verbs
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60054
To unsubscribe, visit https://gerrit.ovirt
Francesco Romani has submitted this change and it was merged.
Change subject: API: doc: reformat docstring for consistency
..
API: doc: reformat docstring for consistency
Change-Id: I13e3b6e85ab6a935ec15e581fba9fecc02fc588b
Bac
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: adding handling for NGN in osinfo.py
..
vdsm: adding handling for NGN in osinfo.py
Current osinfo.py implementation lacks handling for NGN (New G
Piotr Kliczewski has posted comments on this change.
Change subject: Makefile: added 'tests' target
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59417
To unsubscribe, visit https://gerrit.ovirt.org/
Piotr Kliczewski has posted comments on this change.
Change subject: vdsm.spec: during rpm build only tests target will run
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59910
To unsubscribe, visit h
Francesco Romani has submitted this change and it was merged.
Change subject: API: allow setLogLevel to tune a specific logger
..
API: allow setLogLevel to tune a specific logger
The not so known setLogLevel VDSM verb allows to
Francesco Romani has submitted this change and it was merged.
Change subject: API: logging: move setLogLevel code into logUtils
..
API: logging: move setLogLevel code into logUtils
Move the implementation of API.setLogLevel int
Milan Zamazal has posted comments on this change.
Change subject: API: allow setLogLevel to tune a specific logger
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59874
To unsubscribe, visit https://ge
Francesco Romani has submitted this change and it was merged.
Change subject: API: streamline and make setLogLevel correct
..
API: streamline and make setLogLevel correct
According to the schema, setLogLevel should accept
a log
Milan Zamazal has posted comments on this change.
Change subject: API: streamline and make setLogLevel correct
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59873
To unsubscribe, visit https://gerrit
Milan Zamazal has posted comments on this change.
Change subject: API: logging: move setLogLevel code into logUtils
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59872
To unsubscribe, visit https://g
Martin Polednik has posted comments on this change.
Change subject: API: logging: move setLogLevel code into logUtils
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59872
To unsubscribe, visit https:/
Francesco Romani has posted comments on this change.
Change subject: API: doc: reformat docstring for consistency
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59875
To unsubscribe, visit https://ger
Francesco Romani has posted comments on this change.
Change subject: API: streamline and make setLogLevel correct
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59873
To unsubscribe, visit https://ger
Piotr Kliczewski has posted comments on this change.
Change subject: yml: schema validation tests
..
Patch Set 1: Verified+1
Tests used to verify schema changes
--
To view, visit https://gerrit.ovirt.org/60071
To unsubscribe,
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for StoragePool.getInfo
..
Patch Set 2: Verified+1
Verified by running schema verification tests
--
To view, visit https://gerrit.ovi
1 - 100 of 119 matches
Mail list logo
