Change in vdsm[ovirt-4.0]: mount: Support NFS4 mounts with double slash

Freddy Rolland has posted comments on this change. Change subject: mount: Support NFS4 mounts with double slash .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61581 To unsubscribe, visit https://gerri

Change in vdsm[master]: automation: move glusterfs to 3.8

Sahina Bose has posted comments on this change. Change subject: automation: move glusterfs to 3.8 .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62250 To unsubscribe, visit https://gerrit.ovirt.org/se

Change in vdsm[ovirt-4.0]: fileUtils: Normalize initial double slashes

Freddy Rolland has posted comments on this change. Change subject: fileUtils: Normalize initial double slashes .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61580 To unsubscribe, visit https://gerrit

Change in vdsm[master]: lvm: Fix error handling when resizing lvs

Freddy Rolland has posted comments on this change. Change subject: lvm: Fix error handling when resizing lvs .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62338 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: revert net: Libvirt hook that enables ovs-legacy migration

gerrit-hooks has posted comments on this change. Change subject: revert net: Libvirt hook that enables ovs-legacy migration .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -

Change in vdsm[master]: virt net: Support VM migration on OVS based networks

gerrit-hooks has posted comments on this change. Change subject: virt net: Support VM migration on OVS based networks .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: revert net: Libvirt hook that enables ovs-legacy migration

Dan Kenigsberg has posted comments on this change. Change subject: revert net: Libvirt hook that enables ovs-legacy migration .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/62121 To unsubscribe, visit

Change in vdsm[master]: revert net: Libvirt hook that enables ovs-legacy migration

Dan Kenigsberg has submitted this change and it was merged. Change subject: revert net: Libvirt hook that enables ovs-legacy migration .. revert net: Libvirt hook that enables ovs-legacy migration Both the integrated and older

Change in vdsm[master]: virt net: Support VM migration on OVS based networks

Dan Kenigsberg has posted comments on this change. Change subject: virt net: Support VM migration on OVS based networks .. Patch Set 17: Code-Review+2 raising score -- To view, visit https://gerrit.ovirt.org/59645 To unsubscr

Change in vdsm[master]: virt net: Support VM migration on OVS based networks

Dan Kenigsberg has submitted this change and it was merged. Change subject: virt net: Support VM migration on OVS based networks .. virt net: Support VM migration on OVS based networks With the introduction of OVS as a network

Change in vdsm[master]: storage: move outOfProcess module to vdsm storage lib

Dan Kenigsberg has posted comments on this change. Change subject: storage: move outOfProcess module to vdsm storage lib .. Patch Set 7: Code-Review-1 rebase please! -- To view, visit https://gerrit.ovirt.org/56576 To unsubsc

Change in vdsm[master]: storage: move threadPool module to vdsm storage lib

Dan Kenigsberg has posted comments on this change. Change subject: storage: move threadPool module to vdsm storage lib .. Patch Set 4: Code-Review-1 marking with -1 as this needs a rebase and reverification. -- To view, visit

Change in vdsm[master]: Using %{?_smp_mflags} in %install

Dan Kenigsberg has posted comments on this change. Change subject: Using %{?_smp_mflags} in %install .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/62163/1/vdsm.spec.in File vdsm.spec.in: Line 743 Line 744 Line 745

Change in vdsm[master]: Removing deprecated lines from spec

Dan Kenigsberg has posted comments on this change. Change subject: Removing deprecated lines from spec .. Patch Set 2: Code-Review+2 raising score -- To view, visit https://gerrit.ovirt.org/62159 To unsubscribe, visit https:/

Change in vdsm[master]: Removing deprecated lines from spec

Dan Kenigsberg has submitted this change and it was merged. Change subject: Removing deprecated lines from spec .. Removing deprecated lines from spec rm -rf %{buildroot} and %defattr(-, root, root, -) are not needed anymore.

Change in vdsm[master]: Removing deprecated lines from spec

gerrit-hooks has posted comments on this change. Change subject: Removing deprecated lines from spec .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https

Change in vdsm[master]: net: early IP+link setup

Dan Kenigsberg has posted comments on this change. Change subject: net: early IP+link setup .. Patch Set 15: Code-Review+2 raising score -- To view, visit https://gerrit.ovirt.org/60371 To unsubscribe, visit https://gerrit.ov

Change in vdsm[master]: lvm: Fix error handling when resizing lvs

Allon Mureinik has posted comments on this change. Change subject: lvm: Fix error handling when resizing lvs .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62338 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: Live Merge: Restore watermark tracking

Adam Litke has posted comments on this change. Change subject: Live Merge: Restore watermark tracking .. Patch Set 13: (3 comments) https://gerrit.ovirt.org/#/c/60889/13/vdsm/virt/vm.py File vdsm/virt/vm.py: PS13, Line 993: v

Change in vdsm[master]: lvm: Fix error handling when resizing lvs

Nir Soffer has posted comments on this change. Change subject: lvm: Fix error handling when resizing lvs .. Patch Set 3: Verified+1 Verified both positive and negative flows. I could not reproduce the original error so I added

Change in vdsm[master]: lvm: Fix error handling when resizing lvs

gerrit-hooks has posted comments on this change. Change subject: lvm: Fix error handling when resizing lvs .. Patch Set 3: * #1363734::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1363734::OK, public bug * Check

Change in vdsm[master]: lvm: Fix error handling when resizing lvs

Nir Soffer has posted comments on this change. Change subject: lvm: Fix error handling when resizing lvs .. Patch Set 1: (3 comments) Thanks for the quick review! https://gerrit.ovirt.org/#/c/62338/1/vdsm/storage/lvm.py File

Change in vdsm[master]: lvm: Fix error handling when resizing lvs

gerrit-hooks has posted comments on this change. Change subject: lvm: Fix error handling when resizing lvs .. Patch Set 2: * #1363734::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1363734::OK, public bug * Check

Change in vdsm[master]: lvm: Fix error handling when resizing lvs

Nir Soffer has posted comments on this change. Change subject: lvm: Fix error handling when resizing lvs .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/62338/1/vdsm/storage/lvm.py File vdsm/storage/lvm.py: Line 1164

Change in vdsm[master]: lvm: Fix error handling when resizing lvs

Adam Litke has posted comments on this change. Change subject: lvm: Fix error handling when resizing lvs .. Patch Set 1: (4 comments) A few minor nits and questions but otherwise this looks good, https://gerrit.ovirt.org/#/c/

Change in vdsm[master]: net: early IP+link setup

Petr Horáček has posted comments on this change. Change subject: net: early IP+link setup .. Patch Set 15: Verified+1 Restores IP config OK in the first stage of setup. OVS-DHCP reporting is not working with network.service OK

Change in vdsm[master]: lvm: Fix error handling when resizing lvs

Allon Mureinik has posted comments on this change. Change subject: lvm: Fix error handling when resizing lvs .. Patch Set 1: Just to be clear - the theoretical performance penalty here is that we're invalidating caches on erro

Change in vdsm[master]: lvm: Fix error handling when resizing lvs

Nir Soffer has uploaded a new change for review. Change subject: lvm: Fix error handling when resizing lvs .. lvm: Fix error handling when resizing lvs We depended on undocumented and wrong behavior in lvextend, returning error

Change in vdsm[master]: lvm: Fix error handling when resizing lvs

gerrit-hooks has posted comments on this change. Change subject: lvm: Fix error handling when resizing lvs .. Patch Set 1: * #1363734::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1363734::OK, public bug * Check

Change in vdsm[master]: net: early IP+link setup

Edward Haas has posted comments on this change. Change subject: net: early IP+link setup .. Patch Set 15: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60371 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: storage: Sortable ResourceManager lock namespaces

gerrit-hooks has posted comments on this change. Change subject: storage: Sortable ResourceManager lock namespaces .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: storage: domainMonitor.getAllHostIds() API

gerrit-hooks has posted comments on this change. Change subject: storage: domainMonitor.getAllHostIds() API .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header ma

Change in vdsm[master]: storage: Introduce guarded utilities

gerrit-hooks has posted comments on this change. Change subject: storage: Introduce guarded utilities .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: sdm: Use guarded.context in copy_data

gerrit-hooks has posted comments on this change. Change subject: sdm: Use guarded.context in copy_data .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: Introduce FakeSanlock

gerrit-hooks has posted comments on this change. Change subject: tests: Introduce FakeSanlock .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url

Change in vdsm[master]: storage: export volume lease state in getVolumeInfo

gerrit-hooks has posted comments on this change. Change subject: storage: export volume lease state in getVolumeInfo .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: storage: export volume lease state in getVolumeInfo

Adam Litke has posted comments on this change. Change subject: storage: export volume lease state in getVolumeInfo .. Patch Set 1: (5 comments) https://gerrit.ovirt.org/#/c/61995/1/lib/api/vdsm-api.yml File lib/api/vdsm-api.ym

Change in vdsm[master]: virt: periodic health check - WIP

Milan Zamazal has posted comments on this change. Change subject: virt: periodic health check - WIP .. Patch Set 4: Thank you, this looks like a better direction. -- To view, visit https://gerrit.ovirt.org/61592 To unsubscrib

Change in vdsm[master]: infra tests: added functional test for upgrading vdsm

gerrit-hooks has posted comments on this change. Change subject: infra tests: added functional test for upgrading vdsm .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: Adding units to cpu metrics name according to metrics2.0 spec

Nir Soffer has posted comments on this change. Change subject: Adding units to cpu metrics name according to metrics2.0 spec .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/62156/3/lib/vdsm/host/api.py File lib/vdsm/h

Change in vdsm[master]: infra tests: added functional test for upgrading vdsm

gerrit-hooks has posted comments on this change. Change subject: infra tests: added functional test for upgrading vdsm .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sur

Change in vdsm[master]: fixing repos for standard ci

gerrit-hooks has posted comments on this change. Change subject: fixing repos for standard ci .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url

Change in vdsm[master]: fixing repos for standard ci

Eyal Edri has posted comments on this change. Change subject: fixing repos for standard ci .. Patch Set 6: Verified-1 putting -verified since it will break until we'll have centos repos for ppc64le -- To view, visit https://g

Change in vdsm[ovirt-4.0]: periodic: always re-schedule operations

Milan Zamazal has posted comments on this change. Change subject: periodic: always re-schedule operations .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61889 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: net: early IP+link setup

gerrit-hooks has posted comments on this change. Change subject: net: early IP+link setup .. Patch Set 15: * #1364087::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1364087::OK, public bug * Check Product::#136408

Change in vdsm[master]: net: early IP+link setup

Petr Horáček has posted comments on this change. Change subject: net: early IP+link setup .. Patch Set 14: (2 comments) https://gerrit.ovirt.org/#/c/60371/14/lib/vdsm/network/restore.py File lib/vdsm/network/restore.py: > Mod

Change in vdsm[ovirt-4.0]: virt: Limit the number of workers in executor

Milan Zamazal has posted comments on this change. Change subject: virt: Limit the number of workers in executor .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61769 To unsubscribe, visit https://gerri

Change in vdsm[ovirt-4.0]: mount: Support NFS4 mounts with double slash

Idan Shaby has posted comments on this change. Change subject: mount: Support NFS4 mounts with double slash .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/61581 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[ovirt-4.0]: fileUtils: Normalize initial double slashes

Idan Shaby has posted comments on this change. Change subject: fileUtils: Normalize initial double slashes .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/61580 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[ovirt-4.0]: mount: Support NFS4 mounts with double slash

gerrit-hooks has posted comments on this change. Change subject: mount: Support NFS4 mounts with double slash .. Patch Set 2: * #1361182::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1361182::OK, public bug * Che

Change in vdsm[ovirt-4.0]: fileUtils: Normalize initial double slashes

gerrit-hooks has posted comments on this change. Change subject: fileUtils: Normalize initial double slashes .. Patch Set 2: * #1361182::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1361182::OK, public bug * Chec

Change in vdsm[master]: functional tests: fix supervdsmServer test

gerrit-hooks has posted comments on this change. Change subject: functional tests: fix supervdsmServer test .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header m

Change in vdsm[ovirt-4.0]: Collect ksm values only if exist

Yaniv Kaul has posted comments on this change. Change subject: Collect ksm values only if exist .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/62142/4/lib/vdsm/host/api.py File lib/vdsm/host/api.py: Line 113: Line

Change in vdsm[master]: Adding units to memory metrics name according to metrics2.0 ...

gerrit-hooks has posted comments on this change. Change subject: Adding units to memory metrics name according to metrics2.0 spec .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url foun

Change in vdsm[master]: Adding percent suffix to metric name spacing

Yaniv Bronhaim has uploaded a new change for review. Change subject: Adding percent suffix to metric name spacing .. Adding percent suffix to metric name spacing Change-Id: Ibe87f2b9b31aaa9555b2df68689b5e9edbe398b9 Signed-off-by

Change in vdsm[master]: Adding percent suffix to metric name spacing

gerrit-hooks has posted comments on this change. Change subject: Adding percent suffix to metric name spacing .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: Adding memTotal metric

gerrit-hooks has posted comments on this change. Change subject: Adding memTotal metric .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' a

Change in vdsm[master]: Adding units to cpu metrics name according to metrics2.0 spec

gerrit-hooks has posted comments on this change. Change subject: Adding units to cpu metrics name according to metrics2.0 spec .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: Adding units to cpu metrics name according to metrics2.0 spec

Yaniv Bronhaim has posted comments on this change. Change subject: Adding units to cpu metrics name according to metrics2.0 spec .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/62156/3/lib/vdsm/host/api.py File lib/vd

Change in vdsm[ovirt-4.0]: Send metrics info only if metrics enabled to avoid parsing l...

Irit Goihman has posted comments on this change. Change subject: Send metrics info only if metrics enabled to avoid parsing logic .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62146 To unsubscribe, v

Change in vdsm[ovirt-4.0]: Adding get_batch to StatsCache - returns dict with all vms stat

Irit Goihman has posted comments on this change. Change subject: Adding get_batch to StatsCache - returns dict with all vms stat .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62144 To unsubscribe, vi

Change in vdsm[ovirt-4.0]: Collect ksm values only if exist

gerrit-hooks has posted comments on this change. Change subject: Collect ksm values only if exist .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://

Change in vdsm[ovirt-4.0]: Collect ksm values only if exist

Yaniv Bronhaim has submitted this change and it was merged. Change subject: Collect ksm values only if exist .. Collect ksm values only if exist Ksm values appear only if mom is enabled Change-Id: I5d1aa7830bff26c688a7c0322152

Change in vdsm[ovirt-4.0]: Collect ksm values only if exist

Yaniv Bronhaim has posted comments on this change. Change subject: Collect ksm values only if exist .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/62142 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[ovirt-4.0]: Adding report_stats to virt.stats

Irit Goihman has posted comments on this change. Change subject: Adding report_stats to virt.stats .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62143 To unsubscribe, visit https://gerrit.ovirt.org/s

Change in vdsm[ovirt-4.0]: Rename reports to metrics

Irit Goihman has posted comments on this change. Change subject: Rename reports to metrics .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62147 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[ovirt-4.0]: Collect ksm values only if exist

Irit Goihman has posted comments on this change. Change subject: Collect ksm values only if exist .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62142 To unsubscribe, visit https://gerrit.ovirt.org/se

Change in vdsm[master]: jsonrpcvdscli: change getVolumesList schema conversion

gerrit-hooks has posted comments on this change. Change subject: jsonrpcvdscli: change getVolumesList schema conversion .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: jsonrpcvdscli: change getVolumesList schema conversion

Irit Goihman has posted comments on this change. Change subject: jsonrpcvdscli: change getVolumesList schema conversion .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/62325/1//COMMIT_MSG Commit Message: Line 7: json

Change in vdsm[ovirt-4.0]: virt: Fix of Executor._active_workers crash on modification

Milan Zamazal has posted comments on this change. Change subject: virt: Fix of Executor._active_workers crash on modification .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61770 To unsubscribe, visit

Change in vdsm[master]: jsonrpcvdscli: change getVolumesList schema conversion

Nir Soffer has posted comments on this change. Change subject: jsonrpcvdscli: change getVolumesList schema conversion .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/62325/1//COMMIT_MSG Commit Message:

Change in vdsm[master]: virt net: Support VM migration on OVS based networks

Edward Haas has posted comments on this change. Change subject: virt net: Support VM migration on OVS based networks .. Patch Set 17: Verified+1 -- To view, visit https://gerrit.ovirt.org/59645 To unsubscribe, visit https://ge

Change in vdsm[master]: functional tests: fix supervdsmServer test

Irit Goihman has posted comments on this change. Change subject: functional tests: fix supervdsmServer test .. Patch Set 12: (2 comments) https://gerrit.ovirt.org/#/c/61902/11/tests/functional/Makefile.am File tests/functional

Change in vdsm[master]: functional tests: fix supervdsmServer test

gerrit-hooks has posted comments on this change. Change subject: functional tests: fix supervdsmServer test .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header m

Change in vdsm[master]: Adding memTotal metric

Yaniv Bronhaim has posted comments on this change. Change subject: Adding memTotal metric .. Patch Set 3: we don't have anything like a general host agent except vdsm currently, and the value for memTotal is that Shirly wants

Change in vdsm[master]: Adding memTotal metric

Yaniv Kaul has posted comments on this change. Change subject: Adding memTotal metric .. Patch Set 3: What's the value of adding this metric? Don't we expect it to be collected by a general host agent that'll send this metric?