Change in vdsm[master]: net: sourceroute: demote error log message

Assaf Muller has posted comments on this change. Change subject: net: sourceroute: demote error log message .. Patch Set 1: The issue of course is not a missing IP address or netmask, but is a missing default gateway.

Change in vdsm[master]: refactor StaticSourceRoute for better testability

Assaf Muller has posted comments on this change. Change subject: refactor StaticSourceRoute for better testability .. Patch Set 5: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/34067/5/vdsm/network/sourceroute.py File

Change in vdsm[master]: refactor StaticSourceRoute for better testability

Assaf Muller has posted comments on this change. Change subject: refactor StaticSourceRoute for better testability .. Patch Set 4: Code-Review-1 (3 comments)

Change in vdsm[master]: make isVDSMInterface and it's helpers static

Assaf Muller has posted comments on this change. Change subject: make isVDSMInterface and it's helpers static .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34139 To unsubscribe, visit

Change in vdsm[master]: Functional test for Multiple Gateways source routing

Assaf Muller has posted comments on this change. Change subject: Functional test for Multiple Gateways source routing .. Patch Set 8: Code-Review+1 +1 assuming the tests pass. -- To view, visit http://gerrit.ovirt.org/33612

Change in vdsm[master]: refactor StaticSourceRoute for better testability

Assaf Muller has posted comments on this change. Change subject: refactor StaticSourceRoute for better testability .. Patch Set 1: Code-Review-1 (5 comments) http://gerrit.ovirt.org/#/c/34067/1//COMMIT_MSG Commit Message:

Change in vdsm[master]: Functional test for Multiple Gateways source routing

Assaf Muller has posted comments on this change. Change subject: Functional test for Multiple Gateways source routing .. Patch Set 6: Code-Review-1 (5 comments) http://gerrit.ovirt.org/#/c/33612/6//COMMIT_MSG Commit Message:

Change in vdsm[master]: Functional test for Multiple Gateways source routing

Assaf Muller has posted comments on this change. Change subject: Functional test for Multiple Gateways source routing .. Patch Set 4: Code-Review-1 (7 comments) http://gerrit.ovirt.org/#/c/33612/4/AUTHORS File AUTHORS: Line

Change in vdsm[master]: net: source route: don't attempt to configure invalid values

Assaf Muller has posted comments on this change. Change subject: net: source route: don't attempt to configure invalid values .. Patch Set 1: So the configure method is called from lots of places. Don't we want to log the bad

Change in vdsm[master]: ipwrapper: Get rid of unused methods

Assaf Muller has posted comments on this change. Change subject: ipwrapper: Get rid of unused methods .. Patch Set 2: So sad. My babies :( -- To view, visit http://gerrit.ovirt.org/29726 To unsubscribe, visit

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

Assaf Muller has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 9: Code-Review-1 (4 comments) Sorry for the partial reviews, I hate when people do that. Just testing

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

Assaf Muller has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/27193/9/tests/toolTests.py File tests/toolTests.py: Line 380:

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

Assaf Muller has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 10: Code-Review-1 No change in tests, keeping -1 for now... -- To view, visit http://gerrit.ovirt.org/27193 To

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

Assaf Muller has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 11: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27193 To unsubscribe, visit

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

Assaf Muller has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 8: If you run the unified upgrade, do you see lines (in upgrade.log) like: Adding network ovirtmgmt...? -- To

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

Assaf Muller has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 8: To make my previous question clearer: If you run the unified upgrade during VDSM start (IE: Not manually), do

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

Assaf Muller has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 8: Code-Review-1 How is logging output to other loggers/handlers (Such as the root logger, or vdsm logger)

Change in vdsm[master]: sourcerouting: fix _getRoute not to include local routes

Assaf Muller has posted comments on this change. Change subject: sourcerouting: fix _getRoute not to include local routes .. Patch Set 2: You might have individuals placing /32 bit addresses on non-VM networks. For example,

Change in vdsm[master]: sourcerouting: fix _getRoute not to include local routes

Assaf Muller has posted comments on this change. Change subject: sourcerouting: fix _getRoute not to include local routes .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27262/1/vdsm/network/sourceroute.py File

Change in vdsm[master]: sourcerouting: fix _getRoute not to include local routes

Assaf Muller has posted comments on this change. Change subject: sourcerouting: fix _getRoute not to include local routes .. Patch Set 2: Why does a show on a specific table show routes that were not inserted by us? I have a

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

Assaf Muller has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 1: If you git blame and look at the patches that introduced the upgrade mechanism you'd see that Saggi NACK'd

Change in vdsm[master]: Added network directory

Assaf Muller has abandoned this change. Change subject: Added network directory .. Abandoned A lot has changed since this patch was proposed. Some interest has surfaced around this subject, so I'll abandon and Antoni will

Change in vdsm[master]: Added network directory

Assaf Muller has posted comments on this change. Change subject: Added network directory .. Patch Set 2: Antoni, Dan, Yaniv or anyone else - If you are interested in this patch please take ownership. -- To view, visit

Change in vdsm[master]: Fix defaultRoute handling

Assaf Muller has uploaded a new change for review. Change subject: Fix defaultRoute handling .. Fix defaultRoute handling defaultRoute wasn't being past correctly to objectivizeNetwork, so that defaultRoute was always None

Change in vdsm[ovirt-3.4]: Fix defaultRoute handling

Assaf Muller has posted comments on this change. Change subject: Fix defaultRoute handling .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/24677 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[ovirt-3.4]: Fix defaultRoute handling

Assaf Muller has posted comments on this change. Change subject: Fix defaultRoute handling .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24677 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: netconf.ifcfg: include CONFFILE_HEADER in route/rule files

Assaf Muller has posted comments on this change. Change subject: netconf.ifcfg: include CONFFILE_HEADER in route/rule files .. Patch Set 1: Code-Review+1 Looks good. By the way, we could use something like for unified

Change in vdsm[master]: Ethtool_opts: fix retrieval from configwriter.

Assaf Muller has posted comments on this change. Change subject: Ethtool_opts: fix retrieval from configwriter. .. Patch Set 1: If this patch were merged and I were to browse the code, I'd ask why isn't getEthtoolOptions a

Change in vdsm[master]: netinfo: ifcfg: ignore 0 suffix

Assaf Muller has posted comments on this change. Change subject: netinfo: ifcfg: ignore 0 suffix .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/23329/1//COMMIT_MSG Commit Message: Doesn't IPADDR1 mean

Change in vdsm[master]: Change MANAGEMENT_NETWORK to MANAGEMENT_NETWORK*S*

Assaf Muller has posted comments on this change. Change subject: Change MANAGEMENT_NETWORK to MANAGEMENT_NETWORK*S* .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/23182/1/lib/vdsm/constants.py.in File

Change in vdsm[master]: Extend setupNetworks API to accept defaultRoute

Assaf Muller has posted comments on this change. Change subject: Extend setupNetworks API to accept defaultRoute .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/22720/2/vdsm/configNetwork.py File

Change in vdsm[master]: Extend setupNetworks API to accept defaultRoute

Assaf Muller has posted comments on this change. Change subject: Extend setupNetworks API to accept defaultRoute .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/22720 To unsubscribe, visit

Change in vdsm[master]: Change MANAGEMENT_NETWORK to MANAGEMENT_NETWORK*S*

Assaf Muller has posted comments on this change. Change subject: Change MANAGEMENT_NETWORK to MANAGEMENT_NETWORK*S* .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/23182 To unsubscribe, visit

Change in vdsm[master]: Add netinfo.getDefaultGateway()

Assaf Muller has uploaded a new change for review. Change subject: Add netinfo.getDefaultGateway() .. Add netinfo.getDefaultGateway() To be used in next patch. Change-Id: I15be5d69b5ef8f9e4cb9a30a3739a0b060225e0e

Change in vdsm[master]: Add netinfo.getDefaultGateway()

Assaf Muller has posted comments on this change. Change subject: Add netinfo.getDefaultGateway() .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/23346 To unsubscribe, visit

Change in vdsm[master]: netconfig: set ETHTOOL_OPTS when a NIC goes up

Assaf Muller has posted comments on this change. Change subject: netconfig: set ETHTOOL_OPTS when a NIC goes up .. Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/23366/1/vdsm/netconf/iproute2.py File

Change in vdsm[master]: Add netinfo.getDefaultGateway()

Assaf Muller has posted comments on this change. Change subject: Add netinfo.getDefaultGateway() .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/23346 To unsubscribe, visit

Change in vdsm[master]: Extend setupNetworks API to accept defaultRoute

Assaf Muller has posted comments on this change. Change subject: Extend setupNetworks API to accept defaultRoute .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/22720 To unsubscribe, visit

Change in vdsm[master]: utils: Moved pgrep and getCmdArgs from storage/misc

Assaf Muller has posted comments on this change. Change subject: utils: Moved pgrep and getCmdArgs from storage/misc .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23040 To unsubscribe, visit

Change in vdsm[master]: utils: Extend pgrep to accept multiple process names

Assaf Muller has posted comments on this change. Change subject: utils: Extend pgrep to accept multiple process names .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23239/1/lib/vdsm/utils.py File lib/vdsm/utils.py:

Change in vdsm[master]: netinfo: Determine bootproto also without ifcfg files

Assaf Muller has posted comments on this change. Change subject: netinfo: Determine bootproto also without ifcfg files .. Patch Set 3: Code-Review-1 (5 comments) http://gerrit.ovirt.org/#/c/23098/3//COMMIT_MSG Commit Message:

Change in vdsm[master]: Extend setupNetworks API to accept defaultRoute

Assaf Muller has posted comments on this change. Change subject: Extend setupNetworks API to accept defaultRoute .. Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/22720/2/lib/vdsm/tool/unified_persistence.py File

Change in vdsm[master]: Fix VDSM boot

Assaf Muller has uploaded a new change for review. Change subject: Fix VDSM boot .. Fix VDSM boot Fix regression introduced in Gerrit 22750, hash 114692f. The unified net persistence upgrade name was changed, changing the name

Change in vdsm[master]: Fix VDSM boot

Assaf Muller has posted comments on this change. Change subject: Fix VDSM boot .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/23218 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: Extend setupNetworks API to accept defaultRoute

Assaf Muller has posted comments on this change. Change subject: Extend setupNetworks API to accept defaultRoute .. Patch Set 1: (5 comments) File

Change in vdsm[master]: Extend setupNetworks API to accept defaultRoute

Assaf Muller has posted comments on this change. Change subject: Extend setupNetworks API to accept defaultRoute .. Patch Set 2: (2 comments) File

Change in vdsm[master]: Add --run-again option to upgrades

Assaf Muller has posted comments on this change. Change subject: Add --run-again option to upgrades .. Patch Set 1: (1 comment) File lib/vdsm/tool/upgrade.py Line 125:

Change in vdsm[master]: ifcfg: exclude HWADDR lines if requested

Assaf Muller has posted comments on this change. Change subject: ifcfg: exclude HWADDR lines if requested .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22288 To unsubscribe, visit

Change in vdsm[master]: BindingXMLRPC bugfix: Added netinfo:getDeviceByIP and a test

Assaf Muller has posted comments on this change. Change subject: BindingXMLRPC bugfix: Added netinfo:getDeviceByIP and a test .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/22841 To unsubscribe, visit

Change in vdsm[master]: BindingXMLRPC bugfix: Use getDeviceByIP() for lastClientIface

Assaf Muller has posted comments on this change. Change subject: BindingXMLRPC bugfix: Use getDeviceByIP() for lastClientIface .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/22842 To unsubscribe, visit

Change in vdsm[master]: Gluster API verbs will now be callable again

Assaf Muller has posted comments on this change. Change subject: Gluster API verbs will now be callable again .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/23044 To unsubscribe, visit

Change in vdsm[master]: cleanup: move _updateTimestamp to API.py

Assaf Muller has posted comments on this change. Change subject: cleanup: move _updateTimestamp to API.py .. Patch Set 3: (1 comment) Commit Message Line 15: Line 16:

Change in vdsm[master]: cleanup: move _updateTimestamp to API.py

Assaf Muller has posted comments on this change. Change subject: cleanup: move _updateTimestamp to API.py .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23050 To unsubscribe, visit

Change in vdsm[master]: cleanup: move _updateTimestamp to API.py

Assaf Muller has posted comments on this change. Change subject: cleanup: move _updateTimestamp to API.py .. Patch Set 5: Code-Review+1 Oh, didn't notice that patch set 4 moved it back to static (Patch set 3 moved it to

Change in vdsm[ovirt-3.3]: Gluster API verbs will now be callable again

Assaf Muller has posted comments on this change. Change subject: Gluster API verbs will now be callable again .. Patch Set 2: Verified+1 Same patch merged in master. -- To view, visit http://gerrit.ovirt.org/23045 To

Change in vdsm[ovirt-3.3]: Gluster API verbs will now be callable again

Assaf Muller has uploaded a new change for review. Change subject: Gluster API verbs will now be callable again .. Gluster API verbs will now be callable again Fix regression introduced in #22967. wrapApiMethod was using the

Change in vdsm[master]: Gluster API verbs will now be callable again

Assaf Muller has posted comments on this change. Change subject: Gluster API verbs will now be callable again .. Patch Set 2: (1 comment) File vdsm/BindingXMLRPC.py Line

Change in vdsm[master]: Gluster API verbs will now be callable again

Assaf Muller has posted comments on this change. Change subject: Gluster API verbs will now be callable again .. Patch Set 2: (1 comment) File vdsm/BindingXMLRPC.py Line

Change in vdsm[master]: Gluster API verbs will now be callable again

Assaf Muller has posted comments on this change. Change subject: Gluster API verbs will now be callable again .. Patch Set 2: (2 comments) File vdsm/BindingXMLRPC.py Line

Change in vdsm[master]: vm: Bring back missing before_device_migrate_source hook call

Assaf Muller has posted comments on this change. Change subject: vm: Bring back missing before_device_migrate_source hook call .. Patch Set 1: Code-Review-1 Please add Bug-Url to commit message:

Change in vdsm[master]: vm: Bring back missing before_device_migrate_source hook call

Assaf Muller has posted comments on this change. Change subject: vm: Bring back missing before_device_migrate_source hook call .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23006 To unsubscribe,

Change in vdsm[master]: hooks: Security groups support for OVS

Assaf Muller has posted comments on this change. Change subject: hooks: Security groups support for OVS .. Patch Set 6: Code-Review+1 Please open a bug to track the migration issue before merging this patch. -- To view,

Change in vdsm[ovirt-3.3]: BindingXMLRPC bugfix: Return lastClientIface for current con...

Assaf Muller has posted comments on this change. Change subject: BindingXMLRPC bugfix: Return lastClientIface for current connection .. Patch Set 3: Verified+1 Waiting for z-stream ACK on the bug. -- To view, visit

Change in vdsm[master]: vdsm: allow hooks to pass down dictionaries in json format

Assaf Muller has posted comments on this change. Change subject: vdsm: allow hooks to pass down dictionaries in json format .. Patch Set 7: A humble request: Please give enough time for the thread on arch/vdsm to die down

Change in vdsm[master]: [1/x] BindingXMLRPC cleanup: Remove/inline getServerInfo

Assaf Muller has posted comments on this change. Change subject: [1/x] BindingXMLRPC cleanup: Remove/inline getServerInfo .. Patch Set 1: (1 comment) Commit Message Line 3:

Change in vdsm[master]: [2/x] BindingXMLRPC cleanup: Remove unused variables

Assaf Muller has posted comments on this change. Change subject: [2/x] BindingXMLRPC cleanup: Remove unused variables .. Patch Set 1: Will be fixed in the upcoming patchset. -- To view, visit http://gerrit.ovirt.org/22836 To

Change in vdsm[master]: [3/x] Bugfix: Return lastClientIface for *current* connection

Assaf Muller has posted comments on this change. Change subject: [3/x] Bugfix: Return lastClientIface for *current* connection .. Patch Set 1: (2 comments) Commit Message

Change in vdsm[master]: [4/x] Added netinfo:getDeviceByIP and a test

Assaf Muller has posted comments on this change. Change subject: [4/x] Added netinfo:getDeviceByIP and a test .. Patch Set 2: (1 comment) Commit Message Line 3: AuthorDate:

Change in vdsm[master]: BindingXMLRPC cleanup: Inline getServerInfo

Assaf Muller has posted comments on this change. Change subject: BindingXMLRPC cleanup: Inline getServerInfo .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/22835 To unsubscribe, visit

Change in vdsm[master]: BindingXMLRPC bugfix: Added netinfo:getDeviceByIP and a test

Assaf Muller has posted comments on this change. Change subject: BindingXMLRPC bugfix: Added netinfo:getDeviceByIP and a test .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/22841 To unsubscribe, visit

Change in vdsm[master]: BindingXMLRPC cleanup: Remove unused variables

Assaf Muller has posted comments on this change. Change subject: BindingXMLRPC cleanup: Remove unused variables .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/22836 To unsubscribe, visit

Change in vdsm[master]: BindingXMLRPC bugfix: Return lastClientIface for current con...

Assaf Muller has posted comments on this change. Change subject: BindingXMLRPC bugfix: Return lastClientIface for current connection .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/22837 To unsubscribe,

Change in vdsm[master]: BindingXMLRPC bugfix: Use getDeviceByIP() for lastClientIface

Assaf Muller has posted comments on this change. Change subject: BindingXMLRPC bugfix: Use getDeviceByIP() for lastClientIface .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/22842 To unsubscribe, visit

Change in vdsm[master]: hooks: Extract devName function for openstacknet

Assaf Muller has posted comments on this change. Change subject: hooks: Extract devName function for openstacknet .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22584 To unsubscribe, visit

Change in vdsm[master]: hooks: Extract function for command execution

Assaf Muller has posted comments on this change. Change subject: hooks: Extract function for command execution .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22583 To unsubscribe, visit

Change in vdsm[master]: hooks: Security groups support for OVS

Assaf Muller has posted comments on this change. Change subject: hooks: Security groups support for OVS .. Patch Set 4: Code-Review-1 (1 comment) File

Change in vdsm[master]: hooks: Security groups support for OVS

Assaf Muller has posted comments on this change. Change subject: hooks: Security groups support for OVS .. Patch Set 4: (1 comment) File vdsm_hooks/openstacknet/Makefile.am

Change in vdsm[ovirt-3.3]: BindingXMLRPC bugfix: Return lastClientIface for current con...

Hello Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/22967 to review the following change. Change subject: BindingXMLRPC bugfix: Return lastClientIface for current connection ..

Change in vdsm[ovirt-3.3]: BindingXMLRPC cleanup: Remove unused variables

Hello Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/22966 to review the following change. Change subject: BindingXMLRPC cleanup: Remove unused variables .. BindingXMLRPC cleanup:

Change in vdsm[ovirt-3.3]: BindingXMLRPC bugfix: Fix netinfo:getIfaceByIP unit test

Assaf Muller has uploaded a new change for review. Change subject: BindingXMLRPC bugfix: Fix netinfo:getIfaceByIP unit test .. BindingXMLRPC bugfix: Fix netinfo:getIfaceByIP unit test Change-Id:

Change in vdsm[ovirt-3.3]: BindingXMLRPC cleanup: Inline getServerInfo

Hello Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/22965 to review the following change. Change subject: BindingXMLRPC cleanup: Inline getServerInfo .. BindingXMLRPC cleanup:

Change in vdsm[ovirt-3.3]: BindingXMLRPC cleanup: Inline getServerInfo

Assaf Muller has posted comments on this change. Change subject: BindingXMLRPC cleanup: Inline getServerInfo .. Patch Set 1: Verified+1 Cherry pick into manual backport: Verified on ovirt-3.3 branch with this patch. -- To

Change in vdsm[ovirt-3.3]: BindingXMLRPC cleanup: Remove unused variables

Assaf Muller has posted comments on this change. Change subject: BindingXMLRPC cleanup: Remove unused variables .. Patch Set 1: Verified+1 Cherry pick into manual backport: Verified on ovirt-3.3 branch with this patch. -- To

Change in vdsm[ovirt-3.3]: BindingXMLRPC bugfix: Return lastClientIface for current con...

Assaf Muller has posted comments on this change. Change subject: BindingXMLRPC bugfix: Return lastClientIface for current connection .. Patch Set 1: Verified+1 Cherry pick into manual backport: Verified on ovirt-3.3 branch

Change in vdsm[ovirt-3.3]: BindingXMLRPC bugfix: Fix netinfo:getIfaceByIP unit test

Assaf Muller has posted comments on this change. Change subject: BindingXMLRPC bugfix: Fix netinfo:getIfaceByIP unit test .. Patch Set 1: Verified+1 Cherry pick into manual backport: Verified on ovirt-3.3 branch with this

Change in vdsm[ovirt-3.3]: BindingXMLRPC bugfix: Fix netinfo:getIfaceByIP unit test

Assaf Muller has posted comments on this change. Change subject: BindingXMLRPC bugfix: Fix netinfo:getIfaceByIP unit test .. Patch Set 1: Also: This change is *not yet merged into master* -- To view, visit

Change in vdsm[ovirt-3.3]: BindingXMLRPC cleanup: Remove unused variables

Assaf Muller has abandoned this change. Change subject: BindingXMLRPC cleanup: Remove unused variables .. Abandoned I'll backport only the bugfix itself. -- To view, visit http://gerrit.ovirt.org/22966 To unsubscribe, visit

Change in vdsm[ovirt-3.3]: BindingXMLRPC cleanup: Inline getServerInfo

Assaf Muller has abandoned this change. Change subject: BindingXMLRPC cleanup: Inline getServerInfo .. Abandoned I'll backport only the bugfix itself. -- To view, visit http://gerrit.ovirt.org/22965 To unsubscribe, visit

Change in vdsm[master]: update NIC: having no custom properies is valid

Assaf Muller has posted comments on this change. Change subject: update NIC: having no custom properies is valid .. Patch Set 2: Code-Review+1 Looks like this is the only params.get('custom') usage... What a weird miss. --

Change in vdsm[ovirt-3.3]: update NIC: having no custom properies is valid

Assaf Muller has posted comments on this change. Change subject: update NIC: having no custom properies is valid .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22950 To unsubscribe, visit

Change in vdsm[master]: Fixing call to setLinkAndNetwork after hook

Assaf Muller has posted comments on this change. Change subject: Fixing call to setLinkAndNetwork after hook .. Patch Set 1: (1 comment) File vdsm/vm.py Line 3237:

Change in vdsm[master]: Add --run-again option to upgrades

Assaf Muller has posted comments on this change. Change subject: Add --run-again option to upgrades .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/22750 To unsubscribe, visit

Change in vdsm[master]: hooks: Security groups support for OVS

Assaf Muller has posted comments on this change. Change subject: hooks: Security groups support for OVS .. Patch Set 1: (2 comments) File lib/vdsm/constants.py.in Line 101:

Change in vdsm[master]: Add --run-again option to upgrades

Assaf Muller has posted comments on this change. Change subject: Add --run-again option to upgrades .. Patch Set 1: (3 comments) File lib/vdsm/tool/upgrade.py Line 117:

Change in vdsm[master]: [1/2] getVdsCaps returns client iface for *current* connection

Assaf Muller has posted comments on this change. Change subject: [1/2] getVdsCaps returns client iface for *current* connection .. Patch Set 2: Pushing a new chain of patches instead. -- To view, visit

Change in vdsm[master]: [1/2] getVdsCaps returns client iface for *current* connection

Assaf Muller has abandoned this change. Change subject: [1/2] getVdsCaps returns client iface for *current* connection .. Abandoned -- To view, visit http://gerrit.ovirt.org/22742 To unsubscribe, visit

Change in vdsm[master]: [3/x] Bugfix: Return lastClientIface for *current* connection

Assaf Muller has uploaded a new change for review. Change subject: [3/x] Bugfix: Return lastClientIface for *current* connection .. [3/x] Bugfix: Return lastClientIface for *current* connection Change-Id:

Change in vdsm[master]: [1/x] BindingXMLRPC cleanup: Remove/inline getServerInfo

Assaf Muller has uploaded a new change for review. Change subject: [1/x] BindingXMLRPC cleanup: Remove/inline getServerInfo .. [1/x] BindingXMLRPC cleanup: Remove/inline getServerInfo Change-Id:

Change in vdsm[master]: [1/x] BindingXMLRPC cleanup: Remove/inline getServerInfo

Assaf Muller has posted comments on this change. Change subject: [1/x] BindingXMLRPC cleanup: Remove/inline getServerInfo .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/22835 To unsubscribe, visit

Change in vdsm[master]: [2/x] BindingXMLRPC cleanup: Remove unused variables

Assaf Muller has uploaded a new change for review. Change subject: [2/x] BindingXMLRPC cleanup: Remove unused variables .. [2/x] BindingXMLRPC cleanup: Remove unused variables Change-Id:

  1   2   3   4   5   6   >