Daniel Erez has posted comments on this change.
Change subject: ceph: Require ceph-common when it is available
..
Patch Set 13: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42471
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: spec: qemu-kvm-img to handle unaligned images
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/56142/1//COMMIT_MSG
Commit Message:
Line 15: in EL's
Daniel Erez has posted comments on this change.
Change subject: spec: qemu-kvm-img to handle unaligned images
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56142/1//COMMIT_MSG
Commit Message:
Line 15: in EL's
Daniel Erez has posted comments on this change.
Change subject: move blkid to lib
..
Patch Set 4:
What is it needed for? engine doesn't seem to use it..
--
To view, visit https://gerrit.ovirt.org/53872
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: virt: Use Drive.diskType instead of networkDev and blockDev
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40472
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: vm: snapshot - adding appropriate logs
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/50775/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3247:
Daniel Erez has posted comments on this change.
Change subject: vm: snapshot - adding appropriate logs
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/50775
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: vm: snapshot - adding appropriate logs
..
Patch Set 1:
(7 comments)
https://gerrit.ovirt.org/#/c/50775/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3243
Line
Hello Sandro Bonazzola, Nir Soffer, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/50766
to review the following change.
Change subject: spec: Require newer qemu version for el7
Daniel Erez has posted comments on this change.
Change subject: spec: Require newer qemu version for el7
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/50766
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: spec: Require newer qemu version for el7
..
Patch Set 3: Verified+1
Verified on CentOS/EL.
--
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe,
Daniel Erez has uploaded a new change for review.
Change subject: vm: snapshot - adding appropriate logs
..
vm: snapshot - adding appropriate logs
Following https://gerrit.ovirt.org/#/c/49535,
adding some useful logs to
Daniel Erez has posted comments on this change.
Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/44045/7/vdsm/storage/volume.py
File
Daniel Erez has uploaded a new change for review.
Change subject: spec: Require newer qemu version for el7
..
spec: Require newer qemu version for el7
Bumping qemu version to 2.3.0-31.el7_2.4 in order to avoid
a potential
Daniel Erez has posted comments on this change.
Change subject: spec: Require newer qemu version for el7
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: spec: Require newer qemu version for el7
..
Patch Set 2:
@Allon - do we need the separation between RHEL and CentOS when bumping qemu
version?
--
To view,
Daniel Erez has uploaded a new change for review.
Change subject: vm: enabling memory snapshot without disks
..
vm: enabling memory snapshot without disks
Taking a memory snapshot of a VM without disks should be
supported (or
Daniel Erez has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/50199
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: VolumeMetadata: Move getInfo and getVolumeParams
..
Patch Set 22: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41999
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: VolumeMetadata: volume share utilities
..
Patch Set 22: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42004
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: VolumeMetadata: Move getParentVolume
..
Patch Set 11: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44042
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: VolumeMetadata: move validateDelete
..
Patch Set 22: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42000
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: VolumeMetadata: move refreshVolume
..
Patch Set 22: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/42003/22/vdsm/storage/volume.py
File
Daniel Erez has posted comments on this change.
Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/44045/7/vdsm/storage/volume.py
File
Daniel Erez has posted comments on this change.
Change subject: VolumeMetadata: Move getImageVolumes
..
Patch Set 11: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44043
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: VolumeMetadata: move newVolumeLease
..
Patch Set 22: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42002
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: fileVolume: define file extension for volume artifacts metadata
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49544
To unsubscribe,
Daniel Erez has posted comments on this change.
Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/44045/7/vdsm/storage/volume.py
File
Daniel Erez has posted comments on this change.
Change subject: VolumeMetadata: move newMetadata
..
Patch Set 22: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42001
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: VolumeMetadata: move getVolumeSize
..
Patch Set 22: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41998
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: VolumeMetadata: move getVolumeSize
..
Patch Set 23: -Code-Review
--
To view, visit https://gerrit.ovirt.org/41998
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 2:
Verified the flows mentioned in the commit message. I.e. memory snapshot on a
VM with Cinder disks or
Daniel Erez has posted comments on this change.
Change subject: ceph: Do not require ceph-common on ppc64le
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42471
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 2:
Thanks Michal and Arik.
@Nir/Francesco - can we move forward with this then?
--
To view, visit
Daniel Erez has posted comments on this change.
Change subject: vm: snapshot - enabling memory snapshot for diskless VM
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/49535
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: vm: snapshot - enabling memory snapshot for diskless VM
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/49535/1//COMMIT_MSG
Commit Message:
Line 3:
Daniel Erez has posted comments on this change.
Change subject: vm: snapshot - enabling memory snapshot for diskless VM
..
Patch Set 1:
That's not exactly correct - previewing a memory snapshot without disks
prevents running
Daniel Erez has uploaded a new change for review.
Change subject: vm: snapshot - enabling memory snapshot for diskless VM
..
vm: snapshot - enabling memory snapshot for diskless VM
Taking a memory snapshot of a VM without disks
Daniel Erez has posted comments on this change.
Change subject: VolumeMetadata: Move recheckIfLeaf into *Metadata class
..
Patch Set 19: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41850
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: StorageDomain: Add get_manifest
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44566
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: VolumeMetadata: Metadata read utils
..
Patch Set 19: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41846
To unsubscribe, visit
Hello Adam Litke, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49144
to review the following change.
Change subject: image: copy - set VM metadata images format to RAW
..
Daniel Erez has posted comments on this change.
Change subject: image: copy - set VM metadata images format to RAW
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/49144
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: image: copy - set VM metadata images format to RAW
..
Patch Set 7: Verified+1
Verified:
* export/import of new VMs with ram snapshots.
* export/import of old
Daniel Erez has posted comments on this change.
Change subject: VolumeMetadata: Metadata read utils
..
Patch Set 18:
(2 comments)
https://gerrit.ovirt.org/#/c/41846/18/vdsm/storage/blockVolume.py
File
Daniel Erez has posted comments on this change.
Change subject: image: copy - set VM metadata images format to RAW
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/49002/6/vdsm/storage/image.py
File
Daniel Erez has posted comments on this change.
Change subject: image: copy - set VM metadata images format to RAW
..
Patch Set 3:
(7 comments)
https://gerrit.ovirt.org/#/c/49002/3/vdsm/storage/image.py
File
Daniel Erez has posted comments on this change.
Change subject: image: copy - set VM metadata images format to RAW
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/49002/3/vdsm/storage/image.py
File
Daniel Erez has uploaded a new change for review.
Change subject: image: copy - set VM metadata images format to RAW
..
image: copy - set VM metadata images format to RAW
Since commit 0b61c4851a528fd6354d9ab77a68085c41f35dc9
Daniel Erez has abandoned this change.
Change subject: image: fall-back to dd - workaround for bz#1282239
..
Abandoned
replaced by https://gerrit.ovirt.org/#/c/49002/
--
To view, visit https://gerrit.ovirt.org/48907
To
Daniel Erez has posted comments on this change.
Change subject: image: copy - set VM metadata images format to RAW
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/49002
To unsubscribe, visit
Daniel Erez has uploaded a new change for review.
Change subject: image: fall-back to dd - workaround for bz#1282239
..
image: fall-back to dd - workaround for bz#1282239
Since commit 0b61c4851a528fd6354d9ab77a68085c41f35dc9
Daniel Erez has posted comments on this change.
Change subject: image: fall-back to dd - workaround for bz#1282239
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/48907
To unsubscribe, visit
Hello Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/48912
to review the following change.
Change subject: vm: snapshot - use r+ to open vm conf file
..
vm: snapshot - use r+ to
Daniel Erez has posted comments on this change.
Change subject: vm: snapshot - use r+ to open vm conf file
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/48912
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: vm: snapshot - use r+ to open vm conf file
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/48776/2//COMMIT_MSG
Commit Message:
Line 23: to a sector
Daniel Erez has posted comments on this change.
Change subject: vm: snapshot - use r+ to open vm conf file
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/48776
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: vm: snapshot - use r+ to open vm conf file
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/48776/1//COMMIT_MSG
Commit Message:
Line 10: copy of
Daniel Erez has uploaded a new change for review.
Change subject: vm: snapshot - use r+ to open vm conf file
..
vm: snapshot - use r+ to open vm conf file
Since commit 0b61c4851a528fd6354d9ab77a68085c41f35dc9
copy of internal
Daniel Erez has posted comments on this change.
Change subject: hsm: Report vg name in getDeviceList
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45823
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: hotunplug: Supporting lun and cinder disks fix.
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/47846
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: hotunplug: Supporting lun and cinder disks fix.
..
Patch Set 3: Code-Review+1 Verified+1
Verified with Cinder disks.
--
To view, visit
Daniel Erez has posted comments on this change.
Change subject: ceph: Report librbd1 version also on Debian
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44730
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: vm: Improve error handling when Vm._dom is None
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43225
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: snapshot: Add vdsClient freeze() and thaw() APIs
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/43098
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/43018
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: snapshot: Add VM.freeze() and VM.thaw() verbs
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/43058
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: ceph: Do not require ceph-common on ppc64le
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42471
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: ceph: Add option to clear other secrets
..
Patch Set 15:
The add/remove/set design might seem a bit superfluous and would require extra
work in engine side, but,
Daniel Erez has posted comments on this change.
Change subject: ceph: Clear all secrets during startup and shutdown
..
Patch Set 8: Code-Review+1 Verified+1
--
To view, visit https://gerrit.ovirt.org/40968
To unsubscribe,
Daniel Erez has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 14: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38766
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: ceph: Require ceph-common package
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41804
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: ceph: Support ephemeral Libvirt secrets
..
Patch Set 23: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40712
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: ceph: Support hotunplug of network disks
..
Patch Set 15: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38804
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: ceph: Validate network disk parameters
..
Patch Set 11: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40477
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: ceph: Undefine existing secret if usage changed
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40967
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: ceph: Clear only ovirt secrets
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41302
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: ceph: Add option to clear other secrets
..
Patch Set 14: Verified+1
--
To view, visit https://gerrit.ovirt.org/40853
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: ceph: Clear only ovirt secrets
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/41302
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: properties: Add properties module
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/40822/3/lib/vdsm/properties.py
File lib/vdsm/properties.py:
Line 2:
Daniel Erez has posted comments on this change.
Change subject: ceph: Input validation using properties
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/41049/2/vdsm/virt/secret.py
File vdsm/virt/secret.py:
Line 21:
Daniel Erez has posted comments on this change.
Change subject: ceph: Support ephemeral Libvirt secrets
..
Patch Set 18: Code-Review+1 Verified+1
--
To view, visit https://gerrit.ovirt.org/40712
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: ceph: Support ephemeral Libvirt secrets
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/40712/14/tests/vmSecretTests.py
File tests/vmSecretTests.py:
Daniel Erez has posted comments on this change.
Change subject: ceph: Support ephemeral Libvirt secrets
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/40712/13/vdsm/virt/secret.py
File vdsm/virt/secret.py:
Line
Daniel Erez has posted comments on this change.
Change subject: ceph: Support ephemeral Libvirt secrets
..
Patch Set 8:
(3 comments)
https://gerrit.ovirt.org/#/c/40712/8/vdsm/virt/secret.py
File vdsm/virt/secret.py:
Line 48:
Daniel Erez has posted comments on this change.
Change subject: ceph: Support ephemeral Libvirt secrets
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/40712/8/vdsm/virt/secret.py
File vdsm/virt/secret.py:
Line 1: #
Daniel Erez has abandoned this change.
Change subject: task: streamlining lock acquiring api
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/29729
To unsubscribe, visit https://gerrit.ovirt.org/settings
Daniel Erez has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 4: Verified+1 Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38766
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: ceph: Support hotunplug of network disks
..
Patch Set 3: Verified+1 Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38804
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: hsm: Return true truesize for block volumes
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/37785/3/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Daniel Erez has posted comments on this change.
Change subject: tests: Make it easy to debug assertXMLEqual failures
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36930
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: tests: Rename assertXML to assertXMLEqual
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36878
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: API: move diskSizeExtend logic from BindingXMLRPC
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/36590
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: API: move diskSizeExtend logic from BindingXMLRPC
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/36614
To unsubscribe, visit
Daniel Erez has uploaded a new change for review.
Change subject: API: move diskSizeExtend logic from BindingXMLRPC
..
API: move diskSizeExtend logic from BindingXMLRPC
In order to make cold extend disk usable
with JSON-RPC,
Daniel Erez has posted comments on this change.
Change subject: storageServer: Improve iscsi connection logging
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36028
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: storageServer: remove dead code from getSessionInfo
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/34537
To unsubscribe, visit
Daniel Erez has uploaded a new change for review.
Change subject: storageServer: remove dead code from getSessionInfo
..
storageServer: remove dead code from getSessionInfo
storageServer - getSessionInfo:
cleanup of unused code
Daniel Erez has posted comments on this change.
Change subject: storageServer: remove dead code from getSessionInfo
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34537/1/vdsm/storage/storageServer.py
File
Daniel Erez has posted comments on this change.
Change subject: jsonrpc: mssing clone image structure in command info
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/33669/1/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
1 - 100 of 183 matches
Mail list logo