Change in vdsm[ovirt-3.5]: vdsm-tool: Add args to remove_saslpasswd

2014-06-25 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Add args to remove_saslpasswd .. Patch Set 1: backport of http://gerrit.ovirt.org/#/c/29116/ -- To view, visit http://gerrit.ovirt.org/29201 To

Change in vdsm[ovirt-3.5]: log: Remove metadata.log

2014-06-25 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: log: Remove metadata.log .. log: Remove metadata.log This log exists only in the spec file and logger.conf. Removing because not used by VDSM. Change-Id:

Change in vdsm[ovirt-3.5]: log: Remove metadata.log

2014-06-25 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: log: Remove metadata.log .. Patch Set 1: backport of http://gerrit.ovirt.org/#/c/28903/ -- To view, visit http://gerrit.ovirt.org/29205 To unsubscribe, visit

Change in vdsm[master]: log: Change vdsm log file to enforce user/group

2014-06-24 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: log: Change vdsm log file to enforce user/group .. Patch Set 5: this patch needs http://gerrit.ovirt.org/#/c/27193/ to pass -- To view, visit

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

2014-06-24 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 12: Verified+1 Verified with the following way (with subsequent patch to have logging): * manually removed old

Change in vdsm[master]: vdsm-tool: Add args to remove_saslpasswd

2014-06-24 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: vdsm-tool: Add args to remove_saslpasswd .. vdsm-tool: Add args to remove_saslpasswd In a recent patch added, all commands receive arguments, starting with

Change in vdsm[master]: vdsm-tool: Add args to remove_saslpasswd

2014-06-24 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Add args to remove_saslpasswd .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29116/1/lib/vdsm/tool/passwd.py File lib/vdsm/tool/passwd.py:

Change in vdsm[master]: vdsm-tool: Add args to remove_saslpasswd

2014-06-24 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Add args to remove_saslpasswd .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29116/1/lib/vdsm/tool/passwd.py File lib/vdsm/tool/passwd.py:

Change in vdsm[master]: open: Change file() to open()

2014-06-23 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: open: Change file() to open() .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/26776/4/lib/vdsm/libvirtconnection.py File

Change in vdsm[master]: log: Change vdsm log file to enforce user/group

2014-06-18 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: log: Change vdsm log file to enforce user/group .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26728/1/vdsm/logUtils.py File vdsm/logUtils.py: Line

Change in vdsm[master]: vdsm-tool: Add logging configuration.

2014-06-18 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Add logging configuration. .. Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/27481/9/vdsm-tool/vdsm-tool File vdsm-tool/vdsm-tool: Line 169:

Change in vdsm[master]: log: Change vdsm log file to enforce user/group

2014-06-18 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: log: Change vdsm log file to enforce user/group .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/26728/3/vdsm/logger.conf.in File vdsm/logger.conf.in:

Change in vdsm[master]: log: Remove metadata.log

2014-06-18 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: log: Remove metadata.log .. log: Remove metadata.log This log exists only in the spec file and logger.conf. Removing because not used by VDSM. Change-Id:

Change in vdsm[master]: supervdsm: Switch multiprocessing to CPopen

2014-06-18 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: supervdsm: Switch multiprocessing to CPopen .. supervdsm: Switch multiprocessing to CPopen Default implementation of multiprocessing.Process used Popen to

Change in vdsm[master]: supervdsm: Switch multiprocessing to CPopen

2014-06-18 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: supervdsm: Switch multiprocessing to CPopen .. Patch Set 1: CPopen should not take care of zombies, but it solves the issue. Will to investigate further. --

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

2014-06-17 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/27193/11/init/vdsmd_init_common.sh.in File

Change in vdsm[master]: vdsm-tool: Add logging configuration.

2014-06-17 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Add logging configuration. .. Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/27481/8//COMMIT_MSG Commit Message: Line 5: CommitDate:

Change in vdsm[master]: mounts: Optimize mount loop device resolution

2014-06-16 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: mounts: Optimize mount loop device resolution .. Patch Set 5: (1 comment) Barak, I'll ask Saggi if he opened one, if not will open.

Change in vdsm[master]: vdsClient: alternative ways to provide password

2014-06-16 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsClient: alternative ways to provide password .. Patch Set 16: Hey Alon, Currently params= argument cannot contain spaces and is limited to being the 5th

Change in vdsm[ovirt-3.4]: dmidecode: Handle missing values.

2014-06-10 Thread dkuznets
Hello Yaniv Bronhaim, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/28541 to review the following change. Change subject: dmidecode: Handle missing values. .. dmidecode: Handle missing values.

Change in vdsm[ovirt-3.4]: dmidecode: Handle missing values.

2014-06-10 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: dmidecode: Handle missing values. .. Patch Set 1: Verified+1 verified with engine built from ovirt-3.4 -- To view, visit http://gerrit.ovirt.org/28541 To

Change in vdsm[master]: Remove redundant print

2014-06-10 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: Remove redundant print .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28406 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: Remove redundant print

2014-06-10 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: Remove redundant print .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28406 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: Remove redundant print

2014-06-09 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: Remove redundant print .. Patch Set 1: Maybe its worth to print usage on ExtraArgsError? -- To view, visit http://gerrit.ovirt.org/28406 To unsubscribe,

Change in vdsm[master]: Additional oop functionality

2014-06-09 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: Additional oop functionality .. Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/27641/11/vdsm/storage/outOfProcess.py File vdsm/storage/outOfProcess.py:

Change in vdsm[master]: vdsClient: alternative ways to provide password

2014-05-29 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsClient: alternative ways to provide password .. Patch Set 15: (1 comment) http://gerrit.ovirt.org/#/c/24733/15/client/vdsClient.py File

Change in vdsm[master]: vdsm-tool: Add logging and verbosity flags

2014-05-29 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Add logging and verbosity flags .. Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/27481/8/vdsm-tool/vdsm-tool File vdsm-tool/vdsm-tool: Line

Change in vdsm[master]: client: Add warning prompt on dangerous commands

2014-05-28 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: client: Add warning prompt on dangerous commands .. client: Add warning prompt on dangerous commands Added a warning and confirmation prompt for the following

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

2014-05-28 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 9: (4 comments) http://gerrit.ovirt.org/#/c/27193/9/tests/toolTests.py File tests/toolTests.py: Line 370:

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

2014-05-28 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 10: Oops, added to a later commit, fixing. -- To view, visit http://gerrit.ovirt.org/27193 To unsubscribe,

Change in vdsm[master]: vdsClient: alternative ways to provide password

2014-05-28 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsClient: alternative ways to provide password .. Patch Set 14: (2 comments) http://gerrit.ovirt.org/#/c/24733/14/client/vdsClient.py File

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

2014-05-28 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/27193/11/init/vdsmd_init_common.sh.in File

Change in vdsm[master]: vdsm-tool: Add logging and verbosity flags

2014-05-28 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Add logging and verbosity flags .. Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/27481/8//COMMIT_MSG Commit Message: Line 5: CommitDate:

Change in vdsm[master]: client: Add warning prompt on dangerous commands

2014-05-28 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: client: Add warning prompt on dangerous commands .. Patch Set 2: Code-Review-1 blocked by open HE bugs. -- To view, visit http://gerrit.ovirt.org/28174 To

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

2014-05-27 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 8: Assaf, the ordering is truly a bit problematic, because logging facilities only added in a latter patch,

Change in vdsm[master]: unit_tests: Make run_tests_local.sh not be a generated file

2014-05-27 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: unit_tests: Make run_tests_local.sh not be a generated file .. Patch Set 1: Why not give tests/run_tests.sh the same treatment? Also, need to remove the file

Change in vdsm[master]: vdsm-tool: Add logging and verbosity flags

2014-05-27 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Add logging and verbosity flags .. Patch Set 5: We can use argparse, but if we want to preserve the usage of all @exposed commands, we'd have to

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

2014-05-27 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 8: Upon further examination, this was missing logs, because logger was ignoring DEBUG level logs, fixed in

Change in vdsm[master]: dmidecode: Handle missing values

2014-05-27 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: dmidecode: Handle missing values .. Patch Set 4: Verified+1 Verified by using vdsClient getHardwareInformation verb and engine webadmin, locally changed

Change in vdsm[master]: misc: remove readfile function.

2014-05-21 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: misc: remove readfile function. .. misc: remove readfile function. readfile() function was only used inside its own tests, and due to recent changes of

Change in vdsm[master]: misc: remove readfile function.

2014-05-21 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: misc: remove readfile function. .. Patch Set 1: Verified+1 * all remaining tests run * prior to removal, only the tests in miscTests.py used readfile(). (git

Change in vdsm[master]: tests: fix read not blocksize aligned

2014-05-21 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: tests: fix read not blocksize aligned .. Patch Set 3: Please consider http://gerrit.ovirt.org/#/c/27959/ -- To view, visit http://gerrit.ovirt.org/27127 To

Change in vdsm[master]: vdsClient: alternative ways to provide password

2014-05-21 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsClient: alternative ways to provide password .. Patch Set 13: Returned to shlex for conList parsing -- To view, visit http://gerrit.ovirt.org/24733 To

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

2014-05-21 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 7: -Verified Code-Review-1 -- To view, visit http://gerrit.ovirt.org/27193 To unsubscribe, visit

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

2014-05-21 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 8: Verified+1 In addition to previous change, removed upgrade.log config files, as they are not needed

Change in vdsm[master]: pep8: Add non .py sources to PEP8_WHITELIST

2014-05-21 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: pep8: Add non .py sources to PEP8_WHITELIST .. pep8: Add non .py sources to PEP8_WHITELIST Change-Id: Ic84d0acb47766ed3c433e06589114daca93083a5 Signed-off-by:

Change in vdsm[master]: pep8: Add non .py sources to PEP8_WHITELIST

2014-05-21 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: pep8: Add non .py sources to PEP8_WHITELIST .. Patch Set 1: Verified+1 verified with pydiff, diff only in vds_bootstrap/setup: (('22 + -', None), (22,

Change in vdsm[master]: pep8: Fix indentation in supervdsmServer

2014-05-20 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: pep8: Fix indentation in supervdsmServer .. pep8: Fix indentation in supervdsmServer Fix pep8 issue in supervdsmServer and added its path to PEP8_WHITELIST to

Change in vdsm[master]: pep8: Fix indentation in supervdsmServer

2014-05-20 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: pep8: Fix indentation in supervdsmServer .. Patch Set 1: Verified+1 verified with make check-local -- To view, visit http://gerrit.ovirt.org/27899 To

Change in vdsm[master]: pep8: Fix indentation in supervdsmServer

2014-05-20 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: pep8: Fix indentation in supervdsmServer .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27899/1/vdsm/supervdsmServer File vdsm/supervdsmServer: Line

Change in vdsm[master]: pep8: Fix indentation in supervdsmServer

2014-05-20 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: pep8: Fix indentation in supervdsmServer .. Patch Set 2: Verified+1 verified with make check-local -- To view, visit http://gerrit.ovirt.org/27899 To

Change in vdsm[master]: tests: fix read not blocksize aligned

2014-05-20 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: tests: fix read not blocksize aligned .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27127 To unsubscribe, visit

Change in vdsm[master]: vdsm-tool: Change exception reporting

2014-05-20 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Change exception reporting .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.ovirt.org/26565 To unsubscribe, visit

Change in vdsm[master]: vdsm-tool: Add command name to args for command

2014-05-20 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Add command name to args for command .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.ovirt.org/26575 To unsubscribe, visit

Change in vdsm[master]: vdsm-tool: update to print function

2014-05-20 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: update to print function .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/27678 To unsubscribe, visit

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

2014-05-20 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.ovirt.org/27193 To unsubscribe, visit

Change in vdsm[master]: vdsm-tool: Add logging and verbosity flags

2014-05-20 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Add logging and verbosity flags .. Patch Set 4: Verified+1 Rebased and verified by following methods: * Unit tests ran and passed, including tests

Change in vdsm[master]: vdsm-tool: Add logging and verbosity flags

2014-05-20 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Add logging and verbosity flags .. Patch Set 4: There is still a patch that is missing, after this patch all logging will got to screen, and not to

Change in vdsm[master]: pep8: Fix pep8 in vdsm-tool

2014-05-14 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: pep8: Fix pep8 in vdsm-tool .. pep8: Fix pep8 in vdsm-tool Change-Id: I00773932002cdeac939afedad90f1291010fedda Signed-off-by: Dima Kuznetsov

Change in vdsm[master]: vdsm-tool: Add command name to args for command

2014-05-14 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Add command name to args for command .. Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/26575/2/lib/vdsm/tool/unified_persistence.py File

Change in vdsm[master]: vdsm-tool: Add command name to args for command

2014-05-14 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Add command name to args for command .. Patch Set 4: fixed wrong name in one of the docstrings. -- To view, visit http://gerrit.ovirt.org/26575 To

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

2014-05-14 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/27193/3//COMMIT_MSG Commit Message: Line 10: to only run once.

Change in vdsm[master]: vdsm-tool: Change exception reporting

2014-05-14 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Change exception reporting .. Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/26565/6/lib/vdsm/tool/__init__.py File

Change in vdsm[master]: pep8: Fix pep8 in vdsm-tool

2014-05-14 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: pep8: Fix pep8 in vdsm-tool .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27656/2/vdsm-tool/vdsm-tool File vdsm-tool/vdsm-tool: Line 95:

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

2014-05-14 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/27193/4/lib/vdsm/tool/unified_persistence.py File

Change in vdsm[master]: vdsm-tool: update to print function

2014-05-14 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: vdsm-tool: update to print function .. vdsm-tool: update to print function Update prints to python3 print function Change-Id:

Change in vdsm[master]: vdsm-tool: Add command name to args for command

2014-05-14 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Add command name to args for command .. Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/26575/5/lib/vdsm/tool/__init__.py File

Change in vdsm[master]: vdsm-tool: Add command name to args for command

2014-05-14 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Add command name to args for command .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/26575/5/vdsm-tool/vdsm-tool File vdsm-tool/vdsm-tool:

Change in vdsm[master]: hooks: introduce after_get_caps hook

2014-05-14 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: hooks: introduce after_get_caps hook .. Patch Set 1: I suggest adding the following to vdsm.spec.in %dir %{_libexecdir}/%{vdsm_name}/hooks/after_get_caps and

Change in vdsm[master]: fakevmstats: Fix debian install paths.

2014-05-14 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: fakevmstats: Fix debian install paths. .. fakevmstats: Fix debian install paths. Remove non-existant file. Change-Id:

Change in vdsm[master]: hooks: introduce after_get_caps hook

2014-05-14 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: hooks: introduce after_get_caps hook .. Patch Set 1: Yes, sorry, missed the spec change. About the before hook, I don't have a strong opinion. It is not

Change in vdsm[master]: hooks: introduce before/after_get_caps hook points

2014-05-14 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: hooks: introduce before/after_get_caps hook points .. Patch Set 2: Code-Review+1 Looks great. -- To view, visit http://gerrit.ovirt.org/27679 To unsubscribe,

Change in vdsm[master]: fakevmstats: Fix debian install paths.

2014-05-14 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: fakevmstats: Fix debian install paths. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/27682 To unsubscribe, visit

Change in vdsm[master]: pep8: Fix pep8 in vdsm-tool

2014-05-14 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: pep8: Fix pep8 in vdsm-tool .. Patch Set 4: Verified+1 ran make check-local, made sure pep8 ran on vdsm-tool and returned no errors. -- To view, visit

Change in vdsm[master]: open: Change file() to open()

2014-05-14 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: open: Change file() to open() .. Patch Set 3: Verified+1 Ran nosetest and all the tests ran ok, open to suggestions about additional tests. -- To view,

Change in vdsm[master]: pep8: Fix pep8 in vdsm-tool

2014-05-14 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: pep8: Fix pep8 in vdsm-tool .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/27656/5/Makefile.am File Makefile.am: Line 61:vdsm.py \ Line 62:

Change in vdsm[master]: pep8: Fix pep8 in vdsm-tool

2014-05-14 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: pep8: Fix pep8 in vdsm-tool .. Patch Set 6: Verified+1 ran make check-local, made sure pep8 ran on vdsm-tool and returned no errors. -- To view, visit

Change in vdsm[master]: hooks: Add hook for fake VM stats

2014-05-13 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: hooks: Add hook for fake VM stats .. Patch Set 17: (1 comment) http://gerrit.ovirt.org/#/c/25927/17/vdsm/vdsmd.8.in File vdsm/vdsmd.8.in: Line 67: in

Change in vdsm[master]: hooks: Add hook for fake VM stats

2014-05-13 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: hooks: Add hook for fake VM stats .. Patch Set 18: Verified+1 verified with vdsClient and engine frontend. -- To view, visit http://gerrit.ovirt.org/25927 To

Change in vdsm[master]: vdsm-tool: Add logging and verbosity flags

2014-05-11 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Add logging and verbosity flags .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27481/1/vdsm-tool/vdsm-tool File vdsm-tool/vdsm-tool: Line

Change in vdsm[master]: caps: Add selinux enforcement reporting.

2014-05-07 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: caps: Add selinux enforcement reporting. .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/26951/4/vdsm/caps.py File vdsm/caps.py: Line 391: Line 392:

Change in vdsm[master]: vdsm-tool: Change exception reporting

2014-05-07 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Change exception reporting .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/26565/4/lib/vdsm/tool/__init__.py File

Change in vdsm[master]: caps: Add selinux enforcement reporting.

2014-05-07 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: caps: Add selinux enforcement reporting. .. Patch Set 5: rebased and moved _getSELinuxEnforceMode from utils.py to caps.py. -- To view, visit

Change in vdsm[master]: caps: Add selinux enforcement reporting.

2014-05-07 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: caps: Add selinux enforcement reporting. .. Patch Set 5: Verified+1 Verified with vdsClient getVdsCaps, reports correctly. -- To view, visit

Change in vdsm[master]: vdsm-tool: Add logging and verbosity flags

2014-05-07 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: vdsm-tool: Add logging and verbosity flags .. vdsm-tool: Add logging and verbosity flags Added -l/--logfile, -v/--verbose flags to vdsm-tool to control the

Change in vdsm[master]: hooks: Add hook for fake VM stats

2014-05-02 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: hooks: Add hook for fake VM stats .. Patch Set 17: I am only shipping 1 hook implementation, after_get_all_vm_stats. Other hook events were added but up to

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

2014-04-30 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 3: Got rid of class, went for apply_upgrade() function as single point of interface. Added some tests for

Change in vdsm[master]: hooks: Add hook for fake VM stats

2014-04-30 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: hooks: Add hook for fake VM stats .. Patch Set 15: fixed pep8 issue -- To view, visit http://gerrit.ovirt.org/25927 To unsubscribe, visit

Change in vdsm[master]: hooks: Add hook for fake VM stats

2014-04-30 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: hooks: Add hook for fake VM stats .. Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/25927/13/vdsm_hooks/fakevmstats/after_get_all_vm_stats.py File

Change in vdsm[master]: caps: Add selinux enforcement reporting.

2014-04-30 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: caps: Add selinux enforcement reporting. .. Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/26951/4/lib/vdsm/utils.py File lib/vdsm/utils.py: Line

Change in vdsm[master]: hooks: Add hook for fake VM stats

2014-04-30 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: hooks: Add hook for fake VM stats .. Patch Set 15: (2 comments) http://gerrit.ovirt.org/#/c/25927/15/vdsm/vdsmd.8.in File vdsm/vdsmd.8.in: Line 147:

Change in vdsm[master]: schema: Fix wrong type in GuestNetworkDeviceInfo

2014-04-30 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: schema: Fix wrong type in GuestNetworkDeviceInfo .. schema: Fix wrong type in GuestNetworkDeviceInfo Changed inet and inet6 in GuestNetworkDeviceInfo to be

Change in vdsm[master]: schema: Fix wrong type in GuestNetworkDeviceInfo

2014-04-30 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: schema: Fix wrong type in GuestNetworkDeviceInfo .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/27263 To unsubscribe, visit

Change in vdsm[master]: hooks: Add hook for fake VM stats

2014-04-30 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: hooks: Add hook for fake VM stats .. Patch Set 17: Fixed issue in netIfaces due to wrong info in schema: http://gerrit.ovirt.org/#/c/27263/ Also fixed

Change in vdsm[master]: open: Change file() to open()

2014-04-29 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: open: Change file() to open() .. Patch Set 2: Changed file() shadowing, fixed file() in a few more places. -- To view, visit http://gerrit.ovirt.org/26776 To

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

2014-04-29 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: vdsm-tool: Change upgrade mechanism .. vdsm-tool: Change upgrade mechanism The upgrade decorator is a mechanism within vdsm-tool to allow commands to only run

Change in vdsm[master]: hooks: Add hook for fake VM stats

2014-04-29 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: hooks: Add hook for fake VM stats .. Patch Set 13: (2 comments) http://gerrit.ovirt.org/#/c/25927/13/vdsm/API.py File vdsm/API.py: Line 1198: def

Change in vdsm[master]: hooks: Add hook for fake VM stats

2014-04-29 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: hooks: Add hook for fake VM stats .. Patch Set 14: Rebased the code, added before/after_get_vm_stats events. -- To view, visit http://gerrit.ovirt.org/25927

Change in vdsm[master]: vdsm-tool: Change upgrade mechanism

2014-04-29 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: Change upgrade mechanism .. Patch Set 2: After a short discussion with Saggi, I've decided to get rid of the inheritance, instead, rename Upgrade

Change in vdsm[master]: caps: Add support for vdsm3 package

2014-04-28 Thread dkuznets
Dima Kuznetsov has abandoned this change. Change subject: caps: Add support for vdsm3 package .. Abandoned not using vdsm3 anymore -- To view, visit http://gerrit.ovirt.org/26627 To unsubscribe, visit

<    1   2   3   4   5   >