Sergey Gotliv has posted comments on this change.
Change subject: iscsi: Set node.session.timeo.replacement_timeout when creating
a node
..
Patch Set 1: Code-Review+1
(1 comment)
Sergey Gotliv has posted comments on this change.
Change subject: iscsi: Set node.session.timeo.replacement_timeout when creating
a node
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/32363/1//COMMIT_MSG
Commit
Sergey Gotliv has posted comments on this change.
Change subject: Configure iSCSI iface.net_ifacename
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/31534/3/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:
Line
Sergey Gotliv has posted comments on this change.
Change subject: iscsi: Set node.session.timeo.replacement_timeout when creating
a node
..
Patch Set 1: Code-Review-1
(1 comment)
Sergey Gotliv has posted comments on this change.
Change subject: Configure iSCSI iface.net_ifacename
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/31534/3/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:
Line
Sergey Gotliv has posted comments on this change.
Change subject: Configure iSCSI iface.net_ifacename
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/31534/3/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:
Line
Sergey Gotliv has posted comments on this change.
Change subject: Configure iSCSI iface.net_ifacename
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/31534/3/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:
Line
Sergey Gotliv has posted comments on this change.
Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same
subnet
..
Patch Set 2: Code-Review+1
(1 comment)
In general it requires network team review,
Sergey Gotliv has posted comments on this change.
Change subject: Configure iSCSI iface.net_ifacename
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/31534/3/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:
Line
Sergey Gotliv has posted comments on this change.
Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same
subnet
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/31529/2//COMMIT_MSG
Commit
Sergey Gotliv has posted comments on this change.
Change subject: storage: Add logging on filesystem altering operations
..
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26046
To unsubscribe, visit
Hello Nir Soffer, Federico Simoncelli,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/26658
to review the following change.
Change subject: iscsi: Specify tpgt to impose creation of a new style node
record
Hello Douglas Schilling Landgraf, Nir Soffer, Federico Simoncelli, Allon
Mureinik,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/26657
to review the following change.
Change subject: hsm: Rename _BCInitiatorNameResolve function
Hello Nir Soffer, Federico Simoncelli,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/26656
to review the following change.
Change subject: hsm: Distinguish between iface and initiator when creating
iSCSI iface
Sergey Gotliv has posted comments on this change.
Change subject: hsm: Distinguish between iface and initiator when creating
iSCSI iface
..
Patch Set 2: Verified+1
I verified the original patch.
--
To view, visit
Sergey Gotliv has posted comments on this change.
Change subject: iscsi: Specify tpgt to impose creation of a new style node
record
..
Patch Set 2:
I verified and provided steps to verify on original patch.
--
To view,
Sergey Gotliv has posted comments on this change.
Change subject: iscsi: Specify tpgt to impose creation of a new style node
record
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/26658
To unsubscribe,
Sergey Gotliv has posted comments on this change.
Change subject: hsm: Rename _BCInitiatorNameResolve function
..
Patch Set 2: Verified+1
I verified and provided steps to verify on original patch.
--
To view, visit
Sergey Gotliv has posted comments on this change.
Change subject: iscsi: Specify tpgt to impose creation of a new style node
record
..
Patch Set 5:
ping...
--
To view, visit http://gerrit.ovirt.org/25706
To unsubscribe,
Sergey Gotliv has posted comments on this change.
Change subject: iscsi: Specify tpgt to impose creation of a new style node
record
..
Patch Set 5: Verified+1
Steps to verify:
1. Create iSCSI storage domain from Engine -
Sergey Gotliv has posted comments on this change.
Change subject: iscsi: Specify tpgt to impose creation of a new style node
record
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/25706/5/vdsm/storage/iscsi.py
File
Sergey Gotliv has posted comments on this change.
Change subject: iscsi: Specify tpgt to impose creation of a new style node
record
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/25706/5/vdsm/storage/iscsi.py
File
Sergey Gotliv has posted comments on this change.
Change subject: hsm: Distinguish between iface and initiator when creating
iSCSI iface
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/25628
To
Sergey Gotliv has posted comments on this change.
Change subject: hsm: Rename _BCInitiatorNameResolve function
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/25701
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: hsm: Rename _BCInitiatorNameResolve function
..
Patch Set 1:
Steps to verify:
1. Create iSCSI storage domain from Engine - verify that storage domain is
Sergey Gotliv has posted comments on this change.
Change subject: hsm: Distinguish between iface and initiator when creating
iSCSI iface
..
Patch Set 2:
Steps to verify:
1. Create iSCSI storage domain from Engine - verify
Sergey Gotliv has posted comments on this change.
Change subject: sp: fix spm start when failing to produce domain
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Sergey Gotliv has posted comments on this change.
Change subject: iscsi: Specify tpgt to impose creation of a new style node
record
..
Patch Set 5:
PEP8
--
To view, visit http://gerrit.ovirt.org/25706
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: hsm: Distinguish between iface and initiator when creating
iSCSI iface
..
Patch Set 2:
Sure, the Engine patch is ready to go.
--
To view, visit
Sergey Gotliv has posted comments on this change.
Change subject: iscsi: Use tpgt when login, update or remove iscsi node
..
Patch Set 3:
(3 comments)
http://gerrit.ovirt.org/#/c/25706/3/vdsm/storage/hsm.py
File
Sergey Gotliv has posted comments on this change.
Change subject: iscsi: Use tpgt when login, update or remove iscsi node
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25706/1/vdsm/storage/iscsi.py
File
Sergey Gotliv has posted comments on this change.
Change subject: iscsi.py: cleanup - remove temp variable
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25710
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: hsm: Distinguish between iface and initiator when creating
iSCSI iface
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25628/1/vdsm/storage/hsm.py
Sergey Gotliv has uploaded a new change for review.
Change subject: hsm: Rename _BCInitiatorNameResolve function
..
hsm: Rename _BCInitiatorNameResolve function
Function _BCInitiatorNameResolve actually resolves the iface name
Sergey Gotliv has uploaded a new change for review.
Change subject: iscsi: Use tpgt when login, update or remove iscsi node
..
iscsi: Use tpgt when login, update or remove iscsi node
According to iscsi documentation
Sergey Gotliv has uploaded a new change for review.
Change subject: hsm: Distinguish between iface and initiator when creating
iSCSI iface
..
hsm: Distinguish between iface and initiator when creating iSCSI iface
VDSM
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/24467
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: sp: stop all poolMonitoredDomains on disconnect
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24088
To unsubscribe, visit
Sergey Gotliv has uploaded a new change for review.
Change subject: sp: Remove redundant validation
..
sp: Remove redundant validation
Before deactivating storage domain we validate that this domain is a
member of the pool. It
Hello Ayal Baron, Nir Soffer, Allon Mureinik,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/24467
to review the following change.
Change subject: clientIF: Teardown volume path only for VDSM images
Sergey Gotliv has posted comments on this change.
Change subject: vm: discover volume path from xml definition
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/24202/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Sergey Gotliv has posted comments on this change.
Change subject: vm: discover volume path from xml definition
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24202
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: vm: discover volume path from xml definition
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/24202/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/21973
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: vdsm: add support for multiple iSCSI interfaces
..
Patch Set 1: Code-Review-1
Martin,
We discussed the similar approach to resolve this problem here:
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Remove unnecessary device is disk check in
prepareVolumePath
..
Patch Set 2:
Michal,
Please, read Ayal's comments in
Sergey Gotliv has posted comments on this change.
Change subject: vm: Unify checks for vdsm image
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22370
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: vm: Fix attribute error when accessing drive in sampling method
..
Patch Set 1: Code-Review+1
(1 comment)
I assume that this is an upstream patch, right?
Sergey Gotliv has posted comments on this change.
Change subject: vm: Fix attribute error when accessing drive in sampling method
..
Patch Set 1: Code-Review-1
(1 comment)
Sorry, I changed my mind either, please see my
Sergey Gotliv has posted comments on this change.
Change subject: vm: Avoid log spamming when drive format is undefined
..
Patch Set 2: Code-Review+1
Now I like it again! It seems like format is just lost somewhere :-)
--
To
Sergey Gotliv has posted comments on this change.
Change subject: hsm: refresh pool connection on connectStoragePool
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22467
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: vm: Unify checks for vdsm image
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22370
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: sp: consolidate getMasterVersion in one method
..
Patch Set 2: Code-Review+1
(2 comments)
File
Sergey Gotliv has posted comments on this change.
Change subject: sp: consolidate getMasterVersion in one method
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22130
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: sp: move reconnection info check to StoragePool
..
Patch Set 8:
This is the bug I mentioned in my comment BZ#1026697
--
To view, visit
Sergey Gotliv has posted comments on this change.
Change subject: deactivateSD - perform nothing if the domain is already
deactivated
..
Patch Set 1:
(1 comment)
File
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Remove unnecessary device is disk check in
prepareVolumePath
..
Patch Set 2:
I mistakenly pushed patch set 1 to draft.
--
To view, visit
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Remove unnecessary device is disk check in
prepareVolumePath
..
Patch Set 2:
I am not sure that all checks are unnecessary therefore I didn't remove
Sergey Gotliv has posted comments on this change.
Change subject: sp: move reconnection info check to StoragePool
..
Patch Set 8:
(1 comment)
File vdsm/storage/hsm.py
Line
Sergey Gotliv has posted comments on this change.
Change subject: vm: Unify checks for vdsm image
..
Patch Set 2: Code-Review-1
Nir,
I think I told you my opinion about, so I am out of this.
--
To view, visit
Sergey Gotliv has posted comments on this change.
Change subject: vm: Unify checks for vdsm image
..
Patch Set 2: Code-Review-1
(1 comment)
I realized that if I am out my -1 is out with me :-).
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(1 comment)
@Nir, you introduced a nice patch, but please see Ayal's comment device ==
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
Related to my another patch http://gerrit.ovirt.org/#/c/22363/.
Funny that you don't
Sergey Gotliv has posted comments on this change.
Change subject: vm: Unify checks for vdsm image
..
Patch Set 2:
(1 comment)
File vdsm/vm.py
Line 88: :type drive: dict
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(2 comments)
File vdsm/clientIF.py
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(1 comment)
File vdsm/clientIF.py
Line
Sergey Gotliv has posted comments on this change.
Change subject: sp: move reconnection info check to StoragePool
..
Patch Set 8:
(1 comment)
Please, check if my suggestion in hsm.py is doable.
Sergey Gotliv has posted comments on this change.
Change subject: deactivateSD - perform nothing if the domain is already
deactivated
..
Patch Set 1: Code-Review-1
(2 comments)
Sergey Gotliv has uploaded a new change for review.
Change subject: clientIF: Remove unnecessary device is disk check
..
clientIF: Remove unnecessary device is disk check
Change-Id: I98317e805e6770df5dacd3237a383aaca78fde1e
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Remove unnecessary device is disk check
..
Patch Set 1:
(1 comment)
I will improve the commit message later.
Sergey Gotliv has posted comments on this change.
Change subject: Teardown only VDSM images when calling to teardownVolumePath
..
Patch Set 3: Verified-1 Code-Review-1
--
To view, visit http://gerrit.ovirt.org/21973
To
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 4:
(1 comment)
Commit Message
Line 7:
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
PEP8
--
To view, visit http://gerrit.ovirt.org/21973
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(2 comments)
Nir,
Let's wait to see what others think about this patch.
I easily see 2
Sergey Gotliv has posted comments on this change.
Change subject: vdsm: Add an exception for wrong master version.
..
Patch Set 3:
(1 comment)
File
Sergey Gotliv has posted comments on this change.
Change subject: sp: _refreshDomainLinks must not change the metadata
..
Patch Set 1:
(1 comment)
Code looks nice, please improve the commit message.
Sergey Gotliv has posted comments on this change.
Change subject: sp: remove unused recoveryMode from spmStart
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21556
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: sp: remove unused scsiFencing parameter
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21555
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: Teardown only VDSM images when power-off VM
..
Patch Set 2:
(1 comment)
File vdsm/vm.py
Line 2537:
Sergey Gotliv has posted comments on this change.
Change subject: Teardown only VDSM images when power-off VM
..
Patch Set 2:
(1 comment)
File vdsm/vm.py
Line 2537:
Sergey Gotliv has posted comments on this change.
Change subject: Teardown only VDSM images when power-off VM
..
Patch Set 2:
(1 comment)
File vdsm/vm.py
Line 2537:
Sergey Gotliv has posted comments on this change.
Change subject: sp: Fix stopping domain monitors
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22058
To unsubscribe, visit
Sergey Gotliv has uploaded a new change for review.
Change subject: Teardown only VDSM images when power-off VM
..
Teardown only VDSM images when power-off VM
Trying to tear down a cdrom or external lun throws an exception
Sergey Gotliv has posted comments on this change.
Change subject: Teardown only VDSM images when power-off VM
..
Patch Set 2:
Added a bug number.
--
To view, visit http://gerrit.ovirt.org/21973
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: Teardown only VDSM images when power-off VM
..
Patch Set 2:
(2 comments)
Commit Message
Line 3:
Sergey Gotliv has posted comments on this change.
Change subject: vdsm-hooks: fix malformed libvirt xml
..
Patch Set 1: Code-Review+1
(3 comments)
Commit Message
Line 4:
Sergey Gotliv has posted comments on this change.
Change subject: vdsm-hooks: fix malformed libvirt xml
..
Patch Set 1:
Adding maintainers.
--
To view, visit http://gerrit.ovirt.org/21913
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: vdsm hooks: Add missing snapshot=no attribute to disk
ellements.
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21913
To unsubscribe,
Sergey Gotliv has posted comments on this change.
Change subject: domainMonitor: Improve logging
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21936
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: vm: Refix vm unpausing during recovery
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21892
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: domainMonitor: Improve logging
..
Patch Set 1: Code-Review+1
This is exactly the same question I asked myself yesterday :-).
--
To view, visit
Sergey Gotliv has posted comments on this change.
Change subject: sdc: Change error messages to info
..
Patch Set 1:
(1 comment)
We all know that for each FC domain we'll see that message at least once and
since this is
Sergey Gotliv has posted comments on this change.
Change subject: utils: Add unhandled exceptions logging decorator
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21778
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: sp: remove unused recoveryMode from spmStart
..
Patch Set 5:
(1 comment)
File vdsm/BindingXMLRPC.py
Line
Sergey Gotliv has posted comments on this change.
Change subject: Fix getStorageDomainInfo() logic.
..
Patch Set 2:
Ayal,
Did you check the bug I mentioned above?
--
To view, visit http://gerrit.ovirt.org/20209
To
Sergey Gotliv has posted comments on this change.
Change subject: Fix getStorageDomainInfo() logic.
..
Patch Set 2:
Ayal,
Please, check this bug, and Eduardo's latest comment:
Sergey Gotliv has posted comments on this change.
Change subject: Fix getStorageDomainInfo() logic.
..
Patch Set 2:
I am wrong, the backport should be done to downstream!
--
To view, visit http://gerrit.ovirt.org/20209
To
Sergey Gotliv has posted comments on this change.
Change subject: Fix getStorageDomainInfo() logic.
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20209
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: Fix getStorageDomainInfo() logic.
..
Patch Set 2:
We need this patch in order to fix BZ#10133942.
--
To view, visit http://gerrit.ovirt.org/20209
To
Sergey Gotliv has posted comments on this change.
Change subject: Fix getStorageDomainInfo() logic.
..
Patch Set 2:
The correct bug is BZ#1033942.
--
To view, visit http://gerrit.ovirt.org/20209
To unsubscribe, visit
1 - 100 of 249 matches
Mail list logo
