Wenyi Gao has posted comments on this change.
Change subject: Move start_needed_srv and shutdown_conflicting_srv to vdsm-tool
..
Patch Set 2:
Yaniv,
It's very difficulty for me to set up rhel6.3 to run vdsm because the l
Wenyi Gao has posted comments on this change.
Change subject: Move start_needed_srv and shutdown_conflicting_srv to vdsm-tool
..
Patch Set 2:
Yaniv,
How did you test? I tested it on Fedora17 and there is no failure.
--
To
Wenyi Gao has uploaded a new change for review.
Change subject: Move start_needed_srv and shutdown_conflicting_srv to vdsm-tool
..
Move start_needed_srv and shutdown_conflicting_srv to vdsm-tool
Change-Id
Wenyi Gao has posted comments on this change.
Change subject: Add exit code for vdsm-tool commands
..
Patch Set 1: Verified
Work as expected.
--
To view, visit http://gerrit.ovirt.org/8417
To unsubscribe, visit http
Wenyi Gao has uploaded a new change for review.
Change subject: Add exit code for vdsm-tool commands
..
Add exit code for vdsm-tool commands
The exit code is useful for user that calls vdsm-tool commands,
So return the exit
Wenyi Gao has posted comments on this change.
Change subject: Move load_needed_modules to vdsm-tool
..
Patch Set 7: (1 inline comment)
Douglas,
Sorry, I don't catch your point. What do you mean " @ENGINENAME
Wenyi Gao has posted comments on this change.
Change subject: Move load_needed_modules to vdsm-tool
..
Patch Set 5: No score
(1 inline comment)
File vdsm-tool
Wenyi Gao has posted comments on this change.
Change subject: Move load_needed_modules to vdsm-tool
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/7487
To unsubscribe, visit http://gerrit.ovirt.org/settings
Wenyi Gao has uploaded a new change for review.
Change subject: Move load_needed_modules to vdsm-tool
..
Move load_needed_modules to vdsm-tool
Move load_needed_modules to vdsm-tool from vdsmd.init
Change-Id
Wenyi Gao has abandoned this change.
Change subject: Move vdsmd.init to vdsm-tool
..
Patch Set 4: Abandoned
split some small patches
--
To view, visit http://gerrit.ovirt.org/4738
To unsubscribe, visit http://gerrit.ovirt.org
Wenyi Gao has abandoned this change.
Change subject: Make safer to get vdsm section version in configuration files
..
Patch Set 1: Abandoned
Invalid
--
To view, visit http://gerrit.ovirt.org/5051
To unsubscribe, visit http
Wenyi Gao has posted comments on this change.
Change subject: Move validate_libvirt_certs to vdsm-tool
..
Patch Set 5: No score
Sure, I will find someone else to verify this patch.
--
To view, visit http://gerrit.ovirt.org
Wenyi Gao has posted comments on this change.
Change subject: Move validate_libvirt_certs to vdsm-tool
..
Patch Set 5: Verified
Tested on my workstation with ovirt-node packages, works as expected.
--
To view, visit http
Wenyi Gao has posted comments on this change.
Change subject: Move validate_libvirt_certs to vdsm-tool
..
Patch Set 4: No score
(1 inline comment)
File vdsm-tool
Wenyi Gao has posted comments on this change.
Change subject: Move validate_libvirt_certs to vdsm-tool
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/5961
To unsubscribe, visit http://gerrit.ovirt.org
Wenyi Gao has posted comments on this change.
Change subject: Move validate_libvirt_certs to vdsm-tool
..
Patch Set 3: (1 inline comment)
File vdsm-tool
Wenyi Gao has posted comments on this change.
Change subject: Move validate_libvirt_certs to vdsm-tool
..
Patch Set 2: (4 inline comments)
Many thanks for reviewing the patch
Wenyi Gao has uploaded a new change for review.
Change subject: make pep8 clean for vhostmd/before_vm_start.py
..
make pep8 clean for vhostmd/before_vm_start.py
Change-Id: I556bbb687bd181c1e92b25ab15eb267638f51d4b
Signed-off-by
Wenyi Gao has uploaded a new change for review.
Change subject: make pep8 clean for vhostmd/after_vm_destroy.py
..
make pep8 clean for vhostmd/after_vm_destroy.py
Change-Id: I3abd5f034f34a313894e7f53994aa40c0286bb4f
Signed-off
Wenyi Gao has uploaded a new change for review.
Change subject: make pep8 clean for scratchpad/after_vm_destropy.py
..
make pep8 clean for scratchpad/after_vm_destropy.py
Change-Id: Ie86a7f31d441e1ed916052cdc132464dc1c0bd4a
Wenyi Gao has uploaded a new change for review.
Change subject: make pep8 clean for scratchpad/before_vm_start.py
..
make pep8 clean for scratchpad/before_vm_start.py
Change-Id: Ia16173d21984d3bd75f049311a42f79953f3998f
Signed
Wenyi Gao has uploaded a new change for review.
Change subject: make clean for scratchpad/before_vm_migrate_source.py
..
make clean for scratchpad/before_vm_migrate_source.py
Change-Id: I270cef856bce2d39c4173aab05125df6d66e3691
Wenyi Gao has abandoned this change.
Change subject: Make vhostmd/before_vm_start.py compliant to pep8
..
Patch Set 1: Abandoned
confilict
--
To view, visit http://gerrit.ovirt.org/6476
To unsubscribe, visit http
Wenyi Gao has abandoned this change.
Change subject: Make vhostmd/after_vm_destroy.py compliant to pep8
..
Patch Set 1: Abandoned
confilict
--
To view, visit http://gerrit.ovirt.org/6475
To unsubscribe, visit http
Wenyi Gao has abandoned this change.
Change subject: Make scratchpad/before_vm_start.py compliant to pep8
..
Patch Set 1: Abandoned
confilict
--
To view, visit http://gerrit.ovirt.org/6474
To unsubscribe, visit http
Wenyi Gao has abandoned this change.
Change subject: Make before_vm_migrate_source.py compliant to pep8
..
Patch Set 1: Abandoned
confilict
--
To view, visit http://gerrit.ovirt.org/6473
To unsubscribe, visit http
Wenyi Gao has abandoned this change.
Change subject: Make scratchpad/after_vm_destroy.py compliant to pep8
..
Patch Set 1: Abandoned
confilict
--
To view, visit http://gerrit.ovirt.org/6472
To unsubscribe, visit http
Wenyi Gao has abandoned this change.
Change subject: Make vhostmd/before_vm_start.py compliant to pep8
..
Patch Set 2: Abandoned
Move into one branch.
--
To view, visit http://gerrit.ovirt.org/4581
To unsubscribe, visit http
Wenyi Gao has abandoned this change.
Change subject: Make vhostmd/after_vm_destroy.py compliant to pep8
..
Patch Set 2: Abandoned
Move into one branch.
--
To view, visit http://gerrit.ovirt.org/4580
To unsubscribe, visit http
Wenyi Gao has abandoned this change.
Change subject: Make scratchpad/before_vm_start.py compliant to pep8
..
Patch Set 2: Abandoned
Move into one branch.
--
To view, visit http://gerrit.ovirt.org/4578
To unsubscribe, visit
Wenyi Gao has abandoned this change.
Change subject: Make scratchpad/after_vm_destroy.py compliant to pep8
..
Patch Set 2: Abandoned
Move into one branch.
--
To view, visit http://gerrit.ovirt.org/4577
To unsubscribe, visit
Wenyi Gao has abandoned this change.
Change subject: Make before_vm_migrate_source.py compliant to pep8
..
Patch Set 2: Abandoned
Move to one branch
--
To view, visit http://gerrit.ovirt.org/4579
To unsubscribe, visit http
Wenyi Gao has uploaded a new change for review.
Change subject: Make vhostmd/before_vm_start.py compliant to pep8
..
Make vhostmd/before_vm_start.py compliant to pep8
Change-Id: I074ec4db63f8f743d43ece0d1fed33ab42239434
Signed
Wenyi Gao has uploaded a new change for review.
Change subject: Make scratchpad/after_vm_destroy.py compliant to pep8
..
Make scratchpad/after_vm_destroy.py compliant to pep8
Change-Id: I1c7830b0a4ad6aec6be19fe90e824928db4954b5
Wenyi Gao has uploaded a new change for review.
Change subject: Make before_vm_migrate_source.py compliant to pep8
..
Make before_vm_migrate_source.py compliant to pep8
Change-Id: I9e2a63fa08f061b6a79a3f28aa15e6cb6ca5431b
Wenyi Gao has uploaded a new change for review.
Change subject: Make vhostmd/after_vm_destroy.py compliant to pep8
..
Make vhostmd/after_vm_destroy.py compliant to pep8
Change-Id: I7467456f156c04ac81bfebdbea1d9706c6cbee8f
Wenyi Gao has uploaded a new change for review.
Change subject: Make scratchpad/before_vm_start.py compliant to pep8
..
Make scratchpad/before_vm_start.py compliant to pep8
Change-Id: If9256b4fe34e82968b8d8bc97540099c54b9d239
Wenyi Gao has posted comments on this change.
Change subject: Make scratchpad/after_vm_destroy.py compliant to pep8
..
Patch Set 2: Verified
Built and installed, works normally.
--
To view, visit http://gerrit.ovirt.org/4577
Wenyi Gao has posted comments on this change.
Change subject: Make scratchpad/before_vm_start.py compliant to pep8
..
Patch Set 2: Verified
Built and installed, works normally.
--
To view, visit http://gerrit.ovirt.org/4578
Wenyi Gao has posted comments on this change.
Change subject: Make before_vm_migrate_source.py compliant to pep8
..
Patch Set 2: Verified
Built and installed, works normally.
--
To view, visit http://gerrit.ovirt.org/4579
To
Wenyi Gao has posted comments on this change.
Change subject: Make vhostmd/before_vm_start.py compliant to pep8
..
Patch Set 2: Verified
Built and installed, works normal.
--
To view, visit http://gerrit.ovirt.org/4581
To
Wenyi Gao has posted comments on this change.
Change subject: Make vhostmd/after_vm_destroy.py compliant to pep8
..
Patch Set 2: (2 inline comments)
Thanks Saggi for reviewing the patches. Please see my inline comments
Wenyi Gao has uploaded a new change for review.
Change subject: Move validate_libvirt_certs to vdsm-tool
..
Move validate_libvirt_certs to vdsm-tool
Move validate_libvirt_certs in vdsdm.init to vdsm-tool
Change-Id
Wenyi Gao has abandoned this change.
Change subject: Add some base functions to vdsm-tool
..
Patch Set 10: Abandoned
Replace it with another patch
--
To view, visit http://gerrit.ovirt.org/5264
To unsubscribe, visit http
Wenyi Gao has abandoned this change.
Change subject: Remove the effect of other parameters on configure_sysctl in
vdsmd.init
..
Patch Set 3: Abandoned
replaced with another patch
--
To view, visit http://gerrit.ovirt.org
Wenyi Gao has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 6: (1 inline comment)
File vdsm_tool/passwd.py
Wenyi Gao has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 6: (1 inline comment)
File vdsm_tool/passwd.py
Wenyi Gao has posted comments on this change.
Change subject: Replace configure_sysctl with /etc/sysctl.d/vdsm
..
Patch Set 4: Verified
Verified on my workstation Fedora17. Behaved as expected.
--
To view, visit http
Wenyi Gao has posted comments on this change.
Change subject: Replace configure_sysctl with /etc/sysctl.d/vdsm.conf
..
Patch Set 3: (1 inline comment)
File vdsm.spec.in
Line
Wenyi Gao has posted comments on this change.
Change subject: Replace configure_sysctl with /etc/sysctl.d/vdsm.conf
..
Patch Set 2: (2 inline comments)
File vdsm
Wenyi Gao has posted comments on this change.
Change subject: Add some base functions to vdsm-tool
..
Patch Set 8: (1 inline comment)
File vdsm-tool/base.py
Line 67
Wenyi Gao has posted comments on this change.
Change subject: Add some base functions to vdsm-tool
..
Patch Set 8: (2 inline comments)
File vdsm-tool/base.py
Line 47: def
Wenyi Gao has uploaded a new change for review.
Change subject: Replace configure_sysctl with /etc/sysctl.d/vdsm.conf
..
Replace configure_sysctl with /etc/sysctl.d/vdsm.conf
To be simple, replace configure_sysctl in vdsmd.init
Wenyi Gao has posted comments on this change.
Change subject: Add some base functions to vdsm-tool
..
Patch Set 7: (2 inline comments)
File vdsm-tool/base.py
Line 47: def
Wenyi Gao has posted comments on this change.
Change subject: Remove the effect of other parameters on configure_sysctl in
vdsmd.init
..
Patch Set 3:
Yes, it seems to make much sense. I will work on it. Thanks.
--
To view
Wenyi Gao has posted comments on this change.
Change subject: Add some base functions to vdsm-tool
..
Patch Set 7: (4 inline comments)
File vdsm-tool/base.py
Line 47: def
Wenyi Gao has posted comments on this change.
Change subject: Add some base functions to vdsm-tool
..
Patch Set 6: (1 inline comment)
File vdsm-tool/base.py
Line 52
Wenyi Gao has posted comments on this change.
Change subject: Add some base functions to vdsm-tool
..
Patch Set 6: (2 inline comments)
This is the base patch for my sequent patches for moving vdsmd.init script to
vdsm-tool
Wenyi Gao has posted comments on this change.
Change subject: Move vdsmd.init to vdsm-tool
..
Patch Set 4: (9 inline comments)
Dan, thanks for your suggestion. I will divide it into some small patches
Wenyi Gao has posted comments on this change.
Change subject: Add some base functions to vdsm-tool
..
Patch Set 5: (2 inline comments)
File vdsm-tool/base.py
Line 72: def
Wenyi Gao has posted comments on this change.
Change subject: Add some base functions to vdsm-tool
..
Patch Set 3: (1 inline comment)
File vdsm-tool/base.py
Line 64
Wenyi Gao has posted comments on this change.
Change subject: Add some base functions to vdsm-tool
..
Patch Set 3: (2 inline comments)
File vdsm-tool/base.py
Line 43: def
Wenyi Gao has posted comments on this change.
Change subject: Raise a proper error message in vdsClient.py if no permission
to read key files
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/5156
To
Wenyi Gao has posted comments on this change.
Change subject: Add some base functions to vdsm-tool
..
Patch Set 2: (3 inline comments)
File vdsm-tool/base.py
Line 40
Wenyi Gao has posted comments on this change.
Change subject: Avoid racing condition of vmContainer's lenth
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/52
Wenyi Gao has posted comments on this change.
Change subject: Raise a proper error message in vdsClient.py if no permission
to read key files
..
Patch Set 2: (1 inline comment
Wenyi Gao has uploaded a new change for review.
Change subject: Add some base functions to vdsm-tool
..
Add some base functions to vdsm-tool
Add some base functions to vdsm-tool in order that these functions
can be avalilale
Wenyi Gao has posted comments on this change.
Change subject: vdsm-tool: look for .pyc modules, too.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5172
To unsubscribe
Wenyi Gao has posted comments on this change.
Change subject: Move vdsmd.init to vdsm-tool
..
Patch Set 4: (17 inline comments)
Response for partial comments.
File vdsm
Wenyi Gao has posted comments on this change.
Change subject: Check permission to read key files when ssl is enabled
..
Patch Set 1: Verified
Tested on my workstation fedora16
--
To view, visit http://gerrit.ovirt.org/5156
To
Wenyi Gao has uploaded a new change for review.
Change subject: Check permission to read key files when ssl is enabled
..
Check permission to read key files when ssl is enabled
Currently, there is no permission check to read
Wenyi Gao has posted comments on this change.
Change subject: Move vdsmd.init to vdsm-tool
..
Patch Set 4: (1 inline comment)
Thank you Adam and Ewoud for your very helpful suggestions
Wenyi Gao has posted comments on this change.
Change subject: Close and remove the temporary file before raising a exception
..
Patch Set 2: Verified
I built and installed the rpm packate then ran on Fedora16. No abnormal
Wenyi Gao has posted comments on this change.
Change subject: Make safer to get vdsm section version in configuration files
..
Patch Set 1: No score
Hi Douglas, thanks for your comments. Currently, the version number is 4.9.6
Wenyi Gao has posted comments on this change.
Change subject: Add passwd command to vdsm-tool
..
Patch Set 7: (1 inline comment)
File vdsm-tool/passwd.py
Line 48
Wenyi Gao has posted comments on this change.
Change subject: PEP8 fixes for localFsSD
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3938
To unsubscribe, visit http
Wenyi Gao has posted comments on this change.
Change subject: Make safer to get vdsm section version in configuration files
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5051
To unsubscribe, visit http
Wenyi Gao has uploaded a new change for review.
Change subject: Make safer to get vdsm section version in configuration files
..
Make safer to get vdsm section version in configuration files
For "configure_libvirt" f
Wenyi Gao has posted comments on this change.
Change subject: Remove the effect of other parameters on configure_sysctl in
vdsmd.init
..
Patch Set 3: No score
Thanks for Dan's and Mark's comments.
Yes, the "
Wenyi Gao has posted comments on this change.
Change subject: [WIP] Move vdsmd.init to vdsm-tool
..
Patch Set 2: (1 inline comment)
File vdsm-tool/vdsmd.py
Line 196
Wenyi Gao has posted comments on this change.
Change subject: Remove the effect of other parameters on configure_sysctl in
vdsmd.init
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/4865
To unsubscribe
Wenyi Gao has posted comments on this change.
Change subject: Close and remove the temporary file before raising a exception
..
Patch Set 1: (2 inline comments)
File vdsm
Wenyi Gao has posted comments on this change.
Change subject: Remove the effect of other parameters on configure_sysctl
..
Patch Set 2: (2 inline comments)
Commit Message
Wenyi Gao has posted comments on this change.
Change subject: Remove the effect of other parameters on configure_sysctl
..
Patch Set 2:
Just be for clear for previous comments
When vdsm first set sysctl.conf, it will run
Wenyi Gao has posted comments on this change.
Change subject: Remove the effect of other parameters on configure_sysctl
..
Patch Set 2:
When vdsm first set sysctl.conf, it will run 'sysctl -q -p /etc/sysctl.conf',
Wenyi Gao has posted comments on this change.
Change subject: Remove the effect of other parameters on configure_sysctl
..
Patch Set 1: (1 inline comment)
Thanks Ming's sugge
Wenyi Gao has uploaded a new change for review.
Change subject: Close and remove the temporary file before raising a exception
..
Close and remove the temporary file before raising a exception
Change-Id
Wenyi Gao has abandoned this change.
Change subject: Add some external program path
..
Patch Set 1: Abandoned
Merged into another patch: move vdsmd.init to vdsm-tool
--
To view, visit http://gerrit.ovirt.org/4737
To
Wenyi Gao has posted comments on this change.
Change subject: Fix multiple commands with same name in different vdsm-tool
modules
..
Patch Set 5: Verified
I tested and it works okey.
--
To view, visit http://gerrit.ovirt.org
Wenyi Gao has uploaded a new change for review.
Change subject: Remove the effect of other parameters on configure_sysctl
..
Remove the effect of other parameters on configure_sysctl
The function 'configure_sysct
Wenyi Gao has posted comments on this change.
Change subject: remove '/var/log/core' from fedora
..
Patch Set 3: (2 inline comments)
Just add some in line comments
...
Wenyi Gao has posted comments on this change.
Change subject: [WIP] Move vdsmd.init to vdsm-tool
..
Patch Set 1:
Thank you Adam very much for your helpful suggestion and some useful example
code. I will follow your
Wenyi Gao has posted comments on this change.
Change subject: Encapsulate vdsm-unregister into vdsm-tool function
..
Patch Set 1: (1 inline comment)
File vdsm-tool
Wenyi Gao has posted comments on this change.
Change subject: Fix multiple commands with same name in different vdsm-tool
modules
..
Patch Set 1: (2 inline comments)
File
Wenyi Gao has posted comments on this change.
Change subject: Make scratchpad/before_vm_start.py compliant to pep8
..
Patch Set 1: (1 inline comment)
File vdsm_hooks
Wenyi Gao has posted comments on this change.
Change subject: Make scratchpad/after_vm_destroy.py compliant to pep8
..
Patch Set 1: (1 inline comment)
File Makefile.am
Line
Wenyi Gao has uploaded a new change for review.
Change subject: [WIP] Move vdsmd.init to vdsm-tool
..
[WIP] Move vdsmd.init to vdsm-tool
The vdsmd.init script is a bit complex, so recode some functions
with python and move it
Wenyi Gao has uploaded a new change for review.
Change subject: Add some external program path
..
Add some external program path
Change-Id: I154a96417a1d27b1d4f0ad2905771fa6d820e7b5
Signed-off-by: Wenyi Gao
---
M configure.ac
Wenyi Gao has abandoned this change.
Change subject: Add some external program path
..
Patch Set 1: Abandoned
resubmit it later
--
To view, visit http://gerrit.ovirt.org/4722
To unsubscribe, visit http://gerrit.ovirt.org
Wenyi Gao has abandoned this change.
Change subject: Move vdsmd.init to vdsm-tool
..
Patch Set 1: Abandoned
resubmit it later
--
To view, visit http://gerrit.ovirt.org/4723
To unsubscribe, visit http://gerrit.ovirt.org
1 - 100 of 126 matches
Mail list logo