Change in vdsm[master]: Integrate Smartcard support

2013-01-01 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Integrate Smartcard support .. Integrate Smartcard support This patch is a VDSM part of the integrating the smartcard support to the ovirt: This VDSM

Change in vdsm[master]: Integrate Smartcard support

2013-01-01 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 22: Looks good to me, approved copying score, seems like a plain rebase. -- To view, visit http://gerrit.ovirt.org/845

Change in vdsm[master]: Integrate Smartcard support

2013-01-01 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 22: Verified Rebased, verified: was able to start a vm with smart-card device, used engine that supports it as well, cou

Change in vdsm[master]: Integrate Smartcard support

2013-01-01 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 22: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/507/ : SUCCESS http://jenkins.ovirt.org/

Change in vdsm[master]: Integrate Smartcard support

2013-01-01 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 22: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/507/ (1/2) -- To view, visit http://gerrit.ov

Change in vdsm[master]: Integrate Smartcard support

2013-01-01 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 22: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/542/ (2/2) -- To view, visit ht

Change in vdsm[master]: Integrate Smartcard support

2012-12-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 21: Looks good to me, approved Waiting for verification. -- To view, visit http://gerrit.ovirt.org/8450 To unsubscribe

Change in vdsm[master]: Integrate Smartcard support

2012-12-20 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 21: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8450 To unsubscribe, vi

Change in vdsm[master]: Integrate Smartcard support

2012-12-19 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 21: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8450 To unsubscribe, vi

Change in vdsm[master]: Integrate Smartcard support

2012-12-19 Thread agl
Adam Litke has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 21: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8450 To unsubscribe, visit ht

Change in vdsm[master]: Integrate Smartcard support

2012-12-19 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 21: thank you Toni -- To view, visit http://gerrit.ovirt.org/8450 To unsubscribe, visit http://gerrit.ovirt.org/setting

Change in vdsm[master]: Integrate Smartcard support

2012-12-19 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 21: Looks good to me, but someone else must approve I only fixed the version number in the schema since Tomas d

Change in vdsm[master]: Integrate Smartcard support

2012-12-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/451/ : SUCCESS http://jenkins.ovirt.org/

Change in vdsm[master]: Integrate Smartcard support

2012-12-19 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 20: (1 inline comment) File vdsm_api/vdsmapi-schema.json L

Change in vdsm[master]: Integrate Smartcard support

2012-12-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 21: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/451/ (1/2) -- To view, visit http://gerrit.ov

Change in vdsm[master]: Integrate Smartcard support

2012-12-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 21: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/486/ (2/2) -- To view, visit ht

Change in vdsm[master]: Integrate Smartcard support

2012-12-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 20: (1 inline comment) File vdsm_api/vdsmapi-schema.json Line 2359

Change in vdsm[master]: Integrate Smartcard support

2012-12-19 Thread agl
Adam Litke has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 20: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8450 To unsubscribe, visit ht

Change in vdsm[master]: Integrate Smartcard support

2012-12-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 20: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/450/ : SUCCESS http://jenkins.ovirt.org/

Change in vdsm[master]: Integrate Smartcard support

2012-12-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 20: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/450/ (1/2) -- To view, visit http://gerrit.ov

Change in vdsm[master]: Integrate Smartcard support

2012-12-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 20: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/485/ (2/2) -- To view, visit ht

Change in vdsm[master]: Integrate Smartcard support

2012-12-18 Thread agl
Adam Litke has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 19: I would prefer that you didn't submit this (2 inline comments) Fi

Change in vdsm[master]: Integrate Smartcard support

2012-12-18 Thread peet
Peter V. Saveliev has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 17: (2 inline comments) File vdsm_api/vdsmapi-schema.json Line

Change in vdsm[master]: Integrate Smartcard support

2012-12-18 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 19: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/415/ : SUCCESS http://jenkins.ovirt.org/

Change in vdsm[master]: Integrate Smartcard support

2012-12-18 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 19: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/450/ (2/2) -- To view, visit ht

Change in vdsm[master]: Integrate Smartcard support

2012-12-18 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 19: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/415/ (1/2) -- To view, visit http://gerrit.ov

Change in vdsm[master]: Integrate Smartcard support

2012-12-18 Thread peet
Peter V. Saveliev has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 18: the patchset has nothing to do with testNice(), that is failed while Jenkins test-cycle -- To view, visit http

Change in vdsm[master]: Integrate Smartcard support

2012-12-18 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 18: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/406/ : SUCCESS http://jenkins.ovirt.or

Change in vdsm[master]: Integrate Smartcard support

2012-12-18 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 18: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/406/ (1/2) -- To view, visit http://gerrit.ov

Change in vdsm[master]: Integrate Smartcard support

2012-12-18 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 18: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/441/ (2/2) -- To view, visit ht

Change in vdsm[master]: Integrate Smartcard support

2012-12-18 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 17: (1 inline comment) File vdsm/libvirtvm.py Line 2654:

Change in vdsm[master]: Integrate Smartcard support

2012-12-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 17: I would prefer that you didn't submit this (4 inline comments) ...

Change in vdsm[master]: Integrate Smartcard support

2012-12-17 Thread peet
Peter V. Saveliev has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 17: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8450 To unsubscribe, v

Change in vdsm[master]: Integrate Smartcard support

2012-12-11 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 17: Looks good to me, but someone else must approve (3 inline comments)

Change in vdsm[master]: Integrate Smartcard support

2012-12-11 Thread ilvovsky
Igor Lvovsky has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 17: I would prefer that you didn't submit this (4 inline comments) Maybe I am missing something but it looks to me as ve

Change in vdsm[master]: Integrate Smartcard support

2012-12-11 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 17: Looks good to me, but someone else must approve (1 inline comment) .

Change in vdsm[master]: Integrate Smartcard support

2012-12-07 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 17: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/250/ : SUCCESS http://jenkins.ovirt.org/

Change in vdsm[master]: Integrate Smartcard support

2012-12-07 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 17: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/284/ (2/2) -- To view, visit ht

Change in vdsm[master]: Integrate Smartcard support

2012-12-07 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 17: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/250/ (1/2) -- To view, visit http://gerrit.ov

Change in vdsm[master]: Integrate Smartcard support

2012-12-07 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 16: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/

Change in vdsm[master]: Integrate Smartcard support

2012-12-07 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 16: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/283/ (1/2) -- To view, visit ht

Change in vdsm[master]: Integrate Smartcard support

2012-12-07 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 16: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/249/ (2/2) -- To view, visit http://gerrit.ov

Change in vdsm[master]: Integrate Smartcard support

2012-12-07 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 15: (4 inline comments) Just a couple of pep8 things. Now I will review the rest.

Change in vdsm[master]: Integrate Smartcard support

2012-11-23 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 7: well... I'm not sure if we still have time to rewrite it - changing the api would mean to adjust also the engine and

Change in vdsm[master]: Integrate Smartcard support

2012-11-22 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 7: I would prefer that you didn't submit this I'm sorry to spoil the party, but I'm not extremely happy about the propo

Change in vdsm[master]: Integrate Smartcard support

2012-11-22 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 7: Verified it has been already verified by Antoni so I just put back the +1 which got lost after the rebase. -- To vi

Change in vdsm[master]: Integrate Smartcard support

2012-11-22 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 7: Looks good to me, but someone else must approve I agree with this rebase and the addition of the parameter t

Change in vdsm[master]: Integrate Smartcard support

2012-11-22 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/110/ : SUCCESS http://jenkins.ovirt.org/j

Change in vdsm[master]: Integrate Smartcard support

2012-11-22 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 7: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/110/ (1/2) -- To view, visit http://gerrit.ovi

Change in vdsm[master]: Integrate Smartcard support

2012-11-22 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Integrate Smartcard support .. Patch Set 7: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/144/ (2/2) -- To view, visit htt