Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 16:
> Also tested it on ppc and it is definitely somewhat better than
> before, consider that
gerrit-hooks has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 16:
* #1264003::Update tracker: OK
* Set MODIFIED::bug 1264003#1264003OK
--
To view,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: host stats: Collect stats from online cpu cores only
..
host stats: Collect stats from online cpu cores only
When a cpu goes offline while libvirtd is
Milan Zamazal has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 15: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46269
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 15: Code-Review+2
(3 comments)
good enough, raising score. There are a couple of places
Francesco Romani has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 15: Code-Review+1
quick review: looks good. Need to spend more time, especially on tests.
Martin Polednik has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 15: Code-Review+1
Also tested it on ppc and it is definitely somewhat better than before,
gerrit-hooks has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 15:
* #1264003::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1264003::OK, public
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/13/vdsm/virt/sampling.py
File
Nir Soffer has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 14: Code-Review+1
Look good to me, but we need more reviews from the virt team and approval from
Nir Soffer has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/13/vdsm/virt/sampling.py
File
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 13:
(7 comments)
https://gerrit.ovirt.org/#/c/46269/13/tests/hoststatsTests.py
File
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 14: Verified+1
Verified by:
1) vdsClient -s 0 getVdsStats shows all cpu cores
2) disable cpu
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/13/vdsm/virt/hoststats.py
File
gerrit-hooks has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 14:
* #1264003::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1264003::OK, public
Nir Soffer has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 13: Code-Review-1
(7 comments)
https://gerrit.ovirt.org/#/c/46269/13/tests/hoststatsTests.py
Roy Golan has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 13: Code-Review+1
Later we would need to adapt engine scheduling to consider online cpus - And
Arik Hadas has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 13:
Roy, Martin - seems like SLA stuff, please review
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 13:
I would like to get an ack from the engine side, that this is both safe for old
engines, and
gerrit-hooks has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 13:
* #1264003::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1264003::OK, public
Francesco Romani has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 13: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46269
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 12:
Ping
--
To view, visit https://gerrit.ovirt.org/46269
To unsubscribe, visit
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 12: Verified+1
Verified by:
1) vdsClient -s 0 getVdsStats shows all cpu cores
2) disable cpu
automat...@ovirt.org has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 11:
* #1264003::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 9:
(6 comments)
https://gerrit.ovirt.org/#/c/46269/9/tests/hoststatsTests.py
File
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/9/tests/hoststatsTests.py
File
Francesco Romani has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 12: Code-Review+1
thanks for the updates! At first glance looks fine now, will have another
automat...@ovirt.org has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 12:
* #1264003::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Francesco Romani has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 9: Code-Review-1
(1 comment)
unfortunately has to be -1. I'm actually fine with all of
automat...@ovirt.org has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 10:
* #1264003::Update tracker: OK
* Check Bug-Url::OK
* Check Public
automat...@ovirt.org has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 9:
* #1264003::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1264003::OK,
Nir Soffer has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 9: Code-Review-1
(6 comments)
https://gerrit.ovirt.org/#/c/46269/9/tests/hoststatsTests.py
File
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 9: Verified+1
Verified by:
1) vdsClient -s 0 getVdsStats shows all cpu cores
2) disable cpu core
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 8:
ping
--
To view, visit https://gerrit.ovirt.org/46269
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 8:
* Update tracker::#1264003::OK
* Check Bug-Url::OK
* Check Public Bug::#1264003::OK,
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/7//COMMIT_MSG
Commit Message:
Line 57:
Nir Soffer has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/7//COMMIT_MSG
Commit Message:
Line 57:
Francesco Romani has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 7: Code-Review+1
(1 comment)
preliminary ACK, seems OK
automat...@ovirt.org has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/46269/6//COMMIT_MSG
Commit Message:
Line 26:
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/6//COMMIT_MSG
Commit Message:
Line 26:
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/6/vdsm/virt/sampling.py
File
Francesco Romani has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 6:
(3 comments)
https://gerrit.ovirt.org/#/c/46269/6//COMMIT_MSG
Commit Message:
Line 26:
Nir Soffer has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/46269/6//COMMIT_MSG
Commit Message:
Line 26:
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/6//COMMIT_MSG
Commit Message:
Line 26:
Francesco Romani has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/6//COMMIT_MSG
Commit Message:
Line 26:
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/6/vdsm/virt/sampling.py
File
Francesco Romani has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/6/vdsm/virt/sampling.py
File
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/46269
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/6/vdsm/virt/sampling.py
File
Francesco Romani has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/4/vdsm/virt/sampling.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 4:
(5 comments)
https://gerrit.ovirt.org/#/c/46269/4//COMMIT_MSG
Commit Message:
Line 12: When
Francesco Romani has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 6:
(3 comments)
https://gerrit.ovirt.org/#/c/46269/6//COMMIT_MSG
Commit Message:
Line 29:
automat...@ovirt.org has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 5:
* Update tracker::#1264003::OK
* Check Bug-Url::OK
* Check Public Bug::#1264003::OK,
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/46269/4//COMMIT_MSG
Commit Message:
Line 12: When
automat...@ovirt.org has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Francesco Romani has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 3: Code-Review+1
makes sense. Please check also that the schema allows us to skip this
Francesco Romani has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 3:
please add one unit test or one functional test
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/46269
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 3:
* Update tracker::#1264003::OK
* Check Bug-Url::OK
* Check Public Bug::#1264003::OK,
Nir Soffer has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/4//COMMIT_MSG
Commit Message:
Line 12: When
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 4:
> please add one unit test or one functional test
Done
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/4/vdsm/virt/sampling.py
File
Francesco Romani has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 4: Code-Review-1
(2 comments)
let's try to simplify the tests. Codewise looks good.
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/4/vdsm/virt/sampling.py
File
Nir Soffer has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/4/vdsm/virt/sampling.py
File
Roman Mohr has uploaded a new change for review.
Change subject: host stats: Collect stats from online cpu cores only
..
host stats: Collect stats from online cpu cores only
When a cpu goes offline while vdsm is running, the
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/46269
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 4:
> makes sense. Please check also that the schema allows us to skip
> this field (it should)
72 matches
Mail list logo
