Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-18 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-18 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: lib: utils: consolidate Error class in one place .. lib: utils: consolidate Error class in one place Few utilities code have a duplicate Error exception, t

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-18 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 7: Waiting for Dan -- To view, visit https://gerrit.ovirt.org/47964 To unsubscribe, visit https://ge

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-18 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-17 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/47964 To unsubscribe, visit https://gerri

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-16 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/47964 To unsubscribe, visit https:/

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-16 Thread fromani
Francesco Romani has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 6: Verified+1 trivial patches that moves code and fixes import. Did basic sanity check setting

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-16 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/47964 To unsubscribe, visit https://gerri

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-16 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/47964/5/lib/vdsm/cmdutils.py File lib/vdsm/cmdutils.py:

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-16 Thread fromani
Francesco Romani has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/47964/5/lib/vdsm/cmdutils.py File lib/vdsm/cmdutils

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 5: Code-Review-1 (1 comment) One issue that may need little more work, we can also do this in a separ

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/47964 To unsubscribe, visit https://gerri

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/47964/5/lib/vdsm/cmdutils.py File lib/vdsm/cmdutils.py:

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-06 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/47964/5/lib/vdsm/cmdutils.py File lib/vdsm/cmdutils

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/47964/5/lib/vdsm/cmdutils.py File lib/vdsm/cmdutils.py:

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-06 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/47964/5/lib/vdsm/cmdutils.py File lib/vdsm/cmdutils

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-06 Thread fromani
Francesco Romani has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/47964/4//COMMIT_MSG Commit Message: Line 10: they

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-06 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-05 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/47964/4//COMMIT_MSG Commit Message: Line 10: they raise

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-05 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/47964 To unsubscribe, visit https://ge

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-05 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-05 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 3: Fine for me now except the "alogside" typo in the commit message. -- To view, visit https://ge

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-05 Thread fromani
Francesco Romani has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/47964/1/lib/vdsm/udevadm.py File lib/vdsm/udevadm.p

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-05 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/47964/1/lib/vdsm/udevadm.py File lib/vdsm/udevadm.py: Li

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-04 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/47964/1//COMMIT_MSG Commit Message: Line 10: they ra

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 1: (6 comments) https://gerrit.ovirt.org/#/c/47964/1/lib/vdsm/taskset.py File lib/vdsm/taskset.

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-04 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-03 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 1: (5 comments) https://gerrit.ovirt.org/#/c/47964/1/lib/vdsm/taskset.py File lib/vdsm/taskset.py: L

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-03 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/47964 To unsubscribe, visit https:/

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-03 Thread fromani
Francesco Romani has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/47964/1/lib/vdsm/taskset.py File lib/vdsm/taskset.p

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-02 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 1: Code-Review+1 (2 comments) A little concern regarding importing Error directly to module's na

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-02 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: lib: utils: consolidate Error class in one place .. lib: utils: consolidate Error class in one place Few utilities code have a duplicate Error exception, tha

Change in vdsm[master]: lib: utils: consolidate Error class in one place

2015-11-02 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: lib: utils: consolidate Error class in one place .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make