automat...@ovirt.org has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 25:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ssl: runtime config to choose implementation
..
ssl: runtime config to choose implementation
During build process we provide which ssl implementation i
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 24:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/24/vdsm.spec.in
File vdsm.spec.in:
Line 614: se
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 24: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/44689/24/vdsm.spec.in
File vdsm.spec.in:
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 24: Code-Review+1
Acked it - but still consider to use different format than @something@ which is
use
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 24: Verified+1
Fixing token to use only capital letters. No code changes. Verified by running
the b
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 24:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/23/debian/rules
File debian/rules:
Line 32:
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/23/debian/rules
File debian/rules:
Line 32:
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/23/debian/rules
File debian/rules:
Line 32:
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 23: Code-Review-1
(1 comment)
please fix the constant name
https://gerrit.ovirt.org/#/c/44689/23/deb
Yeela Kaplan has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 23:
(1 comment)
One minor comment, other than that looks ok...
https://gerrit.ovirt.org/#/c/44689/23/d
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 22: Verified+1
Fixed log issue.
--
To view, visit https://gerrit.ovirt.org/44689
To unsubscribe, v
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 23: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44689
To unsubscribe, visit https://gerr
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 23:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 22:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 21: Code-Review+1
you could say somewhere that default value that will be install in fedora is
m2c an
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 21:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 20:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 19: Verified+1
Patch updated with removing build time configuration. No code changes. Verified
duri
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 19:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 18:
(5 comments)
https://gerrit.ovirt.org/#/c/44689/18//COMMIT_MSG
Commit Message:
Line 9: During
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 18: Code-Review-1
(5 comments)
https://gerrit.ovirt.org/#/c/44689/18//COMMIT_MSG
Commit Message:
Lin
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 18:
(1 comment)
Yaniv's comments fixed. Dan supports this approach.
https://gerrit.ovirt.org/#/c/4
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 18: Verified+1
Verified by build vdsm with --enable-m2c and with --disable-m2c to set default
imple
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 18:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 17: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/44689
To unsubscribe, visit https://gerr
Francesco Romani has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 17: Code-Review+1
I'm not infra/build expert, but from my perspective looks OK.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 17: Verified+1
Fixed space but still we remove m2c as required. No other code changes.
--
To view,
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 17:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 16:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/16/vdsm.spec.in
File vdsm.spec.in:
Line 628: sed
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 16:
(2 comments)
https://gerrit.ovirt.org/#/c/44689/16/debian/rules
File debian/rules:
Line 33:
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 16:
(3 comments)
https://gerrit.ovirt.org/#/c/44689/16/debian/rules
File debian/rules:
Line 33:
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 16:
(3 comments)
https://gerrit.ovirt.org/#/c/44689/16/debian/rules
File debian/rules:
Line 33:
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 16: Code-Review-1
(4 comments)
https://gerrit.ovirt.org/#/c/44689/16/debian/control
File debian/contr
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 16:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/16/lib/vdsm/config.py.in
File lib/vdsm/config.py
Ondřej Svoboda has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 16: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/44689/16/lib/vdsm/config.py.in
File lib/vd
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 16: Verified+1
Added debian related changes so we can set config.py value for ssl standard
module.
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 16:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 15:
(4 comments)
https://gerrit.ovirt.org/#/c/44689/15/configure.ac
File configure.ac:
Line 161:
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 15: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/44689/15/configure.ac
File configure.ac:
Nir Soffer has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/15/configure.ac
File configure.ac:
Line 161:
Ondřej Svoboda has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 15: Code-Review-1
(1 comment)
Description of vars.ssl_implementation lacks spaces.
https://gerrit.ov
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 15:
(2 comments)
do you verify it over debian?
https://gerrit.ovirt.org/#/c/44689/15/configure.ac
Fi
Yeela Kaplan has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 15:
(3 comments)
https://gerrit.ovirt.org/#/c/44689/15/configure.ac
File configure.ac:
Line 161:
Nir Soffer has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 15:
(2 comments)
https://gerrit.ovirt.org/#/c/44689/15/configure.ac
File configure.ac:
Line 161:
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/15/configure.ac
File configure.ac:
Line 164:
Yeela Kaplan has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/15/configure.ac
File configure.ac:
Line 164: ,
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/15/configure.ac
File configure.ac:
Line 164:
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 15: Verified+1
Verified by building vdsm with m2c enabled and disabled both builds configured
vdsm
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 15:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/14/vdsm.spec.in
File vdsm.spec.in:
Line 628: se
Nir Soffer has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/14/vdsm.spec.in
File vdsm.spec.in:
Line 628: sed -i -
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 14: Verified+1
Moved fixed tests from previous patch. Verified by running build in mock
locally.
-
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 13: Verified+1
Moved sorting order of imports to previous patch as Francesco suggested. No
other co
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/12/lib/vdsm/sslcompat.py
File lib/vdsm/sslcompat
Francesco Romani has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/12/lib/vdsm/sslcompat.py
File lib/vdsm/sslcompat
Francesco Romani has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 12: Code-Review+1
I like this approach more.
--
To view, visit https://gerrit.ovirt.org/44689
To u
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 12:
CI failure is not related to this change
--
To view, visit https://gerrit.ovirt.org/44689
To u
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 12: Verified+1
Verified by building vdsm for both implementation and tested with both
implementatio
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 11: Verified+1
Verified by building vdsm for both implementation and tested with both
implementatio
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/9/lib/vdsm/sslcompat.py
File lib/vdsm/sslcompat.p
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/9/lib/vdsm/sslcompat.py
File lib/vdsm/sslcompat.py:
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/9/lib/vdsm/sslcompat.py
File lib/vdsm/sslcompat.p
Nir Soffer has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/9/lib/vdsm/sslcompat.py
File lib/vdsm/sslcompat.py:
Li
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 9: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/44689/9/lib/vdsm/sslcompat.py
File lib/vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 9:
(5 comments)
https://gerrit.ovirt.org/#/c/44689/9/lib/vdsm/sslcompat.py
File lib/vdsm/sslcompat.
Nir Soffer has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 9: Code-Review-1
(5 comments)
https://gerrit.ovirt.org/#/c/44689/9/lib/vdsm/sslcompat.py
File lib/vdsm/ss
Francesco Romani has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44689
To unsubscribe, visit https://ger
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 9: Verified+1
Verified all combinations of config settings m2c and ssl with and without
m2crypto rp
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 8:
(3 comments)
https://gerrit.ovirt.org/#/c/44689/8/lib/vdsm/config.py.in
File lib/vdsm/config.py.
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 8: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/44689/8/lib/vdsm/config.py.in
File lib/vds
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 8: Verified+1
Verified failed scenario. No issues with communication.
--
To view, visit https://ge
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 8:
Broken scenario tested and I can see that sslcompat works OK.
I am testing hand compiled python
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 7:
Previous tests for ssl where performed when m2crypto was removed and it passed.
--
To view, vis
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 7: Verified-1
(1 comment)
As in the comment I tested different combination of runtime and build set
Sandro Bonazzola has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44689
To unsubscribe, visit https://ger
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/7/lib/vdsm/sslcompat.py
File lib/vdsm/sslcompat.p
Sandro Bonazzola has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/7/lib/vdsm/sslcompat.py
File lib/vdsm/sslcompat.p
Francesco Romani has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/7/lib/vdsm/sslcompat.py
File lib/vdsm/sslcompat.p
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/44689/7/lib/vdsm/sslcompat.py
File lib/vdsm/sslcompat.
Francesco Romani has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 7: Code-Review+1
(2 comments)
good enough for me.
https://gerrit.ovirt.org/#/c/44689/7/lib/vdsm/ss
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 7: Verified+1
Verified by building only with ssl and testing runtime settings with m2c and
ssl. As
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 6:
(5 comments)
https://gerrit.ovirt.org/#/c/44689/6/lib/vdsm/config.py.in
File lib/vdsm/config.py.
Francesco Romani has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 6: Code-Review-1
(5 comments)
-1 for visibility
minor documentation comments, one suggestion
https
Yeela Kaplan has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/6/lib/vdsm/sslcompat.py
File lib/vdsm/sslcompat.py:
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/6/lib/vdsm/sslcompat.py
File lib/vdsm/sslcompat.p
Yeela Kaplan has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/44689/6/lib/vdsm/sslcompat.py
File lib/vdsm/s
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 6: Verified+1
Updated description in config.py, no code changes. Copying verification flag
from pre
automat...@ovirt.org has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/5/lib/vdsm/config.py.in
File lib/vdsm/config.py.i
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 5: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/44689/5/lib/vdsm/config.py.in
File lib/vdsm
1 - 100 of 118 matches
Mail list logo
