Change in vdsm[master]: lib: daemon: autodetect online cpus for affinity

Milan Zamazal has posted comments on this change. Change subject: lib: daemon: autodetect online cpus for affinity .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/49402/4//COMMIT_MSG Commit Message: Line 34: l ...

Change in vdsm[master]: guestagent: Log guest agent life cycle events

Milan Zamazal has posted comments on this change. Change subject: guestagent: Log guest agent life cycle events .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49341 To unsubscribe, visit

Change in vdsm[master]: guestagent: Rename connect() to start()

Milan Zamazal has posted comments on this change. Change subject: guestagent: Rename connect() to start() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49342 To unsubscribe, visit

Change in vdsm[master]: guestagent: Add missing log on disconnect

Milan Zamazal has posted comments on this change. Change subject: guestagent: Add missing log on disconnect .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49343 To unsubscribe, visit

Change in vdsm[master]: guestagent: Use %r for logging message

Milan Zamazal has posted comments on this change. Change subject: guestagent: Use %r for logging message .. Patch Set 1: Code-Review+1 Of course, this is going to escape all such characters in the message, but I assume it's a

Change in vdsm[master]: guestagent: Send complete messages

Milan Zamazal has posted comments on this change. Change subject: guestagent: Send complete messages .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49339 To unsubscribe, visit

Change in vdsm[master]: guestagent: Remove unneeded encoding

Milan Zamazal has posted comments on this change. Change subject: guestagent: Remove unneeded encoding .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49338 To unsubscribe, visit

Change in vdsm[master]: lib: daemon: autodetect online cpus for affinity

Milan Zamazal has posted comments on this change. Change subject: lib: daemon: autodetect online cpus for affinity .. Patch Set 2: Code-Review-1 (8 comments) Basically fine, just please polish it a bit (especially

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

Milan Zamazal has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 13: Code-Review+1 (4 comments) Please fix the typos, otherwise fine for me.

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

Milan Zamazal has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 12: (2 comments) https://gerrit.ovirt.org/#/c/48672/12/vdsm/v2v.py File vdsm/v2v.py: Line 647: if

Change in vdsm[master]: virt: enhance migration.SourceThread.stop()

Milan Zamazal has posted comments on this change. Change subject: virt: enhance migration.SourceThread.stop() .. Patch Set 13: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40520 To unsubscribe, visit

Change in vdsm[master]: startup: Change system default encoding to utf8

Milan Zamazal has posted comments on this change. Change subject: startup: Change system default encoding to utf8 .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48661 To unsubscribe, visit

Change in vdsm[master]: virt: introduce "Async" helper

Milan Zamazal has posted comments on this change. Change subject: virt: introduce "Async" helper .. Patch Set 2: Martin, I think we can go with Async if we can simplify it. E.g. how about something like the following in do():

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

Milan Zamazal has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole .. Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/48404/8/tests/vmTests.py File tests/vmTests.py: Line

Change in vdsm[master]: virt: vm: Update time on VM after migration

Milan Zamazal has uploaded a new change for review. Change subject: virt: vm: Update time on VM after migration .. virt: vm: Update time on VM after migration When a VM is resumed from suspension and/or migrated, its clock

Change in vdsm[master]: virt: enhance/fix migration.SourceThread.stop()

Milan Zamazal has posted comments on this change. Change subject: virt: enhance/fix migration.SourceThread.stop() .. Patch Set 12: Verified+1 With migration working again in master, I rebased and tried to cancel VM migration

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

Milan Zamazal has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole .. Patch Set 8: Verified+1 I verified by: - Building Engine version ovirt-engine-3.6.0.3 + fbfaf94 (vmconsole

Change in vdsm[master]: virt: vm: Update time on VM after resume

Milan Zamazal has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 4: Verified+1 Verified by: - Suspending a VM (without NTP running) from engine for a while. - Awaking the

Change in vdsm[master]: tests: proper cleanup in periodic tests

Milan Zamazal has posted comments on this change. Change subject: tests: proper cleanup in periodic tests .. Patch Set 5: Code-Review+1 Just for curiosity: Why unreliable test results -- is it due to extra resource

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

Milan Zamazal has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole .. Patch Set 4: (3 comments) Is the test better in patch set 5?

Change in vdsm[master]: logging: Don't crash on non-ASCII in SimpleLogAdapter

Milan Zamazal has posted comments on this change. Change subject: logging: Don't crash on non-ASCII in SimpleLogAdapter .. Patch Set 3: > this issue should be fixed by https://gerrit.ovirt.org/48661 Indeed, I think that patch

Change in vdsm[master]: logging: Don't crash on non-ASCII in SimpleLogAdapter

Milan Zamazal has posted comments on this change. Change subject: logging: Don't crash on non-ASCII in SimpleLogAdapter .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/48542/2/vdsm/logUtils.py File vdsm/logUtils.py:

Change in vdsm[master]: startup: Change system default encoding to utf8

Milan Zamazal has posted comments on this change. Change subject: startup: Change system default encoding to utf8 .. Patch Set 4: Code-Review+1 (3 comments) I made some checks and it seems this patch indeed solves the

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

Milan Zamazal has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole .. Patch Set 4: Verified+1 I verified the patch works by: - Building Engine version ovirt-engine-3.6.0.3 +

Change in vdsm[master]: logging: Don't crash on non-ASCII in SimpleLogAdapter

Milan Zamazal has posted comments on this change. Change subject: logging: Don't crash on non-ASCII in SimpleLogAdapter .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/48542/3/tests/utilsTests.py File

Change in vdsm[ovirt-3.6]: periodic: make VmDispatcher ignore TooManyTasks

Milan Zamazal has posted comments on this change. Change subject: periodic: make VmDispatcher ignore TooManyTasks .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48409 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: vm: add support for "Crashed" event

Milan Zamazal has posted comments on this change. Change subject: vm: add support for "Crashed" event .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48790 To unsubscribe, visit

Change in vdsm[master]: virt: devices: initial support for device updates with etree's

Milan Zamazal has posted comments on this change. Change subject: virt: devices: initial support for device updates with etree's .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/46525/1/vdsm/virt/domain_descriptor.py

Change in vdsm[master]: virt: vm: Update time on VM after resume

Milan Zamazal has uploaded a new change for review. Change subject: virt: vm: Update time on VM after resume .. virt: vm: Update time on VM after resume When a VM is resumed from suspension and/or migrated, its clock continues

Change in vdsm[master]: virt: vm: Update time on VM after resume

Milan Zamazal has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 1: (5 comments) https://gerrit.ovirt.org/#/c/48860/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1200:

Change in vdsm[master]: config: Trivial typo fix in option description

Milan Zamazal has uploaded a new change for review. Change subject: config: Trivial typo fix in option description .. config: Trivial typo fix in option description Change-Id: I527f3f64601d1845e5cca2c73b44d69f957df78f

Change in vdsm[master]: debuging: Use __repr__ instead of __str__

Milan Zamazal has posted comments on this change. Change subject: debuging: Use __repr__ instead of __str__ .. Patch Set 1: Code-Review+1 I'd suggest documenting __str__ vs. __repr__ usage on

Change in vdsm[master]: lib: executor: log pool status on discard

Milan Zamazal has posted comments on this change. Change subject: lib: executor: log pool status on discard .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/48333/5/lib/vdsm/executor.py File lib/vdsm/executor.py:

Change in vdsm[ovirt-3.6]: daemon: ignore cpu affinity on single processor

Milan Zamazal has posted comments on this change. Change subject: daemon: ignore cpu affinity on single processor .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48961 To unsubscribe, visit

Change in vdsm[master]: debuging: Use __repr__ instead of __str__

Milan Zamazal has posted comments on this change. Change subject: debuging: Use __repr__ instead of __str__ .. Patch Set 1: > do you want to update this page now? OK, I'll do it once we are in confirmed agreement on the method

Change in vdsm[master]: gitignore: Missing autogenerated files added

Milan Zamazal has posted comments on this change. Change subject: gitignore: Missing autogenerated files added .. Patch Set 1: Dan, is it OK to merge this trivial change to get rid of it? -- To view, visit

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

Milan Zamazal has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole .. Patch Set 5: (1 comment) Just renamed a one-char variable in tests.

Change in vdsm[master]: virt: vm: Update time on VM after resume

Milan Zamazal has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 2: (1 comment) Jenkins happy after rebase. https://gerrit.ovirt.org/#/c/48860/2/vdsm/virt/vm.py File

Change in vdsm[ovirt-3.6]: vm: reformat _EVENT_STRINGS

Milan Zamazal has posted comments on this change. Change subject: vm: reformat _EVENT_STRINGS .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48789 To unsubscribe, visit

Change in vdsm[master]: virt: vm: Update time on VM after resume

Milan Zamazal has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/48860/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2808:

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

Milan Zamazal has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole .. Patch Set 6: Verified+1 It still works, verified in the same way as in Patch Set 4. -- To view, visit

Change in vdsm[ovirt-3.6]: vmstats: network: avoid ZeroDivisionError

Milan Zamazal has posted comments on this change. Change subject: vmstats: network: avoid ZeroDivisionError .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/48478/1/vdsm/virt/vmstats.py File vdsm/virt/vmstats.py:

Change in vdsm[master]: virt: vm: Update time on VM after resume

Milan Zamazal has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/48860/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1190:

Change in vdsm[master]: virt: vm: Update time on VM after resume

Milan Zamazal has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 4: Additionally virdomain.NotConnectedError handled in this patch set. -- To view, visit

Change in vdsm[master]: lib: executor: log pool status on discard

Milan Zamazal has posted comments on this change. Change subject: lib: executor: log pool status on discard .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48333 To unsubscribe, visit

Change in vdsm[master]: stomp: Drain pending bytes from SSLConnection

Milan Zamazal has posted comments on this change. Change subject: stomp: Drain pending bytes from SSLConnection .. Patch Set 2: Verified+1 I verified that it fixes https://bugzilla.redhat.com/1274670 for me: - I downloaded the

Change in vdsm[master]: vm: use response module in the destroy path

Milan Zamazal has posted comments on this change. Change subject: vm: use response module in the destroy path .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51383 To unsubscribe, visit

Change in vdsm[master]: virt: Don't expose GuestAgent.guestInfo directly

Milan Zamazal has posted comments on this change. Change subject: virt: Don't expose GuestAgent.guestInfo directly .. Patch Set 3: We discussed that with Vinzenz extensively and we decided making a shallow copy instead of a

Change in vdsm[master]: virt: Don't expose GuestAgent.guestInfo directly

Milan Zamazal has posted comments on this change. Change subject: virt: Don't expose GuestAgent.guestInfo directly .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/51508/4/vdsm/virt/guestagent.py File

Change in vdsm[master]: migration: use context manager for semaphore

Milan Zamazal has posted comments on this change. Change subject: migration: use context manager for semaphore .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51655 To unsubscribe, visit

Change in vdsm[master]: vm: safer removal of the recovery file

Milan Zamazal has posted comments on this change. Change subject: vm: safer removal of the recovery file .. Patch Set 3: Code-Review-1 (8 comments) I think the general approach is OK, let's just improve the "technical

Change in vdsm[master]: virt: safer handling of migration parameters

Milan Zamazal has posted comments on this change. Change subject: virt: safer handling of migration parameters .. Patch Set 3: Code-Review+1 (4 comments) Please fix the typos in the commit message and I've got a question for

Change in vdsm[master]: vm: safer handling of conf in restore

Milan Zamazal has posted comments on this change. Change subject: vm: safer handling of conf in restore .. Patch Set 6: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/51657/6//COMMIT_MSG Commit Message: Line 12:

Change in vdsm[master]: virt: Don't create on non-x86 architectures

Milan Zamazal has posted comments on this change. Change subject: virt: Don't create on non-x86 architectures .. Patch Set 3: Verified+1 Verified is still there for x86. Martin's ppc verification should be still valid as

Change in vdsm[master]: vm: safer removal of the recovery file

Milan Zamazal has posted comments on this change. Change subject: vm: safer removal of the recovery file .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/51387/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 827:

Change in vdsm[master]: vm: safer removal of the recovery file

Milan Zamazal has posted comments on this change. Change subject: vm: safer removal of the recovery file .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/51387/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 827:

Change in vdsm[master]: vm: safer removal of the recovery file

Milan Zamazal has posted comments on this change. Change subject: vm: safer removal of the recovery file .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51387 To unsubscribe, visit

Change in vdsm[master]: vm: safer removal of the recovery file

Milan Zamazal has posted comments on this change. Change subject: vm: safer removal of the recovery file .. Patch Set 4: It looks fine for me now. Hopefully there should be not much issues with I/O blocking as we do similar

Change in vdsm[master]: vm: extract cleanupRecoveryFile() helper

Milan Zamazal has posted comments on this change. Change subject: vm: extract cleanupRecoveryFile() helper .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51386 To unsubscribe, visit

Change in vdsm[master]: virt: Don't create on non-x86 architectures

Milan Zamazal has posted comments on this change. Change subject: virt: Don't create on non-x86 architectures .. Patch Set 3: Test duplication resolved + rebase. -- To view, visit https://gerrit.ovirt.org/51648 To

Change in vdsm[master]: virt: Don't create on non-x86 architectures

Milan Zamazal has posted comments on this change. Change subject: virt: Don't create on non-x86 architectures .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/51648/2/tests/vmTests.py File tests/vmTests.py: Line

Change in vdsm[master]: rpc: Log important info from VM stats

Milan Zamazal has posted comments on this change. Change subject: rpc: Log important info from VM stats .. Patch Set 17: (10 comments) https://gerrit.ovirt.org/#/c/58465/14/lib/vdsm/logUtils.py File lib/vdsm/logUtils.py:

Change in vdsm[master]: rpc: Use Suppressed class instead of logging workarounds

Milan Zamazal has posted comments on this change. Change subject: rpc: Use Suppressed class instead of logging workarounds .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/59078/3/lib/vdsm/logUtils.py File

Change in vdsm[ovirt-3.6]: migration: downtime: handle steps=1

Milan Zamazal has posted comments on this change. Change subject: migration: downtime: handle steps=1 .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59218 To unsubscribe, visit

Change in vdsm[master]: build: Make sure run_tests*.sh scripts are executable

Milan Zamazal has posted comments on this change. Change subject: build: Make sure run_tests*.sh scripts are executable .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/55949/4/build-aux/Makefile.subs File

Change in vdsm[master]: rpc: Use Suppressed class instead of logging workarounds

Milan Zamazal has posted comments on this change. Change subject: rpc: Use Suppressed class instead of logging workarounds .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/59078/1/lib/vdsm/logUtils.py File

Change in vdsm[master]: rpc: Log important info from VM stats

Milan Zamazal has posted comments on this change. Change subject: rpc: Log important info from VM stats .. Patch Set 16: Just rebase for now, I'll reviewers' comments later. -- To view, visit https://gerrit.ovirt.org/58465

Change in vdsm[master]: rpc: Log RPC call summary on info level

Milan Zamazal has posted comments on this change. Change subject: rpc: Log RPC call summary on info level .. Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/59080/1/lib/vdsm/rpc/bindingxmlrpc.py File

Change in vdsm[master]: build: Make sure run_tests*.sh scripts are executable

Milan Zamazal has posted comments on this change. Change subject: build: Make sure run_tests*.sh scripts are executable .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/55949/4/build-aux/Makefile.subs File

Change in vdsm[master]: rpc: Log RPC call summary on info level

Milan Zamazal has posted comments on this change. Change subject: rpc: Log RPC call summary on info level .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/59080/3/lib/vdsm/rpc/bindingxmlrpc.py File

Change in vdsm[master]: rpc: Log RPC call summary on info level

Milan Zamazal has posted comments on this change. Change subject: rpc: Log RPC call summary on info level .. Patch Set 5: (3 comments) https://gerrit.ovirt.org/#/c/59080/3/lib/vdsm/rpc/bindingxmlrpc.py File

Change in vdsm[master]: rpc: Log RPC call summary on info level

Milan Zamazal has posted comments on this change. Change subject: rpc: Log RPC call summary on info level .. Patch Set 14: (1 comment) https://gerrit.ovirt.org/#/c/59080/12/lib/yajsonrpc/__init__.py File

Change in vdsm[master]: rpc: Log important info from VM stats

Milan Zamazal has posted comments on this change. Change subject: rpc: Log important info from VM stats .. Patch Set 26: Logging moved from clienIF.py to API.py. We are going to find a better place in future, master only,

Change in vdsm[master]: rpc: Log also error codes of RPC calls

Milan Zamazal has posted comments on this change. Change subject: rpc: Log also error codes of RPC calls .. Patch Set 12: (3 comments) https://gerrit.ovirt.org/#/c/59234/10/lib/vdsm/rpc/bindingxmlrpc.py File

Change in vdsm[ovirt-3.6]: migration: downtime: update step delay computation

Milan Zamazal has posted comments on this change. Change subject: migration: downtime: update step delay computation .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59221 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: migrations: change convergence schedule from time to iterations

Milan Zamazal has posted comments on this change. Change subject: migrations: change convergence schedule from time to iterations .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/59219/4/vdsm/virt/migration.py File

Change in vdsm[master]: sampling: periodic: improve logging

Milan Zamazal has posted comments on this change. Change subject: sampling: periodic: improve logging .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/58972 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: migrations: change convergence schedule from time to iterations

Milan Zamazal has posted comments on this change. Change subject: migrations: change convergence schedule from time to iterations .. Patch Set 4: As this basically performs just iteration counting without any real action, the

Change in vdsm[ovirt-3.6]: migration: downtime: add tunable for back compat

Milan Zamazal has posted comments on this change. Change subject: migration: downtime: add tunable for back compat .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/59467/2/vdsm/virt/migration.py File

Change in vdsm[ovirt-3.6]: migration: downtime: start thread after 1st iter

Milan Zamazal has posted comments on this change. Change subject: migration: downtime: start thread after 1st iter .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59220 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: migration: early exit when stopped

Milan Zamazal has posted comments on this change. Change subject: migration: early exit when stopped .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57935 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: migration: wait for monitor thread before to exit

Milan Zamazal has posted comments on this change. Change subject: migration: wait for monitor thread before to exit .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59217 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: migration: make MonitorThread own DowntimeThread

Milan Zamazal has posted comments on this change. Change subject: migration: make MonitorThread own DowntimeThread .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57933 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: migration: downtime: add tunable for back compat

Milan Zamazal has posted comments on this change. Change subject: migration: downtime: add tunable for back compat .. Patch Set 2: Code-Review+1 (1 comment) This change requires careful examination. It seems correct to me

Change in vdsm[ovirt-3.6]: migration: track qemu iterations

Milan Zamazal has posted comments on this change. Change subject: migration: track qemu iterations .. Patch Set 5: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/59219/5//COMMIT_MSG Commit Message: Line 11:

Change in vdsm[ovirt-3.6]: migrations: change convergence schedule from time to iterations

Milan Zamazal has posted comments on this change. Change subject: migrations: change convergence schedule from time to iterations .. Patch Set 4: (1 comment) Just please update the commit message to correspond to the actual

Change in vdsm[ovirt-3.6]: jsonrpc: Pass JsonRpcInternalError instance, not class, to r...

Hello Piotr Kliczewski, Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/59595 to review the following change. Change subject: jsonrpc: Pass JsonRpcInternalError instance, not class, to response

Change in vdsm[ovirt-3.6]: migration: downtime: add tunable for back compat

Milan Zamazal has posted comments on this change. Change subject: migration: downtime: add tunable for back compat .. Patch Set 3: Code-Review+1 (1 comment) Thanks. https://gerrit.ovirt.org/#/c/59467/2/vdsm/virt/migration.py

Change in vdsm[ovirt-3.6]: jsonrpc: Pass JsonRpcInternalError instance, not class, to r...

Milan Zamazal has posted comments on this change. Change subject: jsonrpc: Pass JsonRpcInternalError instance, not class, to response .. Patch Set 1: Verified+1 Verified that there is no attribute error traceback when

Change in vdsm[master]: logging: Introduce throttledlog

Milan Zamazal has posted comments on this change. Change subject: logging: Introduce throttledlog .. Patch Set 4: (3 comments) https://gerrit.ovirt.org/#/c/59461/3//COMMIT_MSG Commit Message: PS3, Line 7: logging: Introduce

Change in vdsm[master]: xmlrpc: Hide fenceNode password in the log

Milan Zamazal has posted comments on this change. Change subject: xmlrpc: Hide fenceNode password in the log .. Patch Set 5: Verified+1 Rebased due to a merge conflict. Verified as usually. -- To view, visit

Change in vdsm[master]: rpc: Use Suppressed class instead of logging workarounds

Milan Zamazal has posted comments on this change. Change subject: rpc: Use Suppressed class instead of logging workarounds .. Patch Set 4: Verified+1 Verified that: - (suppressed) is logged for getAllVmStats, for both jsonrpc

Change in vdsm[master]: xmlrpc: Hide fenceNode password in the log

Milan Zamazal has posted comments on this change. Change subject: xmlrpc: Hide fenceNode password in the log .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/58833/4/lib/vdsm/rpc/bindingxmlrpc.py File

Change in vdsm[master]: rpc: Log RPC call summary on info level

Milan Zamazal has posted comments on this change. Change subject: rpc: Log RPC call summary on info level .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/59080/7/lib/vdsm/rpc/bindingxmlrpc.py File

Change in vdsm[master]: rpc: Log important info from VM stats

Milan Zamazal has posted comments on this change. Change subject: rpc: Log important info from VM stats .. Patch Set 19: (2 comments) https://gerrit.ovirt.org/#/c/58465/19/lib/vdsm/throttledlog.py File

Change in vdsm[master]: rpc: Log important info from VM stats

Milan Zamazal has posted comments on this change. Change subject: rpc: Log important info from VM stats .. Patch Set 19: (2 comments) https://gerrit.ovirt.org/#/c/58465/19/lib/vdsm/throttledlog.py File

Change in vdsm[master]: jsonrpc: Pass JsonRpcInternalError instance, not class, to r...

Milan Zamazal has posted comments on this change. Change subject: jsonrpc: Pass JsonRpcInternalError instance, not class, to response .. Patch Set 1: Should we backport the fix? The bug is present in 4.0 and 3.6 as well. --

Change in vdsm[ovirt-4.0]: jsonrpc: Pass JsonRpcInternalError instance, not class, to r...

Hello Piotr Kliczewski, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/59554 to review the following change. Change subject: jsonrpc: Pass JsonRpcInternalError instance, not class, to response ..

Change in vdsm[ovirt-4.0]: jsonrpc: Pass JsonRpcInternalError instance, not class, to r...

Milan Zamazal has posted comments on this change. Change subject: jsonrpc: Pass JsonRpcInternalError instance, not class, to response .. Patch Set 1: Verified+1 Verified that there is no attribute error traceback when

Change in vdsm[ovirt-4.0]: jsonrpc: Pass JsonRpcInternalError instance, not class, to r...

Milan Zamazal has posted comments on this change. Change subject: jsonrpc: Pass JsonRpcInternalError instance, not class, to response .. Patch Set 1: > But do we have a BZ we can piggyback on? No, we don't, it was discovered

<    1   2   3   4   5   6   7   8   9   >