Piotr Kliczewski has posted comments on this change.
Change subject: schema: remove unused types
..
Patch Set 2:
Francesco any news?
--
To view, visit https://gerrit.ovirt.org/53521
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 11:
(2 comments)
https://gerrit.ovirt.org/#/c/52864/11/lib/api/vdsm-api.yaml
File lib/api/vdsm-api.yaml:
Line 6928
Piotr Kliczewski has posted comments on this change.
Change subject: m2c: use custom certificate validation function
..
Patch Set 1:
(5 comments)
https://gerrit.ovirt.org/#/c/53398/1/lib/vdsm/m2cutils.py
File lib/vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 11:
I checked and current yaml implementation do not support splitting files when
alias/anchor is used in the file
Piotr Kliczewski has uploaded a new change for review.
Change subject: jsonrpc: provide more info when method not found
..
jsonrpc: provide more info when method not found
When there was no method to be invoked we returned
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: provide more info when method not found
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/53714/1/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py
Piotr Kliczewski has posted comments on this change.
Change subject: sudoers: narrow dmidecode commandline
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53774
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Move network tests to its own folder
..
Patch Set 3: Code-Review-1
(16 comments)
https://gerrit.ovirt.org/#/c/53704/3/Makefile.am
File Makefile.am
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Move network tests to its own folder
..
Patch Set 5: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/53704/5/tests/network/tc_filter_show.out
Piotr Kliczewski has uploaded a new change for review.
Change subject: bridge: remove dead code
..
bridge: remove dead code
Change-Id: I6e9a1a1289ffb89d3b39cd4b46ef72df0a615ff3
Signed-off-by: pkliczewski
---
M vdsm/rpc
Piotr Kliczewski has uploaded a new change for review.
Change subject: [wip] bridge: usage of yaml schema
..
[wip] bridge: usage of yaml schema
Change-Id: Id24a5e078fa92e4129d37a47593c7a167e78712e
Signed-off-by: pkliczewski
Piotr Kliczewski has posted comments on this change.
Change subject: [wip] bridge: usage of yaml schema
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/53919/1/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 62
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: provide more info when method not found
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/53714/2/tests/integration/jsonRpcTests.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 14:
(5 comments)
https://gerrit.ovirt.org/#/c/52864/14/lib/api/Makefile.am
File lib/api/Makefile.am:
Line 31
Piotr Kliczewski has posted comments on this change.
Change subject: repoplot: Distribute repoplot tool
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53941
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: schema: remove unused types
..
Patch Set 4:
Francesco have you checked?
--
To view, visit https://gerrit.ovirt.org/53521
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: provide more info when method not found
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/53714/2/tests/integration/jsonRpcTests.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: provide more info when method not found
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/53714/2/tests/integration/jsonRpcTests.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: lib: executor: report worker status in __repr__
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53998
To unsubscribe, visit https
Piotr Kliczewski has uploaded a new change for review.
Change subject: gluster: fix schema
..
gluster: fix schema
There were bunch of inconsistencies in gluster schema which needs to be
fixed.
Change-Id
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: fix schema
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/54065/1/lib/api/vdsmapi-gluster-schema.json
File lib/api/vdsmapi-gluster
Piotr Kliczewski has posted comments on this change.
Change subject: schema: remove unused types
..
Patch Set 5:
@Francesco ping
--
To view, visit https://gerrit.ovirt.org/53521
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: fix schema
..
Patch Set 1:
Our parsing code fails on changes introduced in 3.6. Is it good idea to push
this patch to 3.6 branch?
--
To view
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: remove misleading log entry
..
Patch Set 1:
ping
--
To view, visit https://gerrit.ovirt.org/48375
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: provide more info when method not found
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/53714/3/tests/integration/jsonRpcTests.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: obtain method
..
Patch Set 6:
(3 comments)
https://gerrit.ovirt.org/#/c/53472/6/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 509
Piotr Kliczewski has posted comments on this change.
Change subject: moving protocoldetector under lib
..
Patch Set 1: Code-Review+1
Once it is verified will give +2
--
To view, visit https://gerrit.ovirt.org/54150
To
Piotr Kliczewski has posted comments on this change.
Change subject: moving kaxmlrpclib.py to lib
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54151
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: fix schema
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/54065/1/lib/api/vdsmapi-gluster-schema.json
File lib/api/vdsmapi-gluster
Piotr Kliczewski has uploaded a new change for review.
Change subject: json: use forzenset for filtered methods
..
json: use forzenset for filtered methods
Change-Id: I17becc319fb8e226f0badc883007900c8862a520
Signed-off-by
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: provide more info when method not found
..
Patch Set 4: Verified+1
Verified by host deploying the host and seeing no issues.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: remove dead code
..
Patch Set 3: Verified+1
Verified by host deploying the host and seeing no issues.
--
To view, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: json: use forzenset for filtered methods
..
Patch Set 1: Verified+1
Verified by host deploying the host and seeing no issues.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: obtain method
..
Patch Set 7: Verified+1
Verified by host deploying the host and seeing no issues.
--
To view, visit https://gerrit.ovirt.org/53472
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 16: Verified+1
Verified by host deploying the host and seeing no issues.
--
To view, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: [wip] bridge: usage of yaml schema
..
Patch Set 4: Verified+1
Verified by host deploying the host and seeing no issues.
Before I assume this patch to be
Piotr Kliczewski has posted comments on this change.
Change subject: api: remove unused methods
..
Patch Set 3: Verified+1
Verified by running local build.
--
To view, visit https://gerrit.ovirt.org/53673
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: json: use forzenset for filtered methods
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/54160/1/lib/yajsonrpc/__init__.py
File lib/yajsonrpc
Piotr Kliczewski has posted comments on this change.
Change subject: spec: Add a dependency to vdsm on vdsm-cli
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/54006/1/vdsm.spec.in
File vdsm.spec.in:
Line 255
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: provide more info when method not found
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/53714/4/lib/yajsonrpc/__init__.py
File lib
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: obtain method
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/53472/7/tests/stompTests.py
File tests/stompTests.py:
Line 55: def
Piotr Kliczewski has posted comments on this change.
Change subject: rpc: moving module to lib/vdsm
..
Patch Set 3: Verified+1
Verified by host deploying vdsm and seeing no issues during communication.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: moving kaxmlrpclib.py to lib
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54151
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: moving protocoldetector under lib
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54150
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: repoplot: Support dd copy commands used in 3.5
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54117
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: moving kaxmlrpclib.py to lib
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54151
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: fix schema
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/54065/1/lib/api/vdsmapi-gluster-schema.json
File lib/api/vdsmapi-gluster
Piotr Kliczewski has posted comments on this change.
Change subject: json: use forzenset for filtered methods
..
Patch Set 2: Verified+1
Verified by host deploying vdsm and seeing that there are no issues.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: provide more info when method not found
..
Patch Set 5: Verified+1
Verified by host deploying vdsm and seeing that there are no issues.
--
To view
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: fix schema
..
Patch Set 3:
Can you please verify whether updated schema works with gluster?
--
To view, visit https://gerrit.ovirt.org/54065
To
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: remove dead code
..
Patch Set 4: Verified+1
Verified by host deploying vdsm and seeing that there are no issues.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 17: Verified+1
Verified by host deploying vdsm and seeing that there are no issues.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 5:
With type verification I noticed many inconsistencies so strict mode is
disabled for now because it would make
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: obtain method
..
Patch Set 8: Verified+1
Verified by host deploying vdsm and seeing that there are no issues.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 5:
(1 comment)
I added bunch of tests to bridgeTests and the complex code is covered. I need
to see coverage
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 5:
This patch should be verified but I am not confident setting the flag due to
number of inconsistencies we have
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 5:
Agreed, I need to post one more patch to remove old schema(s) and parsing code.
--
To view, visit https
Piotr Kliczewski has uploaded a new change for review.
Change subject: caps: unable to marshal defaultdict by xmlrpc
..
caps: unable to marshal defaultdict by xmlrpc
When using vdsClient to getCaps we saw:
:cannot marshal
Piotr Kliczewski has posted comments on this change.
Change subject: caps: unable to marshal defaultdict by xmlrpc
..
Patch Set 1: Verified+1
Verified by host deploying vdsm and seeing that vdsClient works when calling
Piotr Kliczewski has posted comments on this change.
Change subject: caps: unable to marshal defaultdict by xmlrpc
..
Patch Set 1:
It seems that we need this one or #54283 because master is broken
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: caps: unable to marshal defaultdict by xmlrpc
..
Patch Set 2: Verified+1
As in patch set #1
--
To view, visit https://gerrit.ovirt.org/54353
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: fix schema
..
Patch Set 3: Verified+1
This schema change was not tested with running gluster but I used vdsmapi
module to parse and process it and
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: remove dead code
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/53918/4/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:
Line 69
Line
Piotr Kliczewski has posted comments on this change.
Change subject: storage: create lib storage directory
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54381
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 17:
(4 comments)
https://gerrit.ovirt.org/#/c/52864/17/lib/api/vdsm-api.yaml
File lib/api/vdsm-api.yaml:
Line 4836
Piotr Kliczewski has posted comments on this change.
Change subject: vdsm.host.uuid: eliminate obsoleted argument "legacy"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54384
To unsubscr
Piotr Kliczewski has posted comments on this change.
Change subject: net schema: Remove unused NetworkOptions type
..
Patch Set 1: Code-Review+2
53521 already removes this type but if you want to keep it network specific I
am
Piotr Kliczewski has posted comments on this change.
Change subject: net schema: Add IPv6 setupNetworks attributes
..
Patch Set 2: Code-Review+2
We need to backport it to 3.6.
--
To view, visit https://gerrit.ovirt.org/54382
Piotr Kliczewski has posted comments on this change.
Change subject: net schema: Add IPv6 networking caps attributes
..
Patch Set 2: Code-Review-1
We are stating here that it was added in 3.6 but using required attributes
Piotr Kliczewski has posted comments on this change.
Change subject: HA: Make getHostLeaseStatus API public
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/29157
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: schema: remove unused types
..
Patch Set 7:
@Francesco do you have the answer from the engine guy(s) whether it is OK to
remove unused types?
--
To view
Piotr Kliczewski has posted comments on this change.
Change subject: vdsm.host.uuid: eliminate obsoleted argument "legacy"
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54384
To unsubscr
Piotr Kliczewski has posted comments on this change.
Change subject: net schema: Add IPv6 networking caps attributes
..
Patch Set 2:
I assume that it will be backported to 3.6 so please check how it works with
3.5 engine or
Piotr Kliczewski has posted comments on this change.
Change subject: net schema: Add IPv6 networking caps attributes
..
Patch Set 2:
So, if we are not going to backport it to 3.6 we need to change version when it
was added
Piotr Kliczewski has posted comments on this change.
Change subject: moving protocoldetector under lib
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54150
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: schema: remove unused types
..
Patch Set 7:
I have to admit that I run tests on top of whole topic so it was not only this
patch. The vdsm was up and
Piotr Kliczewski has posted comments on this change.
Change subject: schema: remove unused types
..
Patch Set 7:
Once type verification is in we will start to complain about extra data that is
send which is not part of the
Piotr Kliczewski has posted comments on this change.
Change subject: api: remove unused methods
..
Patch Set 4: Verified+1
Rebase only
--
To view, visit https://gerrit.ovirt.org/53673
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: schema: add Rng and Tpm device to the device list
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54425
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: schema: remove unused types
..
Patch Set 7:
I acked your patch. Will check whether this patch is still needed because
network type was removed in different
Piotr Kliczewski has posted comments on this change.
Change subject: schema: remove unused types
..
Patch Set 7:
It looks like when Francesco's patch is merged we can abandon this patch.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: schema: add Rng and Tpm device to the device list
..
Patch Set 1:
I will perform conversion and run unit tests that I created and later will
verify in run
Piotr Kliczewski has posted comments on this change.
Change subject: schema: add Rng and Tpm device to the device list
..
Patch Set 1:
They look the same from schema definition perspective. We can leave them as
they are (both
Piotr Kliczewski has posted comments on this change.
Change subject: schema: add Rng and Tpm device to the device list
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/54425/2/lib/api/vdsmapi-schema.json
File lib/api
Piotr Kliczewski has posted comments on this change.
Change subject: storage: add storage folder to spec
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54431
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: spec: add virt and netinfo dir in spec
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54439
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: schema: add Rng and Tpm device to the device list
..
Patch Set 3: Code-Review+2 Verified+1
I verified by running my unit tests and schema validation. I was
Piotr Kliczewski has posted comments on this change.
Change subject: net schema: Add IPv6 networking caps attributes
..
Patch Set 2: Code-Review+2
OK, let's have it in.
--
To view, visit https://gerrit.ovirt.org/543
Piotr Kliczewski has posted comments on this change.
Change subject: net schema: Add IPv6 networking caps attributes
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54445
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: make sure that subscriptions use uniqe id
..
Patch Set 3:
ping
--
To view, visit https://gerrit.ovirt.org/46656
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: message tracking do not clean properly
..
Patch Set 5:
ping
--
To view, visit https://gerrit.ovirt.org/48616
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: improve message id handling during response send
..
Patch Set 2:
ping
--
To view, visit https://gerrit.ovirt.org/49185
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: PoC: enforcement of contract for notifications
..
Patch Set 1:
let's update something here. We still need it.
--
To view, visit https://gerrit.ovir
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: make sure that stomp connection is active before sending
messages
..
Patch Set 3:
ping
--
To view, visit https://gerrit.ovirt.org/49000
To
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 17:
(4 comments)
https://gerrit.ovirt.org/#/c/52864/17/lib/api/vdsm-api.yaml
File lib/api/vdsm-api.yaml:
Line 4805
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 17:
(2 comments)
https://gerrit.ovirt.org/#/c/52864/17/lib/api/vdsm-api.yaml
File lib/api/vdsm-api.yaml:
Line 4836
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 17:
(20 comments)
https://gerrit.ovirt.org/#/c/52864/17/lib/api/vdsm-api.yaml
File lib/api/vdsm-api.yaml:
Line 5659
Piotr Kliczewski has posted comments on this change.
Change subject: vm: rng: add TODO about schema cleanup
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54506
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: schema: add Rng and Tpm device to the device list
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54425
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: vm: rng: add TODO about schema cleanup
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54506
To unsubscribe, visit https
1001 - 1100 of 1323 matches
Mail list logo
