Piotr Kliczewski has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/46625/1/lib/yajsonrpc/betterAsyncore.py
File lib
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 2: Verified+1
Patch rebased and added logging as requested. Copying verification flag.
--
To
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: increase call timeout to allow valid response
..
Patch Set 1:
Can you please give more information about the issues you are seeing? Changing
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: make sure to send error message when no subscription
..
Patch Set 4:
Yaniv do you still have some comments to this patch.
Patch rebased only.
--
To
Piotr Kliczewski has posted comments on this change.
Change subject: tests: StompAdapter test suite
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/43342
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: tests: StompAdapter test suite
..
Patch Set 7:
Verified by building locally. Rebased only.
--
To view, visit https://gerrit.ovirt.org/43342
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: tests: AsyncClient test suite
..
Patch Set 5: Verified+1
Rebased only.
--
To view, visit https://gerrit.ovirt.org/43393
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: allow to mock monotonic_time method
..
Patch Set 3: Verified+1
Fixed comments. Verified by building locally on my machine.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: tests: AsyncDispatcher tests suite
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/43394
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: tests: AsyncDispatcher tests suite
..
Patch Set 5:
Rebased only.
--
To view, visit https://gerrit.ovirt.org/43394
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: tests: JsonRpcServer tests suite
..
Patch Set 4: Verified+1
Rebased only.
--
To view, visit https://gerrit.ovirt.org/43581
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: tests: JsonRpcClient tests suite
..
Patch Set 4: Verified+1
Rebased only.
--
To view, visit https://gerrit.ovirt.org/43582
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/46625/2/lib/yajsonrpc/betterAsyncore.py
File lib
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: make sure that subscriptions use uniqe id
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/46656/2/lib/yajsonrpc/stompreactor.py
File lib
Piotr Kliczewski has posted comments on this change.
Change subject: dispatcher: improve failure logging
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/46624/1/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: make sure that subscriptions use uniqe id
..
Patch Set 3: Verified+1
Simplified as Francesco requested. Verified on previous patch set so copying
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 3: Verified+1
Make sure to be consistent with other if branches when handling issue. Verified
Piotr Kliczewski has posted comments on this change.
Change subject: dispatcher: improve failure logging
..
Patch Set 3: Verified+1
Verified by host installing vdsm and causing connection reset by killing the
engine (SSLError
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 3:
Verified by causing connection issue by killing the engine.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/45750/3/vdsm.spec.in
File vdsm.spec.in:
Line 1353: %files
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Wait for udev events after unmounting
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46702
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 13: Verified+1
Verified by building vdsm for both implementation and tested with both
implementation settings
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 11: Verified+1
Verified by building vdsm for both implementation and tested with both
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 12: Verified+1
Verified by building vdsm for both implementation and tested with both
Piotr Kliczewski has abandoned this change.
Change subject: tests: ignore empty frame
..
Abandoned
It looks like we do not need this patch anymore
--
To view, visit https://gerrit.ovirt.org/42919
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: change default protocol
..
Patch Set 2:
Yaniv please check updated commit message.
--
To view, visit https://gerrit.ovirt.org/43457
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 13:
CI failure is not related to this change
--
To view, visit https://gerrit.ovirt.org/44494
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 12:
CI failure is not related to this change
--
To view, visit https://gerrit.ovirt.org/44689
To
Piotr Kliczewski has posted comments on this change.
Change subject: integration: remove an unused import
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46795
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: tests: inherit from object
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46801
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 4:
I am ok with both approaches. I would like to get more opinions and leave or
change this patch.
--
To
Piotr Kliczewski has posted comments on this change.
Change subject: CI: On fc22 trying to install a src.rpm fails
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46812
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/12/lib/vdsm/sslcompat.py
File lib/vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 14: Verified+1
There were implementation fallback issues during tests which were discovered
while running
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 13: Verified+1
Moved sorting order of imports to previous patch as Francesco suggested. No
other
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 15: Verified+1
Moved test fixes to next patch. No other changes. Verified by running build in
mock env locally
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 14: Verified+1
Moved fixed tests from previous patch. Verified by running build in mock
locally
Piotr Kliczewski has posted comments on this change.
Change subject: json cli: use ssl when creating a socket
..
Patch Set 4:
Patch rebased. I was not able to verify the patch due to config.py path to
certificates. There was
Piotr Kliczewski has posted comments on this change.
Change subject: tests: functional - convert to run over jsonrpc
..
Patch Set 3: Verified+1
Patch rebased. I was not able to verify the patch due to config.py path to
Piotr Kliczewski has posted comments on this change.
Change subject: vdscli: map invocation params to dictionary
..
Patch Set 9: Verified+1
Patch rebased. I was not able to verify the patch due to config.py path to
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 5: Verified+1
Patch rebased. Verified by host deploying vdsm and seeing that communication
works between
Piotr Kliczewski has abandoned this change.
Change subject: jsonrpc: check whether the connection is still open before
processing
..
Abandoned
Patch https://gerrit.ovirt.org/#/c/45615 solved the problem so we do not need
it
Piotr Kliczewski has posted comments on this change.
Change subject: automation: enable pep8
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46885
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has uploaded a new change for review.
Change subject: asyncore: use default handing of read event
..
asyncore: use default handing of read event
It seems that we provided our own handle_read_event method due to
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: use default handing of read event
..
Patch Set 1: Verified+1
(1 comment)
Verified by running tests several times as well host installing vdsm as
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: reducing log footprint from stomp lib
..
Patch Set 1: Verified+1
Verified by running UT and host deploying vdsm and seeing that communication is
OK
Piotr Kliczewski has uploaded a new change for review.
Change subject: stomp: reducing log footprint from stomp lib
..
stomp: reducing log footprint from stomp lib
There was bunch of not needed information about being not able
Piotr Kliczewski has uploaded a new change for review.
Change subject: stomp: reducing log footprint from stomp lib
..
stomp: reducing log footprint from stomp lib
There was bunch of not needed information about being not able
Piotr Kliczewski has posted comments on this change.
Change subject: automation: enable pep8
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46928
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: reducing log footprint from stomp lib
..
Patch Set 1: Verified+1
Verified by running UT and host deploying vdsm and seeing that communication
works
Piotr Kliczewski has uploaded a new change for review.
Change subject: test: moving getInstance to its class
..
test: moving getInstance to its class
Change-Id: Iadc44aef17d1ebcf8b6b7b63fce3fa8d34b4c0a3
Signed-off-by
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: use default handing of read event
..
Patch Set 2: Verified+1
Rebased and fixed francesco comment. Copying verification flag.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: test: moving getInstance to its class
..
Patch Set 1: Verified+1
Verified by running tests many times.
--
To view, visit https://gerrit.ovirt.org/46941
To
Piotr Kliczewski has posted comments on this change.
Change subject: test: moving getInstance to its class
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/46941/1/tests/integration/jsonRpcHelper.py
File tests
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: ignore unknown message id
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/43746/4//COMMIT_MSG
Commit Message:
Line 8:
Line 9: When we
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: use default handing of read event
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/46911/2//COMMIT_MSG
Commit Message:
Line 9: It seems
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/14/vdsm.spec.in
File vdsm.spec.in:
Line 628
Piotr Kliczewski has posted comments on this change.
Change subject: test: moving getInstance to its class
..
Patch Set 1:
Franceso can you tell me what do you want me to fix in this patch?
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: test: moving getInstance to its class
..
Patch Set 1:
Will update docstring
--
To view, visit https://gerrit.ovirt.org/46941
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: use default handing of read event
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/46911/2/lib/yajsonrpc/betterAsyncore.py
File lib
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: use default handing of read event
..
Patch Set 3: Verified+1
Patch rebased only on code changes. Copying verification flag from previous
patch set
Piotr Kliczewski has posted comments on this change.
Change subject: test: moving getInstance to its class
..
Patch Set 2: Verified+1
Added docstring and verified by running local build. Patch rebased.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: test: moving getInstance to its class
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/46941/2/tests/integration/jsonRpcHelper.py
File tests
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: use default handing of read event
..
Patch Set 3:
CI failure is not related to the previous patch. Will fix it anyway.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: test: getInstance is not used so removing
..
Patch Set 4: Verified+1
Verified by running build and integration tests.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Fix unmount in mkimage tests
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47038
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: test: getInstance is not used so removing
..
Patch Set 4: Continuous-Integration+1
As CI is not able to give the score and the comment was updated I am
Piotr Kliczewski has posted comments on this change.
Change subject: utils: Add memoized invalidation
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40029
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: spec: Require newer kernel version on Fedora
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44851
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: utils: split out execCmd wrapping logic
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47107
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 15: Verified+1
Verified by building vdsm with m2c enabled and disabled both builds configured
vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 16:
Rebase only, no code changes
--
To view, visit https://gerrit.ovirt.org/44494
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/15/configure.ac
File configure.ac:
Line 164
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 16:
(3 comments)
https://gerrit.ovirt.org/#/c/44494/16/lib/vdsm/m2cutils.py
File lib/vdsm/m2cutils.py:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: change default protocol
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/43457/2//COMMIT_MSG
Commit Message:
Line 11: see issues that it is
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/43759/10/vdsm/rpc/bindingjsonrpc.py
File vdsm/rpc
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: more meaningful name of address param
..
Patch Set 1:
It is really hard to follow good practices with inherited code. I will do my
best to keep the
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: reducing log footprint from stomp lib
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/46931/1//COMMIT_MSG
Commit Message:
Line 3
Piotr Kliczewski has posted comments on this change.
Change subject: spec: Require newer kernel version on Fedora
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47207
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: increase call timeout to allow valid response
..
Patch Set 1: Code-Review-1
I think we need to investigate the issues and fix them instead of
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: increase call timeout to allow valid response
..
Patch Set 1:
Can you describe the specific scenario and what verbs are called and which part
of
Piotr Kliczewski has posted comments on this change.
Change subject: service: change vdsm KillMode to mixed
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/45038/5/vdsm.spec.in
File vdsm.spec.in:
Line 200: Requires
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 15:
(4 comments)
https://gerrit.ovirt.org/#/c/44689/15/configure.ac
File configure.ac:
Line 161
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 17:
Only rebase no code changes. Pending changes to remove spec changes but not yet
agreed on.
--
To view
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 16: Verified+1
Added debian related changes so we can set config.py value for ssl standard
module
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 16:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/16/lib/vdsm/config.py.in
File lib/vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 16:
(3 comments)
https://gerrit.ovirt.org/#/c/44689/16/debian/rules
File debian/rules:
Line 33
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 16:
(2 comments)
https://gerrit.ovirt.org/#/c/44689/16/debian/rules
File debian/rules:
Line 33
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 6:
Good point. Will add debian support.
--
To view, visit https://gerrit.ovirt.org/45750
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: configurable implementation
..
Patch Set 18:
Rebase only.
--
To view, visit https://gerrit.ovirt.org/44494
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
..
Patch Set 17: Verified+1
Fixed space but still we remove m2c as required. No other code changes.
--
To view
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 7: Verified+1
Added new deb for debian build. Not built on debian due to issue with pcopen.
--
To view
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/45750/7/debian/control
File debian/control:
Line 327: Depends
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: increase call timeout to allow valid response
..
Patch Set 2: Code-Review-1
Why no to use 'timeout' in kwargs? We check for it in the
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Wait for udev events after unmounting
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47040
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Fix and simplify cleanup after failures
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47342
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Wait for udev events after unmounting
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47343
To unsubscribe, visit https
Piotr Kliczewski has uploaded a new change for review.
Change subject: ssl: ssl socket may throw sslerror during reading
..
ssl: ssl socket may throw sslerror during reading
When client closes socket in not clean way sometimes
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 1: Verified+1
Patch verified on master so copying verification flag.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: ssl socket may throw sslerror during reading
..
Patch Set 1: Verified-1
It seems that one of ssl related patches was not backported to 3.6. Will push
401 - 500 of 1223 matches
Mail list logo
