Change in vdsm[master]: jsonrpc: more meaningful name of address param

2015-10-12 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: more meaningful name of address param .. Patch Set 1: It is really hard to follow good practices with inherited code. I will do my best to keep the

Change in vdsm[master]: stomp: reducing log footprint from stomp lib

2015-10-12 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: stomp: reducing log footprint from stomp lib .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/46931/1//COMMIT_MSG Commit Message: Line 3

Change in vdsm[ovirt-3.6]: spec: Require newer kernel version on Fedora

2015-10-12 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: spec: Require newer kernel version on Fedora .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/47207 To unsubscribe, visit https

Change in vdsm[master]: jsonrpc: increase call timeout to allow valid response

2015-10-12 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: increase call timeout to allow valid response .. Patch Set 1: Code-Review-1 I think we need to investigate the issues and fix them instead of

Change in vdsm[master]: jsonrpc: increase call timeout to allow valid response

2015-10-12 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: increase call timeout to allow valid response .. Patch Set 1: Can you describe the specific scenario and what verbs are called and which part of

Change in vdsm[master]: service: change vdsm KillMode to mixed

2015-10-12 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/45038/5/vdsm.spec.in File vdsm.spec.in: Line 200: Requires

Change in vdsm[master]: ssl: runtime config to choose implementation

2015-10-13 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: ssl: runtime config to choose implementation .. Patch Set 15: (4 comments) https://gerrit.ovirt.org/#/c/44689/15/configure.ac File configure.ac: Line 161

Change in vdsm[master]: ssl: configurable implementation

2015-10-13 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: ssl: configurable implementation .. Patch Set 17: Only rebase no code changes. Pending changes to remove spec changes but not yet agreed on. -- To view

Change in vdsm[master]: ssl: runtime config to choose implementation

2015-10-13 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: ssl: runtime config to choose implementation .. Patch Set 16: Verified+1 Added debian related changes so we can set config.py value for ssl standard module

Change in vdsm[master]: ssl: runtime config to choose implementation

2015-10-13 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: ssl: runtime config to choose implementation .. Patch Set 16: (1 comment) https://gerrit.ovirt.org/#/c/44689/16/lib/vdsm/config.py.in File lib/vdsm

Change in vdsm[master]: ssl: runtime config to choose implementation

2015-10-13 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: ssl: runtime config to choose implementation .. Patch Set 16: (3 comments) https://gerrit.ovirt.org/#/c/44689/16/debian/rules File debian/rules: Line 33

Change in vdsm[master]: ssl: runtime config to choose implementation

2015-10-13 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: ssl: runtime config to choose implementation .. Patch Set 16: (2 comments) https://gerrit.ovirt.org/#/c/44689/16/debian/rules File debian/rules: Line 33

Change in vdsm[master]: schema: rpm for jsonrpc schema files

2015-10-13 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: schema: rpm for jsonrpc schema files .. Patch Set 6: Good point. Will add debian support. -- To view, visit https://gerrit.ovirt.org/45750 To unsubscribe

Change in vdsm[master]: ssl: configurable implementation

2015-10-14 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: ssl: configurable implementation .. Patch Set 18: Rebase only. -- To view, visit https://gerrit.ovirt.org/44494 To unsubscribe, visit https

Change in vdsm[master]: ssl: runtime config to choose implementation

2015-10-14 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: ssl: runtime config to choose implementation .. Patch Set 17: Verified+1 Fixed space but still we remove m2c as required. No other code changes. -- To view

Change in vdsm[master]: schema: rpm for jsonrpc schema files

2015-10-14 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: schema: rpm for jsonrpc schema files .. Patch Set 7: Verified+1 Added new deb for debian build. Not built on debian due to issue with pcopen. -- To view

Change in vdsm[master]: schema: rpm for jsonrpc schema files

2015-10-14 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: schema: rpm for jsonrpc schema files .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/45750/7/debian/control File debian/control: Line 327: Depends

Change in vdsm[master]: jsonrpc: increase call timeout to allow valid response

2015-10-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: increase call timeout to allow valid response .. Patch Set 2: Code-Review-1 Why no to use 'timeout' in kwargs? We check for it in the

Change in vdsm[ovirt-3.5]: tests: Wait for udev events after unmounting

2015-10-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: tests: Wait for udev events after unmounting .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/47040 To unsubscribe, visit https

Change in vdsm[ovirt-3.6]: tests: Fix and simplify cleanup after failures

2015-10-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: tests: Fix and simplify cleanup after failures .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/47342 To unsubscribe, visit https

Change in vdsm[ovirt-3.6]: tests: Wait for udev events after unmounting

2015-10-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: tests: Wait for udev events after unmounting .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/47343 To unsubscribe, visit https

Change in vdsm[ovirt-3.6]: ssl: ssl socket may throw sslerror during reading

2015-10-15 Thread piotr . kliczewski
Piotr Kliczewski has uploaded a new change for review. Change subject: ssl: ssl socket may throw sslerror during reading .. ssl: ssl socket may throw sslerror during reading When client closes socket in not clean way sometimes

Change in vdsm[ovirt-3.6]: ssl: ssl socket may throw sslerror during reading

2015-10-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: ssl: ssl socket may throw sslerror during reading .. Patch Set 1: Verified+1 Patch verified on master so copying verification flag. -- To view, visit https

Change in vdsm[ovirt-3.6]: ssl: ssl socket may throw sslerror during reading

2015-10-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: ssl: ssl socket may throw sslerror during reading .. Patch Set 1: Verified-1 It seems that one of ssl related patches was not backported to 3.6. Will push

Change in vdsm[ovirt-3.6]: ssl: ssl socket may throw sslerror during reading

2015-10-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: ssl: ssl socket may throw sslerror during reading .. Patch Set 2: Verified+1 Changes verified by building on local env. -- To view, visit https

Change in vdsm[master]: utils: Consider sleep time in deadline calculation

2015-10-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: utils: Consider sleep time in deadline calculation .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/46400 To unsubscribe, visit

Change in vdsm[master]: ssl: runtime config to choose implementation

2015-10-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: ssl: runtime config to choose implementation .. Patch Set 18: Verified+1 Verified by build vdsm with --enable-m2c and with --disable-m2c to set default

Change in vdsm[master]: ssl: runtime config to choose implementation

2015-10-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: ssl: runtime config to choose implementation .. Patch Set 18: (1 comment) Yaniv's comments fixed. Dan supports this approach. https://gerrit.ovirt.or

Change in vdsm[master]: ssl: configurable implementation

2015-10-15 Thread piotr . kliczewski
Piotr Kliczewski has abandoned this change. Change subject: ssl: configurable implementation .. Abandoned Due to squashing this patch with https://gerrit.ovirt.org/#/c/44689/ we do not need it anymore. -- To view, visit

Change in vdsm[master]: betterAsyncore: Override asyncore logging to use our logger

2015-10-16 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: betterAsyncore: Override asyncore logging to use our logger .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/47407 To unsubscribe

Change in vdsm[master]: betterAsyncore: Fix AttributeError on disconnect

2015-10-16 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: betterAsyncore: Fix AttributeError on disconnect .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/47406 To unsubscribe, visit https

Change in vdsm[ovirt-3.6]: betterAsyncore: Fix AttributeError on disconnect

2015-10-18 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: betterAsyncore: Fix AttributeError on disconnect .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/47421 To unsubscribe, visit https

Change in vdsm[master]: test: Unit Test target with NOSE attribute/marker

2016-03-10 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: test: Unit Test target with NOSE attribute/marker .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/54388/1/tests/network/qos_test.py

Change in vdsm[master]: tests: Remove unneeded assert

2016-03-10 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: tests: Remove unneeded assert .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51922 To unsubscribe, visit https://gerrit.ovirt.org

Change in vdsm[master]: test: Unit Test target with NOSE attribute/marker

2016-03-10 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: test: Unit Test target with NOSE attribute/marker .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/54388/1/tests/network/qos_test.py File tests

Change in vdsm[master]: stomp: make sure that we are connected before sending data

2016-03-10 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: stomp: make sure that we are connected before sending data .. Patch Set 1: Verified+1 Verified by running UTs several times. -- To view, visit https

Change in vdsm[master]: stomp: make sure that we are connected before sending data

2016-03-10 Thread piotr . kliczewski
Piotr Kliczewski has uploaded a new change for review. Change subject: stomp: make sure that we are connected before sending data .. stomp: make sure that we are connected before sending data There could be a situation that we

Change in vdsm[master]: test: Unit Test target with NOSE attribute/marker

2016-03-10 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: test: Unit Test target with NOSE attribute/marker .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54388 To unsubscribe, visit https

Change in vdsm[master]: tests: Classify network tests type

2016-03-10 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: tests: Classify network tests type .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54391 To unsubscribe, visit https

Change in vdsm[master]: api: remove unused methods

2016-03-10 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: api: remove unused methods .. Patch Set 4: There is nothing to fix. The tests only use the code which is removed in this patch. -- To view, visit https

Change in vdsm[master]: api: remove unused methods

2016-03-10 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: api: remove unused methods .. Patch Set 4: Can you give more info how the virt tests are failing? -- To view, visit https://gerrit.ovirt.org/53673 To

Change in vdsm[master]: stomp: make sure that we are connected before sending data

2016-03-10 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: stomp: make sure that we are connected before sending data .. Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/54578/1/lib/yajsonrpc/__init__.py File

Change in vdsm[master]: migration: added support for convergence schedule

2016-03-10 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: migration: added support for convergence schedule .. Patch Set 22: Please add me to the patches where there is schema change. I am maintaining not merged

Change in vdsm[master]: build: clean tests certificates

2016-03-10 Thread piotr . kliczewski
Piotr Kliczewski has uploaded a new change for review. Change subject: build: clean tests certificates .. build: clean tests certificates There were recent changes how we represent host in tests certificates so we can support

Change in vdsm[master]: build: clean tests certificates

2016-03-10 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: build: clean tests certificates .. Patch Set 1: Verified+1 Verified by running make clean -- To view, visit https://gerrit.ovirt.org/54590 To unsubscribe

Change in vdsm[master]: contrib: schema converter

2016-03-10 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 21: Verified+1 New patches changing schema were merged so I updated yaml schema to reflect the changes. -- To view

Change in vdsm[master]: json: removal of old schemas

2016-03-10 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: json: removal of old schemas .. Patch Set 4: Verified+1 No code changes, rebase only. Patch verified as in previous patch set. -- To view, visit https

Change in vdsm[master]: stomp: make sure that we are connected before sending data

2016-03-10 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: stomp: make sure that we are connected before sending data .. Patch Set 2: Verified-1 Forgot to restore changes in __init__.py -- To view, visit https

Change in vdsm[master]: stomp: make sure that we are connected before sending data

2016-03-10 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: stomp: make sure that we are connected before sending data .. Patch Set 3: Verified+1 Verified by running UTs -- To view, visit https://gerrit.ovirt.org

Change in vdsm[master]: schema: add Rng and Tpm device to the device list

2016-03-11 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: schema: add Rng and Tpm device to the device list .. Patch Set 8: Verified+1 I run bunch of verification tests and deployed vdsm, run a vm and suspended

Change in vdsm[master]: misc: Replace assert with AssetionError

2016-03-14 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: misc: Replace assert with AssetionError .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/34363 To unsubscribe, visit https

Change in vdsm[master]: stomp: make sure that we are connected before sending data

2016-03-14 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: stomp: make sure that we are connected before sending data .. Patch Set 3: Code-Review-1 (1 comment) I am planning to do more tests. I was not able to

Change in vdsm[master]: build: clean tests certificates

2016-03-14 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: build: clean tests certificates .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/54590/1/tests/Makefile.am File tests/Makefile.am: Line 233: Line

Change in vdsm[master]: rfh: Remove legacy remoteFileHandler

2016-03-14 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: rfh: Remove legacy remoteFileHandler .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54703 To unsubscribe, visit https

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

2016-03-14 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: exception: Add exceptions for vdsm.define errors .. Patch Set 15: Code-Review-1 (8 comments) It seems that we need to align the codes between engine and

Change in vdsm[master]: WIP: POC: virt: common handling of exception

2016-03-14 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: WIP: POC: virt: common handling of exception .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/54664/2/lib/vdsm/virt/utils.py File lib/vdsm/virt

Change in vdsm[master]: tests: Use multiple context expressions

2016-03-14 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: tests: Use multiple context expressions .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54676 To unsubscribe, visit https

Change in vdsm[master]: build: clean tests certificates

2016-03-14 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: build: clean tests certificates .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/54590/1/tests/Makefile.am File tests/Makefile.am: Line 233: Line

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

2016-03-14 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: exception: Add exceptions for vdsm.define errors .. Patch Set 16: Code-Review-1 Please see my comments from patch set #15. -- To view, visit https

Change in vdsm[master]: build: clean tests certificates

2016-03-14 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: build: clean tests certificates .. Patch Set 3: Verified+1 Verified that changes to makecert script causes regeneration of certs. -- To view, visit https

Change in vdsm[master]: contrib: schema converter

2016-03-14 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 21: (1 comment) https://gerrit.ovirt.org/#/c/52864/21/lib/api/vdsm-api.yaml File lib/api/vdsm-api.yaml: Line 6697

Change in vdsm[master]: contrib: schema converter

2016-03-14 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 21: (1 comment) https://gerrit.ovirt.org/#/c/52864/21/lib/api/vdsm-api.yaml File lib/api/vdsm-api.yaml: Line 6697

Change in vdsm[master]: vm: remove not used monitorCommand

2016-03-14 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: vm: remove not used monitorCommand .. Patch Set 1: @Francesco any news? -- To view, visit https://gerrit.ovirt.org/54513 To unsubscribe, visit https

Change in vdsm[master]: vm: remove not used monitorCommand

2016-03-14 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: vm: remove not used monitorCommand .. Patch Set 1: Verified+1 Verified that during runtime no issues found. -- To view, visit https://gerrit.ovirt.org

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

2016-03-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: exception: Add exceptions for vdsm.define errors .. Patch Set 15: (3 comments) https://gerrit.ovirt.org/#/c/48871/15/lib/vdsm/exception.py File lib/vdsm

Change in vdsm[master]: test: Unit Test target with NOSE attribute/marker

2016-03-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: test: Unit Test target with NOSE attribute/marker .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54388 To unsubscribe, visit https

Change in vdsm[master]: tests: Classify network tests type

2016-03-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: tests: Classify network tests type .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54391 To unsubscribe, visit https

Change in vdsm[master]: events: introduction of schema

2016-03-15 Thread piotr . kliczewski
Piotr Kliczewski has uploaded a new change for review. Change subject: events: introduction of schema .. events: introduction of schema Change-Id: I43a9f1852b1459a2e905244049507704f0187201 Signed-off-by: pkliczewski --- M lib

Change in vdsm[master]: contrib: schema converter

2016-03-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 22: Verified+1 I updated schema with recent networking changes and removed monitorCommand verb. Set of patches

Change in vdsm[master]: json: removal of old schemas

2016-03-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: json: removal of old schemas .. Patch Set 5: Verified+1 Set of patches verified by host deploying a host, configuring nfs data domain and provision a vm

Change in vdsm[master]: events: introduction of schema

2016-03-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: events: introduction of schema .. Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/54754/1/lib/api/vdsm-events.yaml File lib/api/vdsm-events.yaml

Change in vdsm[master]: rfh: Remove legacy remoteFileHandler

2016-03-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: rfh: Remove legacy remoteFileHandler .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54703 To unsubscribe, visit https

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

2016-03-16 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: exception: Add exceptions for vdsm.define errors .. Patch Set 15: (2 comments) https://gerrit.ovirt.org/#/c/48871/15/lib/vdsm/exception.py File lib/vdsm

Change in vdsm[master]: WIP: POC: virt: common handling of exception

2016-03-16 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: WIP: POC: virt: common handling of exception .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/54664/2/lib/vdsm/virt/utils.py File lib/vdsm/virt

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

2016-03-18 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: tests: Run unit tests using travis-ci and docker .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/54856/1/.travis.yml File .travis.yml: Line 8

Change in vdsm[master]: bridge: usage of yaml schema

2016-03-19 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: bridge: usage of yaml schema .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/54528/5/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py

Change in vdsm[master]: bridge: data verification

2016-03-19 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: bridge: data verification .. Patch Set 10: (6 comments) https://gerrit.ovirt.org/#/c/53919/10/lib/api/schemaapi.py File lib/api/schemaapi.py: Line 111

Change in vdsm[master]: virt: common handling of exceptions

2016-03-19 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: virt: common handling of exceptions .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54664 To unsubscribe, visit https

Change in vdsm[master]: bridge: usage of yaml schema

2016-03-19 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: bridge: usage of yaml schema .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/54528/5/lib/vdsm/rpc/Bridge.py File lib/vdsm/rpc/Bridge.py: Line 1

Change in vdsm[master]: bridge: fix naming style

2016-03-19 Thread piotr . kliczewski
Piotr Kliczewski has uploaded a new change for review. Change subject: bridge: fix naming style .. bridge: fix naming style Change-Id: I149b233303a7bddfc52a7d690e77ae91b8152f84 Signed-off-by: pkliczewski --- M lib/vdsm/rpc

Change in vdsm[master]: bridge: usage of yaml schema

2016-03-19 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: bridge: usage of yaml schema .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/54528/6/lib/api/schemaapi.py File lib/api/schemaapi.py: Line 48 Line

Change in vdsm[master]: contrib: schema converter

2016-03-19 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 22: (2 comments) https://gerrit.ovirt.org/#/c/52864/22/lib/api/vdsmapi.py File lib/api/vdsmapi.py: Line 333

Change in vdsm[master]: contrib: schema converter

2016-03-19 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 22: (1 comment) https://gerrit.ovirt.org/#/c/52864/22//COMMIT_MSG Commit Message: Line 8: Line 9: As part of this

Change in vdsm[master]: net tests: IPv6 autoconf with RA server

2016-03-19 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: net tests: IPv6 autoconf with RA server .. Patch Set 6: Can we revert this change? I can see: ERROR: test_local_auto_with_dynamic_address_from_ra

Change in vdsm[master]: api: remove unused methods

2016-03-19 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: api: remove unused methods .. Patch Set 5: ping -- To view, visit https://gerrit.ovirt.org/53673 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: contrib: schema converter

2016-03-19 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 22: (2 comments) https://gerrit.ovirt.org/#/c/52864/22/contrib/schema-converter File contrib/schema-converter: Line

Change in vdsm[master]: api: remove unused methods

2016-03-19 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: api: remove unused methods .. Patch Set 5: Verified+1 Rebase only, no code changes. Verified by running local build. -- To view, visit https

Change in vdsm[master]: contrib: schema converter

2016-03-21 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 23: (5 comments) https://gerrit.ovirt.org/#/c/52864/23/contrib/schema-converter File contrib/schema-converter: Line

Change in vdsm[master]: bridge: fix naming style

2016-03-21 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: bridge: fix naming style .. Patch Set 2: Verified+1 Change verified by host deploying vdsm, configuring a data domain and running single vm. -- To view

Change in vdsm[master]: contrib: schema converter

2016-03-21 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 24: Verified+1 Change verified by host deploying vdsm, configuring a data domain and running single vm. -- To view

Change in vdsm[master]: bridge: usage of yaml schema

2016-03-21 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: bridge: usage of yaml schema .. Patch Set 7: Verified+1 Change verified by host deploying vdsm, configuring a data domain and running single vm. -- To

Change in vdsm[master]: bridge: data verification

2016-03-21 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: bridge: data verification .. Patch Set 12: Verified+1 Change verified by host deploying vdsm, configuring a data domain and running single vm. -- To view

Change in vdsm[master]: json: removal of old schemas

2016-03-21 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: json: removal of old schemas .. Patch Set 7: Verified+1 Change verified by host deploying vdsm, configuring a data domain and running single vm. -- To

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

2016-03-22 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: exception: Add exceptions for vdsm.define errors .. Patch Set 24: Code-Review+2 Looks good to me, we need a patch which would make errors code part of api

Change in vdsm[master]: bridge: data verification

2016-03-22 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: bridge: data verification .. Patch Set 13: Verified+1 Fixed build verification issue. No other code changes. -- To view, visit https://gerrit.ovirt.org

Change in vdsm[master]: bridge: usage of yaml schema

2016-03-22 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: bridge: usage of yaml schema .. Patch Set 8: Verified+1 Added changes in jsonrpcvdscli to fix vm migration issue. Client verified by running subset of

Change in vdsm[master]: json: removal of old schemas

2016-03-22 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: json: removal of old schemas .. Patch Set 8: Verified+1 Added changes in jsonrpcvdscli to fix vm migration issue. Client verified by running subset of

Change in vdsm[master]: net: IP address hosttail split tool

2016-03-22 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: net: IP address hosttail split tool .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54312 To unsubscribe, visit https

Change in vdsm[master]: vm: events: don't abort creation if event fails

2016-03-22 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: vm: events: don't abort creation if event fails .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/54933/3/vdsm/virt/vm.py File vdsm/virt/vm.py:

Change in vdsm[master]: hostdev: add support for hotunplug

2016-03-22 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: hostdev: add support for hotunplug .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/42747/6/lib/api/vdsmapi-schema.json File lib/api/vdsmapi

<    2   3   4   5   6   7   8   9   10   11   >