[vpp-dev] Kubernetes and contiv vpp issue

2019-11-20 Thread Mohamed feroz Abdul majeeth
Hi Team, We add sample( sample.so) plugins with existing vpp plugins. I used 3.3.2 tag contiv vpp and copied sample plugins related code *patches *.diff under contiv vpp patches folder( vpp/ docker/ vpp- vswitch /vpp/ patches). Patches also applied correctly and able to create the contiv/vswitch

[vpp-dev] CI Jobs being marked as unstable.

2019-11-20 Thread Paul Vinciguerra
Can someone please review https://gerrit.fd.io/r/c/vpp/+/23574 The containers may also need to have make install-dep run.  I'm not sure on how they are configured. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14652):

Re: [vpp-dev] VPP New plugin intergation

2019-11-20 Thread Caffeine Coder via Lists.Fd.Io
Why can't you just add your plugin to run after ethernet-input and enable it on all physical interfaces so that you can avoid spanning. For your approach, are you sure you added your node to run after span-input and correctly placed on a feature-arc?pls run "show vlib graph" it will tell you

Re: [vpp-dev] Change to Gerrit

2019-11-20 Thread Paul Vinciguerra
Hi Andrew. That used to be the case, not anymore. See: https://gerrit.fd.io/r/c/vpp/+/23521 . Changing just the commit via the UI, triggers everything. Paul On Wed, Nov 20, 2019 at 6:56 PM Andrew  Yourtchenko wrote: > Does this idea keep in mind a corner case of editing the commit message >

Re: [vpp-dev] Change to Gerrit

2019-11-20 Thread Andrew Yourtchenko
Does this idea keep in mind a corner case of editing the commit message over the gerrit UI? That operation currently doesn’t trigger the rebuilds... (Though i tend to use it for a quick edit to recover a checkstyle error, so I would rather have it trigger the checkstyle :-) If these things

Re: [vpp-dev] Change to Gerrit

2019-11-20 Thread Damjan Marion via Lists.Fd.Io
+1 > On 20 Nov 2019, at 19:32, Paul Vinciguerra wrote: > > How would the group feel about implementing something like [0], so that > changes to the commit message don't trigger rebuilds? > > To enforce the commit message structure, we could skip the jobs and set > verify label after the

Re: [vpp-dev] Requesting feedback on a change.

2019-11-20 Thread Florin Coras
Quick reply wrt to point 2. This is just the way I separate things, others may have different opinions: - I believe perror is called after some syscall fails. Alternatively, clib_unix_error/clib_unix_warning maybe used for the same purpose - If by local loggers you mean the vlib log infra, that

Re: [EXTERNAL] [vpp-dev] Change to Gerrit

2019-11-20 Thread Chris Luke
+1 From: vpp-dev@lists.fd.io On Behalf Of Paul Vinciguerra Sent: Wednesday, November 20, 2019 1:33 PM To: vpp-dev@lists.fd.io Subject: [EXTERNAL] [vpp-dev] Change to Gerrit How would the group feel about implementing something like [0], so that changes to the commit message don't trigger

Re: [vpp-dev] Change to Gerrit

2019-11-20 Thread Dave Barach via Lists.Fd.Io
+1 From: vpp-dev@lists.fd.io On Behalf Of Paul Vinciguerra Sent: Wednesday, November 20, 2019 1:33 PM To: vpp-dev@lists.fd.io Subject: [vpp-dev] Change to Gerrit How would the group feel about implementing something like [0], so that changes to the commit message don't trigger rebuilds? To

Re: [vpp-dev] Change to Gerrit

2019-11-20 Thread Florin Coras
+1 Florin > On Nov 20, 2019, at 10:32 AM, Paul Vinciguerra > wrote: > > How would the group feel about implementing something like [0], so that > changes to the commit message don't trigger rebuilds? > > To enforce the commit message structure, we could skip the jobs and set > verify

[vpp-dev] Change to Gerrit

2019-11-20 Thread Paul Vinciguerra
How would the group feel about implementing something like [0], so that changes to the commit message don't trigger rebuilds? To enforce the commit message structure, we could skip the jobs and set verify label after the codestyle checks if no files were changed. Maybe others don't care, but I

[vpp-dev] Requesting feedback on a change.

2019-11-20 Thread Paul Vinciguerra
I introduced a change [0] that passes the CI gate, but it does so, because it it not actually tested by the CI.  ;P 1. For it to be tested properly, I need to reduce the number of cpu's exposed to vpp, and that requires running with elevated privileges [CAP_SYS_NICE] from what I can tell. We

Re: [vpp-dev] VPP New plugin intergation

2019-11-20 Thread Muthukumar Sivaperumal
Hi Dave, Actually while enabling my plugin on physical interface after spanning traffic from physical interface to physical interface I could see the packets on my plugin. But enabling my plugin on virtual interface after spanning traffic from physical interface to virtual interface I

Re: [vpp-dev] VPP New plugin intergation

2019-11-20 Thread Dave Barach via Lists.Fd.Io
Does “show interface VirtualEthernet0/0/0 features” show your output feature? You might try “trace add dpdk-input 10” and “show trace” to see what’s happening to packet received on GigabitEthernet0/8/0. The story about debug messages not appearing makes me wonder if you’re actually running the

[vpp-dev] VPP New plugin intergation

2019-11-20 Thread muthukumar . sivaperumal
Hi Team, We are  trying to implement a plugin to process all packets on virtual interface. We are doing span  from physical interface to virtual interface on vpp,by running plugin arc node with interface-output. We are facing some problems. Could you please help us to resolve the issue by

[vpp-dev] Coverity run FAILED as of 2019-11-20 14:01:25 UTC

2019-11-20 Thread Noreply Jenkins
Coverity run failed today. Current number of outstanding issues are 5 Newly detected: 0 Eliminated: 0 More details can be found at https://scan.coverity.com/projects/fd-io-vpp/view_defects -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14638):

Re: [vpp-dev] centos + vpp : while creating host-interface , error : permission denied / bad file descriptor

2019-11-20 Thread Benoit Ganne (bganne) via Lists.Fd.Io
It should be fixed since 19.08 by this commit: https://gerrit.fd.io/r/c/vpp/+/19646 Gaoxf, can you check if it is fixed in 19.08? I understood you tested only 18.04 and 19.01. ben > -Original Message- > From: Dave Barach (dbarach) > Sent: mercredi 20 novembre 2019 14:08 > To: Benoit

Re: [vpp-dev] centos + vpp : while creating host-interface , error : permission denied / bad file descriptor

2019-11-20 Thread Dave Barach via Lists.Fd.Io
If you figure out the missing / incorrect SELinux rule, please let us know and/or push a patch... Thanks... Dave -Original Message- From: vpp-dev@lists.fd.io On Behalf Of Benoit Ganne (bganne) via Lists.Fd.Io Sent: Wednesday, November 20, 2019 3:48 AM To: xfg ; vpp-dev@lists.fd.io Cc:

Re: [vpp-dev] UDP echo server-session-queue node TX event issue

2019-11-20 Thread Shiva Shankar
Hi Florin, Thank you for replying. Sure, I will test with half-duplex mode. Shiva On Wed, Nov 20, 2019 at 7:44 AM Florin Coras wrote: > Hi Shiva, > > The echo client/server code was mainly built for tcp testing and was never > made to properly work with udp (it does not support session

Re: [vpp-dev] centos + vpp : while creating host-interface , error : permission denied / bad file descriptor

2019-11-20 Thread xfg
Wow, it works. Thank you very much!~ Regards, gaoxf -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14634): https://lists.fd.io/g/vpp-dev/message/14634 Mute This Topic: https://lists.fd.io/mt/60756275/21656 Group Owner: vpp-dev+ow...@lists.fd.io

Re: [vpp-dev] centos + vpp : while creating host-interface , error : permission denied / bad file descriptor

2019-11-20 Thread Benoit Ganne (bganne) via Lists.Fd.Io
Did you try to disable SELinux? ~# setenforce 0 I think VPP is missing some SELinux rules on CentOS. ben > -Original Message- > From: vpp-dev@lists.fd.io On Behalf Of xfg > Sent: mercredi 20 novembre 2019 06:46 > To: vpp-dev@lists.fd.io > Subject: [vpp-dev] centos + vpp : while