Re: [Wikitech-l] MediaWiki Technical Debt

2014-10-27 Thread Erik Bernhardson
On Fri, Oct 24, 2014 at 3:37 PM, Addshore addshorew...@gmail.com wrote: I did some work toward getting scrutinizer some time ago including the following pull req that has been merged (and I guess deployed now) as prior to this the inspection crashed out.

Re: [Wikitech-l] MediaWiki Technical Debt

2014-10-24 Thread Addshore
The maximum allowed limit is 5000 issues. We currently only have 3886 (or thats what the scan is currently showing... It would be great to get the .scrutinizer.yml file in the git repo so that we can see what inspections are actually being run and people can poke them! I did some work toward

[Wikitech-l] MediaWiki Technical Debt

2014-10-23 Thread Tyler Romeo
Found this today: https://twitter.com/symfony_en/status/525222757567827968 It's probably a useless statistic, but I still found it amusing. Good to know we still have less technical debt than WordPress. ;) *-- * *Tyler Romeo* Stevens Institute of Technology, Class of 2016 Major in Computer

Re: [Wikitech-l] MediaWiki Technical Debt

2014-10-23 Thread Jeroen De Dauw
Hey, I've looked at the code and it's quality of most of these projects at some point in the last two years, and have to say this graph is much in line with my impressions. And with what the knowledgeable people at PHP conferences and meetups convey. Want an example of bad code? Wordpress! Want

Re: [Wikitech-l] MediaWiki Technical Debt

2014-10-23 Thread David Gerard
On 23 October 2014 16:16, Jeroen De Dauw jeroended...@gmail.com wrote: I've looked at the code and it's quality of most of these projects at some point in the last two years, and have to say this graph is much in line with my impressions. And with what the knowledgeable people at PHP

Re: [Wikitech-l] MediaWiki Technical Debt

2014-10-23 Thread Tyler Romeo
Much agreed on this. I tried out SensioLabsInsight once or twice, and overall it has never given me anything useful that PhpStorm’s built-in inspections did not already catch. --  Tyler Romeo 0x405D34A7C86B42DF On October 23, 2014 at 11:17:22, Jeroen De Dauw (jeroended...@gmail.com) wrote:

Re: [Wikitech-l] MediaWiki Technical Debt

2014-10-23 Thread Jan Zerebecki
Actual results for mediawiki core: https://insight.sensiolabs.com/projects/8b5d527f-f70c-4fc0-977f-de99743eae06/analyses/16 Over all I think making stuff more testable with phpunit is much more important than going through any parts of that report. On 2014-10-23 17:16, Jeroen De Dauw wrote:

Re: [Wikitech-l] MediaWiki Technical Debt

2014-10-23 Thread Antoine Musso
Le 23/10/2014 14:46, Tyler Romeo a écrit : Found this today: https://twitter.com/symfony_en/status/525222757567827968 It's probably a useless statistic, but I still found it amusing. Good to know we still have less technical debt than WordPress. ;) Hello, Since a friend introduced me to

Re: [Wikitech-l] MediaWiki Technical Debt

2014-10-23 Thread Brian Wolff
Some more examples that might be useful in some form: - Global variable or function should never be used (This is probably the only really useful one, because removing global functions/variables would result in better testable code.) - PHP debug statements found In maintenance scripts and

Re: [Wikitech-l] MediaWiki Technical Debt

2014-10-23 Thread Jeroen De Dauw
Hey, Since a friend introduced me to Scrutinizer yesterday and the graph above seems to be based on it, SensioLabsInsight != ScrutinizerCI I added mediawiki/core to their interface: https://scrutinizer-ci.com/g/wikimedia/mediawiki/ Yay. I tried doing this a year ago or so, and back at that