Re: add minimal ctxtcall.h

2008-09-09 Thread Rob Shearman
2008/9/8 Louis. Lenders [EMAIL PROTECTED]: +typedef HRESULT (*PFNCONTEXTCALL)(ComCallData *pparam); You don't explicitly tell widl that this function is a __stdcall function. Please check if that is automatically added in the generated header file. If not, you'll have to specify it here. +

Re: Simplify tools/wrc a bit (RESEND)

2008-09-09 Thread Alexandre Julliard
Gerald Pfeifer [EMAIL PROTECTED] writes: Any thoughts on this patch? It breaks the WANT_NEAR_INDICATION case. -- Alexandre Julliard [EMAIL PROTECTED]

Re: mshtml: Implement HTMLElement2 get_scrollLeft

2008-09-09 Thread Alexandre Julliard
Alistair Leslie-Hughes [EMAIL PROTECTED] writes: @@ -831,8 +831,31 @@ static HRESULT WINAPI HTMLElement2_put_scrollLeft(IHTMLElement2 *iface, long v) static HRESULT WINAPI HTMLElement2_get_scrollLeft(IHTMLElement2 *iface, long *p) { HTMLElement *This = HTMLELEM2_THIS(iface); -

Re: [1/5] secur32: Require gnutls for schannel

2008-09-09 Thread Alexandre Julliard
Henri Verbeet [EMAIL PROTECTED] writes: diff --git a/dlls/secur32/Makefile.in b/dlls/secur32/Makefile.in index df9695a..9805d92 100644 --- a/dlls/secur32/Makefile.in +++ b/dlls/secur32/Makefile.in @@ -6,6 +6,8 @@ MODULE= secur32.dll IMPORTLIB = secur32 IMPORTS = netapi32 advapi32

Re: notepad: Only append .txt to missing files without a dot in them (try2)

2008-09-09 Thread Rob Shearman
2008/9/8 Alexander Nicolaysen Sørnes [EMAIL PROTECTED]: -if (!lstrcmp(txtW, cmdline + lstrlen(cmdline) - lstrlen(txtW))) +if (strchrW(PathFindFileNameW(cmdline), '.')) You're using one shell helper function already so why not use PathFindExtensionW instead? -- Rob

coverity ... new run finally

2008-09-09 Thread Marcus Meissner
Hi folks, A new Coverity run (274) was done finally, so we can restart looking at issues ;) Still a lot of NULL ptr migration issues which suck to fix, but well. Ciao, Marcus

Re: Patchwatcher security improvements

2008-09-09 Thread Dan Kegel
On Mon, Sep 8, 2008 at 9:01 PM, Austin English [EMAIL PROTECTED] wrote: On Mon, Sep 8, 2008 at 6:06 PM, Dan Kegel [EMAIL PROTECTED] wrote: Interesting.One of my goals is to support Solaris and BSD; have you tried your stuff there? What about OS X? Yes, of course.

Re: user32/test Added test about window sizes

2008-09-09 Thread Michael Karcher
Am Dienstag, den 09.09.2008, 14:13 +0200 schrieb Florian Köberle: +ok( width == 500 height == 6, rect is not 6x6 but %dx%d: %d,%d-%d,%d\n, +width, height, rect.left, rect.top, rect.right, rect.bottom); [...] +ok( width == 6 height == 500, rect is not 6x6 but

Re: user32.dll: Add stub for LockWorkStation

2008-09-09 Thread Rob Shearman
2008/9/8 Steven Edwards [EMAIL PROTECTED]: On Mon, Sep 8, 2008 at 2:32 PM, Paul Chitescu [EMAIL PROTECTED] wrote: Changelog: user32.dll: Stub for LockWorkStation() Not sure if user_main.c is the right place but I put it together with ExitWindowsEx. Would you mind taking a shot at

Re: socket errors...

2008-09-09 Thread celticht32
Ok thanks... so its safe to ignore which is what I was wondering =) Chris -Original Message- From: Damjan Jovanovic [EMAIL PROTECTED] To: [EMAIL PROTECTED] Cc: wine-devel wine-devel@winehq.org Sent: Tue, 9 Sep 2008 1:01 am Subject: Re: socket errors... On Tue, Sep 9,

Patchwatcher status: added urlmon:protocol.c and urlmon:url.c to blacklist

2008-09-09 Thread Dan Kegel
These tests failed randomly for a few people: urlmon:url.c:2125: Test succeeded inside todo block: unexpected OnProgress_CONNECTING urlmon:url.c:2129: Test failed: expected OnProgress_SENDINGREQUEST urlmon:url.c:2131: Test failed: expected OnResponse urlmon:protocol.c:1597: Test failed: Read

re: coverity ... new run finally

2008-09-09 Thread Dan Kegel
Marcus wrote: A new Coverity run (274) was done finally, so we can restart looking at issues ;) Still a lot of NULL ptr migration issues which suck to fix, but well. Yay! Here are the new errors introduced since the end of May, sorted by source file. There are only 23 not in test code: 725

I just found out that when the input content is alread y GB2312, “wine” automatica lly mistakes it for unicode

2008-09-09 Thread hawaii.wine wong
*Hi there, I am a Chinese programmer. I have a problem here with wine As we know wine is able to convert unicode to GB2312-- but weirdly, I just found out that when the input content is already GB2312, wine automatically mistakes it for unicode and therefore attempts to convert it again—and of

Re: coverity ... new run finally

2008-09-09 Thread Reece Dunn
2008/9/9 Dan Kegel [EMAIL PROTECTED]: Marcus wrote: A new Coverity run (274) was done finally, so we can restart looking at issues ;) Still a lot of NULL ptr migration issues which suck to fix, but well. Sure would be nice if Coverity could identify the cl which introduced each problem

Re: I just found out that when the input content is alre ady GB2312, “wine” automatic ally mistakes it for unicode

2008-09-09 Thread Rob Shearman
2008/9/9 hawaii.wine wong [EMAIL PROTECTED]: Hi there, I am a Chinese programmer. I have a problem here with wine As we know wine is able to convert unicode to GB2312-- but weirdly, I just found out that when the input content is already GB2312, wine automatically mistakes it for unicode

[PATCH] Open file in binary mode to work around a windows bug

2008-09-09 Thread Steven Edwards
-- Steven Edwards There is one thing stronger than all the armies in the world, and that is an idea whose time has come. - Victor Hugo From d7e5946566433ee18ffda721dd48bd026ec8ee71 Mon Sep 17 00:00:00 2001 From: Steven Edwards [EMAIL PROTECTED] Date: Wed, 10 Sep 2008 09:18:14 -0400 Subject:

Re: [PATCH] Open file in binary mode to work around a windows bug

2008-09-09 Thread Dmitry Timoshkov
Steven Edwards [EMAIL PROTECTED] wrote: [PATCH] Open file in binary mode to work around a windows bug What bug is that? If that's a Windows bug why Wine needs to be patched? -- Dmitry.

Re: I just found out that when the input content is alre ady GB2312, “wine” automatic ally mistakes it for unicode

2008-09-09 Thread hawaii.wine wong
I am using some third party apps developed in Chinese GB2312 by some Chinese companies(in china, usually the companies use GB 2312) OS info: Linux version 2.6.24-19-generic ([EMAIL PROTECTED]) (gcc version 4.2.3 (Ubuntu 4.2.3-2ubuntu7)) #1 SMP Wed Aug 20 22:56:21 UTC 2008 wine-1.1.4( install

Re: [PATCH] Open file in binary mode to work around a windows bug

2008-09-09 Thread Rob Shearman
2008/9/9 Dmitry Timoshkov [EMAIL PROTECTED]: Steven Edwards [EMAIL PROTECTED] wrote: [PATCH] Open file in binary mode to work around a windows bug What bug is that? If that's a Windows bug why Wine needs to be patched? It's not a bug. When opening a file in text mode on Windows, all LFs will

Re: I just found out that when the input content is alre ady GB2312, “wine” automatic ally mistakes it for unicode

2008-09-09 Thread Rob Shearman
2008/9/9 hawaii.wine wong [EMAIL PROTECTED]: I am using some third party apps developed in Chinese GB2312 by some Chinese companies(in china, usually the companies use GB 2312) OS info: Linux version 2.6.24-19-generic ([EMAIL PROTECTED]) (gcc version 4.2.3 (Ubuntu 4.2.3-2ubuntu7)) #1 SMP

Re: I just found out that when the input content is alre ady GB2312, “wine” automatic ally mistakes it for unicode

2008-09-09 Thread hawaii.wine wong
In simple words, i use a app that's text written in gb2312, wine can not show that correctly. i use ubuntu and it has support for gb2312 , because i can use gedit to read text encoding in gb2312 . On Tue, Sep 9, 2008 at 11:14 PM, Rob Shearman [EMAIL PROTECTED] wrote: 2008/9/9 hawaii.wine wong

Launching a Linux Executable from a Windows app Running under Wine

2008-09-09 Thread Mike Engelhardt
I write a Windows application that I want to be useful under Linux WINE. I want to use xchm to view the help documentation .chm file since WINE doesn't yet properly display this .chm file which was generated with third party tools and includes advanced features. xchm does render the file

Re: Simplify dlls/atl/registrar.c

2008-09-09 Thread Rob Shearman
2008/9/7 Gerald Pfeifer [EMAIL PROTECTED]: --- dlls/atl/registrar.c7 May 2008 12:06:02 - 1.29 +++ dlls/atl/registrar.c7 Sep 2008 13:42:54 - @@ -661,7 +661,7 @@ static const IRegistrarVtbl RegistrarVtb Registrar_ResourceUnregister, }; -static HRESULT

Re: I just found out that when the input content is alre ady GB2312, “wine” automatic ally mistakes it for unicode

2008-09-09 Thread Rob Shearman
2008/9/9 hawaii.wine wong [EMAIL PROTECTED]: In simple words, i use a app that's text written in gb2312, wine can not show that correctly. i use ubuntu and it has support for gb2312 , because i can use gedit to read text encoding in gb2312 . So, you're trying to type text into the

Re: I just found out that when the input content is alre ady GB2312, “wine” automatic ally mistakes it for unicode

2008-09-09 Thread hawaii.wine wong
i can not type Chinese into notepad and the code follows also can not work correctly it'soutput was 45 ��� not 45 你好 //winegcc -o test test.c #includestdio.h //#includewindows.h #include locale.h int main() { int i; int sum=0; for( i=0 ; i 10 ; i++ ){ sum+=i; }

Re: [PATCH] Open file in binary mode to work around a windows bug

2008-09-09 Thread Steven Edwards
On Tue, Sep 9, 2008 at 11:10 AM, Rob Shearman [EMAIL PROTECTED] wrote: 2008/9/9 Dmitry Timoshkov [EMAIL PROTECTED]: Steven Edwards [EMAIL PROTECTED] wrote: [PATCH] Open file in binary mode to work around a windows bug What bug is that? If that's a Windows bug why Wine needs to be patched?

Re: coverity ... new run finally

2008-09-09 Thread Juan Lang
Hi Dan, There are only 23 not in test code: am I confused by this statement? The following sure seem to be in test code, unless I misunderstand your meaning: 726 OVERRUN_STATIC test_EnumGroupsInGroup dplayx/tests/dplayx.c 722 FORWARD_NULLtest_OpenRequest

Re: user32.dll: Implementation for LockWorkStation() based on xdg-screensaver

2008-09-09 Thread Michael Karcher
Am Dienstag, den 09.09.2008, 18:25 +0300 schrieb Paul Chitescu: Known problems: 1. Although trying to check with access() if /usr/bin/xdg-screensaver is executable there is no error returned from spawnvp() if exec() eventually fails after fork() succeeds. Unlikely but possible. I see that as

Re: user32.dll: Implementation for LockWorkStation() based on xdg-screensaver

2008-09-09 Thread Steven Edwards
On Tue, Sep 9, 2008 at 11:25 AM, Paul Chitescu [EMAIL PROTECTED] wrote: Changelog: user32.dll: Implementation for LockWorkStation() based on xdg-screensaver Thanks to Steven Edwards ([EMAIL PROTECTED]) for the idea of using xdg-screensaver lock. When I submitted the patch before,

Re: James Hawkins : netapi32: Fix two failing tests in NT4.

2008-09-09 Thread Kai Blin
On Wednesday 03 September 2008 14:43:55 Alexandre Julliard wrote: -ok(ret == NERR_BadUsername, Adding user with too long username returned 0x%08x\n, ret); +ok(ret == NERR_BadUsername || + broken(ret == NERR_PasswordTooShort), /* NT4 */ + Adding user with

Re: Launching a Linux Executable from a Windows app Running under Wine

2008-09-09 Thread Steven Edwards
On Tue, Sep 9, 2008 at 11:24 AM, Mike Engelhardt [EMAIL PROTECTED] wrote: Is there a supported/recommended manner of launching an X Window System executable with Linux absolute path arguments from a MS Windows application running under Linux WINE? There is a script to invoke native apps that

Re: [PATCH] Open file in binary mode to work around a windows bug

2008-09-09 Thread Dmitry Timoshkov
Steven Edwards [EMAIL PROTECTED] wrote: If Alexandre does not apply it I will resend. Usually he doesn't apply the patches sent to wine-devel, so you have to resend. -- Dmitry.

Re: [PATCH] Open file in binary mode to work around a windows bug

2008-09-09 Thread Steven Edwards
On Tue, Sep 9, 2008 at 12:03 PM, Dmitry Timoshkov [EMAIL PROTECTED] wrote: Steven Edwards [EMAIL PROTECTED] wrote: If Alexandre does not apply it I will resend. Usually he doesn't apply the patches sent to wine-devel, so you have to resend. Duh! I am being really careless today for some

Re: coverity ... new run finally

2008-09-09 Thread Dan Kegel
On Tue, Sep 9, 2008 at 8:51 AM, Juan Lang [EMAIL PROTECTED] wrote: There are only 23 not in test code: am I confused by this statement? The following sure seem to be in test code, unless I misunderstand your meaning: 726 OVERRUN_STATIC test_EnumGroupsInGroup dplayx/tests/dplayx.c 722

Re: coverity ... new run finally

2008-09-09 Thread Juan Lang
Did you count the ones I listed not in test code? I probably should have separated them out... No, I didn't. Now I understand the source of my confusion, thanks. My account appears to be closed, so I hope you don't mind if I tell you the status of the two new crypt32 reports: 725

Re: Launching a Linux Executable from a Windows app Running under Wine

2008-09-09 Thread Mike Engelhardt
Steve, On Tue, Sep 9, 2008 at 11:24 AM, Mike Engelhardt [EMAIL PROTECTED] wrote: Is there a supported/recommended manner of launching an X Window System executable with Linux absolute path arguments from a MS Windows application running under Linux WINE? There is a script to invoke

Re: ws2_32: ioctlsocket should try to check if argp is valid

2008-09-09 Thread Juan Lang
Hi Jeff, I have a stylistic complaint about your tests in this patch: +if(sock == INVALID_SOCKET) +{ +ok(0, Creating the socket failed: %d, skipping test\n, WSAGetLastError()); +return; +} If you intend to skip a test, shouldn't you use skip instead? +ret =

Re: Launching a Linux Executable from a Windows app Running under Wine

2008-09-09 Thread Rob Shearman
2008/9/9 Mike Engelhardt [EMAIL PROTECTED]: Steve, On Tue, Sep 9, 2008 at 11:24 AM, Mike Engelhardt [EMAIL PROTECTED] wrote: Is there a supported/recommended manner of launching an X Window System executable with Linux absolute path arguments from a MS Windows application running under

Re: ws2_32: ioctlsocket should try to check if argp is valid

2008-09-09 Thread Jeff Zaroyko
On Wed, Sep 10, 2008 at 2:57 AM, Juan Lang [EMAIL PROTECTED] wrote: Hi Jeff, I have a stylistic complaint about your tests in this patch: +if(sock == INVALID_SOCKET) +{ +ok(0, Creating the socket failed: %d, skipping test\n, WSAGetLastError()); +return; +} If

Re: coverity ... new run finally

2008-09-09 Thread Alexander Dorofeyev
Dan Kegel wrote: Still a lot of NULL ptr migration issues which suck to fix, but well. 709 DEADCODEDEVENUM_ReadPinTypesdevenum/createdevenum.c 717 FORWARD_NULLDEVENUM_ReadPinTypesdevenum/createdevenum.c NULL-dereference may be a false positive from the way memory

Re: Patchwatcher online

2008-09-09 Thread Detlef Riekenberg
On Fr, 2008-09-05 at 10:24 -0700, Dan Kegel wrote: The results page http://kegel.com/wine/patchwatcher/results/ looks nice and green; Opps, all developer send there Patches in September with 09 as minute, and in August with 08 ... :-) And it would be very nice, when you hide the

Re: Patchwatcher online

2008-09-09 Thread Dan Kegel
On Tue, Sep 9, 2008 at 11:37 AM, Detlef Riekenberg [EMAIL PROTECTED] wrote: http://kegel.com/wine/patchwatcher/results/ Opps, all developer send there Patches in September with 09 as minute, and in August with 08 ... Whoops! And it would be very nice, when you hide the Email-Address to

Re: ws2_32: ioctlsocket should try to check if argp is valid (try 2)

2008-09-09 Thread Juan Lang
Hi Jeff, +if(sock == INVALID_SOCKET) +skip(Creating the socket failed: %d, skipping test.\n, WSAGetLastError()); skip needs a return too. +ret = ioctlsocket(sock, cmds[i], (u_long *)1); +if(ok(ret == SOCKET_ERROR, ioctlsocket succeeded unexpectedly\n)) +{ I

Re: ws2_32: ioctlsocket should try to check if argp is valid (try 2)

2008-09-09 Thread Jeff Zaroyko
On Wed, Sep 10, 2008 at 4:55 AM, Juan Lang [EMAIL PROTECTED] wrote: Hi Jeff, +if(sock == INVALID_SOCKET) +skip(Creating the socket failed: %d, skipping test.\n, WSAGetLastError()); skip needs a return too. +ret = ioctlsocket(sock, cmds[i], (u_long *)1); +

Re: Patchwatcher online

2008-09-09 Thread Henri Verbeet
2008/9/9 Dan Kegel [EMAIL PROTECTED]: And it would be very nice, when you hide the Email-Address to block the bots, who collect spam targets. Is that needed, given how the addresses are in the open on the mailing list and all its archives? I doubt it, we're probably on every possible spam

splint (Re: Adding Flawfinder to Patchwatcher)

2008-09-09 Thread Detlef Riekenberg
On So, 2008-09-07 at 18:10 +, Jason Spiro wrote: Other people may be able to suggest more good tools. AFAIK splint is one of the most popular OSS static analysis tools, but I've never really used it. Has anyone here used it? On the flawfinder homepage, it says that splint does

Re: msi: Uninitialized variable fix (Coverity)

2008-09-09 Thread James Hawkins
On Tue, Sep 9, 2008 at 3:54 PM, Andrew Talbot [EMAIL PROTECTED] wrote: Fix for Coverity error CID: 762. --- Changelog: msi: Uninitialized variable fix (Coverity). diff --git a/dlls/msi/action.c b/dlls/msi/action.c index 8a8efe7..48557f0 100644 --- a/dlls/msi/action.c +++

Re: msi: Uninitialized variable fix (Coverity)

2008-09-09 Thread Andrew Talbot
James Hawkins wrote: On Tue, Sep 9, 2008 at 3:54 PM, Andrew Talbot [EMAIL PROTECTED] wrote: Fix for Coverity error CID: 762. [...] -RegCloseKey(userdata); +if (userdata) RegCloseKey(userdata); return rc; Please don't add another NULL-before-free check. Hi James, Sorry,

Re: msi: Uninitialized variable fix (Coverity)

2008-09-09 Thread James Hawkins
On Tue, Sep 9, 2008 at 4:24 PM, Andrew Talbot [EMAIL PROTECTED] wrote: James Hawkins wrote: On Tue, Sep 9, 2008 at 3:54 PM, Andrew Talbot [EMAIL PROTECTED] wrote: Fix for Coverity error CID: 762. [...] -RegCloseKey(userdata); +if (userdata) RegCloseKey(userdata); return rc;

Re: coverity ... new run finally

2008-09-09 Thread Dan Kegel
alexd4 asked: is there more details available on what and where it detects in the function (free of charge)? Yes. See http://scan.coverity.com/devfaq.html#account - Dan

Re: msi: Uninitialized variable fix (Coverity)

2008-09-09 Thread Juan Lang
Hi Andy, Sorry, I don't understand what I have done wrong. RegCloseKey() will return ERROR_INVALID_HANDLE if called with hkey==NULL. To expand on James's brief response, -HKEY userdata; +HKEY userdata = NULL; This change looks correct, but the other isn't necessary. --Juan

Re: msi: Uninitialized variable fix (Coverity)

2008-09-09 Thread Andrew Talbot
James Hawkins wrote: Sorry, I don't understand what I have done wrong. RegCloseKey() will return ERROR_INVALID_HANDLE if called with hkey==NULL. ...and we don't care what value it returns. Ah, of course! Thanks, James (and Juan). -- Andy.

Re: Debugging applications running on wine

2008-09-09 Thread Kevin Krieser
On Sep 8, 2008, at 9:36 PM, Dan Kegel wrote: Kevin K wrote: Is winedbg the only method of debugging applications being developed for Windows on Wine? For instance, assume a program developed with Visual Studio in C or C++, and I needed to debug it on Linux? If winedbg doesn't work for

Praise of sorts for Wine re Softmaker Office 2008

2008-09-09 Thread Dan Kegel
http://forum.ubuntuusers.de/topic/softmaker-office-2008--eine-alternative--vora/ has a review of an office suite named Softmaker Office 2008, available for Windows and now also Linux. The review says in part Irritiert hat uns, daß die Windows-Version von Office 2008, die von Stick gestartet