Re: RFC: Adding Mac support to secur32/schannel.c

2011-01-31 Thread Juan Lang
Hi Ken, thanks for the reply. > As Henri said, it's that it's a set of external dependencies (not just one; > GnuTLS has its own dependencies) and that they are security-related.  To the > greatest extent practical, security-related libraries should come from one's > distro or OS vendor. Sure,

Re: RFC: Adding Mac support to secur32/schannel.c

2011-01-31 Thread Ken Thomases
Hi Juan, On Jan 28, 2011, at 10:36 AM, Juan Lang wrote: >> I'm planning to add an alternative implementation of schannel (SSL/TLS) >> support for the Mac. The current implementation is based on GnuTLS. That >> library is not typically found on Mac OS X. Although packagers can build it >> an

Re: user32: Test for behavior of WM_SETTEXT handler regarding WM_CTLCOLOR*

2011-01-31 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8777 Your paranoid android.

Re: msvcrt: Add type_info::name_internal_method() as alias for ::name()

2011-01-31 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8775 Your paranoid android.

Re: [PATCH 2/4] d3d9/tests: Check ColorFill() return codes in color_fill_test() (LLVM/Clang).

2011-01-31 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8768 Your paranoid android.

Re: Wine Gecko 1.2.0 beta1

2011-01-31 Thread Eric Pouech
- dbghelp fixes winedbg has problems with debug info from Gecko debug build, making debugging possibilities quite limited and backtraces lacking most of the calls. This is not related to Gecko release itself, but still it would be great to have it fixed. what are your favorite steps to repro

Re: Correction to crash inside RtlCaptureStackBackTrace() + test case

2011-01-31 Thread Alexandre Julliard
Janne Hakonen writes: > Should I still add the try-except blocks to RtlCaptureStackBackTrace() > and tests for 0xfffc value also? It doesn't need a try-except block, just better wrap-around handling. -- Alexandre Julliard julli...@winehq.org

Re: Wine Gecko 1.2.0 beta1

2011-01-31 Thread Jacek Caban
On 1/31/11 6:59 PM, Jacek Caban wrote: [1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/1.2.0-beta1/ Sourceforge seems to have strange problems now. It closes connection just after downloading starts. Hopefully it will be fixed soon. Jacek

RE: Correction to crash inside RtlCaptureStackBackTrace() + test case

2011-01-31 Thread Janne Hakonen
Hi Alexandre Julliard, I see you had another idea of how to correct the RtlCaptureStackBackTrace() function. I tested your implementation with Anarchy Online's item store (ingame web browser based on Awesomium) and with AwesomiumGL (sample app from Awesomium's SDK). With AwesomiumGL I did

Re: [PATCH] Clarify 'fixme'...

2011-01-31 Thread Charles Davis
On 1/31/11 12:01 PM, m...@mtew.isa-geek.net wrote: > @@ -2519,7 +2519,7 @@ static BOOL CommitUrlCacheEntryInternal( > > if (URLCache_FindHash(pHeader, lpszUrlNameA, &pHashEntry)) > { > -FIXME("entry already in cache - don't know what to do!\n"); > +FIXME("hash matces - c

Re: user32/gdi32: Fix for a crash in create_alpha_bitmap()

2011-01-31 Thread Peter Schlaile
Hi Alexandre, On Mon, 31 Jan 2011, Alexandre Julliard wrote: And: from a design perspective it sounds very strange that a fast track optimisation *silently* changes protection bits! There's nothing silent about it, the protection bits have to match the DIB state. Hmm. In which way changes S

Re: user32/gdi32: Fix for a crash in create_alpha_bitmap()

2011-01-31 Thread Peter Schlaile
Hi Alexandre, On Mon, 31 Jan 2011, Alexandre Julliard wrote: Peter Schlaile writes: Fix: X11DRV_SetDIBits() shouldn't silently change Bitmap protection, so we now restore the protection bits, that were present before instead of always changing to READONLY. No, it needs to be read-only so

Wine Gecko 1.2.0 beta1

2011-01-31 Thread Jacek Caban
Hi all, We're nearing the time for the next Gecko update. Beta builds are done and available on Sourceforge [1]. To use them, you need to download the .cab file, put it as you usually do into the right directory (most likely wine_gecko-1.2.0-beta1-x86.cab, see [2] for details) and apply the a

Re: wined3d: Update clip planes when switching to/from offscreen rendering.

2011-01-31 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 31.01.2011 um 17:08 schrieb Matteo Bruni: > The attached patch should follow your idea, does it look right? FWIW, > I can't see any 1-pixel offset in The Sims 3 with this patch. Yes, I > know that's not how it should be tested... Looks OK on first

Re: wined3d: Update clip planes when switching to/from offscreen rendering.

2011-01-31 Thread Matteo Bruni
2011/1/31 Stefan Dösinger : > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > Am 31.01.2011 um 15:57 schrieb Henri Verbeet: > >> On 31 January 2011 15:45, Stefan Dösinger wrote: >>> >>> If we change the shader code to write gl_ClipVertex and result.clip before >>> applying the y inversion t

Re: winex11.drv: Make sure that default clipping region exists before calling ExcludeUpdateRgn().

2011-01-31 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> > I looks like the default clip region created by ExtSelectClipRgn() uses >> > the dimensions of the selected bitmap, and it's not large enough. >> >> That's a window DC, it doesn't have a selected bitmap. > > You are right. The app crea

Re: winex11.drv: Make sure that default clipping region exists before calling ExcludeUpdateRgn().

2011-01-31 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > I looks like the default clip region created by ExtSelectClipRgn() uses > > the dimensions of the selected bitmap, and it's not large enough. > > That's a window DC, it doesn't have a selected bitmap. You are right. The app creates very large child window to fit th

Re: wined3d: Update clip planes when switching to/from offscreen rendering.

2011-01-31 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 31.01.2011 um 15:57 schrieb Henri Verbeet: > On 31 January 2011 15:45, Stefan Dösinger wrote: >> >> If we change the shader code to write gl_ClipVertex and result.clip before >> applying the y inversion then we should be able to avoid this. Tha

Re: user32/gdi32: Fix for a crash in create_alpha_bitmap()

2011-01-31 Thread Alexandre Julliard
Peter Schlaile writes: > And: do you want to say, that there is a page fault handler within > wine, that can handle *that* case above? Yes, that's how DIBs work in Wine. > In either way, I hope we can agree on the following: > > a) the app is *not* broken (at least not regarding it's usage of >

Re: wined3d: Update clip planes when switching to/from offscreen rendering.

2011-01-31 Thread Henri Verbeet
On 31 January 2011 15:45, Stefan Dösinger wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > Am 31.01.2011 um 15:13 schrieb Matteo Bruni: > >> It should fix http://bugs.winehq.org/show_bug.cgi?id=25877 >> <0001-wined3d-Update-clip-planes-when-switching-to-from-offs.txt> > If we change

Re: wined3d: Update clip planes when switching to/from offscreen rendering.

2011-01-31 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 31.01.2011 um 15:13 schrieb Matteo Bruni: > It should fix http://bugs.winehq.org/show_bug.cgi?id=25877 > <0001-wined3d-Update-clip-planes-when-switching-to-from-offs.txt> If we change the shader code to write gl_ClipVertex and result.clip before

Re: [3/3] d3d9: account for another different behavior in the viewport test

2011-01-31 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I just noticed that I sent the other two mails with my gmail account, so they got stuck in moderation. This patch should apply on its own, but depending on what Alexandre commits today I'll resend the patches after today's commit wave. Am 31.01.2011

Re: winex11.drv: Make sure that default clipping region exists before calling ExcludeUpdateRgn().

2011-01-31 Thread Alexandre Julliard
Dmitry Timoshkov writes: > I looks like the default clip region created by ExtSelectClipRgn() uses > the dimensions of the selected bitmap, and it's not large enough. That's a window DC, it doesn't have a selected bitmap. -- Alexandre Julliard julli...@winehq.org

Re: winex11.drv: Make sure that default clipping region exists before calling ExcludeUpdateRgn().

2011-01-31 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > If there is no current clipping region ExtSelectClipRgn(hdc, hrgn, RGN_DIFF) > > creates its own default clipping region which in most cases doesn't match > > neither a visible region nor the window extents attached to the DC. > > It will get intersected with the vi

Re: winex11.drv: Make sure that default clipping region exists before calling ExcludeUpdateRgn().

2011-01-31 Thread Alexandre Julliard
Dmitry Timoshkov writes: > If there is no current clipping region ExtSelectClipRgn(hdc, hrgn, RGN_DIFF) > creates its own default clipping region which in most cases doesn't match > neither a visible region nor the window extents attached to the DC. It will get intersected with the visible regio

Re: [PATCH] [patch] Already in cache means nothing more to do...

2011-01-31 Thread Alexandre Julliard
m...@mtew.isa-geek.net writes: > @@ -2519,11 +2519,7 @@ static BOOL CommitUrlCacheEntryInternal( > > if (URLCache_FindHash(pHeader, lpszUrlNameA, &pHashEntry)) > { > -FIXME("entry already in cache - don't know what to do!\n"); > -/* > - *SetLastError(ERROR_FILE_NOT_FOUN

Re: user32/gdi32: Fix for a crash in create_alpha_bitmap()

2011-01-31 Thread Alexandre Julliard
Peter Schlaile writes: > At least, wine reacts very differently than windows here :) > Read: it crashes the application I mentioned in my previous mail: > http://www.phononet.de/downloads/support/downloads/Aktueller_PNClient/PNCLIENT1.9.zip > > And: from a design perspective it sounds very strang

Re: user32/gdi32: Fix for a crash in create_alpha_bitmap()

2011-01-31 Thread Alexandre Julliard
Peter Schlaile writes: > Fix: X11DRV_SetDIBits() shouldn't silently change Bitmap protection, so > we now restore the protection bits, that were present before instead of > always changing to READONLY. No, it needs to be read-only so that we can detect further changes. > Additional minor fix: