On Oct 9, 2013, at 4:49 PM, Phil Krylov wrote:
Thanks!
You're welcome.
Do you consider adding an option to stop interpreting Command as Alt?
I have not considered it. What would be gained? Do you want the Command key
interpreted as the Windows key? Do you want something else to happen
Hi,
I finally got around to working on support for Cocoa full-screen mode in the
Mac driver, based on the work of Kevin Eaves. I've attached a new patch. This
patch can only be applied on top of the other Mac driver patches I just
submitted to wine-patches.
Some changes from Kevin's
On Oct 4, 2013, at 12:17 AM, Ken Thomases wrote:
---
dlls/winemac.drv/cocoa_app.m| 8 ++--
dlls/winemac.drv/cocoa_window.h | 1 +
dlls/winemac.drv/cocoa_window.m | 16 +---
dlls/winemac.drv/event.c| 5 +
dlls/winemac.drv/macdrv.h | 1 +
dlls/winemac.drv
On Oct 1, 2013, at 11:24 PM, Ken Thomases wrote:
May fix bug http://bugs.winehq.org/show_bug.cgi?id=34475.
Should fix bug http://bugs.winehq.org/show_bug.cgi?id=34209, too.
-Ken
Hi,
I have a need for a new icon in Wine and I'm hoping somebody with some
graphics-design skills might be able to create it.
The Mac driver attempts to extract an icon from the executable to use for the
Dock icon of its process. This is also the icon that appears in the
Command-Tab
On Sep 20, 2013, at 9:44 AM, Roderick Colenbrander wrote:
That change looks suspicious. If switching to i+1 fixes a problem, the real
problem is that the if-statement in question gets entered in the first
place. Some bounds checking on the outer for-loop (the one which loops
through nCfgs and
On Sep 16, 2013, at 1:21 PM, Ken Thomases wrote:
On Sep 16, 2013, at 12:55 PM, Alexandre Julliard wrote:
It's better to avoid adding entry points that don't correspond to
Windows APIs. Instead you should request the info when you need it.
Cocoa makes use of the size limits spontaneously
On Sep 16, 2013, at 12:55 PM, Alexandre Julliard wrote:
Ken Thomases k...@codeweavers.com writes:
---
dlls/user32/driver.c | 12
dlls/user32/user_private.h |1 +
dlls/user32/winpos.c |2 ++
3 files changed, 15 insertions(+), 0 deletions(-)
It's better
On Sep 12, 2013, at 12:23 AM, Dmitry Timoshkov wrote:
Ken Thomases k...@codeweavers.com wrote:
+@ cdecl __wine_get_min_max_info(long ptr ptr ptr ptr) WINPOS_GetMinMaxInfo
What's wrong with calling SendMessage(WM_GETMINMAXINFO) from the driver?
Because I would have to duplicate all
On Sep 12, 2013, at 10:48 AM, Dmitry Timoshkov wrote:
Ken Thomases k...@codeweavers.com wrote:
+@ cdecl __wine_get_min_max_info(long ptr ptr ptr ptr) WINPOS_GetMinMaxInfo
What's wrong with calling SendMessage(WM_GETMINMAXINFO) from the driver?
Because I would have to duplicate all
On Sep 10, 2013, at 5:45 AM, Phil Krylov wrote:
On Tue, Sep 10, 2013 at 6:05 AM, Ken Thomases k...@codeweavers.com wrote:
Is there a specific problem that you're trying to fix?
Yes. I didn't file a bug report yet, but an application I am using
(IBM Translation Manager) has some
Hi,
On Sep 9, 2013, at 7:38 PM, Phil Krylov wrote:
Sorry, my first try had wrong patch attached
-- Ph.
0001-winemac-Don-t-return-characters-for-Ctrl-non-letter-try2.patch.txt
Is there a specific problem that you're trying to fix?
The Mac driver's ToUnicodeEx() implementation started out
Hi,
On Aug 27, 2013, at 4:08 PM, André Hentschel wrote:
@@ -94,6 +95,9 @@ static void module_fill_module(const WCHAR* in, WCHAR* out,
size_t size)
if (len 3 !strcmpiW(out[len - 3], S_DotSoW)
(l = match_ext(out, len - 3)))
strcpyW(out[len - l - 3],
On Aug 21, 2013, at 11:49 PM, Charles Davis wrote:
On Aug 21, 2013, at 10:34 PM, Ken Thomases wrote:
On Aug 21, 2013, at 9:42 PM, Charles Davis wrote:
+static HANDLE import_utf16_to_unicodetext(CFDataRef data)
+{
+const WCHAR *src;
+unsigned long data_len;
+unsigned long
On Aug 22, 2013, at 12:07 AM, Charles Davis wrote:
Try 2: Eliminiate dead store. Sort export functions by name.
Looks OK to me.
-Ken
On Aug 20, 2013, at 10:49 PM, Charles Davis wrote:
In the Windows world, Unicode almost universally means UTF-16. So,
use the well-known UTF-16 type instead of making up our own.
I have to wonder if there was a good reason Ken didn't use this
initially.
Please hold this patch while I
On Aug 21, 2013, at 10:12 AM, Ken Thomases wrote:
On Aug 20, 2013, at 10:49 PM, Charles Davis wrote:
In the Windows world, Unicode almost universally means UTF-16. So,
use the well-known UTF-16 type instead of making up our own.
I have to wonder if there was a good reason Ken didn't use
On Aug 21, 2013, at 9:42 PM, Charles Davis wrote:
@@ -90,6 +93,9 @@ static CFDataRef export_hdrop_to_filenames(HANDLE data);
static CFDataRef export_oemtext_to_utf8(HANDLE data);
static CFDataRef export_text_to_utf8(HANDLE data);
static CFDataRef export_unicodetext_to_utf8(HANDLE data);
On Aug 8, 2013, at 5:56 PM, Austin English wrote:
+AC_ARG_WITH(winemac, AS_HELP_STRING([--without-winemac],[do not build
native Mac (Cocoa) driver]),
+[if test x$withval = xno; then
ac_cv_header_ApplicationServices_ApplicationServices_h=no; fi])
A switch to disable the Mac
On Aug 2, 2013, at 4:22 AM, Alexandre Julliard wrote:
Ken Thomases k...@codeweavers.com writes:
+/* If the Mac driver might be used, then load AppKit now before using
the Core Text API.
+ Otherwise, AppKit crashes on Mac OS X 10.7+ because CTFontDescriptor
isn't toll-free
On Aug 2, 2013, at 9:19 AM, Alexandre Julliard wrote:
Ken Thomases k...@codeweavers.com writes:
On Aug 2, 2013, at 4:22 AM, Alexandre Julliard wrote:
That's ugly. freetype.c has no business knowing about the details of the
graphics driver.
Is it acceptable to load the graphics driver
On Aug 2, 2013, at 9:57 AM, Ken Thomases wrote:
OK. So, is it acceptable to load AppKit regardless of which graphics driver
is configured?
And, if so, would you prefer that I just link gdi32 against AppKit rather than
loading it dynamically? That would mean that it would be loaded even
On Jul 24, 2013, at 9:41 PM, Ken Thomases wrote:
On Jul 24, 2013, at 9:34 PM, Charles Davis wrote:
Try 2: Don't duplicate a constant string; we might need to add more legacy
extensions. (Hopefully not. ;)
Thanks for making that change. Looks good to me.
Actually, on further thought
On Jul 25, 2013, at 9:57 AM, Ken Thomases wrote:
If vsync is disallowed, the corresponding functions are left as NULL in the
OpenGL function table, so clients may crash if WGL_EXT_swap_control is
advertised.
Well, this part is wrong. They won't crash because opengl32 protects against
On Jul 25, 2013, at 10:49 AM, Charles Davis wrote:
Try 3: Don't advertise WGL_EXT_swap_control if vsync is disabled.
Looks good.
Thanks,
Ken
Hi Qian,
On Jul 25, 2013, at 11:53 AM, Qian Hong wrote:
On Thu, Jul 25, 2013 at 2:33 AM, Ken Thomases k...@codeweavers.com wrote:
Hmm. You may need to mark the dummy array as volatile to prevent it from
being optimized away. Worth trying. You might also increase the size of
the array
On Jul 25, 2013, at 2:11 PM, Qian Hong wrote:
On Fri, Jul 26, 2013 at 2:52 AM, Ken Thomases k...@codeweavers.com wrote:
I think your Valgrind results are telling us that there's a bug in the game
where it's using an uninitialized stack variable.
There's still a chance that it's something
On Jul 24, 2013, at 12:49 PM, Qian Hong wrote:
Hi Ken,
On Sun, Jul 21, 2013 at 2:39 PM, Ken Thomases k...@codeweavers.com wrote:
Instead of enabling the trace, try replacing it with something like:
char dummy[256];
memset(dummy, 0x55, sizeof(dummy));
I bet the crash will change
Hi,
On Jul 23, 2013, at 10:26 PM, Charles Davis wrote:
@@ -1226,8 +1227,10 @@ static BOOL init_gl_info(void)
gl_info.glVersion = HeapAlloc(GetProcessHeap(), 0, strlen(str) + 1);
strcpy(gl_info.glVersion, str);
str = (const char*)opengl_funcs.gl.p_glGetString(GL_EXTENSIONS);
-
On Jul 23, 2013, at 10:26 PM, Charles Davis wrote:
This is akin to what glxdrv already does, and apparently what Windows
does. It allows the GLView sample from the OpenGL SuperBible to
correctly enumerate pixel formats with the Mac driver.
---
dlls/winemac.drv/opengl.c |2 +-
1 files
On Jul 24, 2013, at 9:34 PM, Charles Davis wrote:
Try 2: Don't duplicate a constant string; we might need to add more legacy
extensions. (Hopefully not. ;)
Thanks for making that change. Looks good to me.
Cheers,
Ken
On Jul 19, 2013, at 8:34 AM, Qian Hong wrote:
I was debugging on a popular game [1] [2] (9 GB), it crashes on start.
+relay,+seh,+tid log show that there are some calls to
wined3d.wined3d_mutex_lock / wined3d.wined3d_buffer_map /
wined3d.wined3d_mutex_unlock before crashing, so I turn on
On Jul 1, 2013, at 3:29 PM, Юрий Воротилов wrote:
Fix to support input of characters with diacritic symbols using AltGr (e.g.
Latvian - AltGr+a=ā).
Tested on Ubuntu 12.04 and Centos 6.
I also have a bug opened in Crossover tracker:
On Jul 1, 2013, at 4:26 PM, Ken Thomases wrote:
On Jul 1, 2013, at 3:29 PM, Юрий Воротилов wrote:
Fix to support input of characters with diacritic symbols using AltGr (e.g.
Latvian - AltGr+a=ā).
Tested on Ubuntu 12.04 and Centos 6.
I also have a bug opened in Crossover tracker:
http
On Jun 18, 2013, at 1:26 AM, Dmitry Timoshkov wrote:
Daniel Jeliński djelins...@gmail.com wrote:
I'm quite sure you didn't mean to ignore return value of GetStockObject and
leave logfont uninitialized here.
GetStockObject(DEFAULT_GUI_FONT) can't fail.
I think the question is: what does
Hi,
On Jun 12, 2013, at 10:47 AM, Andrey Upadyshev wrote:
I've installed a Wine 1.5.31 instead of 1.4.smthng and found that tablets
support is broken. Some research gives me that wintab32 DLL fails to init
because winemac driver doesn't implement tablet related functions
(LoadTabletInfo etc)
On Jun 4, 2013, at 5:15 AM, Dmitry Timoshkov wrote:
Ken Thomases k...@codeweavers.com wrote:
---
dlls/winemac.drv/cocoa_app.h |2 ++
dlls/winemac.drv/cocoa_app.m |3 ++-
2 files changed, 4 insertions(+), 1 deletions(-)
I wonder, do you actually run 'make test' in dlls/user32/tests
On May 29, 2013, at 10:37 AM, Aric Stewart wrote:
---
dlls/winemac.drv/cocoa_window.m | 9 +
dlls/winemac.drv/event.c| 3 --
dlls/winemac.drv/ime.c | 85 +
dlls/winemac.drv/macdrv.h | 1 -
dlls/winemac.drv/macdrv_cocoa.h | 5
On May 29, 2013, at 1:11 PM, Aric Stewart wrote:
---
dlls/winemac.drv/cocoa_window.m | 9 +
dlls/winemac.drv/event.c| 5 ---
dlls/winemac.drv/ime.c | 85 +
dlls/winemac.drv/macdrv.h | 1 -
dlls/winemac.drv/macdrv_cocoa.h | 6
On May 15, 2013, at 8:49 PM, Kevin Eaves wrote:
… The title is also empty when exiting borderless to titled, which can be
fixed here.
Hmm, good catch. I'll have to check, but I suspect the window no longer
remembers its title at that point. And the Mac driver doesn't currently store
it
On May 17, 2013, at 12:21 AM, Dmitry Timoshkov wrote:
Ken Thomases k...@codeweavers.com wrote:
dlls/user32/tests/menu.c | 21 -
Please add a message test instead, it would much more clearer show what is
going on.
I added to the existing tests of WM_CANCELMODE because
I have submitted an alternative patch to fix this issue. It ended up being
more involved.
First, on considering exactly how disabling a window should interact with its
resizability features, I decided that disabling should not remove
NSResizableWindowMask from the style mask.
Consider a
On May 12, 2013, at 3:22 PM, Ken Thomases wrote:
As mentioned in the other thread, I'm not seeing the problem that this is
meant to solve on 10.6. I will test 10.7+ tomorrow.
OK, I've tested on 10.8 and I see that the zoom button highlights when the
mouse moves over it, although clicking
great. The only real problem is with user32.
Everything else is easy to clean up and get working with Wine properly
without any issues. Just wanted to show that.
Sure, that's what I figured.
On May 9, 2013, at 9:56 PM, Ken Thomases wrote:
The fullscreen button appears if a main window
Hi Kevin,
As mentioned in the other thread, I'm not seeing the problem that this is meant
to solve on 10.6. I will test 10.7+ tomorrow. Also, I'm pretty sure that
setting the style mask after disabling the buttons can reenable them. At least
in some versions of the frameworks, we've seen
On May 9, 2013, at 1:36 PM, Alexandre Julliard wrote:
Handling external resizes
should be done in the desktop process, and most likely involves the
wineserver too. It certainly won't be an easy task.
Hmm. Then that probably means I messed it up in the Mac driver, since what I
did didn't
Hi,
On May 9, 2013, at 5:48 PM, Kevin Eaves wrote:
Attached patch is a proof-of-concept for the fullscreen APIs provided in OS X
10.7+, which allows applications to enter fullscreen in a separate desktop
space.
Thanks for this. It's quite interesting.
The fullscreen button appears if a
On Apr 29, 2013, at 10:42 AM, Roderick Colenbrander wrote:
Updated version of the patch which marks the failing test as todo_wine. The
final goal is to make the swap interval in the winex11 driver not global
anymore (and store it with the drawable) and add some new functionality.
On Apr 29, 2013, at 3:41 PM, Qian Hong wrote:
Thanks Ken for many helps!
You're welcome and, regarding the patch: looks good to me.
-Ken
On Apr 24, 2013, at 5:10 AM, Jacek Caban wrote:
On 04/24/13 11:35, Frédéric Delanoy wrote:
Although, one can sort/filter by file, or if it's really that
annoying, a quick script removing tr elements containing /tests
should be easy enough.
Well... that's far from perfect, but could work.
On Apr 23, 2013, at 2:45 AM, Sam Edwards wrote:
On 04/22/2013 07:08 PM, Ken Thomases wrote:
I can't speak to how Windows would render it, but one such font is Zapfino.
It's an exuberant calligraphic font with lots of flourishes, some of which
have strokes extending into the line above
On Apr 22, 2013, at 1:17 PM, Kirill Smirnov wrote:
While debugging bug #33307 (http://bugs.winehq.org/show_bug.cgi?id=33307)
I found a suspicious piece of code, looking like off-by-one error.
Unfortunately, I'm not familiar with this part of wine and I don't know
how to write
On Apr 22, 2013, at 6:40 PM, Sam Edwards wrote:
On 04/19/2013 10:32 AM, Max TenEyck Woodbury wrote:
As I understand it, some fonts deliberately have glyphs larger than
their metrics bounding boxes. Clipping them is almost certainly not a
good idea.
Forgive my disbelief, but can you
On Apr 16, 2013, at 3:43 AM, Simon Lipp wrote:
That's how it's supposed to work.
But it doesn’t work that way under Windows. Shouldn’t Wine try to stick
to Windows behavior as close as possible ?
Wine should never generate WM_DEADCHAR message, it relies in the
driver to handle dead keys
Hi Jacek,
On Apr 10, 2013, at 4:24 AM, Jacek Caban wrote:
On 3/28/13 8:31 PM, Ken Thomases wrote:
Mac OS X 10.8 introduced support for TLS 1.1 and 1.2.
Can someone with Mac OS X 10.8 test the attached patch for me, please. All I
need is to verify that it compiles and when running
dlls
On Apr 1, 2013, at 6:41 AM, Jacek Caban wrote:
There are still some missing features. Most notably, it lacks support
for system tray baloons.
I know; that's, like, the hardest thing to do!
Great work, though! Actually, since HTML is available everywhere, there's
little reason for me to
On Mar 28, 2013, at 2:26 AM, Per Johansson wrote:
On Wed, Mar 27, 2013 at 7:22 PM, Ken Thomases k...@codeweavers.com wrote:
---
This has probably been discussed before, but shouldn't snprintfW be
safe against this kind of thing, the way POSIX snprintf is?
I actually checked the man page
On Mar 27, 2013, at 3:31 PM, Ken Thomases wrote:
dlls/winemac.drv/macdrv.h | 12 +++-
dlls/winemac.drv/surface.c | 16 ++--
dlls/winemac.drv/window.c | 17 ++---
3 files changed, 27 insertions(+), 18 deletions(-)
0001-winemac-Track-drawn-surface-rect
On Mar 28, 2013, at 6:05 AM, Jacek Caban wrote:
--- a/dlls/secur32/schannel_macosx.c
+++ b/dlls/secur32/schannel_macosx.c
@@ -630,6 +630,11 @@ static OSStatus schan_push_adapter(SSLConnectionRef
transport, const void *buff,
return ret;
}
+DWORD schan_imp_enabled_protocols(void)
On Mar 27, 2013, at 6:41 AM, Hugh McMaster wrote:
This patch modifies the dlls/kernel32 Makefile.in to (1) compile a new source
file (screensize.c) (patch 3/3) and (2) add -lX11 to the ExtraDllFlags line.
This approach is untenable. Kernel32 can't be made to depend on X11. It has
to still
On Mar 27, 2013, at 6:08 PM, Hugh McMaster wrote:
Ken Thomases wrote:
This approach is untenable. Kernel32 can't be made to depend on X11. It
has to still work when X11 isn't available. Also, X11 is just one possible
graphics/windowing system that Wine can use, so it's not always
On Mar 8, 2013, at 6:20 AM, joerg-cyril.hoe...@t-systems.com
joerg-cyril.hoe...@t-systems.com wrote:
I had a very annoying experience: when I started winemac the first
time, the whole screen turned black for a fraction of a second. That
was very unwelcome and reminded me of the infamous
On Mar 26, 2013, at 3:20 AM, Dmitry Timoshkov wrote:
Ken Thomases k...@codeweavers.com wrote:
+ShowWindow( hwnd, SW_SHOW );
SetWindowLongPtrW( hwnd, GWLP_WNDPROC, (LONG_PTR)desktop_wnd_proc );
SendMessageW( hwnd, WM_SETICON, ICON_BIG, (LPARAM)LoadIconW( 0
On Mar 25, 2013, at 8:51 PM, Hugh McMaster wrote:
I've written a function to determine the largest possible screen buffer that
wineconsole is able to display. This function replaces the hard-coded
constants listed in both instances of GetLargestConsoleWindowSize in
dlls/kernel32/console.c.
On Mar 21, 2013, at 3:41 PM, C.W. Betts wrote:
On Mar 18, 2013, at 3:22 PM, Ken Thomases k...@codeweavers.com wrote:
On Mar 18, 2013, at 4:04 PM, Charles Davis wrote:
At this point, though, I'm wondering if it wouldn't just be easier to have
Explorer draw the balloons itself à la Windows
On Mar 22, 2013, at 1:21 AM, Ken Thomases wrote:
---
dlls/winemac.drv/window.c | 33 -
1 files changed, 16 insertions(+), 17 deletions(-)
0001-winemac-Calculate-surface-rect-correctly-in-macdrv_U.patch
Hmm. On further consideration, I'm not sure
On Mar 20, 2013, at 1:33 PM, André Hentschel wrote:
Am 18.03.2013 04:41, schrieb Ken Thomases:
---
dlls/winemac.drv/display.c | 131
dlls/winemac.drv/gdi.c |4 +-
dlls/winemac.drv/macdrv.h |2 +
3 files changed, 135 insertions(+), 2
On Mar 19, 2013, at 1:31 AM, Charles Davis wrote:
I have one more of my own to add:
* Fix crash whenever an app makes a GLU call.
Ah, yes, I forgot that one. Thanks for reminding me.
I suspect this is because Mesa's GLU calls Mesa's libGL--which crashes
horribly because there's no
On Mar 18, 2013, at 3:03 PM, C.W. Betts wrote:
On Mar 17, 2013, at 9:40 PM, Ken Thomases k...@codeweavers.com wrote:
Doesn't support right-clicks, mouse moves, or notification balloons.
Notification balloons can probably be done using either Notification Center
or Growl
Yeah, I
On Mar 18, 2013, at 3:15 PM, Ken Thomases wrote:
On Mar 18, 2013, at 3:03 PM, C.W. Betts wrote:
On Mar 17, 2013, at 9:40 PM, Ken Thomases k...@codeweavers.com wrote:
Doesn't support right-clicks, mouse moves, or notification balloons.
Notification balloons can probably be done using
Hi,
With my latest set of patches, the Mac driver in Wine is up to speed with
what's in CrossOver 12 (plus some extra goodies).
Of course, that's not to say that the Mac driver is done, but if you were
holding off getting involved because you figured big chunks of already-done
work were
On Mar 18, 2013, at 4:04 PM, Charles Davis wrote:
On Mar 18, 2013, at 2:23 PM, Ken Thomases wrote:
On Mar 18, 2013, at 2:15 PM, Ken Thomases wrote:
On Mar 18, 2013, at 3:03 PM, C.W. Betts wrote:
On Mar 17, 2013, at 9:40 PM, Ken Thomases k...@codeweavers.com wrote:
Doesn't support
On Mar 17, 2013, at 12:18 PM, Per Johansson wrote:
+namestr = CFStringCreateWithCString(NULL, link_name,
CFStringGetSystemEncoding());
You should use CFStringCreateWithFileSystemRepresentation() to create CFStrings
from POSIX path strings.
+pathstr =
On Mar 17, 2013, at 12:18 PM, Per Johansson wrote:
+CFStringRef iconstr = CFStringCreateWithCString(NULL, icon,
CFStringGetSystemEncoding());
Another place to use CFStringCreateWithFileSystemRepresentation().
-Ken
On Mar 7, 2013, at 9:39 AM, C.W. Betts wrote:
It looks like if GL_ARB_shader_objects is defined, then the OS X GLhandleARB
isn't typedef'd.
I think a better approach is to define __gltypes_h_ just to no-op that whole
header. Does that fix compilation for you? If so, please submit it as a
On Mar 7, 2013, at 12:03 PM, Charles Davis wrote:
On Mar 6, 2013, at 7:56 AM, Ken Thomases wrote:
On Mar 6, 2013, at 8:24 AM, joerg-cyril.hoe...@t-systems.com
joerg-cyril.hoe...@t-systems.com wrote:
Bug report:
Toying around with built-in notepad, clock, winhlp32, I noticed
On Mar 7, 2013, at 5:12 PM, Charles Davis wrote:
In the case that the window doesn't have its own grow box, though, it can be
hard to tell that you actually still can resize the window by dragging the
corner. (In notepad's case, it's weird, because I can click and drag the Down
button on
On Mar 7, 2013, at 4:15 PM, C.W. Betts wrote:
This patch defines __gltypes_h_ so that the Mac header doesn't get included.
Thanks!
-Ken
On Mar 6, 2013, at 8:24 AM, joerg-cyril.hoe...@t-systems.com
joerg-cyril.hoe...@t-systems.com wrote:
Bug report:
Toying around with built-in notepad, clock, winhlp32, I noticed that
notepad and winhlp32 are not resizable, whereas the system
preferences control is. By comparison, with the
On Mar 6, 2013, at 1:58 PM, C.W. Betts wrote:
It seems like there's conflicting types for GLhandleARB, one defined by Wine,
the other by OS X, on Mountain Lion. I assume that the #define __gl_h_ is a
try to work around the issue, but OS X's gltypes.h still gets included.
Ugh. Thanks for
On Mar 5, 2013, at 6:32 PM, Josh DuBois wrote:
---
dlls/gdi32/driver.c | 102 +++--
dlls/gdi32/gdi32.spec |1 +
dlls/gdi32/gdi_private.h |2 +
dlls/user32/driver.c | 27 ++--
include/wine/gdi_driver.h | 11 +
5
On Mar 5, 2013, at 6:32 PM, Josh DuBois wrote:
diff --git a/dlls/winemac.drv/macdrv_main.c b/dlls/winemac.drv/macdrv_main.c
index cd1cc0c..1f16694 100644
--- a/dlls/winemac.drv/macdrv_main.c
+++ b/dlls/winemac.drv/macdrv_main.c
@@ -85,7 +85,7 @@ static BOOL process_attach(void)
My feeling (like Josh's and Per's) is that the Mac driver should be what you
get by default, in most cases, without taking any special steps.
If the concern is what you get when you're ssh'd into a remote system, then
it's probably possible for the Mac driver to detect when it doesn't have GUI
On Feb 17, 2013, at 4:18 AM, Alessandro Pignotti wrote:
Third attempt
Hi everyone,
I've found two different games:
-) Of orcs and men
-) The testament of sherlock holmes
which are using a protection scheme which reset the GS segment selector,
possibly to confuse
the
default terminal icon. I also had a winecfg icon somewhere but I can't
remember where that one is right now.
Let me know and tell me where to send them.
Ken Thomases (cc'ed) is the person on winemac.drv, though wine-devel
or attaching them to bugzilla would likely be best to preserve
On Jan 22, 2013, at 12:22 PM, C.W. Betts wrote:
This version should fix the problems you mentioned
Sorry about this – I should have thought about this last time – but I think you
shouldn't fall through in the SPI_SETSCREENSAVEACTIVE case. It's asking for
trouble in the future, if anybody
On Jan 22, 2013, at 6:38 AM, joerg-cyril.hoe...@t-systems.com
joerg-cyril.hoe...@t-systems.com wrote:
Ken Thomases wrote:
+if(success != kIOReturnSuccess)
Another style nitpick: please put a space between if and the condition.
That applies to the if(count2) above, too
On Jan 22, 2013, at 5:33 PM, C.W. Betts wrote:
Yet another fix.
Looks good to me. Thanks for doing this and for putting up with me.
Cheers,
Ken
On Jan 21, 2013, at 9:31 AM, C.W. Betts wrote:
On Jan 20, 2013, at 11:06 PM, Ken Thomases k...@codeweavers.com wrote:
I'm not sure it's correct that these are two different names for roughly the
same thing. I think the two assertion types do slightly different things.
NoDisplaySleep
On Jan 21, 2013, at 11:50 AM, C.W. Betts wrote:
This version gets rid of redundant comments.
According to Alexandre's comment on your X11 driver patch, you should be
returning FALSE from the SET case so that user32 will update the registry.
Otherwise, looking good.
-Ken
Hi,
On Jan 21, 2013, at 6:21 PM, C.W. Betts wrote:
This version falls through in SPI_SETSCREENSAVEACTIVE.
Sadly, you used C++ style for the fall-through comment. :-/
Also, you have some trailing whitespace and the patch no longer applies cleanly
after today's commits of mine. It should be
On Jan 20, 2013, at 11:47 AM, C.W. Betts wrote:
On Jan 20, 2013, at 12:38 AM, Ken Thomases k...@codeweavers.com wrote:
On Jan 19, 2013, at 4:08 PM, C.W. Betts wrote:
+CFNumberRef count =
CFDictionaryGetValue(assertsionStats, kIOPMAssertionTypeNoDisplaySleep
Hi,
On Jan 20, 2013, at 2:00 PM, C.W. Betts wrote:
This version implements changes and advice from Ken Thomases, including using
kIOPMAssertionTypePreventUserIdleDisplaySleep on Lion and later. Also, some
comments were added.
+//Get pre-Lion no display sleep counts
C
Hi,
On Jan 19, 2013, at 4:08 PM, C.W. Betts wrote:
This implements getting and setting the screen saver state on the Mac Wine
driver.
Thanks for your contribution to the Mac driver. There are some issues with the
patch:
+CFDictionaryRef assertsionStats = NULL;
That
On Jan 12, 2013, at 4:12 AM, Alexandre Julliard wrote:
Ken Thomases k...@codeweavers.com writes:
On Jan 11, 2013, at 11:13 AM, Alexandre Julliard wrote:
It doesn't seem to work when installed:
wine: failed to initialize: dlopen(/usr/local/lib/wine/ntdll.dll.so, 258):
image not found
I
On Jan 11, 2013, at 11:13 AM, Alexandre Julliard wrote:
Ken Thomases k...@codeweavers.com writes:
---
configure.ac |3 ++-
libs/wine/Makefile.in |6 +++---
2 files changed, 5 insertions(+), 4 deletions(-)
It doesn't seem to work when installed:
wine: failed
On Jan 7, 2013, at 1:23 AM, Per Johansson wrote:
On Mon, Jan 7, 2013 at 4:48 AM, Charles Davis cdavi...@gmail.com wrote:
With this, you won't be able to launch Wine from the Finder or with open(1)
prior to 10.6.
I don't see how you'd do use open or the Finder to launch wine, could
you
On Dec 17, 2012, at 8:06 AM, Alexandre Julliard wrote:
Ken Thomases k...@codeweavers.com writes:
---
dlls/winemac.drv/Makefile.in |1 +
dlls/winemac.drv/gdi.c | 321 -
dlls/winemac.drv/macdrv.h| 101 +
3 files changed, 415
On Dec 17, 2012, at 11:53 AM, Alexandre Julliard wrote:
Ken Thomases k...@codeweavers.com writes:
Oh, right. The Mac driver requires 10.6 or later. So, I'll have to change
the configure script to only enable building of it on such systems.
Is there really a compelling reason
On Dec 17, 2012, at 1:35 PM, Alexandre Julliard wrote:
Ken Thomases k...@codeweavers.com writes:
On Dec 17, 2012, at 11:53 AM, Alexandre Julliard wrote:
Ken Thomases k...@codeweavers.com writes:
Oh, right. The Mac driver requires 10.6 or later. So, I'll have to
change the configure
1 - 100 of 218 matches
Mail list logo
