s a bugreport is because i really
> don't exactly know what's going on - there are just rather a lot of
> empirical observations that are ... "out there" :) so i apologise for
> this being a bit long, and not very specific, and if ever i get
> anything specific i
Hi!
Nikolay Sivov wrote:
> Hi, your patch for wldap32 added a warning:
I know and I sent a patch to revert that change:
http://www.winehq.org/pipermail/wine-patches/2009-January/067780.html
and Alexandre rejected it:
http://www.winehq.org/pipermail/wine-devel/2009-January/072151.html
He is right a
Alexandre Julliard wrote:
> Michael Stefaniuc writes:
>
>> This cast is needed to silence a compile warning with older openldap
>> versions; e.g. on RHEL5.
>
> Actually the code is broken now, since you changed long to LONG the
> structures are no longer compati
James Mckenzie wrote:
> Hans Leidekker
>> Sent: Jan 15, 2009 10:45 AM
>> To: wine-devel@winehq.org
>> Subject: Wine runs IE7!
>>
>>
>> Well, sort of. I found bugs in shell32, rpcrt4, comctl32 and wininet
>> that I had to implement, stub and override my way past before it would
>> render a page, bu
Paul Vriens wrote:
> Michael Stefaniuc wrote:
>> +/*
>> + * English resources for SETUPAPI
>> + *
>
> I guess that should be Romanian resources.
Thanks Paul!
I have removed that part of the comment and resubmitted the patch. I
always remove those comments as they are
Rob Shearman wrote:
> 2009/1/4 Michael Stefaniuc :
>> Hello guys,
>>
>> i guess that we need to change long to LONG in IDL files too, right?
>> Or would that be something that widl could/should do automatically?
>
> long/unsigned long are explicitly defined by th
Hello guys,
i guess that we need to change long to LONG in IDL files too, right?
Or would that be something that widl could/should do automatically?
bye
michael
James Hawkins wrote:
> On Sat, Jan 3, 2009 at 4:49 PM, Michael Stefaniuc wrote:
>> Also fix the compiler warnings introduced by this change.
>>
>> diff --git a/dlls/advapi32/crypt.c b/dlls/advapi32/crypt.c
>> index 5d0b15e..8ef0a5f 100644
>> --- a/dlls/advapi
Jeff Zaroyko wrote:
> On Tue, Dec 23, 2008 at 9:57 PM, Rico Schüller wrote:
>> Hi,
>>
>> on my XP machine the visual d3d9 test produces a timeout message, when
>> it is started from the winetest build. Anyone here could run the tests
>> on windows without a timeout (and off course without skipping
Hi Alasdair,
Alasdair Sinclair wrote:
>> Would you mind sharing what hardware that's on? You're using Fedora 10,
>> right?
>>
>>
> Sure, Its a Dell XPS1530 laptop (core 2 duo T8100), 4GB Ram, GeForce
> 8600M GT.
> Running fedora 10 x86-64 (recently upgraded from 9) all latest patches
> appli
Alexander Morozov wrote:
> Please, use this patch instead of previous "ntoskrnl.exe: Implement
> Io{Allocate,Get}DriverObjectExtension."
Shouldn't this have gone to wine-patches instead of wine-devel?
bye
michael
Andrew Talbot wrote:
>
> On Fri Dec 12 0:58 , Michael Stefaniuc sent:
>
>> Andrew Talbot wrote:
>>> What is wrong with this patch, please?
>> If I may venture a guess: You have replaced a nice and concise for loop
>> into and ugly 4 line while loop.
> U
zeof(MMDrvs) / sizeof(MMDrvs[0]) - 1; i >= 0; i--)
> +i = sizeof(MMDrvs) / sizeof(MMDrvs[0]);
> +while (i > 0)
> {
> +--i;
> +
> MMDRV_ExitPerType(&MMDrvs[i], MMDRV_AUX);
> MMDRV_ExitPerType(&MMDrvs[i], MMDRV_MIXER);
>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hello Dan,
did the patchwatcher look up? The last patch it shows is from
30-Nov-2008 14:01.
bye
michael
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.5 (GNU/Linux)
Comment: Using GnuPG with Red Hat - http://enigmail.mozdev.org
iD8DBQFJNC
you want it here it is:
chmod a+x .git/hooks/pre-commit
Run it in your (git) Wine source directory. That will prevent your elves
from doing those funny whitespace tricks again.
bye
michael
> On Thu, 2008-11-27 at 11:16 +0100, Michael Stefaniuc wrote:
>> Hello Peter,
>&g
Hello Peter,
Peter Dons Tychsen wrote:
> Fixed a problem with timer values that are smaller than the minimum time
> that can be assigned to the SetTimer() win32 call (approx 50ms). The
> patch splits up the timer into several interrupts if too long time has
> passed.This fixes good old OutRun, whi
Rob Shearman wrote:
> 2008/11/18 ricardo filipe <[EMAIL PROTECTED]>:
>> diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c
>> index 3d66740..815ed64 100644
>> --- a/dlls/rpcrt4/rpc_transport.c
>> +++ b/dlls/rpcrt4/rpc_transport.c
>> @@ -479,7 +479,6 @@ static size_t rpcrt4_ncacn
Marcus Meissner wrote:
> On Wed, Nov 12, 2008 at 10:28:37AM +0100, Michael Stefaniuc wrote:
>> Austin English wrote:
>>> This series of patches fixes most of the new warnings generated in gcc
>>> 4.3.2. There's one issue left, but I'm not quite sure what sho
Austin English wrote:
> This series of patches fixes most of the new warnings generated in gcc
> 4.3.2. There's one issue left, but I'm not quite sure what should be
> done on that one.
> diff --git a/tools/fnt2bdf.c b/tools/fnt2bdf.c
> index 1a14d6c..3c3134b 100644
> --- a/tools/fnt2bdf.c
> +++ b/
Henri Verbeet wrote:
> 2008/11/4 Michael Stefaniuc <[EMAIL PROTECTED]>:
>> ---
>> server/console.c |2 +-
>> server/trace.c | 130
>> +++---
>> 2 files changed, 66 insertions(+), 66 deletions(-)
>&
Francois Gouget wrote:
> On Tue, 4 Nov 2008, Stefan Dösinger wrote:
> [...]
>> I think we still have the problem that gcc doesn't support the calling
>> convention Win64 uses, so we can't compile a Wine that is compatible with
>> Win64 apps.
>
> In the meantime we can work on the long vs. LONG iss
Hello Pete,
Pete Myers wrote:
> Hi, this is my first ever commit to the Wine project.
>
> In line with http://wiki.winehq.org/ReplaceMalloc this is a small patch
> that changes all malloc calls in ./dlls/kernel32/process.c to HeapAlloc.
>
> Changelog:
> * malloc calls in dlls/kernel32/process.c
Pete Myers wrote:
>> In addition to what James said please split the patch up; one patch per
>> module. A dll or program is a "module".
>
> Sorry, I'm inundated with noobie errors here I think.
No problem. Janitorial tasks are really good to accustom new people to
the patch submission process.
>
Hello Pete,
James Hawkins wrote:
> On Wed, Oct 29, 2008 at 8:02 PM, Pete Myers
> <[EMAIL PROTECTED]> wrote:
>> It does match the style of the way that HeapAlloc is used elsewhere in the
>> file, though not malloc admittedly. I wasn't sure which convention had
>> precedent.
>>
>
> Please bottom-p
; URL:
> http://source.winehq.org/git/wine.git/?a=commit;h=d6359edd3cbe366c71f22e09e27d3e427520f609
>
> Author: Michael Stefaniuc <[EMAIL PROTECTED]>
> Date: Tue Oct 14 16:32:33 2008 +0200
>
> shlwapi: Remove break after return (Smatch).
>
> ---
>
> dlls/sh
Hello Jacek,
Smatch complains about unreachable code introduced by this patch:
Alexandre Julliard wrote:
> Module: wine
> Branch: master
> Commit: 536fac7c1b4ef7f6f124d7f3100d3284313f3018
> URL:
> http://source.winehq.org/git/wine.git/?a=commit;h=536fac7c1b4ef7f6f124d7f3100d3284313f3018
>
>
Hello Alexandre,
please cherry-pick the attached list of translation patches into the
"stable" aka wine-1.0.x branch. Some of the patches seem to be already
cherry-picked but as a git cherry-pick will just do nothing for those I
didn't bother to find them and remove them.
The list was genera
Hi,
Kjell Rune Skaaraas wrote:
> Hello,I've submitted a patch to wine-patches for
> IWineD3DResourceImpl_GetPriority/SetPriority that's incorrect (it
> makes changes to exception.c which shouldn't be there, they were just
> part of me trying to debug something). Is there anything like a cancel
> p
Hello Jacek,
this patch introduces a gcc warning:
dlls/jscript/engine.c:954: warning: empty body in an if-statement
Alexandre Julliard wrote:
> Module: wine
> Branch: master
> Commit: dfb867af56f4b15986482deef588d33d2458b101
> URL:
> http://source.winehq.org/git/wine.git/?a=commit;h=dfb867af5
Detlef Riekenberg wrote:
> On Do, 2008-09-18 at 09:58 +0200, Michael Stefaniuc wrote:
>
>> there is no point in adding new resources in English to the other
>> languages rc files. If a resource doesn't exist Win32 will automatically
>> fail over to use the en_
Hello Gal,
there is no point in adding new resources in English to the other
languages rc files. If a resource doesn't exist Win32 will automatically
fail over to use the en_US version.
Actually its even detrimental to add the new resources as:
a.) http://pf128.krakow.sdi.tpnet.pl/wine-transl/ ca
Vitaliy Margolen wrote:
> Chris Ahrendt wrote:
>> Dmitry Timoshkov wrote:
>>> "Chris Ahrendt" <[EMAIL PROTECTED]> wrote:
How do I fix it?
>>> Update to current git and regenerate the patch:
>>>
>> The thing is I just did a refresh and it said I was up to date...
>>
>> I guess wait till tomorro
Francois Gouget wrote:
> On Mon, 18 Aug 2008, Detlef Riekenberg wrote:
>
>> On So, 2008-08-17 at 19:03 +0200, Michael Karcher wrote:
>>> ---
>>> configure | 303
>>> +++
>> You should never include autogenerated code in a Patch.
>
> How d
Dan Kegel wrote:
> The Chinese resource files are already utf-8,
Romanian was always utf-8. Slovenian seems to be on a quick glance utf-8
only too.
German, French and Spanish have a few files in utf-8 too.
> but I suspect lots of other files are in obscure character
> sets, which complicates pat
Henri Verbeet wrote:
> 2008/8/29 Dan Kegel <[EMAIL PROTECTED]>:
>> Henri wrote:
>>> glibc implements acos() as the FPU equivalent of atan2(sqrt(1 - x ^ 2), x).
>> I just looked, and there are several implementations of acos
>> in glibc, and they all seem to very carefully choose
>> how to do it bas
Alexander Nicolaysen Sørnes wrote:
> regedit 1/2: Convert key creation to unicode
Why do you add extra TCHARs then? You replace one or two with WCHAR and
then add a lot more TCHARs.
> From 2f56e158d55011ac4294d113f844c32fb998a2c2 Mon Sep 17 00:00:00 2001
> From: =?utf-8?q?Alexander=20Nicolaysen=2
t auto detecting the encoding and kept detecting
utf-8). Why latin-1? latin-1 is 8bit clean in regards to git; the patch
might look garbled in the mail client but git-am will apply the patch
just fine. For utf-8 git will check the patch if it really is valid
utf-8 and barf out if not.
bye
Markus Hitter wrote:
> Am 18.08.2008 um 06:57 schrieb James Hawkins:
>
>> Also, Julliard hasn't had trouble scaling with the pace of
>> development so far.
>
> I'd be not so sure about this. So far I've filed four bugs and sent
> two patches. Bugs get little or no attention, patches obviously
>
> Golly. Maybe I should have gotten a quad core :-)
>
> BTW, I just compared the e7200 and e8400 on the 'valgrind wine test
> suite with -j2' task.
> Results: e8400 is 18% faster (83 minutes vs. 99 minutes).
> I&#
Andrew Talbot wrote:
> Is there anything wrong with this patch, please?
If I might venture a guess it's probably because of the casts. Casts are
evil if not really needed and using casts to get rid of the sign
comparison warnings is debatable at best.
> ---
> Changelog:
> advpack: Sign-compa
Tue, Jul 8, 2008 at 8:05 AM, Michael Stefaniuc <[EMAIL PROTECTED]>
> wrote:
>
>> This fixes a warning introduced by 69cf4e9a :
>> dlls/riched20/editor.c:1647: warning: 'clickMsg.pt.y' is used uninitialized
>> in this function
>>
>>
>>
Hello Dylan,
Dylan Smith wrote:
> I tried to make richedit.h more consistent with the public SDK headers
> by adding anything any missing defines and structures that I could find.
> ---
> include/richedit.h | 395
> ++--
> 1 files changed, 384 ins
Francois Gouget wrote:
> On Wed, 18 Jun 2008, Michael Stefaniuc wrote:
> [...]
>> What about patches that have no associated bug report but can and
>> probably should be cherry picked into stable? Translation patches come
>> to mind as a class of patches that would fa
Hello Alexandre,
good job on 1.0. Hopefully now the time of boring commit messages is over ;)
Alexandre Julliard wrote:
> The process I suggest for the 1.0.1 release is as follows:
>
> - all bugs should be fixed in the master branch first
> - once a bug fix has been committed to master, the corr
Dan Kegel wrote:
> The penultimate update?
>
>
>
> 1.0 bugs deferred to 1.0.1 since May 27th:
> +http://bugs.winehq.org/show_bug.cgi?id=12097";>12097
Wine 1.0 should not ship out-of-sync resource translations
This bug is
Dan Kegel wrote:
> Casting a VT_EMPTY to a string gets you a null string.
> The test was doing that and taking the string length, then comparing to zero.
> Better to simply compare to null; that's a stronger test, and
> avoids generating a behind-the-scenes exception.
>
> Passes on Wine and XP, an
to upgrade the libxml2 rpms on your Red Hat Linux 9 box by
recompiling the libxml2 srpm from F9. No clue if that will work.
bye
michael
> On Jun 6, 2008, at 3:42 AM, Michael Stefaniuc wrote:
>
>> Hello!
>>
>> Wen Huang wrote:
>>> I was trying to co
Hello!
Wen Huang wrote:
> I was trying to compile a winehq on Red Hat 9 and I downloaded the
> source 0.9.60 from sourceforge.
Do you really mean Red Hat Linux 9? Or Fedora 9? Red Hat Linux 9 is
really old and unsupported for years now.
> When I tried to compile by
>
> ./configure
> make depe
Austin English wrote:
> Alexandre committed a few fixed to the README today, but I still see a
> few things that may need fixing:
>
> ./tool/wineinstall - Has been mentioned to be deprecated a few times
> in bugzilla. If it's deprecated, we need to remove it. If not, we need
> to fix whatever it's
TheBlunderbuss wrote:
> During the day's compile, I noticed some functions were declared
> deprecated, mainly in sound components.
> I logged more context, if anyone needs it.
This is known. But the ALSA functions were only recently deprecated,
e.g. Fedora 8 doesn't show them but F9 does.
> alsa.
-themed goodie of some sort.
>
> So fire up your keyboards and start testing!
> Thanks, and good hunting!
> --- snip ---
>
> (Not sure how the goodie would be handled, but I'm willing to cover the
> expenses myself, especially if I get to pick the winner :-)
sXExtensionDevice) || (devices[loop].use
> == IsXExtensionPointer))
> {
> LPWTI_CURSORS_INFO cursor;
>
> -TRACE("Is Extension Device\n");
> +TRACE("Is XExtension%s\n", (devices[loop].use ==
> IsXEx
Jeremy White wrote:
> I'd like to start the planning for WineConf 2008.
>
> My sense is that 3 years in Europe and 1 year in the US
> is a reasonable balance, so I feel it makes sense to
> try to have it over here this year.
>
> Further, I would like to host WineConf this year in St. Paul, Minnes
Andreas Bierfert wrote:
> On Thu, 03 Apr 2008 01:58:04 -0700
> Scott Ritchie <[EMAIL PROTECTED]> wrote:
>
>> PulseAudio will take off exactly because Ubuntu is using it.
>
> Just to remind you that Fedora has been using it before :P
>
> Anyway, I had to deal with a lot of people when F8 hit beca
Alexandre Julliard wrote:
> Michael Stefaniuc <[EMAIL PROTECTED]> writes:
>
>> Right, forgot about that one. But I am still sure he would accept a
>> "perfect" full featured and beautiful written pulseaudio driver. What he
>> doesn't wants at a
James Hawkins wrote:
> On Wed, Apr 2, 2008 at 1:52 PM, Michael Stefaniuc <[EMAIL PROTECTED]> wrote:
>> James Hawkins wrote:
>> > And I believe Julliard rejected the idea of adding a pulseaudio driver.
>> Nope! He isn't against a pulseaudio driver. He is agai
James Hawkins wrote:
> On Wed, Apr 2, 2008 at 1:05 PM, Austin English <[EMAIL PROTECTED]> wrote:
>> On Wed, Apr 2, 2008 at 10:08 AM, Bryan Haskins <[EMAIL PROTECTED]> wrote:
>> > I'm more interested in a direct pulseaudio gateway for Wine... since by
>> > application sound control is the biggest
Michael Stefaniuc wrote:
> there are a couple resource file translations that are so way out of
> sync that they are commented out of the main rc file of the relevant
> module.
>
> programs/winecfg/winecfg.rc:
>
> - Pt.rc - Portuguese (Brazi
Hello guys,
there are a couple resource file translations that are so way out of
sync that they are commented out of the main rc file of the relevant
module.
programs/progman/rsrc.rc:
-
- Da.rc - Danish
- Fi.rc - Finnish
- Sk.rc - Slovak
- Sw.rc - Swedish (correct filename
Dan Kegel wrote:
> 40 days to code freeze.
>
> One bug fixed in last couple days:
> 9459 -unknown8 FIFA 2007 crashes with the recent versions
>
> One bug added:
> 12246 -unknown0 "make test" gives different results
> with and without warn+heap
>
> One bug deferred:
Reece Dunn wrote:
> On 30/03/2008, Michael Stefaniuc <[EMAIL PROTECTED]> wrote:
>> Dan Kegel wrote:
>> > 40 days to code freeze.
>> >
>>> 12097 -unknown2 Wine 1.0 should not ship out-of-sync
>>> resource translations
Vitaly Perov wrote:
> Bug is the following:
> When a application is responsible for printing multiple copies printer
> prints
> X^2 copies (4 instead of 2, 9 instead of 3 ...)
> It happen bacause application already prepared requested copies, and printer
> driver prints copies ( number placed i
Hello Nikolay,
thanks for the patch.
Nikolay Sivov wrote:
> Changelog:
> gdi32: initial implementation using coord transformation and MaskBlt
> patch is made in Windows using TortoiseCVS functionality (all that
> I can use at this moment, shouldn't be a problem I hope)
No that's not a
Dan Kegel wrote:
> On Wed, Mar 26, 2008 at 4:04 AM, Michael Stefaniuc <[EMAIL PROTECTED]> wrote:
>> > This would require reviewing all uses of WideCharToMultiByte in Wine,
>> > many places get this wrong. Unless you have an app that requires this
>> >
Alexandre Julliard wrote:
> "Dan Kegel" <[EMAIL PROTECTED]> writes:
>
>> While investigating a crash in gs-auftrag in bug 9039, noticed
>> WideCharToMultiByte wasn't quite conformant for negative destlen.
>> Fixed, with tests. Passes for me in Wine and Win XP.
>
> This would require reviewing al
Hello Alistair,
Alexandre Julliard wrote:
> Module: wine
> Branch: master
> Commit: 264be58812fedf9a066bac521f9fff5821759890
> URL:
> http://source.winehq.org/git/wine.git/?a=commit;h=264be58812fedf9a066bac521f9fff5821759890
>
> Author: Alistair Leslie-Hughes <[EMAIL PROTECTED]>
> Date: Tue
Dan Kegel wrote:
> On Thu, Mar 20, 2008 at 3:28 PM, Alexandre Julliard <[EMAIL PROTECTED]> wrote:
>> I hope you are not seriously suggesting that we do this...
>
> Seriously.
>
>> I'm not at all convinced that we need even a warning, there doesn't seem
>> to be much concrete evidence that runn
Dimi Paun wrote:
> On Wed, 2008-03-19 at 23:57 +0100, Michael Stefaniuc wrote:
>> +LTEXT "O îeșire sau oprire simulată este în curs dar
>> acest proces nu răspunde.",
>
> This should be "O ieșire" not "O îeșire", no?
Thanks man, I've resent it!
bye
michael
Ian Macfarlane wrote:
> Just to resurrect this topic, as last time, of the responses to my
> email, two were positive (and the other just pointed out that I'd
> mistaken the Samba licensing for LGPL instead of GPL) but nothing else
> happened after that.
>
> Seeing as Wine is officially going to b
;;>wine-devel at
winehq.org
bye
michael
> policy is to try to keep with un-patched packages from Debian stable.
> I can manually fix the archives though.
>
> Michael Stefaniuc wrote:
>> Groeschel, Volker wrote:
>>> I apologize I was not looking in th
Groeschel, Volker wrote:
> But wouldn't be http://www.winehq.org/mailman/listinfo/wine-devel better
> than [EMAIL PROTECTED]
>
> I just quote: "Note: You should be subscribed to the lists before you
> post to them, otherwise your posting will be treated as possible spam by
> the mailing list softw
Groeschel, Volker wrote:
> I apologize I was not looking in the diff but in the wine-cvs message
> http://www.winehq.org/pipermail/wine-cvs/2008-March/041392.html
>
> There it points to wine-cvs.
>
> I don't know where this difference comes from.
The list archives obfuscate email addresses, adds
please report
it to [EMAIL PROTECTED]",
I cannot see any wine-cvs in there.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Consulting Communications Engineer Fax.: +49-711-96437-111
---
Groeschel, Volker wrote:
> The Patch points to wine-cvs. Shouldn't it point to wine-devel.
It points to wine-devel.
bye
michael
Dan Kegel wrote:
> http://wiki.winehq.org/SummerOfCode
> currently sends people to #WineHQ.
> Should it send them to #winehackers?
#winehackers is probably better.
bye
michael
Hello Lei,
Lei Zhang wrote:
> On Tue, Mar 18, 2008 at 5:30 AM, Michael Stefaniuc <[EMAIL PROTECTED]> wrote:
>> We should try to update the translations of Wine to other languages for
>> 1.0. The code freeze during the release candidate time frame is perfect
>> f
Paul Vriens wrote:
> Michael Stefaniuc wrote:
>> Hello!
>>
>> We should try to update the translations of Wine to other languages for
>> 1.0. The code freeze during the release candidate time frame is perfect
>> for this as the translations don't have to tra
Hello!
We should try to update the translations of Wine to other languages for
1.0. The code freeze during the release candidate time frame is perfect
for this as the translations don't have to track a moving target.
Somebody had scripts/a web page to check for missing translations or
broken ones
4
> --- a/dlls/gdiplus/gdiplus_private.h
> +++ b/dlls/gdiplus/gdiplus_private.h
> @@ -184,4 +184,9 @@ struct GpStringFormat{
> StringAlignment vertalign;
> };
>
> +struct GpFontCollection{
> +};
> +
> +struct GpFontFamily
Alexandre Julliard wrote:
> "Dan Kegel" <[EMAIL PROTECTED]> writes:
>
>> I've updated http://wiki.winehq.org/WineReleaseCriteria
>> to be a bit more final.
>>
>> I've also written a draft release plan; see
>> http://wiki.winehq.org/WineReleasePlan
>>
>> Comments?
>
> We need a code freeze and sta
Maarten Lankhorst wrote:
> Hi,
>
> 2008/3/12, Michael Stefaniuc <[EMAIL PROTECTED]>:
>> James Hawkins wrote:
>> > On Tue, Mar 11, 2008 at 3:15 PM, Dan Kegel <[EMAIL PROTECTED]> wrote:
>> >> I'm kind of hoping James implements the missing bit
cause it requires fusion.dll being
> implemented.
Implementing fusion.dll sounds like a GSoC project to me (no clue how
much work that is). At least getting the basic structure in place should
be doable.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Michael Stefaniuc wrote:
> ---
> This duplicates for now the FONT_LogFont16ToW() function but Alexandre
It duplicates FONT_LogFontWTo16() and not FONT_LogFont16ToW() (that one
was already duplicated).
> told me on irc that he removed the other user of it in an yet unpublished
>
readability,
No, it doesn't increase readability it decreases readability a lot.
Especially as you have to replace "goto error:" with deeply nested
if/else code and that is not readable at all.
Using goto right is an art; you need to look at the code and say that it
looks good.
by
ou need that? Wine uses git, a distributed SCM. You are
free to publish your own Wine tree without waiting for Alexandre.
People prefer to follow Alexandre's tree but nobody forces them to use it.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-
ons and spread
the load of deleting rogue users on many shoulders.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Consulting Communications Engineer Fax.: +49-711-96437-111
Austin English wrote:
> I'm seeing quite a few abbreviations. While they don't hurt anything,
> they do give the code a slang tone. I personally think that wine is a
It's not slang but jargon!
> very professional project, and it's code should reflect that. While
This is an open source project and
Hans Leidekker wrote:
> $ for y in {2002..2007}; do \
> n=$( git log | grep ^Date: | grep $y | wc -l ); \
> echo "Number of commits in $y: $n"; \
> done
> Number of commits in 2002: 3094
> Number of commits in 2003: 3283
> Number of commits in 2004: 3851
> Number of commits in 2005: 6006
> Nu
t; Is this with a specific X driver? The binary nvidia driver only lists
> modes explicitly declared in xorg.conf.
Huh? I don't declare any mode in the xorg.conf and i'm using the nvidia
binary driver. The drivers can figure out nowadays what wor
Andrew Talbot wrote:
> Please do not commit this patch. It relies on UINT (= unsigned int) and
> DWORD (= unsigned long int) both being 32 bits wide.
Those are 32 bits wide on Win64 too. Even LONG is 32 bits on Win64.
bye
michael
--
Michael Stefaniuc Tel
nt to the compiler but normally the compiler knows anyway
better what to inline and what not.
If you really want to force an inline you have the
__attribute__((always_inline))
bye
michael
--
Michael Stefaniuc
Juan Lang wrote:
> On Dec 5, 2007 12:52 PM, Michael Stefaniuc <[EMAIL PROTECTED]> wrote:
>> Checked with Kai and Dmitry and there is nothing special about
>> SECUR32_ALLOC(). There are more direct usages of HeapAlloc()
>> than of the macro so instead of replacing SECUR32
if (Timeout > t) Timeout -= t;
> +else Timeout = 0;
> continue;
> } else {
> /* This is a reply to our packet */
>
>
--
Michael Stefaniuc Tel.: +49-711-96437-199
Consulting Communications Engineer
Hey,
Steven Edwards wrote:
> On Nov 29, 2007 4:12 PM, Michael Stefaniuc <[EMAIL PROTECTED]> wrote:
>> diff --git a/dlls/urlmon/urlmon_main.h b/dlls/urlmon/urlmon_main.h
>> index aeb0eb2..9f31fb9 100644
>> --- a/dlls/urlmon/urlmon_main.h
>> +++ b/dlls/urlmon/
James Hawkins wrote:
> On Nov 28, 2007 3:39 PM, Michael Stefaniuc <[EMAIL PROTECTED]> wrote:
>> i'm unsure about this patch series. Yes this are simple wrappers around
>> HeapAlloc() that are the same as the "standard" wrappers used in Wine.
>> But the
Vijay Kiran Kamuju wrote:
> On Nov 28, 2007 12:34 PM, Michael Stefaniuc <[EMAIL PROTECTED]> wrote:
>> Maarten Lankhorst wrote:
>>> Stefan Dösinger schreef:
>>>> What do we do if there's a d3dx9_37.dll next month?
>>>>
>>> One thin
se the history.
bye
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Consulting Communications Engineer Fax.: +49-711-96437-111
Reg. Adresse: Red Hat GmbH, Hauptstätter Strasse
Frank Richter wrote:
> On 27.11.2007 09:28, Michael Stefaniuc wrote:
>> Just go for
>> if ( !pSrcFile )
>>return D3DXERR_INVALIDDATA;
>>
>> LPWSTR pSrcFileW = NULL;
>> DWORD len;
>> HRESULT ret;
>> ...
>
> That's C++, not C, isn&#
Alexandre Julliard wrote:
> Michael Stefaniuc <[EMAIL PROTECTED]> writes:
>
>> I therefor propose to standardize all the internal HeapAlloc wrappers to
>> a common name and form, Something along the lines of:
>> walloc()
>> wzalloc()
>> wrealloc()
&
, Flags, ppConstants,
> ppCompiledShader, ppCompilationErrors);
> + HeapFree( GetProcessHeap(), 0, pSrcFileW );
> + return ret;
> + }
> }
>
>
>> This is not more readable than a previous version. There is no need
>> for 'else {}' construct and therefore f
401 - 500 of 713 matches
Mail list logo
