Re: [PATCH 5/5] d3d9/tests: D3DCMP_GREATER is broken on r500.

2013-09-12 Thread Henri Verbeet
On 12 September 2013 12:23, Stefan Dösinger ste...@codeweavers.com wrote: + * On the r500 driver on Windows D3DCMP_GREATER and D3DCMP_GREATEREQUAL are broken for depth + * values 0.5. The range appears to be distored, apparently an incoming value of ~0.875 is distorted?

Re: [2/2] kernel32: Remove a 0-length read optimization from ReadFile.

2013-09-12 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@baikal.ru writes: This matches WriteFile behaviour and ensures that invalid parameters are properly handled and fields in the OVERLAPPED structure are initialized. This is again causing test failures. Please do a full test run before sending patches. -- Alexandre

Re: [2/2] kernel32: Remove a 0-length read optimization from ReadFile.

2013-09-12 Thread Dmitry Timoshkov
Alexandre Julliard julli...@winehq.org wrote: This matches WriteFile behaviour and ensures that invalid parameters are properly handled and fields in the OVERLAPPED structure are initialized. This is again causing test failures. Please do a full test run before sending patches. Could you

Re: [2/2] kernel32: Remove a 0-length read optimization from ReadFile.

2013-09-12 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@baikal.ru writes: Alexandre Julliard julli...@winehq.org wrote: This matches WriteFile behaviour and ensures that invalid parameters are properly handled and fields in the OVERLAPPED structure are initialized. This is again causing test failures. Please do a full

Re: [PATCH 5/5] d3d9/tests: D3DCMP_GREATER is broken on r500.

2013-09-12 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-12 12:44, schrieb Henri Verbeet: On 12 September 2013 12:23, Stefan Dösinger ste...@codeweavers.com wrote: + * On the r500 driver on Windows D3DCMP_GREATER and D3DCMP_GREATEREQUAL are broken for depth + * values 0.5. The range

Re: [PATCH 5/5] d3d9/tests: D3DCMP_GREATER is broken on r500.

2013-09-12 Thread Henri Verbeet
On 12 September 2013 13:33, Stefan Dösinger ste...@codeweavers.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-12 12:44, schrieb Henri Verbeet: On 12 September 2013 12:23, Stefan Dösinger ste...@codeweavers.com wrote: + * On the r500 driver on Windows D3DCMP_GREATER

Re: [PATCH 5/5] d3d9/tests: D3DCMP_GREATER is broken on r500.

2013-09-12 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-12 13:36, schrieb Henri Verbeet: I really just meant the typo in the comment. Ah yes, that should be distorted. -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird -

Re: [PATCH 3/6] user32: Export WINPOS_GetMinMaxInfo() as __wine_get_min_max_info() so it can be called by drivers.

2013-09-12 Thread Ken Thomases
On Sep 12, 2013, at 12:23 AM, Dmitry Timoshkov wrote: Ken Thomases k...@codeweavers.com wrote: +@ cdecl __wine_get_min_max_info(long ptr ptr ptr ptr) WINPOS_GetMinMaxInfo What's wrong with calling SendMessage(WM_GETMINMAXINFO) from the driver? Because I would have to duplicate all of the

Re: d3d9/tests: D3DCMP_GREATER is broken on r500 (try 2).

2013-09-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2136 Your paranoid

Re: [PATCH 3/6] user32: Export WINPOS_GetMinMaxInfo() as __wine_get_min_max_info() so it can be called by drivers.

2013-09-12 Thread Ken Thomases
On Sep 12, 2013, at 10:48 AM, Dmitry Timoshkov wrote: Ken Thomases k...@codeweavers.com wrote: +@ cdecl __wine_get_min_max_info(long ptr ptr ptr ptr) WINPOS_GetMinMaxInfo What's wrong with calling SendMessage(WM_GETMINMAXINFO) from the driver? Because I would have to duplicate all of

Re: [try3] gdi32: abc values remain the same despite any changes in layout direction or Viewport

2013-09-12 Thread Alexandre Julliard
Aric Stewart a...@codeweavers.com writes: @@ -1262,6 +1290,70 @@ static void test_GetCharABCWidths(void) } ReleaseDC(NULL, hdc); + +memset(lf, 0, sizeof(lf)); +strcpy(lf.lfFaceName, Tahoma); +lf.lfHeight = 20; + +#define helper_ABC(a)

Re: [PATCH 3/6] user32: Export WINPOS_GetMinMaxInfo() as __wine_get_min_max_info() so it can be called by drivers.

2013-09-12 Thread Dmitry Timoshkov
Ken Thomases k...@codeweavers.com wrote: +@ cdecl __wine_get_min_max_info(long ptr ptr ptr ptr) WINPOS_GetMinMaxInfo What's wrong with calling SendMessage(WM_GETMINMAXINFO) from the driver? Because I would have to duplicate all of the rest of the logic in WINPOS_GetMinMaxInfo(), too.

Re: ntdll/tests: Fix compilation on systems that don't support nameless unions.

2013-09-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2144 Your paranoid

Re: (resend) [PATCH] serial: wait_for_event() must set Information in PIO_STATUS_BLOCK

2013-09-11 Thread Dmitry Timoshkov
Wolfgang Walter w...@stwm.de wrote: -if (commio-iosb) commio-iosb-u.Status = *commio-events ? STATUS_SUCCESS : STATUS_CANCELLED; +if (commio-iosb) { +commio-iosb-u.Status = *commio-events ? STATUS_SUCCESS : STATUS_CANCELLED; +if (*commio-events) +

RFC: HKCR merge implementation

2013-09-11 Thread George Stephanos
I'm proposing my HKEY_CLASSES_ROOT implementation patches for review. Feel free to comment. So far, I've written code for all functions except for the RegEnum family. General description: HKCR handles are special. All wine handles have the two lowest bits zero'd. HKCR handles are masked. 10b

Re: po: Add English (Philippines) resource (resend)

2013-09-11 Thread Alexandre Julliard
Ken Sharp kennyb...@o2.co.uk writes: @@ -111,6 +111,9 @@ filter: dummy .svg.bmp: CONVERT=$(CONVERT) ICOTOOL=$(ICOTOOL) RSVG=$(RSVG) $(BUILDIMAGE) $ $@ +$(top_srcdir)/po/en_PH.po: $(top_srcdir)/po/en_US.po + $(LN_S) -f en_US.po $@ + You can't create links in the source tree,

Re: (resend) gdi32: abc values remain the same despite any changes in layout direction or Viewport

2013-09-11 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2103 Your paranoid

Re: [PATCH 3/5] wined3d: Pass stream info and needed fixups to buffer_find_decl.

2013-09-11 Thread Henri Verbeet
On 11 September 2013 11:31, Stefan Dösinger ste...@codeweavers.com wrote: @@ -330,7 +331,7 @@ static BOOL buffer_find_decl(struct wined3d_buffer *This) if(This-resource.usage WINED3DUSAGE_STATICDECL) return FALSE; } -if (use_vs(state)) +if (fixup_flags

Re: [PATCH 4/5] wined3d: Move the decoded stream info into the context.

2013-09-11 Thread Henri Verbeet
On 11 September 2013 11:31, Stefan Dösinger ste...@codeweavers.com wrote: @@ -1880,9 +1888,8 @@ struct wined3d_device WORD d3d_initialized : 1; WORD inScene : 1; /* A flag to check for proper BeginScene / EndScene call pairs */ WORD softwareVertexProcessing :

Re: [PATCH 4/5] wined3d: Move the decoded stream info into the context.

2013-09-11 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-11 13:32, schrieb Henri Verbeet: On 11 September 2013 11:31, Stefan Dösinger ste...@codeweavers.com wrote: @@ -1880,9 +1888,8 @@ struct wined3d_device WORD d3d_initialized : 1; WORD inScene : 1; /* A flag to check for

Re: [PATCH 5/5] wined3d: Explicitly pass the state information to buffer_internal_preload

2013-09-11 Thread Henri Verbeet
On 11 September 2013 11:31, Stefan Dösinger ste...@codeweavers.com wrote: -/* Reading the declaration makes only sense if the stateblock is finalized and the buffer bound to a stream */ -if (device-isInDraw buffer-resource.bind_count 0) +/* Reading the declaration makes only

Re: [PATCH 4/5] wined3d: Move the decoded stream info into the context.

2013-09-11 Thread Henri Verbeet
On 11 September 2013 13:37, Stefan Dösinger ste...@codeweavers.com wrote: The next element is a BYTE. The 8 bits padding were stupid considering that, it just generates a hole. Now I am removing one bit, which leaves one bit of padding left. It doesn't really work like that, the layout is like

Re: [PATCH 2/2] d3d11.idl: Added some missing declarations.

2013-09-11 Thread Henri Verbeet
On 11 September 2013 12:09, Jacek Caban ja...@codeweavers.com wrote: +typedef enum D3D11_RESOURCE_MISC_FLAG +{ +D3D11_RESOURCE_MISC_GENERATE_MIPS= 0x0001, +D3D11_RESOURCE_MISC_SHARED = 0x0002, +D3D11_RESOURCE_MISC_TEXTURECUBE

Re: [PATCH 2/2] d3d11.idl: Added some missing declarations.

2013-09-11 Thread Michael Stefaniuc
On 09/11/2013 02:11 PM, Henri Verbeet wrote: On 11 September 2013 12:09, Jacek Caban ja...@codeweavers.com wrote: +typedef enum D3D11_RESOURCE_MISC_FLAG +{ +D3D11_RESOURCE_MISC_GENERATE_MIPS= 0x0001, +D3D11_RESOURCE_MISC_SHARED =

riched20/tests: Add tests for ITextDocument_Save. (try 2)

2013-09-11 Thread Jactry Zeng
Update: Add todo_wine From 8f464b1ffa384ffba25af5041065c23d21ede041 Mon Sep 17 00:00:00 2001 From: Jactry Zeng jactr...@gmail.com Date: Wed, 11 Sep 2013 18:06:02 +0800 Subject: riched20/tests: Add tests for ITextDocument_Save. To: wine-patches wine-patc...@winehq.org Reply-To: wine-devel

Re: [PATCH 2/2] d3d11.idl: Added some missing declarations.

2013-09-11 Thread Jacek Caban
On 09/11/13 14:22, Michael Stefaniuc wrote: On 09/11/2013 02:11 PM, Henri Verbeet wrote: On 11 September 2013 12:09, Jacek Caban ja...@codeweavers.com wrote: +typedef enum D3D11_RESOURCE_MISC_FLAG +{ +D3D11_RESOURCE_MISC_GENERATE_MIPS= 0x0001, +

Re: wininet: Don't assume that end of chunk means end of stream.

2013-09-11 Thread Jacek Caban
Hi Hans, On 09/11/13 13:50, Hans Leidekker wrote: static DWORD chunked_get_avail_data(data_stream_t *stream, http_request_t *req) { -/* Allow reading only from read buffer */ +chunked_stream_t *chunked_stream = (chunked_stream_t*)stream; +DWORD res; + +

Re: wininet: Don't assume that end of chunk means end of stream.

2013-09-11 Thread Hans Leidekker
On Wed, 2013-09-11 at 16:38 +0200, Jacek Caban wrote: Hi Hans, On 09/11/13 13:50, Hans Leidekker wrote: static DWORD chunked_get_avail_data(data_stream_t *stream, http_request_t *req) { -/* Allow reading only from read buffer */ +chunked_stream_t *chunked_stream =

Re: [PATCH 4/5] ddraw: Avoid LPVOID.

2013-09-11 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2112 Your paranoid

Re: wininet: Don't assume that end of chunk means end of stream.

2013-09-11 Thread Jacek Caban
On 9/11/13 7:09 PM, Hans Leidekker wrote: On Wed, 2013-09-11 at 17:53 +0200, Jacek Caban wrote: Network traces tell me that native also performs a read on the first call to InternetQueryDataAvailable. Are you sure it's not an asynchronous read from a separated thread that is ordered by

Re: [PATCH 4/5] ddraw: Avoid LPVOID.

2013-09-11 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-11 19:05, schrieb Marvin: === wxppro (32 bit d3d) === d3d.c:1260: Test failed: Homogeneous output was generated despite UNCLIPPED flag Fyi, I am seeing those on my Windows machines as well. No idea why it suddenly started popping up on

Re: RFC: HKCR merge implementation

2013-09-11 Thread André Hentschel
Am 11.09.2013 01:15, schrieb Juan Lang: Hi George, On Tue, Sep 10, 2013 at 3:55 PM, George Stephanos gaf.stepha...@gmail.com mailto:gaf.stepha...@gmail.com wrote: I'm proposing my HKEY_CLASSES_ROOT implementation patches for review. Feel free to comment. So far, I've written

Re: wininet: Don't assume that end of chunk means end of stream.

2013-09-11 Thread Hans Leidekker
On Wed, 2013-09-11 at 17:53 +0200, Jacek Caban wrote: Network traces tell me that native also performs a read on the first call to InternetQueryDataAvailable. Are you sure it's not an asynchronous read from a separated thread that is ordered by InternetQueryDataAvailable if no data is

Re: wininet: Don't assume that end of chunk means end of stream.

2013-09-11 Thread Jacek Caban
On 09/11/13 17:32, Hans Leidekker wrote: On Wed, 2013-09-11 at 16:38 +0200, Jacek Caban wrote: Hi Hans, On 09/11/13 13:50, Hans Leidekker wrote: static DWORD chunked_get_avail_data(data_stream_t *stream, http_request_t *req) { -/* Allow reading only from read buffer */ +

Re: ws2_32: Fix WSADuplicateSocket implementation

2013-09-11 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2119 Your paranoid

Re: kernel32/tests: Add tests for ResolveDelayLoadedAPI (try3)

2013-09-11 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2121 Your paranoid

Re: [try3] gdi32: abc values remain the same despite any changes in layout direction or Viewport

2013-09-11 Thread Aric Stewart
Alexandre, Do you want me to rewrite this patch with your new width_to_LP helper function or are you going to do that rewrite yourself? (assuming it is acceptable in other ways) thanks! -aric

Re: ws2_32/tests: Add more WSASocket tests

2013-09-11 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2126 Your paranoid

Re: [PATCH 3/6] user32: Export WINPOS_GetMinMaxInfo() as __wine_get_min_max_info() so it can be called by drivers.

2013-09-11 Thread Dmitry Timoshkov
Ken Thomases k...@codeweavers.com wrote: +@ cdecl __wine_get_min_max_info(long ptr ptr ptr ptr) WINPOS_GetMinMaxInfo What's wrong with calling SendMessage(WM_GETMINMAXINFO) from the driver? -- Dmitry.

Re: [1/5] ntdll: Add support to NtWriteFile for special offset -1. Take 3.

2013-09-10 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@baikal.ru writes: @@ -961,16 +961,23 @@ NTSTATUS WINAPI NtWriteFile(HANDLE hFile, HANDLE hEvent, if (type == FD_TYPE_FILE) { +off_t off; + if (!(options (FILE_SYNCHRONOUS_IO_ALERT | FILE_SYNCHRONOUS_IO_NONALERT)) !offset) {

Re: xcopy: Add an explicit check to avoid an out of array access. access. (RESEND)

2013-09-10 Thread Alexandre Julliard
Gerald Pfeifer ger...@pfeifer.com writes: On Sun, 24 Mar 2013, Gerald Pfeifer wrote: This _may_ not be necessary, strictly speaking, but new versions of GCC (GCC 4.8) complain about this. (And there might be a fringe case?) How about this patch? I see it was not applied, but also did not

Re: [2/5] ntdll: Make NtWriteFile handle special offset -2 same way as -1. Resend.

2013-09-10 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@baikal.ru writes: --- dlls/ntdll/file.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) Why do you need that? It doesn't look to me like an improvement. -- Alexandre Julliard julli...@winehq.org

Re: [2/5] ntdll: Make NtWriteFile handle special offset -2 same way as -1. Resend.

2013-09-10 Thread Dmitry Timoshkov
Alexandre Julliard julli...@winehq.org wrote: Why do you need that? It doesn't look to me like an improvement. IMO it simplifies the code and avoids using two different code paths for normal files. -- Dmitry.

Re: [2/2] oledb32: Implement IDataSourceLocator get/put hWnd (resend)

2013-09-10 Thread Nikolay Sivov
On 9/10/2013 13:30, Alistair Leslie-Hughes wrote: Hi, Changelog: oledb32: Implement IDataSourceLocator get/put hWnd Best Regards Alistair Leslie-Hughes Hi, Alistair. This is wrong, interface definition should be fixed as well, HWND parameter can't be LONG: ---

Re: [2/5] ntdll: Make NtWriteFile handle special offset -2 same way as -1. Resend.

2013-09-10 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@baikal.ru writes: Alexandre Julliard julli...@winehq.org wrote: Why do you need that? It doesn't look to me like an improvement. IMO it simplifies the code and avoids using two different code paths for normal files. At the cost of two extra seeks, plus introducing

Re: winemac: Don't return characters for Ctrl-(non-letter symbol) keypresses from ToUnicodeEx() as X11 driver already does (try 2)

2013-09-10 Thread Phil Krylov
Hi, On Tue, Sep 10, 2013 at 6:05 AM, Ken Thomases k...@codeweavers.com wrote: Is there a specific problem that you're trying to fix? Yes. I didn't file a bug report yet, but an application I am using (IBM Translation Manager) has some functionality bound to Ctrl-[0-9/] keypresses. Now with the

Re: ntdll: Try application manifest path when searching for dependent assemblies

2013-09-10 Thread Alexandre Julliard
Nikolay Sivov nsi...@codeweavers.com writes: @@ -2776,8 +2776,7 @@ static NTSTATUS lookup_assembly(struct actctx_loader* acl, /* FIXME: add support for language specific lookup */ nameW.Buffer = NULL; -if (!(buffer = RtlAllocateHeap( GetProcessHeap(), 0, -

Re: winemac: Don't return characters for Ctrl-(non-letter symbol) keypresses from ToUnicodeEx() as X11 driver already does (try 2)

2013-09-10 Thread Ken Thomases
On Sep 10, 2013, at 5:45 AM, Phil Krylov wrote: On Tue, Sep 10, 2013 at 6:05 AM, Ken Thomases k...@codeweavers.com wrote: Is there a specific problem that you're trying to fix? Yes. I didn't file a bug report yet, but an application I am using (IBM Translation Manager) has some

RFC: HKCR merge implementation

2013-09-10 Thread George Stephanos
I'm proposing my HKEY_CLASSES_ROOT implementation patches for review. Feel free to comment. So far, I've written code for all functions except for the RegEnum family. General description: HKCR handles are special. All wine handles have the two lowest bits zero'd. HKCR handles are masked. 10b

Re: RFC: HKCR merge implementation

2013-09-10 Thread Juan Lang
Hi George, On Tue, Sep 10, 2013 at 3:55 PM, George Stephanos gaf.stepha...@gmail.comwrote: I'm proposing my HKEY_CLASSES_ROOT implementation patches for review. Feel free to comment. So far, I've written code for all functions except for the RegEnum family. General description: HKCR

Re: Embedding a HWND window into an X11 window

2013-09-10 Thread jordan
Could we extend winelib to let user embed win32 window into X11 window? Wouldn't you do this at the toolkit level? (in your winelib app) like gtkplug+gtksocket or something like that?? ie: in Gtk+ https://developer.gnome.org/gtk3/3.7/GtkPlug.html I was thinking about testing this out in a

Re: RFC: HKCR merge implementation

2013-09-10 Thread George Stephanos
a couple bitwise nits in your first patch: +#define HKCR_MASK 2 +#define IS_HKCR(hk) ((UINT_PTR)hk 0 ((UINT_PTR)hk 3) == HKCR_MASK) Typically a mask would define all the bits that could be set, and a flag would be the particular bit you want to test. Something like: #define

Re: [PATCH 3/6] ws2_32: Fix parameters checking in WSADuplicateSocket

2013-09-09 Thread Alexandre Julliard
Bruno Jesus 00cp...@gmail.com writes: +fd = get_sock_fd( s, FILE_READ_DATA, NULL ); +if (fd == -1) +{ +SetLastError(WSAENOTSOCK); +return SOCKET_ERROR; +} +release_sock_fd( s, fd ); You should avoid retrieving the fd if you are not using it. The handle

Re: [PATCH 1/5] wined3d: Don't mess with the device in buffer_create_buffer_object

2013-09-09 Thread Henri Verbeet
On 9 September 2013 12:56, Stefan Dösinger ste...@codeweavers.com wrote: @@ -148,7 +149,7 @@ static void buffer_create_buffer_object(struct wined3d_buffer *This, const struc } if (This-buffer_type_hint == GL_ELEMENT_ARRAY_BUFFER_ARB) -

Re: [PATCH 5/5] wined3d: Explicitly pass the state information to buffer_internal_preload

2013-09-09 Thread Henri Verbeet
On 9 September 2013 12:56, Stefan Dösinger ste...@codeweavers.com wrote: -static BOOL buffer_find_decl(struct wined3d_buffer *This, const struct wined3d_context *context) +static BOOL buffer_find_decl(struct wined3d_buffer *This, const struct wined3d_context *context, +const struct

Re: [PATCH 4/5] wined3d: Move the decoded stream info into the context

2013-09-09 Thread Henri Verbeet
On 9 September 2013 12:56, Stefan Dösinger ste...@codeweavers.com wrote: --- I think this patch does a couple of things at once, and would probably benefit from being broken up. static struct arb_vs_compiled_shader *find_arb_vshader(struct wined3d_shader *shader, -const struct

Re: [PATCH 4/5] wined3d: Move the decoded stream info into the context

2013-09-09 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-09 13:42, schrieb Henri Verbeet: I think that's an unfortunate place to insert the field, and you should update the padding. @@ -1880,9 +1889,7 @@ struct wined3d_device WORD d3d_initialized : 1; WORD inScene : 1;

Re: [PATCH 4/5] wined3d: Move the decoded stream info into the context

2013-09-09 Thread Henri Verbeet
On 9 September 2013 13:49, Stefan Dösinger ste...@codeweavers.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-09 13:42, schrieb Henri Verbeet: I think that's an unfortunate place to insert the field, and you should update the padding. @@ -1880,9 +1889,7 @@ struct

Re: [PATCH 4/5] wined3d: Move the decoded stream info into the context

2013-09-09 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-09 13:55, schrieb Henri Verbeet: Not strictly, but I think it helps with keeping track of how much bits are left and avoiding silly things like holes in the structure. Fair enough. Please ignore patches 4 and 5 for today, I'll take my

Re: [PATCH 3/6] ws2_32: Fix parameters checking in WSADuplicateSocket

2013-09-09 Thread Bruno Jesus
On Mon, Sep 9, 2013 at 6:39 AM, Alexandre Julliard julli...@winehq.org wrote: Bruno Jesus 00cp...@gmail.com writes: +fd = get_sock_fd( s, FILE_READ_DATA, NULL ); +if (fd == -1) +{ +SetLastError(WSAENOTSOCK); +return SOCKET_ERROR; +} +release_sock_fd( s,

Re: [PATCH 3/6] ws2_32: Fix parameters checking in WSADuplicateSocket

2013-09-09 Thread Alexandre Julliard
Bruno Jesus 00cp...@gmail.com writes: On Mon, Sep 9, 2013 at 6:39 AM, Alexandre Julliard julli...@winehq.org wrote: Bruno Jesus 00cp...@gmail.com writes: +fd = get_sock_fd( s, FILE_READ_DATA, NULL ); +if (fd == -1) +{ +SetLastError(WSAENOTSOCK); +return

Re: server: Add a serial event mask change counter.

2013-09-09 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@baikal.ru writes: @@ -209,7 +211,7 @@ DECL_HANDLER(get_serial_info) reply-writemult= serial-writemult; /* event mask */ -reply-eventmask= serial-eventmask; +reply-eventmask= serial-eventmask | (serial-generation 16);

Re: [PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty

2013-09-09 Thread Wolfgang Walter
Am Sonntag, 8. September 2013, 11:32:26 schrieb Francois Gouget: On Thu, 5 Sep 2013, Wolfgang Walter wrote: [...] To see that my later patches are needed you must modify the test a little bit: - dlls/kernel32/tests/comm.c.old 2013-09-05 13:40:10.275757373 +0200 +++

Re: D3D command stream patches for testing

2013-09-09 Thread LOMBARD Maxime
Hi Stefan, I've tested two games FarCry3 and Splinter Cell Blacklist with : - Wine 1.7.1 + CS patch + CSMT On/Off - Wine 1.7.1 clean - CSMT On = CSMT enabled + StrictDrawOrdering disabled - CSMT Off = CSMT disabled + StrictDrawOrdering enabled I run the game by *WINEDEBUG=fps,err-all,fixme-all

Re: [1/5] ntdll: Add support to NtWriteFile for special offset -1. Take 2.

2013-09-09 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@baikal.ru writes: --- dlls/ntdll/file.c | 13 ++--- dlls/ntdll/tests/file.c | 15 --- 2 files changed, 10 insertions(+), 18 deletions(-) This is causing test failures all over the place. -- Alexandre Julliard julli...@winehq.org

Re: winemac: Don't return characters for Ctrl-(non-letter symbol) keypresses from ToUnicodeEx() as X11 driver already does (try 2)

2013-09-09 Thread Ken Thomases
Hi, On Sep 9, 2013, at 7:38 PM, Phil Krylov wrote: Sorry, my first try had wrong patch attached -- Ph. 0001-winemac-Don-t-return-characters-for-Ctrl-non-letter-try2.patch.txt Is there a specific problem that you're trying to fix? The Mac driver's ToUnicodeEx() implementation started out

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 5)

2013-09-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2084 Your paranoid

Re: [PATCH 4/6] ws2_32: Add more WSADuplicateSocket tests

2013-09-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2063 Your paranoid

Implementation of ITextDocument_fnOpen needs some advice

2013-09-08 Thread Jactry Zeng
Hi folks, I need your advice or comment! Implement ITextDocument_fnOpen[0] (riched20) is a part of work to my GSoC. The 'pencils down' date is coming. And I think it is time to clear the code up. This series of patches is the implementation of ITextDocument_fnOpen. I would like to improve

Re: [PATCH 6/6] ws2_32: Fill WSAPROTOCOL_INFO struct in WSADuplicateSocket

2013-09-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2065 Your paranoid

Re: [PATCH 5/6] ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 4)

2013-09-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2064 Your paranoid

Re: [PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty

2013-09-08 Thread Francois Gouget
On Thu, 5 Sep 2013, Wolfgang Walter wrote: [...] To see that my later patches are needed you must modify the test a little bit: - dlls/kernel32/tests/comm.c.old 2013-09-05 13:40:10.275757373 +0200 +++ dlls/kernel32/tests/comm.c 2013-09-05 13:40:06.779074398 +0200 @@ -844,6 +844,8 @@

Re: [PATCH 1/6] ws2_32: Mark WinNT result as broken

2013-09-08 Thread Bruno Jesus
On Sun, Sep 8, 2013 at 1:58 AM, Marvin test...@winehq.org wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at

Re: ntdll: Implement job objects. (try 3)

2013-09-07 Thread Alexandre Julliard
Andrew Cook aris...@gmail.com writes: This will be my last submission for this piece of code, i want to work on other things and it's been almost 2 weeks with zero comments on my previous submission. It's clearly not ready, and you already know that since you've added TODOs all over the

Re: Patch for bug 34388

2013-09-07 Thread Juan Lang
On Fri, Sep 6, 2013 at 9:17 PM, Charles Davis cdavi...@gmail.com wrote: On Sep 6, 2013, at 5:01 PM, Juan Lang wrote: On Fri, Sep 6, 2013 at 3:54 PM, Charles Davis cdavi...@gmail.com wrote: Maybe then the real fix is to make Wine accept either a constructor SET or the custom tag

Re: [PATCH 1/6] ws2_32: Mark WinNT result as broken

2013-09-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2061 Your paranoid

Re: [PATCH 3/6] ws2_32: Fix parameters checking in WSADuplicateSocket

2013-09-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2062 Your paranoid

Patch for bug 34388

2013-09-06 Thread Charles Davis
Hi Juan, I need some advice. Attached is a patch to fix bug 34388, where an app that tries to verify its code signature fails because Wine, while parsing the certificates embedded within the signature, encounters an item in the CMS signer info (tag 0x31, i.e. ASN_UNIVERSAL | ASN_CONSTRUCTOR |

Re: ntdll/tests: Add tests for job objects. (try 2)

2013-09-06 Thread Frédéric Delanoy
On Fri, Sep 6, 2013 at 5:41 AM, Andrew Cook aris...@gmail.com wrote: --- dlls/ntdll/tests/Makefile.in | 1 + dlls/ntdll/tests/job.c | 151 +++ include/winnt.h | 5 ++ 3 files changed, 157 insertions(+) create mode 100644

Re: ntdll/tests: Add tests for job objects. (try 2)

2013-09-06 Thread Andrew Cook
On 06/09/13 17:12, Frédéric Delanoy wrote: On Fri, Sep 6, 2013 at 5:41 AM, Andrew Cook aris...@gmail.com wrote: --- dlls/ntdll/tests/Makefile.in | 1 + dlls/ntdll/tests/job.c | 151 +++ include/winnt.h | 5 ++ 3 files changed,

Re: crypt32 patch review

2013-09-06 Thread Jacek Caban
On 09/05/13 18:53, Juan Lang wrote: [+wine-devel] Hi Jacek, I've added the list so the discussion can take place in public. On Tue, Sep 3, 2013 at 8:50 AM, Jacek Caban ja...@codeweavers.com mailto:ja...@codeweavers.com wrote: I have a patch for crypt32. I'd appreciate your review

Re: [2/6] ntdll: Add support to NtWriteFile for special offset -1.

2013-09-06 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@baikal.ru writes: --- dlls/ntdll/file.c | 3 +++ dlls/ntdll/tests/file.c | 15 --- 2 files changed, 3 insertions(+), 15 deletions(-) diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c index 9420df5..9d5b02a 100644 --- a/dlls/ntdll/file.c +++

Re: [PATCH 2/3] ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 3)

2013-09-06 Thread Alexandre Julliard
Bruno Jesus 00cp...@gmail.com writes: +static int ws_protocol_info(SOCKET s, int unicode, WSAPROTOCOL_INFOW *buffer) +{ +int size; +union _info +{ +WSAPROTOCOL_INFOA *a; +WSAPROTOCOL_INFOW *w; +} info; +info.w = buffer; + +size = unicode ?

Re: [PATCH 2/3] ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 3)

2013-09-06 Thread Bruno Jesus
On Fri, Sep 6, 2013 at 7:16 AM, Alexandre Julliard julli...@winehq.org wrote: Bruno Jesus 00cp...@gmail.com writes: +static int ws_protocol_info(SOCKET s, int unicode, WSAPROTOCOL_INFOW *buffer) +{ +int size; +union _info +{ +WSAPROTOCOL_INFOA *a; +

Re: [2/6] ntdll: Add support to NtWriteFile for special offset -1.

2013-09-06 Thread Dmitry Timoshkov
Alexandre Julliard julli...@winehq.org wrote: +if (offset offset-QuadPart == (LONGLONG)-1 /* FILE_WRITE_TO_END_OF_FILE */) +offset-QuadPart = lseek( unix_handle, 0, SEEK_END ); + This looks very wrong, offset belongs to the caller. Of course you are correct,

Re: aclui: Remove some unneeded header inclusions. (IWYU)

2013-09-06 Thread Alexandre Julliard
Amine Khaldi amine.kha...@reactos.org writes: @@ -18,15 +18,7 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ -#include config.h - -#include stdarg.h - #include initguid.h -#include windef.h -#include winbase.h -#include winuser.h -#include

Re: aclui: Remove some unneeded header inclusions. (IWYU)

2013-09-06 Thread Amine Khaldi
On 06/09/2013 16:28, Alexandre Julliard wrote: Amine Khaldi amine.kha...@reactos.org writes: @@ -18,15 +18,7 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ -#include config.h - -#include stdarg.h - #include initguid.h -#include windef.h

Re: aclui: Remove some unneeded header inclusions. (IWYU)

2013-09-06 Thread Alexandre Julliard
Amine Khaldi amine.kha...@reactos.org writes: On 06/09/2013 16:28, Alexandre Julliard wrote: Amine Khaldi amine.kha...@reactos.org writes: @@ -18,15 +18,7 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ -#include config.h - -#include stdarg.h -

Re: Patch for bug 34388

2013-09-06 Thread Juan Lang
Hiya Chip, I don't have an answer off the top of my head. But let's see if we can unpack that ASN.1 a bit. First, with the type, notice that crypt32_private.h defines a few useful types that Microsoft omitted for some reason from their public header, including: #define ASN_SETOF

RFC: Completely revised SIO_ADDRESS_LIST_CHANGE patches

2013-09-06 Thread Erich E. Hoover
As some of you know I've been working on fixing SIO_ADDRESS_LIST_CHANGE in order to fix some problems with Silverlight on a variety of streaming sites. Due to some feedback I've received I've gone to the effort to completely revise these patches to work inside of the server instead of using

Re: Patch for bug 34388

2013-09-06 Thread Charles Davis
On Sep 6, 2013, at 1:10 PM, Juan Lang wrote: Hiya Chip, I don't have an answer off the top of my head. But let's see if we can unpack that ASN.1 a bit. First, with the type, notice that crypt32_private.h defines a few useful types that Microsoft omitted for some reason from their

Re: Patch for bug 34388

2013-09-06 Thread Juan Lang
On Fri, Sep 6, 2013 at 3:54 PM, Charles Davis cdavi...@gmail.com wrote: Maybe then the real fix is to make Wine accept either a constructor SET or the custom tag (ASN_CONTEXT | ASN_CONSTRUCTOR) it currently accepts, for either attribute set. I should come up with a test case first, though, to

Re: Patch for bug 34388

2013-09-06 Thread Charles Davis
On Sep 6, 2013, at 5:01 PM, Juan Lang wrote: On Fri, Sep 6, 2013 at 3:54 PM, Charles Davis cdavi...@gmail.com wrote: Maybe then the real fix is to make Wine accept either a constructor SET or the custom tag (ASN_CONTEXT | ASN_CONSTRUCTOR) it currently accepts, for either attribute set. I

Re: D3D command stream patches for testing

2013-09-05 Thread Prot Secret
Hi, I am interested in your work, but after patching wine171 of this patch and enabled csmt, i have seen this in SC2 http://postimg.org/gallery/1w8y6jbg I use nvidia GTX 680 with proprietary i386 nvidia driver 319.49. Where I could be wrong, or what else can be set that would be normalized image

Re: D3D command stream patches for testing

2013-09-05 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-04 20:11, schrieb Prot Secret: Hi, I am interested in your work, but after patching wine171 of this patch and enabled csmt, i have seen this in SC2 http://postimg.org/gallery/1w8y6jbg I use nvidia GTX 680 with proprietary i386 nvidia

Re: [PATCH 1/5] use a correct timeout in test_waittxempty

2013-09-05 Thread Wolfgang Walter
On Thursday 05 September 2013 10:32:15 Dmitry Timoshkov wrote: Wolfgang Walter w...@stwm.de wrote: When we send 17 bytes with 150 baud, no parity, one stop bit then we need to wait at least 17*10/150 seconds 1000 ms Under Windows with both real COM-port and USB-serial cable this test

Re: [PATCH 5/5] kernel32/tests: remove several todos in test_waittxempty

2013-09-05 Thread Wolfgang Walter
On Thursday 05 September 2013 10:42:40 you wrote: Wolfgang Walter w...@stwm.de wrote: -ok(!res GetLastError() == ERROR_IO_PENDING, %d: WaitCommEvent error %d\n, i, GetLastError()); +ok(res || (!res GetLastError() == ERROR_IO_PENDING), %d: WaitCommEvent error %d\n, i,

Re: [PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty

2013-09-05 Thread Wolfgang Walter
On Thursday 05 September 2013 10:37:22 you wrote: Wolfgang Walter w...@stwm.de wrote: +if (res || (!res GetLastError() == ERROR_IO_PENDING)) +/* if data has been sent: wait for termination */ +Sleep(timeout); I don't see such a problem with real COM-port and

Re: [PATCH 1/5] use a correct timeout in test_waittxempty

2013-09-05 Thread Dmitry Timoshkov
Wolfgang Walter w...@stwm.de wrote: When we send 17 bytes with 150 baud, no parity, one stop bit then we need to wait at least 17*10/150 seconds 1000 ms Under Windows with both real COM-port and USB-serial cable this test takes no longer than 890 ms, usually it's even shorter like

Re: [PATCH 5/5] kernel32/tests: remove several todos in test_waittxempty

2013-09-05 Thread Dmitry Timoshkov
Wolfgang Walter w...@stwm.de wrote: On Thursday 05 September 2013 10:42:40 you wrote: Wolfgang Walter w...@stwm.de wrote: -ok(!res GetLastError() == ERROR_IO_PENDING, %d: WaitCommEvent error %d\n, i, GetLastError()); +ok(res || (!res GetLastError() ==

<    1   2   3   4   5   6   7   8   9   10   >