Re: iphlpapi: Add AllocateAndGetTcpExTableFromStack().

2013-08-31 Thread Bruno Jesus
On Sat, Aug 31, 2013 at 9:16 AM, Ralf Habacker ralf.habac...@freenet.de wrote: new - add doc for family parameter - add doc for additional return code - sorting in c file fixed Signed-off-by: Ralf Habacker ralf.habac...@freenet.de I guess the patch was marked as pending because you didn't

Re: [2/2] ntdll: Store full line status register in the internal structure, not just the TIOCSER_TEMT bit.

2013-08-30 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@baikal.ru writes: Dmitry Timoshkov dmi...@baikal.ru wrote: Printing complete lsr value in the log may help with diagnosing test failures on Alexandre's machine. This patch is marked as 'Build failure' in the tracker, but I've checked it once again and compiles just

Re: d3d9: Partial implementation of IDirect3DSwapChain9Ex

2013-08-30 Thread Nikolay Sivov
On 8/30/2013 12:19, Michael Müller wrote: This patch implements the IDirect3DSwapChain9Ex interface as an extension of IDirect3DSwapChain9 and thus fixes bug 34252 - Silverlight accelerated graphics cause a D3D critical section lockup since Silverlight does no longer try to create a Direct3D

Re: d3d9: Partial implementation of IDirect3DSwapChain9Ex

2013-08-30 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Am 2013-08-30 10:19, schrieb Michael Müller: This patch implements the IDirect3DSwapChain9Ex interface as an extension of IDirect3DSwapChain9 and thus fixes bug 34252 - Silverlight accelerated graphics cause a D3D critical section lockup

Re: ntdll: Store full line status register in the internal structure, not just the TIOCSER_TEMT bit. Take 2.

2013-08-30 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@baikal.ru writes: Printing complete lsr value in the log may help with diagnosing test failures on Alexandre's machine. I don't see how, since TIOCSER_TEMT is the only defined bit. Do you actually have a driver that returns other status? -- Alexandre Julliard

Re: ntdll: Store full line status register in the internal structure, not just the TIOCSER_TEMT bit. Take 2.

2013-08-30 Thread Dmitry Timoshkov
Alexandre Julliard julli...@winehq.org wrote: Printing complete lsr value in the log may help with diagnosing test failures on Alexandre's machine. I don't see how, since TIOCSER_TEMT is the only defined bit. Do you actually have a driver that returns other status? I don't, but maybe

Re: ntdll: Store full line status register in the internal structure, not just the TIOCSER_TEMT bit. Take 2.

2013-08-30 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@baikal.ru writes: Alexandre Julliard julli...@winehq.org wrote: Printing complete lsr value in the log may help with diagnosing test failures on Alexandre's machine. I don't see how, since TIOCSER_TEMT is the only defined bit. Do you actually have a driver that

Re: ntdll: Store full line status register in the internal structure, not just the TIOCSER_TEMT bit. Take 2.

2013-08-30 Thread Dmitry Timoshkov
Alexandre Julliard julli...@winehq.org wrote: Printing complete lsr value in the log may help with diagnosing test failures on Alexandre's machine. I don't see how, since TIOCSER_TEMT is the only defined bit. Do you actually have a driver that returns other status? I don't, but

Re: kernel32/tests: Add a FlushFileBuffers test for a COM port. Resend.

2013-08-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=1932 Your paranoid

Re: ntdll: Store full line status register in the internal structure, not just the TIOCSER_TEMT bit. Take 2.

2013-08-30 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@baikal.ru writes: Alexandre Julliard julli...@winehq.org wrote: Printing complete lsr value in the log may help with diagnosing test failures on Alexandre's machine. I don't see how, since TIOCSER_TEMT is the only defined bit. Do you actually have a driver

Re: oleaut32: Add ICreateTypeInfo2::SetVarName implementation

2013-08-30 Thread Nikolay Sivov
On 8/30/2013 16:28, Piotr Caban wrote: --- dlls/oleaut32/tests/typelib.c | 13 +++-- dlls/oleaut32/typelib.c | 13 +++-- 2 files changed, 22 insertions(+), 4 deletions(-) ITypeInfoImpl *This = info_impl_from_ICreateTypeInfo2(iface); -FIXME(%p %u %s - stub\n,

Sequences in a loop

2013-08-30 Thread matyapiro31
I found many wine sources use not a pointer,but a sequence . for example: krnl386.exe16/dma.c: for(i=0,p=(char*)DMA_CurrentBaseAddress[channel];iret*size;i++) msdaps/usrmarshal.c: for(prop = 0; prop rgPropertySets[prop_set].cProperties; prop++) I know in some cases to use sequences are wiser way

Re: Help to create a server request

2013-08-30 Thread Bruno Jesus
On Thu, Aug 29, 2013 at 10:38 PM, Charles Davis cdavi...@gmail.com wrote: To add a new request to the server, you first add a definition to server/protocol.def . This file is processed by the make_requests tool, which generates a bunch of other files from it. The syntax of the server protocol

Re: Sequences in a loop

2013-08-30 Thread Nikolay Sivov
On 8/30/2013 16:33, matyapiro31 wrote: I found many wine sources use not a pointer,but a sequence . for example: krnl386.exe16/dma.c: for(i=0,p=(char*)DMA_CurrentBaseAddress[channel];iret*size;i++) msdaps/usrmarshal.c: for(prop = 0; prop rgPropertySets[prop_set].cProperties; prop++) I know in

Re: Sequences in a loop

2013-08-30 Thread Michael Stefaniuc
On 08/30/2013 02:33 PM, matyapiro31 wrote: I found many wine sources use not a pointer,but a sequence . for example: krnl386.exe16/dma.c: for(i=0,p=(char*)DMA_CurrentBaseAddress[channel];iret*size;i++) msdaps/usrmarshal.c: for(prop = 0; prop rgPropertySets[prop_set].cProperties; prop++) I

Re: [PATCH 5/5] wined3d: Enforce volume texture block restrictions

2013-08-30 Thread Henri Verbeet
On 30 August 2013 17:35, Stefan Dösinger ste...@codeweavers.com wrote: Am 2013-08-30 17:31, schrieb Henri Verbeet: Is this different from surfaces? IIRC surfaces are padded up to the next multiple of the block size, although I may have that wrong. Not a fan of the (%p) : trace formatting.

Re: [PATCH 5/5] wined3d: Enforce volume texture block restrictions

2013-08-30 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-30 17:31, schrieb Henri Verbeet: On 30 August 2013 00:19, Stefan Dösinger ste...@codeweavers.com wrote: +if (format-flags WINED3DFMT_FLAG_BLOCKS) +{ + UINT width_mask = format-block_width - 1; +UINT height_mask =

Re: [PATCH 3/5] d3d9/tests: Add a DXT5 volume test

2013-08-30 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-30 17:31, schrieb Henri Verbeet: On 30 August 2013 00:19, Stefan Dösinger ste...@codeweavers.com wrote: +/* A 8x4x2 texture consisting of 4 4x4 blocks. The colors of the blocks are red, green, blue and white. */ + 0xff, 0xff,

Re: [PATCH 3/5] d3d9/tests: Add a DXT5 volume test

2013-08-30 Thread Henri Verbeet
On 30 August 2013 00:19, Stefan Dösinger ste...@codeweavers.com wrote: +/* A 8x4x2 texture consisting of 4 4x4 blocks. The colors of the blocks are red, green, blue and white. */ +0xff, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xF8, 0x00, 0xF8, 0x00, 0x00, 0x00, 0x00,

Re: [PATCH 5/5] wined3d: Enforce volume texture block restrictions

2013-08-30 Thread Henri Verbeet
On 30 August 2013 00:19, Stefan Dösinger ste...@codeweavers.com wrote: +if (format-flags WINED3DFMT_FLAG_BLOCKS) +{ +UINT width_mask = format-block_width - 1; +UINT height_mask = format-block_height - 1; +if (desc-width width_mask || desc-height height_mask)

Re: [PATCH 5/5] wined3d: Enforce volume texture block restrictions

2013-08-30 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-30 17:50, schrieb Henri Verbeet: Well, regardless of which one it is, I don't see a similar check for 2D and cube textures at the moment. I think some tests would be welcome. You are right, there's neither a check nor tests. I am certain

Re: [PATCH] widl: Limit recursion deepth within structs to 1 for checking for full-pointers.

2013-08-30 Thread Paul Chitescu
Hi! It would help to attach the patch, not your editor's swap file. Paul On Friday 30 August 2013 10:57:26 pm Kai Tietz wrote: Hello, attached patch limits recursion in type_has_full_pointer-function to a deeth of 1. By this all necessary checks should be possible, but endless-recursion

Re: [PATCH] widl: Limit recursion deepth within structs to 1 for checking for full-pointers.

2013-08-30 Thread Kai Tietz
Ups, sorry 2013/8/30 Paul Chitescu pa...@voip.null.ro: Hi! It would help to attach the patch, not your editor's swap file. Paul On Friday 30 August 2013 10:57:26 pm Kai Tietz wrote: Hello, attached patch limits recursion in type_has_full_pointer-function to a deeth of 1. By this all

Re: [PATCH 3/3] ws2_32: Implement get socket option SO_PROTOCOL_INFO

2013-08-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=1945 Your paranoid

Re: [1/2] server: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port. Take 2.

2013-08-29 Thread Dmitry Timoshkov
Dmitry Timoshkov dmi...@baikal.ru wrote: Based on a patch of Wolfgang Walter. Is there anything wrong with this patch? -- Dmitry.

Re: [4/4] ntdll: Properly set flag which indicates buffer empty state.

2013-08-29 Thread Wolfgang Walter
Am Donnerstag, 29. August 2013, 10:47:46 schrieb Dmitry Timoshkov: Wolfgang Walter w...@stwm.de wrote: I think that happens: * application writes data to com port. * all is written, serial buffer is empty * application calls WaitCommEvent() * wait_on() is called * wait_on() calls

Embedding a HWND window into an X11 window

2013-08-29 Thread Alexandre Bique
Hi, How could I embed a HWND window created with CreateWindow() into an X11 window? Thanks! :-) -- Alexandre Bique

Re: [PATCH] iphlpapi: Add AllocateAndGetTcpExTableFromStack().

2013-08-29 Thread Ralf Habacker
On 28.08.2013 12:54, Hans Leidekker wrote: On Wed, 2013-08-28 at 12:21 +0200, Ralf Habacker wrote: diff --git a/dlls/iphlpapi/iphlpapi.spec b/dlls/iphlpapi/iphlpapi.spec index 36ba13f..1eed5ae 100644 --- a/dlls/iphlpapi/iphlpapi.spec +++ b/dlls/iphlpapi/iphlpapi.spec @@ -6,6 +6,7 @@ @ stdcall

Re: wininet: Replacing a header with an empty value deletes it.

2013-08-29 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://newtestbot.winehq.org/JobDetails.pl?Key=1918 Your paranoid

Re: patch:try 2 of adding wine ja mannual

2013-08-29 Thread Akihiro Sagawa
On Wed, 28 Aug 2013 20:29:43 +0900, �� wrote: diff --git a/loader/Makefile.in b/loader/Makefile.in index a7ab893..bc11378 100644 --- a/loader/Makefile.in +++ b/loader/Makefile.in @@ -20,14 +20,16 @@ MANPAGE = wine.man EXTRA_MANPAGES = \ wine.de.man \ wine.fr.man \ -

Re: patch:kernel32

2013-08-29 Thread Bruno Jesus
On Thu, Aug 29, 2013 at 11:15 AM, matyapiro31 matyapir...@gmail.com wrote: The patch could have a better subject =) +unix_len=sizeof(unix_vars)/sizeof(unix_vars[0]; Missing the closing ) ? Will this compile? -for ( i = 0; i sizeof (special) / sizeof (WCHAR); i++ ) +for ( i = 0; i

my patch was wrong at dlls/kernel32/computernames.c

2013-08-29 Thread matyapiro31
From if ( isalnumW ( wc ) ) return wc; for ( i = 0; i 17; i++ ) To if ( isalnumW ( wc ) ) return wc; for ( i = 0; i 16; i++ ) and the original version was wrong,too. It counts the NULL of the end.

Re: my patch was wrong at dlls/kernel32/computernames.c

2013-08-29 Thread Marcus Meissner
On Thu, Aug 29, 2013 at 11:31:06PM +0900, matyapiro31 wrote: From if ( isalnumW ( wc ) ) return wc; for ( i = 0; i 17; i++ ) To if ( isalnumW ( wc ) ) return wc; for ( i = 0; i 16; i++ ) and the original version was wrong,too. It counts the NULL of the end. Thats why you should use

Re: [PATCH 2/2] ddraw/tests: Test WM_ACTIVATEAPP messages generated by SetCooperativeLevel

2013-08-29 Thread Henri Verbeet
On 29 August 2013 11:14, Stefan Dösinger ste...@codeweavers.com wrote: +BOOL activateapp_received; +IDirectDraw *activateapp_ddraw; +HWND activateapp_window; +DWORD activateapp_coop_level; + I think those should be static, and you'll probably want to put them in a structure.

Re: RFC: Mark dylib/mach-o on Mac OS X

2013-08-29 Thread André Hentschel
Hi, thank you both for the comments, i'll see what i can do.

Re: gdi32: Fixed Rectangle() rotation problem with GM_ADVANCED graphics mode.

2013-08-29 Thread Alexandre Julliard
Ralf Habacker r...@habacker.de writes: see http://bugs.winehq.org/show_bug.cgi?id=34381 --- dlls/gdi32/painting.c | 18 -- 1 Datei geändert, 16 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) This would have to be done in the drivers. -- Alexandre Julliard

Re: patch:kernel32

2013-08-29 Thread Charles Davis
On Aug 29, 2013, at 8:15 AM, matyapiro31 wrote: 0001-kernel32-change-for-loop-to-optimize.patch0002-kernel32-change-for-loop-to-optimize.patch One patch per email, please. Also, the subject should be more descriptive. The first one doesn't look much better than the second one (which was

Re: Embedding a HWND window into an X11 window

2013-08-29 Thread Vincent Povirk
The systray/notification area code has to do that: http://source.winehq.org/source/dlls/winex11.drv/systray.c#L620 I don't think it can be done without modifying winex11.drv.

Re: Embedding a HWND window into an X11 window

2013-08-29 Thread Erich E. Hoover
The pipelight guys put together a patch to support XEmbed: http://www.compholio.com/wine-compholio/download.php?file=0008-winex11-Add-minimal-XEmbed-client-support.patch That might do what he wants. Best, Erich On Thu, Aug 29, 2013 at 1:33 PM, Vincent Povirk madewokh...@gmail.com wrote: The

Re: RFC: Mark dylib/mach-o on Mac OS X

2013-08-29 Thread André Hentschel
Am 29.08.2013 19:52, schrieb André Hentschel: Hi, thank you both for the comments, i'll see what i can do. How about that? diff --git a/dlls/dbghelp/module.c b/dlls/dbghelp/module.c index 6bea436..ed1d9c0 100644 --- a/dlls/dbghelp/module.c +++ b/dlls/dbghelp/module.c @@ -33,6 +33,7 @@

Re: Embedding a HWND window into an X11 window

2013-08-29 Thread André Hentschel
Am 29.08.2013 21:58, schrieb Erich E. Hoover: The pipelight guys put together a patch to support XEmbed: http://www.compholio.com/wine-compholio/download.php?file=0008-winex11-Add-minimal-XEmbed-client-support.patch That might do what he wants. might be interesting to clean/fix it up and try

Re: RFC: Mark dylib/mach-o on Mac OS X

2013-08-29 Thread Charles Davis
On Aug 29, 2013, at 2:35 PM, André Hentschel wrote: Am 29.08.2013 19:52, schrieb André Hentschel: Hi, thank you both for the comments, i'll see what i can do. How about that? Much better, but... diff --git a/programs/winedbg/info.c b/programs/winedbg/info.c index c0b86ba..0667ad7

Re: RFC: Mark dylib/mach-o on Mac OS X

2013-08-29 Thread André Hentschel
Am 29.08.2013 22:46, schrieb Charles Davis: On Aug 29, 2013, at 2:35 PM, André Hentschel wrote: Am 29.08.2013 19:52, schrieb André Hentschel: Hi, thank you both for the comments, i'll see what i can do. How about that? Much better, but... diff --git a/programs/winedbg/info.c

Re: Embedding a HWND window into an X11 window

2013-08-29 Thread Vincent Povirk
This solutions implies to modify wine, so do you think that this patch or an improved version could be merged into wine? Because I don't want to require a custom version of wine. Even if it were merged, that would not give you the ability to use it from within a Windows or winelib program. For

Re: RFC: Mark dylib/mach-o on Mac OS X

2013-08-29 Thread Alexandre Julliard
André Hentschel n...@dawncrow.de writes: Am 29.08.2013 19:52, schrieb André Hentschel: Hi, thank you both for the comments, i'll see what i can do. How about that? I don't see the point at all. There's no reason to add all that complexity for a purely cosmetic detail. -- Alexandre

Re: RFC: Mark dylib/mach-o on Mac OS X

2013-08-29 Thread André Hentschel
Am 29.08.2013 23:15, schrieb Alexandre Julliard: André Hentschel n...@dawncrow.de writes: Am 29.08.2013 19:52, schrieb André Hentschel: Hi, thank you both for the comments, i'll see what i can do. How about that? I don't see the point at all. There's no reason to add all that

Re: RFC: Mark dylib/mach-o on Mac OS X

2013-08-29 Thread Alexandre Julliard
André Hentschel n...@dawncrow.de writes: Am 29.08.2013 23:15, schrieb Alexandre Julliard: André Hentschel n...@dawncrow.de writes: Am 29.08.2013 19:52, schrieb André Hentschel: Hi, thank you both for the comments, i'll see what i can do. How about that? I don't see the point at all.

Help to create a server request

2013-08-29 Thread Bruno Jesus
Hi all, I need some help to continue my current wine work. In order to implement SO_PROTOCOL_INFO for getsockopt I need to retrieve some information from the socket like its family and protocol. I have searched for a few days and ended up with a solution I dislike so I had a better idea (at

Re: Help to create a server request

2013-08-29 Thread Charles Davis
On Aug 29, 2013, at 6:43 PM, Bruno Jesus wrote: Hi all, I need some help to continue my current wine work. In order to implement SO_PROTOCOL_INFO for getsockopt I need to retrieve some information from the socket like its family and protocol. I have searched for a few days and ended up

Re: [2/2] ntdll: Store full line status register in the internal structure, not just the TIOCSER_TEMT bit.

2013-08-29 Thread Dmitry Timoshkov
Dmitry Timoshkov dmi...@baikal.ru wrote: Printing complete lsr value in the log may help with diagnosing test failures on Alexandre's machine. This patch is marked as 'Build failure' in the tracker, but I've checked it once again and compiles just fine here. What kind of build failure is that?

Re: [4/4] ntdll: Properly set flag which indicates buffer empty state.

2013-08-28 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@baikal.ru writes: Dmitry Timoshkov dmi...@baikal.ru wrote: Alexandre Julliard julli...@winehq.org wrote: It doesn't work here: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so comm.c touch comm.ok comm.c:835: Test

Re: [4/4] ntdll: Properly set flag which indicates buffer empty state.

2013-08-28 Thread Dmitry Timoshkov
Alexandre Julliard julli...@winehq.org wrote: I assume it's a real hardware and not a VM? Is this with a real COM port, or USB-serial cable? If the latter one what driver is it using? Looking at the failure messages above once again, I can say that WriteFile failure is definitely not

Re: [4/4] ntdll: Properly set flag which indicates buffer empty state.

2013-08-28 Thread Wolfgang Walter
On Wednesday 28 August 2013 12:41:00 Dmitry Timoshkov wrote: Dmitry Timoshkov dmi...@baikal.ru wrote: Alexandre Julliard julli...@winehq.org wrote: It doesn't work here: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so comm.c touch comm.ok

Re: [PATCH] iphlpapi: Add AllocateAndGetTcpExTableFromStack().

2013-08-28 Thread Nikolay Sivov
On 8/28/2013 13:41, Ralf Habacker wrote: Signed-off-by: Ralf Habacker ralf.habac...@freenet.de --- dlls/iphlpapi/iphlpapi.spec |1 + dlls/iphlpapi/ipstats.c | 26 ++ dlls/iphlpapi/ipstats.h |1 + include/tcpmib.h|3 +++ 4 Dateien

Re: [PATCH] iphlpapi: Add AllocateAndGetTcpExTableFromStack().

2013-08-28 Thread Hans Leidekker
On Wed, 2013-08-28 at 11:41 +0200, Ralf Habacker wrote: diff --git a/dlls/iphlpapi/iphlpapi.spec b/dlls/iphlpapi/iphlpapi.spec index 36ba13f..cad2ca9 100644 --- a/dlls/iphlpapi/iphlpapi.spec +++ b/dlls/iphlpapi/iphlpapi.spec @@ -6,6 +6,7 @@ @ stdcall AllocateAndGetIpForwardTableFromStack(

Re: [PATCH] iphlpapi: Add AllocateAndGetTcpExTableFromStack().

2013-08-28 Thread Hans Leidekker
On Wed, 2013-08-28 at 12:21 +0200, Ralf Habacker wrote: diff --git a/dlls/iphlpapi/iphlpapi.spec b/dlls/iphlpapi/iphlpapi.spec index 36ba13f..1eed5ae 100644 --- a/dlls/iphlpapi/iphlpapi.spec +++ b/dlls/iphlpapi/iphlpapi.spec @@ -6,6 +6,7 @@ @ stdcall AllocateAndGetIpForwardTableFromStack(

Re: [4/4] ntdll: Properly set flag which indicates buffer empty state.

2013-08-28 Thread Wolfgang Walter
Hello Dimitry, I think I now found the difference between my patches and yours and what makes that one application fail (with or without [4/4] ntdll: Properly set flag which indicates buffer empty state.) My patch removes the attempt to flag EV_TXEMPTY only once. In check_events() EV_TXEMPTY

Re: [AppDB] How to deal with hardware/driver dependent test result?

2013-08-28 Thread Rosanne DiMesio
On Wed, 28 Aug 2013 11:57:26 +0800 Felix Yan felixonm...@gmail.com wrote: I'm maintaining Spore 1.0, and it works correctly in wine for over a year on Nvidia video card with closed-source nvidia driver - but I do noticed with Intel cards with open source drivers, the game is nearly not

Re: [PATCH] iphlpapi: Add AllocateAndGetTcpExTableFromStack().

2013-08-28 Thread Hans Leidekker
On Wed, 2013-08-28 at 14:49 +0200, Ralf Habacker wrote: diff --git a/dlls/iphlpapi/ipstats.h b/dlls/iphlpapi/ipstats.h index bf5bb92..efdb1cc 100644 --- a/dlls/iphlpapi/ipstats.h +++ b/dlls/iphlpapi/ipstats.h @@ -33,6 +33,7 @@ DWORD getInterfaceStatsByName(const char *name,

Re: ntdll: Store all 'comClass' attributes (try3)

2013-08-28 Thread Michael Stefaniuc
Hello Nikolay, On 08/27/2013 12:16 PM, Nikolay Sivov wrote: +static OLEMISC get_olemisc_value(const WCHAR *str, int len) +{ +int min, max; + +min = 0; +max = sizeof(olemisc_values)/sizeof(struct olemisc_entry) - 1; + +while (min = max) +{ +int n, c; + +

Re: [4/4] ntdll: Properly set flag which indicates buffer empty state.

2013-08-28 Thread Dmitry Timoshkov
Dmitry Timoshkov dmi...@baikal.ru wrote: Wolfgang Walter w...@stwm.de wrote: I think that happens: * application writes data to com port. * all is written, serial buffer is empty * application calls WaitCommEvent() * wait_on() is called * wait_on() calls get_irq_info() *

Re: [4/4] ntdll: Properly set flag which indicates buffer empty state.

2013-08-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26878 Your paranoid

Re: ntdll: Store all 'comClass' attributes (try2)

2013-08-27 Thread Alexandre Julliard
Nikolay Sivov nsi...@codeweavers.com writes: +static OLEMISC get_olemisc_value(const WCHAR *str, int len) +{ +int min, max; + +min = 0; +max = ARRAY_SIZE(olemisc_values) - 1; + +while (min = max) +{ +int n, c; + +n = (min+max)/2; + +c =

Re: [4/4] ntdll: Properly set flag which indicates buffer empty state.

2013-08-27 Thread Dmitry Timoshkov
Marvin test...@testbot.winehq.org wrote: === WVISTAX64 (32 bit comm) === comm.c:835: Test failed: WriteFile took 16 ms to write 0 Bytes at 150 Baud Failure is not caused by this patch, probably a VM is very slow. -- Dmitry.

Re: [1/4] ntdll: Ignore ioctl(TIOCGICOUNT) failures.

2013-08-27 Thread Wolfgang Walter
Hello, I made similar changes so that several applications we use work. I tested your patches, all but one do work. I don't know why one does not, though. I attached my patch, maybe it is usefull to you. Regards, -- Wolfgang Walter Studentenwerk München Anstalt des öffentlichen Rechts

Re: [1/4] ntdll: Ignore ioctl(TIOCGICOUNT) failures.

2013-08-27 Thread Dmitry Timoshkov
Hi Wolfgang, Wolfgang Walter w...@stwm.de wrote: I made similar changes so that several applications we use work. I tested your patches, all but one do work. I don't know why one does not, though. What patch doesn't work for you? Do you have a test case or a specific scenario which doesn't

Re: ntdll: Implement job objects

2013-08-27 Thread Dmitry Timoshkov
Andrew Cook aris...@gmail.com wrote: +typedef struct _JOBOBJECT_ASSOCIATE_COMPLETION_PORT { + PVOID CompletionKey; + HANDLE CompletionPort; +} JOBOBJECT_ASSOCIATE_COMPLETION_PORT, *PJOBOBJECT_ASSOCIATE_COMPLETION_PORT; This needs to go into its owm header. +static DWORD

Re: ntdll: Implement job objects

2013-08-27 Thread Andrew Cook
On 27/08/13 22:02, Dmitry Timoshkov wrote: Andrew Cook aris...@gmail.com wrote: --- a/include/wine/server_protocol.h +++ b/include/wine/server_protocol.h And don't include autogenerated stuff in the patch. Is there anything about this on the wiki? i wasn't sure how autogenerated files are

Re: ntdll: Implement job objects

2013-08-27 Thread Dmitry Timoshkov
Andrew Cook aris...@gmail.com wrote: On 27/08/13 22:02, Dmitry Timoshkov wrote: Andrew Cook aris...@gmail.com wrote: --- a/include/wine/server_protocol.h +++ b/include/wine/server_protocol.h And don't include autogenerated stuff in the patch. Is there anything about this on the

Re: ntdll: Implement job objects

2013-08-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26885 Your paranoid

Re: Does auto-apt work to get wine dependencies in source code?

2013-08-27 Thread Susan Cragin
--Sorry about the HTML in the earlier message. Was thinking of running some tests but the list of dependencies on the website seems outdated, apt-get build-dep does not work. Is that with the ubuntu-wine ppa enabled? There are two answers to that question, surprisingly. (1) bitbox In the

Retiring winetestbot

2013-08-27 Thread Jeremy White
Folks, I am writing to announce that we will be retiring the original Wine Test Bot, written by the late Ge van Geldorp, as of August 31, 2013. We will switch over to the new test bot that Francois has been working on at that time. On September 1, we'll panic and fix everything that is broken

Re: [1/4] ntdll: Ignore ioctl(TIOCGICOUNT) failures.

2013-08-27 Thread Wolfgang Walter
Am Dienstag, 27. August 2013, 22:00:59 schrieben Sie: Wolfgang Walter w...@stwm.de wrote: Wolfgang Walter w...@stwm.de wrote: I made similar changes so that several applications we use work. I tested your patches, all but one do work. I don't know why one does not, though.

Re: [4/4] ntdll: Properly set flag which indicates buffer empty state.

2013-08-27 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@baikal.ru writes: --- dlls/kernel32/tests/comm.c | 5 + dlls/ntdll/serial.c| 13 + 2 files changed, 6 insertions(+), 12 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so

RFC: Mark dylib/mach-o on Mac OS X

2013-08-27 Thread André Hentschel
Hi, at [1] i noticed that dylibs are printed as PEs. This intents to fix that, but i have no Mac, could someone please review/test? [1] http://test.winehq.org/data/8ef3a142263e6db11f1514f77b3de84c8b08d7a0/mac_fg-snow-macdrv/advapi32:cred.html diff --git a/dlls/dbghelp/module.c

Re: [4/4] ntdll: Properly set flag which indicates buffer empty state.

2013-08-27 Thread Wolfgang Walter
On Tuesday 27 August 2013 21:14:05 Alexandre Julliard wrote: Dmitry Timoshkov dmi...@baikal.ru writes: --- dlls/kernel32/tests/comm.c | 5 + dlls/ntdll/serial.c| 13 + 2 files changed, 6 insertions(+), 12 deletions(-) It doesn't work here:

Re: RFC: Mark dylib/mach-o on Mac OS X

2013-08-27 Thread Ken Thomases
Hi, On Aug 27, 2013, at 4:08 PM, André Hentschel wrote: @@ -94,6 +95,9 @@ static void module_fill_module(const WCHAR* in, WCHAR* out, size_t size) if (len 3 !strcmpiW(out[len - 3], S_DotSoW) (l = match_ext(out, len - 3))) strcpyW(out[len - l - 3],

Re: msvcr90/tests: Add more ARM forwards and use them in tests

2013-08-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26894 Your paranoid

Re: [4/4] ntdll: Properly set flag which indicates buffer empty state.

2013-08-27 Thread Dmitry Timoshkov
Alexandre Julliard julli...@winehq.org wrote: It doesn't work here: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so comm.c touch comm.ok comm.c:835: Test failed: WriteFile took 1 ms to write 17 Bytes at 150 Baud comm.c:848: Test failed: WaitCommEvent

Re: RFC: Mark dylib/mach-o on Mac OS X

2013-08-27 Thread Charles Davis
On Aug 27, 2013, at 3:08 PM, André Hentschel wrote: Hi, at [1] i noticed that dylibs are printed as PEs. This intents to fix that, but i have no Mac, could someone please review/test? [1]

Re: [4/4] ntdll: Properly set flag which indicates buffer empty state.

2013-08-27 Thread Dmitry Timoshkov
Dmitry Timoshkov dmi...@baikal.ru wrote: Alexandre Julliard julli...@winehq.org wrote: It doesn't work here: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so comm.c touch comm.ok comm.c:835: Test failed: WriteFile took 1 ms to write 17 Bytes at

[AppDB] How to deal with hardware/driver dependent test result?

2013-08-27 Thread Felix Yan
Hi, I'm maintaining Spore 1.0, and it works correctly in wine for over a year on Nvidia video card with closed-source nvidia driver - but I do noticed with Intel cards with open source drivers, the game is nearly not playable - missing texture and more problems. Today comes in a new test

Re: kernel32/tests: Remove a useless trace.

2013-08-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26897 Your paranoid

Re: [AppDB] How to deal with hardware/driver dependent test result?

2013-08-27 Thread Austin English
On Tue, Aug 27, 2013 at 8:57 PM, Felix Yan felixonm...@gmail.com wrote: Hi, I'm maintaining Spore 1.0, and it works correctly in wine for over a year on Nvidia video card with closed-source nvidia driver - but I do noticed with Intel cards with open source drivers, the game is nearly not

Re: [2/3] server: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port.

2013-08-26 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@baikal.ru writes: MSDN for FlushFileBuffers says: Flushes the buffers of a specified file and causes all buffered data to be written to a file. Linux man page says: tcdrain() waits until all output written to the object referred to by fd has been transmitted. It's

Re: [2/3] server: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port.

2013-08-26 Thread Wolfgang Walter
Hello Dmitry, we had this problem, too. I sent a patch to wine-devel some time ago (I think 2008). It had the same flaw as yours. I sent a different patch after Alexandre gave me the same answer. I then posted 2009 an different one. It did not make it into wine, though. I don't know why as

Re: [2/3] server: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port.

2013-08-26 Thread Dmitry Timoshkov
Alexandre Julliard julli...@winehq.org wrote: It's a blocking call, you can't do that on the server side. Can then something like in the patch from Wolfgang Walter be done instead? -- Dmitry.

Re: [2/3] server: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port.

2013-08-26 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@baikal.ru writes: Alexandre Julliard julli...@winehq.org wrote: It's a blocking call, you can't do that on the server side. Can then something like in the patch from Wolfgang Walter be done instead? Something like that, yes. -- Alexandre Julliard

Re: Does auto-apt work to get wine dependencies in source code?

2013-08-26 Thread Maarten Lankhorst
Op 25-08-13 14:09, Susan Cragin schreef: Hello, Was thinking of running some tests but the list of dependencies on the website seems outdated, apt-get build-dep does not work. Is that with the ubuntu-wine ppa enabled?

Re: [patch fix]for 98152 and 98151,the encoding type was wrong.

2013-08-26 Thread Akihiro Sagawa
On Sun, 25 Aug 2013 23:13:53 +0900, matyapiro31 wrote: The first one is 0001-add-japanese-man-page-of-wine.patch the second one is 0001-last-change-of-my-translation-of-man-page.patch Please cancel 98152 and 98151and try those two. These translations are outdated. The file seems to be based

Re: [PATCH 2/7] wined3d: Use PBOs for dynamic volumes (try 2)

2013-08-26 Thread Matteo Bruni
2013/8/26 Stefan Dösinger ste...@codeweavers.com: Try 2: *) Require only GPU access for buffers *) Reduce number of checkGLcall invocations *) Remove a return from an ERR case --- dlls/wined3d/utils.c | 1 + dlls/wined3d/volume.c | 168

Re: [PATCH 2/7] wined3d: Use PBOs for dynamic volumes (try 2)

2013-08-26 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-26 16:16, schrieb Matteo Bruni: 2013/8/26 Stefan Dösinger ste...@codeweavers.com: Try 2: *) Require only GPU access for buffers *) Reduce number of checkGLcall invocations *) Remove a return from an ERR case --- dlls/wined3d/utils.c

Re: questions to your commit wineps.drv: Allow for vertical text printing!

2013-08-26 Thread Aric Stewart
Hello Wolfgang, Thanks for the review. On 8/24/13 2:16 PM, Wolfgang Walter wrote: Hello Aric, I read commit 745e7c93c9042f62460f181daaa1f05645560b41 (wineps.drv: Allow for vertical text printing.) and I have some questions: 1) You added the parameter vertical to PSDRV_WriteSetFont() in

Re: ntdll: Store all 'comClass' attributes

2013-08-26 Thread Alexandre Julliard
Nikolay Sivov nsi...@codeweavers.com writes: +while (min = max) +{ +int n, c; + +n = (min+max)/2; + +c = strncmpW(olemisc_values[n].name, str, len); strncmp isn't enough. -- Alexandre Julliard julli...@winehq.org

Re: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port.

2013-08-26 Thread Alexandre Julliard
Wolfgang Walter w...@stwm.de writes: @@ -2749,19 +2752,46 @@ NTSTATUS WINAPI NtFlushBuffersFile( HANDLE hFile, IO_STATUS_BLOCK* IoStatusBlock { NTSTATUS ret; HANDLE hEvent = NULL; - -SERVER_START_REQ( flush_file ) -{ -req-handle = wine_server_obj_handle( hFile

Re: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port.

2013-08-26 Thread Wolfgang Walter
Am Montag, 26. August 2013, 17:13:46 schrieb Alexandre Julliard: Wolfgang Walter w...@stwm.de writes: @@ -2749,19 +2752,46 @@ NTSTATUS WINAPI NtFlushBuffersFile( HANDLE hFile, IO_STATUS_BLOCK* IoStatusBlock { NTSTATUS ret; HANDLE hEvent = NULL; - -

Re: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port.

2013-08-26 Thread Alexandre Julliard
Wolfgang Walter w...@stwm.de writes: Am Montag, 26. August 2013, 17:13:46 schrieb Alexandre Julliard: You probably don't want to fail just because there's no unix fd. What is the correct behaviour if there ist no such handle? Should I only fail in the case FD_FILE_SERIAL ? You'd want to

Re: Use tcdrain() instead of tcflush() to implement FlushFileBuffers() for a COM port.

2013-08-26 Thread Wolfgang Walter
Am Montag, 26. August 2013, 19:55:04 schrieben Sie: Wolfgang Walter w...@stwm.de writes: Am Montag, 26. August 2013, 17:13:46 schrieb Alexandre Julliard: You probably don't want to fail just because there's no unix fd. What is the correct behaviour if there ist no such handle? Should I

Re: Does auto-apt work to get wine dependencies in source code?

2013-08-26 Thread Susan Cragin
Was thinking of running some tests but the list of dependencies on the website seems outdated, apt-get build-dep does not work.Is that with the ubuntu-wine ppa enabled?There are two answers to that question, surprisingly. (1) bitboxIn the instructions it looks like the wine ppa repository can be

Re: [PATCH 1/3] ws2_32: Implement SIO_ADDRESS_LIST_CHANGE with NotifyAddrChange (try 2).

2013-08-26 Thread Bruno Jesus
On Mon, Aug 5, 2013 at 1:24 AM, Erich E. Hoover erich.e.hoo...@gmail.com wrote: The attached patch is the next step in the series of fixes for Silverlight/PlayReady under Wine. This particular patch does not impact Netflix, but it does impact a number of other PlayReady streaming services (and

<    2   3   4   5   6   7   8   9   10   11   >