Re: dlls/explorerframe: build tests with -D__WINESRC__

2013-10-14 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2750 Your paranoid andr

Re: wsock32: Add a fallback for inet_network.

2013-10-14 Thread Alexandre Julliard
Huw Davies writes: > --- > dlls/wsock32/protocol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This doesn't build on MingW: protocol.o: In function `WSOCK32_inet_network@4': /home/julliard/wine/build/obj-pe32/dlls/wsock32/../../../wine/dlls/wsock32/protocol.c:55: undefined referen

RE: Help / Mentoring

2013-10-14 Thread Hugh McMaster
On Monday, 14 October 2013 9:50 PM, Ricardo Filipe wrote: >I'd be more than happy to help you review your patches, although I am no >wineconsole expert, I believe I could help you get your changes into wine. >Contact me if no better offer comes around :) cheers Hello Ricardo, Thank you for you

Re: Help / Mentoring

2013-10-14 Thread Ricardo Filipe
Hello Hugh, I'd be more than happy to help you review your patches, although I am no wineconsole expert, I believe I could help you get your changes into wine. Contact me if no better offer comes around :) cheers 2013/10/11 Hugh McMaster : > Can anyone help me on this? I do realize that winecons

Re: Mono Update

2013-10-14 Thread Ricardo Filipe
IMHO it is more than time. Mono has several release cycles of new features that we are not taking advantage of with wine-mono cheers 2013/10/14 Alistair Leslie-Hughes : > Hi, > > wine-mono hasn't been updated in nearly a year.Should it be time to > consider a new release? > > Thoughts. > > Be

Re: [PATCH] d3drm: added some freeing of memory in error paths (Coverity)

2013-10-14 Thread Henri Verbeet
On 13 October 2013 11:13, Marcus Meissner wrote: > 1104553 Resource leak > Fixing the memory leak is fine of course, but I think it would be better to handle the array initialization in d3drm_visual_array_create() etc. instead, so that those functions actually return an object that's properly init

Re: [2/4] dnsapi/tests: Compile with -D__WINESRC__.

2013-10-14 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2733 Your paranoid andr

Re: *** GMX Spamverdacht *** MSYS touch.exe timestamp resolution issue on Wine-1.6

2013-10-13 Thread Thorsten Kani
Am 12.10.2013 23:28, schrieb Alan W. Irwin: Under MSYS bash.exe if I use the touch command I only get 1-second resolution when reading the results. bash.exe-3.1$ touch touch1.test touch2.test bash.exe-3.1$ ls --full-time touch*.test -rw-r--r-- 1 wine 544 0 2013-10-12 13:57:58.0 -0700 tou

RE: d3d11 patch

2013-10-13 Thread Max .
Hum... WIR= When it's ready ??? Ok ok, i still wait > From: frederic.dela...@gmail.com > Date: Sun, 13 Oct 2013 01:49:04 +0200 > Subject: Re: d3d11 patch > To: asnl...@hotmail.com > CC: wine-devel@winehq.org > > On Fri, Oct 11, 2013 at 7:20 PM, Max . wrote: > >

Re: ntdll: Support pinning module refcount with LdrAddRefDll()

2013-10-13 Thread Nikolay Sivov
On 10/14/2013 05:21, Dmitry Timoshkov wrote: Nikolay Sivov wrote: +FreeLibrary(mod); Please add the tests for FreeLibrary return value. Makes sense, thanks.

Re: ntdll: Support pinning module refcount with LdrAddRefDll()

2013-10-13 Thread Dmitry Timoshkov
Nikolay Sivov wrote: > +FreeLibrary(mod); Please add the tests for FreeLibrary return value. -- Dmitry.

Re: MSYS touch.exe timestamp resolution issue on Wine-1.6

2013-10-13 Thread Peter Rosin
On 2013-10-12 23:28, Alan W. Irwin wrote: > Under MSYS bash.exe if I use the touch command I only get 1-second > resolution when reading the results. > > bash.exe-3.1$ touch touch1.test touch2.test > bash.exe-3.1$ ls --full-time touch*.test > -rw-r--r-- 1 wine 544 0 2013-10-12 13:57:58.0 -

Re: mscoree: Add support for ICLRMetaHostPolicy interface

2013-10-12 Thread Dmitry Timoshkov
Alistair Leslie-Hughes wrote: > +static HRESULT WINAPI metahostpolicy_QueryInterface(ICLRMetaHostPolicy > *iface, REFIID riid, void **ppvObject) > +{ > +TRACE("%s %p\n", debugstr_guid(riid), ppvObject); > + > +if ( IsEqualGUID( riid, &IID_ICLRMetaHostPolicy ) || > + IsEqualGUID(

Re: d3d11 patch

2013-10-12 Thread Frédéric Delanoy
On Fri, Oct 11, 2013 at 7:20 PM, Max . wrote: > Hi, > > I would like to know when the first patchs for d3d11 will be introduce into > wine ? > Beginning of 2014 ? middle 2014 ? End 2014 ? > > Thanks, WIR

Re: winmm/tests: Use BOOL type where appropriate

2013-10-11 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2721 Your paranoid andr

Re: wined3d: Use BOOL type where appropriate

2013-10-11 Thread Henri Verbeet
On 11 October 2013 22:51, Frédéric Delanoy wrote: > -DWORD onesided_enable = FALSE; > -DWORD twosided_enable = FALSE; > +DWORD onesided_enable = 0; > +DWORD twosided_enable = 0; Actually, all of those initializations are redundant.

Re: [PATCH] user32/tests: Test SetUserObjectInformation for invisible winstation.

2013-10-11 Thread Qian Hong
Hmm... It still fails today. I have a better idea to fix it, will send a patch tomorrow. Sorry for introducing the failures :(

Fwd: Re: kernel32/tests: Add tests for job objects (try 7)

2013-10-11 Thread Andrew Cook
(no idea why my client sent this to wine-patches) On 10/10/13 15:23, Andrew Cook wrote: > --- > dlls/kernel32/tests/process.c | 159 > +- > include/winbase.h | 1 + > include/winnt.h | 90 > 3 files chan

RE: Help / Mentoring

2013-10-11 Thread Hugh McMaster
Can anyone help me on this? I do realize that wineconsole is only a minor focus of development. Hugh - Hi everyone, I just wanted to know if anyone would mind helping/mentoring me with a few small patches. I am working primarily on wineconsole'

Re: Fix text rotation problem in GM_ADVANCED graphics mode caused by incorrect implementation of GetTextExtentPointW().

2013-10-10 Thread Ralf Habacker
On 01.10.2013 12:12, Alexandre Julliard wrote: > Ralf Habacker writes: > >> With other patches i have been told to implement such stuff in the dib >> driver. Unfortunally this do not works in this case, because in the top >> level function it looks like having driver specific stuff using display >

Re: xmllite: Use BOOL type where appropriate

2013-10-10 Thread Henri Verbeet
On 10 October 2013 16:59, Frédéric Delanoy wrote: > Basically cleanup/clarity. Using boolean values when expressing > logical expressions results does make sense (and it makes the intent > clearer) IMHO. I just think it would have been nice if we could have used the C99 bool type, but clearly C99

Re: xmllite: Use BOOL type where appropriate

2013-10-10 Thread Frédéric Delanoy
On Thu, Oct 10, 2013 at 12:40 PM, Nikolay Sivov wrote: > On 10/10/2013 00:36, Frédéric Delanoy wrote: >> >> --- >> dlls/xmllite/reader.c | 16 >> 1 file changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/dlls/xmllite/reader.c b/dlls/xmllite/reader.c >> index 0a4423c..a

Re: mshtml: Compile tests with __WINESRC__ define.

2013-10-10 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2689 Your paranoid andr

Re: [PATCH] user32/tests: Test SetUserObjectInformation for invisible winstation.

2013-10-10 Thread Qian Hong
On Thu, Oct 10, 2013 at 8:42 PM, Qian Hong wrote: > Sorry for introduced the failures, I'd like to investigate, however I > can't reproduce the failures on my own Win7. I try to run > winetest-latest.exe on the testbot, but it ran timeout (as expect), is > there any way I can increase the timeout

Re: [PATCH] user32/tests: Test SetUserObjectInformation for invisible winstation.

2013-10-10 Thread Qian Hong
Hello, On Thu, Oct 10, 2013 at 6:48 PM, Alexandre Julliard wrote: > Can you please fix the test failures introduced by your previous changes > first? cf. https://test.winehq.org/data/tests/user32:winstation.html Sorry for introduced the failures, I'd like to investigate, however I can't reprodu

Re: ieframe: Compile tests with __WINESRC__ define.

2013-10-10 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2688 Your paranoid andr

Re: wmvcore: Stub implementation of IWMMetadataEditor interface

2013-10-10 Thread Nikolay Sivov
On 10/10/2013 14:58, Jeff Latimer wrote: --- dlls/wmvcore/Makefile.in| 2 +- dlls/wmvcore/wmvcore_main.c | 100 +++- include/wmsdkidl.idl| 11 ++--- 3 files changed, 105 insertions(+), 8 deletions(-) +typedef struct MetadataEditorImpl {

Re: [PATCH] user32/tests: Test SetUserObjectInformation for invisible winstation.

2013-10-10 Thread Alexandre Julliard
Qian Hong writes: > --- > dlls/user32/tests/winstation.c | 57 > > 1 file changed, 57 insertions(+) Can you please fix the test failures introduced by your previous changes first? cf. https://test.winehq.org/data/tests/user32:winstation.html -- Alex

Re: xmllite: Use BOOL type where appropriate

2013-10-10 Thread Nikolay Sivov
On 10/10/2013 00:36, Frédéric Delanoy wrote: --- dlls/xmllite/reader.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/dlls/xmllite/reader.c b/dlls/xmllite/reader.c index 0a4423c..a216951 100644 --- a/dlls/xmllite/reader.c +++ b/dlls/xmllite/reader.c @@ -72

Re: [PATCH 5/5] user32: Implement better stub of OpenInputDesktop.

2013-10-10 Thread Qian Hong
Hi Vincent, Thanks a lot for the advice, I'll try that. On Thu, Oct 10, 2013 at 12:41 AM, Vincent Povirk wrote: > I don't think it's possible to properly implement SwitchDesktop in > either the X11 or Mac driver. There's just nothing sensible for it to > do. > That's one reason that I didn't try

Re: winemac: Add registry settings to make Option keys send Alt rather than accessing additional characters from the keyboard layout.

2013-10-10 Thread Phil Krylov
Hello, On Thu, Oct 10, 2013 at 3:24 AM, Ken Thomases wrote: > On Oct 9, 2013, at 4:49 PM, Phil Krylov wrote: >> Do you consider adding an option to stop interpreting Command as Alt? > > I have not considered it. What would be gained? Do you want the Command key > interpreted as the Windows key

Re: Fix text rotation problem in GM_ADVANCED graphics mode caused by incorrect implementation of GetTextExtentPointW().

2013-10-09 Thread Ralf Habacker
On 01.10.2013 12:40, Alexandre Julliard wrote: > Ralf Habacker writes: > >> On 01.10.2013 12:12, Alexandre Julliard wrote: >>> Ralf Habacker writes: >>> With other patches i have been told to implement such stuff in the dib driver. Unfortunally this do not works in this case, because in

Re: winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?

2013-10-09 Thread Hamzat
Dears, I faced the same problem, but, unfortunally, link to answer is invalid. Please, tell me, how did you resolve situation? Thanks. -- View this message in context: http://wine.1045685.n5.nabble.com/winspool-ERROR-INVALID-NAME-in-GetDefaultPrinter-tp1788463p5773073.html Sent from the Wine

Re: kernel32/tests: Add tests for job objects (try 7)

2013-10-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2683 Your paranoid andr

Re: ddraw/tests: Use BOOL type where appropriate

2013-10-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2682 Your paranoid andr

Re: winemac: Add registry settings to make Option keys send Alt rather than accessing additional characters from the keyboard layout.

2013-10-09 Thread Ken Thomases
On Oct 9, 2013, at 4:49 PM, Phil Krylov wrote: > Thanks! You're welcome. > Do you consider adding an option to stop interpreting Command as Alt? I have not considered it. What would be gained? Do you want the Command key interpreted as the Windows key? Do you want something else to happen w

Re: winemac: Add registry settings to make Option keys send Alt rather than accessing additional characters from the keyboard layout.

2013-10-09 Thread Phil Krylov
Thanks! Do you consider adding an option to stop interpreting Command as Alt? On Thu, Oct 10, 2013 at 1:30 AM, Ken Thomases wrote: > --- > dlls/winemac.drv/cocoa_window.m | 22 -- > dlls/winemac.drv/macdrv_cocoa.h |2 ++ > dlls/winemac.drv/macdrv_main.c |7 +++ > 3

Re: [PATCH 5/5] user32: Implement better stub of OpenInputDesktop.

2013-10-09 Thread Vincent Povirk
I don't think it's possible to properly implement SwitchDesktop in either the X11 or Mac driver. There's just nothing sensible for it to do. One possible strategy would be to implement SwitchDesktop in user32 and wineserver. Wineserver could logically track the input desktop, and OpenInputDesktop

Re: [PATCH] d3dx9: Move object initialization into a separate function.

2013-10-09 Thread Matteo Bruni
2013/10/9 Rico Schüller : > On 09.10.2013 01:12, Matteo Bruni wrote: >> >> Hi Rico, >> >> 2013/10/8 Rico Schüller : >>> >>> Hi, >>> >>> this moves the object initialization into a separate function, so it >>> could >>> be used for strings and resources. It also removes the STATE_TYPE as we >>> coul

Re: [PATCH 4/5] d3drm: Compare with the correct IID in IDirect3DRMVisualArrayImpl_QueryInterface().

2013-10-09 Thread Henri Verbeet
On 9 October 2013 11:26, Dmitry Timoshkov wrote: > Henri Verbeet wrote: > >> +static HRESULT WINAPI >> IDirect3DRMVisualArrayImpl_QueryInterface(IDirect3DRMVisualArray *iface, >> REFIID riid, void **out) >> { >> -TRACE("(%p)->(%s, %p)\n", iface, debugstr_guid(riid), ret_iface); >> +TRA

Re: [PATCH 4/5] d3drm: Compare with the correct IID in IDirect3DRMVisualArrayImpl_QueryInterface().

2013-10-09 Thread Dmitry Timoshkov
Henri Verbeet wrote: > +static HRESULT WINAPI > IDirect3DRMVisualArrayImpl_QueryInterface(IDirect3DRMVisualArray *iface, > REFIID riid, void **out) > { > -TRACE("(%p)->(%s, %p)\n", iface, debugstr_guid(riid), ret_iface); > +TRACE("iface %p, riid %s, out %p.\n", iface, debugstr_guid(rii

Re: [PATCH] d3dx9: Move object initialization into a separate function.

2013-10-09 Thread Rico Schüller
On 09.10.2013 01:12, Matteo Bruni wrote: Hi Rico, 2013/10/8 Rico Schüller : Hi, this moves the object initialization into a separate function, so it could be used for strings and resources. It also removes the STATE_TYPE as we could distinguish the types at the object level. 1. When an object

Re: ws2_32/tests: Use BOOL type where appropriate

2013-10-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2674 Your paranoid andr

Re: [PATCH] d3dx9: Move object initialization into a separate function.

2013-10-08 Thread Matteo Bruni
Hi Rico, 2013/10/8 Rico Schüller : > Hi, > > this moves the object initialization into a separate function, so it could > be used for strings and resources. It also removes the STATE_TYPE as we > could distinguish the types at the object level. > > 1. When an object has a destination, it points to

Re: [PATCH 5/5] user32: Implement better stub of OpenInputDesktop.

2013-10-08 Thread Qian Hong
Hello, this patch is in pending status, is there any way I can improve it? IMO there is no way to 'correctly' implement OpenInputDesktop before implementing SwitchDesktop, as far as SwitchDesktop is a stub, it is safe to assume that OpenInputDesktop will always return either NULL or Winsta0/Defaul

Re: Wrong status of gdi32

2013-10-08 Thread Austin English
On Tue, Oct 8, 2013 at 11:54 AM, C.W. Betts wrote: > Some of those are probably Wine-specific, and/or are forwarded from other > DLLs. > > On Oct 8, 2013, at 8:35 AM, Akira Nakagawa wrote: > > I found this page shows that gdi32 dll has more than 800 functions,but the > spec file has only 500 .

Re: Wrong status of gdi32

2013-10-08 Thread C.W. Betts
Some of those are probably Wine-specific, and/or are forwarded from other DLLs. On Oct 8, 2013, at 8:35 AM, Akira Nakagawa wrote: > I found this page shows that gdi32 dll has more than 800 functions,but the > spec file has only 500 . > >

RE: binfmt support

2013-10-08 Thread xantares 09
From: xantare...@hotmail.com To: hverb...@gmail.com Subject: RE: binfmt support Date: Mon, 7 Oct 2013 11:47:05 + > Date: Mon, 7 Oct 2013 12:23:30 +0200 > Subject: Re: binfmt support > From: hverb...@gmail.com > To: xantare...@hotmail.com > CC: wine-devel@winehq.org &g

Re: gdi32/tests: Skip linked font like SimSun-ExtB in fixed-pitch font selection.

2013-10-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2669 Your paranoid andr

Re: (try 6)[3/5] imm32: use thread data from target HWND

2013-10-08 Thread Alexandre Julliard
Aric Stewart writes: > @@ -1597,7 +1612,9 @@ BOOL WINAPI ImmGetConversionStatus( > HWND WINAPI ImmGetDefaultIMEWnd(HWND hWnd) > { > HWND ret; > -IMMThreadData* thread_data = IMM_GetThreadData(0); > +IMMThreadData* thread_data = IMM_GetThreadDataForWindow(hWnd); > +if (!thread_d

Re: [PATCH 3/5] wined3d: Handle sRGB_decode when reading the sampler state.

2013-10-08 Thread Henri Verbeet
On 8 October 2013 13:44, Stefan Dösinger wrote: > Are you sure? E.g. if a texture is used with srgb=true and sRGB_decode > is supported, wined3d_texture_bind sets WINED3D_TEXTURE_IS_SRGB. If > the application later calls PreLoad manually, texture2d_preload is > called with SRGB_ANY. Because of the

Re: [1/3] xmllite: Use buffer offset instead of pointers

2013-10-08 Thread Nikolay Sivov
On 10/8/2013 10:56, Alexandre Julliard wrote: Nikolay Sivov writes: On 10/6/2013 19:06, Nikolay Sivov wrote: It's normal to grow destination buffer, in this case all stored pointers will be trashed. This patch uses offsets from start of a buffer instead. Hi, Alexandre. Patches list shows a

Re: [PATCH 3/5] wined3d: Handle sRGB_decode when reading the sampler state.

2013-10-08 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-10-08 12:06, schrieb Henri Verbeet: > On 8 October 2013 00:27, Stefan Dösinger > wrote: >> diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c >> index 52eac16..eb8ca7e 100644 --- a/dlls/wined3d/surface.c +++ >> b/dlls/wined3d/surfac

Re: riched20: Set control content in WM_CREATE message

2013-10-08 Thread Piotr Caban
Hi Akihiro, On 10/08/13 12:51, Akihiro Sagawa wrote: On Sat, 05 Oct 2013 14:54:07 +0200, Piotr Caban wrote: + if (!(editor->styleFlags & ES_MULTILINE)) + { +len = 0; +while(textW[len] != '0' && textW[len] != '\r' && textW[len] != '\n') + len++; + } Alth

Re: riched20: Set control content in WM_CREATE message

2013-10-08 Thread Akihiro Sagawa
On Sat, 05 Oct 2013 14:54:07 +0200, Piotr Caban wrote: > + if (!(editor->styleFlags & ES_MULTILINE)) > + { > +len = 0; > +while(textW[len] != '0' && textW[len] != '\r' && textW[len] != '\n') > + len++; > + } Although this patch has been committed as e660bf6

Re: [PATCH 3/5] wined3d: Handle sRGB_decode when reading the sampler state.

2013-10-08 Thread Henri Verbeet
On 8 October 2013 00:27, Stefan Dösinger wrote: > diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c > index 52eac16..eb8ca7e 100644 > --- a/dlls/wined3d/surface.c > +++ b/dlls/wined3d/surface.c > @@ -5608,8 +5608,6 @@ HRESULT surface_load_location(struct wined3d_surface > *surface, DWO

Re: winemac.drv: add fullscreen mode support for Mac OS X 10.7+

2013-10-08 Thread Ken Thomases
Hi, I finally got around to working on support for Cocoa full-screen mode in the Mac driver, based on the work of Kevin Eaves. I've attached a new patch. This patch can only be applied on top of the other Mac driver patches I just submitted to wine-patches. Some changes from Kevin's original

Re: [1/3] xmllite: Use buffer offset instead of pointers

2013-10-07 Thread Alexandre Julliard
Nikolay Sivov writes: > On 10/6/2013 19:06, Nikolay Sivov wrote: >> It's normal to grow destination buffer, in this case all stored >> pointers will be trashed. This patch uses offsets from start of a >> buffer instead. >> > Hi, Alexandre. > > Patches list shows a build failure for this one, and

Re: msi/tests: Use BOOL type where appropriate (resend)

2013-10-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2667 Your paranoid andr

Re: msi/tests: Use BOOL type where appropriate

2013-10-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2660 Your paranoid andr

Re: [1/3] xmllite: Use buffer offset instead of pointers

2013-10-07 Thread Nikolay Sivov
On 10/6/2013 19:06, Nikolay Sivov wrote: It's normal to grow destination buffer, in this case all stored pointers will be trashed. This patch uses offsets from start of a buffer instead. Hi, Alexandre. Patches list shows a build failure for this one, and I don't see any failures on testbot

Re: mscoree: Partial implement ICLRMetaHost RequestRuntimeLoadedNotification (try 2)

2013-10-07 Thread Vincent Povirk
HRESULT CLRMetaHost_CreateInstance(REFIID riid, void **ppobj) { +GlobalCLRMetaHost.callback = NULL; return ICLRMetaHost_QueryInterface(&GlobalCLRMetaHost.ICLRMetaHost_iface, riid, ppobj); } I don't think we should be changing global state every time someone creates an instance of this

Re: riched20: Set control content in WM_CREATE message

2013-10-07 Thread Alexandre Julliard
Piotr Caban writes: > --- > dlls/riched20/editor.c | 21 + > dlls/riched20/tests/editor.c | 38 ++ > 2 files changed, 59 insertions(+) It doesn't work: ../../../tools/runtest -q -P wine -M riched20.dll -T ../../.. -p riched20_test.

Re: [PATCH 2/3] msvcrt: Add support for vcall thunks demangling (try2)

2013-10-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2651 Your paranoid andr

Re: [PATCH 2/3] msvcrt: Add support for vcall thunks demangling

2013-10-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2649 Your paranoid andr

Re: [PATCH 3/3] msvcrt: Add support for vtordispex demangling

2013-10-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2650 Your paranoid andr

Re: msvcrt: add support for _chsize_s (try #2)

2013-10-07 Thread Piotr Caban
Hi, On 10/06/13 00:45, morphiend wrote: + * _chsize_s (MSVCRT.@) + */ +int CDECL MSVCRT__chsize_s(int fd, __int64 size) +{ +LARGE_INTEGER cur, pos; +LARGE_INTEGER temp = { 0 }; This causes compilation warnings. There's also a trailing space in this line. +TRACE("(fd=%

Re: binfmt support

2013-10-07 Thread Henri Verbeet
On 7 October 2013 12:06, xantares 09 wrote: > ... I don't see a reason why to not include it at the wine level instead of > every linux distros, see: > https://github.com/xantares/wine/commit/76ebd5d29effaf4b6b39ceecb689f7008bf6b376 > > What do you think ? > Ignoring the discussion if we want this

Re: msvcrt: add support for _chsize_s (try #2)

2013-10-06 Thread Henri Verbeet
On 6 October 2013 20:32, Frédéric Delanoy wrote: > On Sun, Oct 6, 2013 at 12:45 AM, morphiend wrote: >> This patch adds the _chsize_s() to the mscvrt and corresponding mscvr*s. >> This was tested on Ubuntu 12.10 using IDA 6.4 as a test application. Without >> the implementation of _chsize_s(), ce

Re: msvcrt: add support for _chsize_s (try #2)

2013-10-06 Thread Frédéric Delanoy
On Sun, Oct 6, 2013 at 12:45 AM, morphiend wrote: > This patch adds the _chsize_s() to the mscvrt and corresponding mscvr*s. > This was tested on Ubuntu 12.10 using IDA 6.4 as a test application. Without > the implementation of _chsize_s(), certain binaries caused an internal crash > of IDA. This

Re: mshtml/tests: Fix compilation on systems that don't support nameless unions.

2013-10-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2637 Your paranoid andr

Re: kernel32/tests: Fix compilation on systems that don't support nameless unions.

2013-10-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2634 Your paranoid andr

Re: d3d9: update locked_rect only if wined3d_surface_map succeeded

2013-10-05 Thread Lasse Rasinen
Stefan Dösinger writes: > Am 2013-10-03 21:45, schrieb Henri Verbeet: >> On 3 October 2013 21:16, Lasse Rasinen wrote: >>> According to debugging output, Artemis Spaceship Bridge Simulator >>> 2.0 calls LockRect twice on the same texture (for whatever >>> reason) and crashes. >>> >>> http://bug

Re: BiDi, Unicode 6.3 and Wine.

2013-10-04 Thread Alexandre Julliard
Aric Stewart writes: > Hello, > > So Unicode 6.3 was just recently released. One of the things it > features is an updated BIDI (Bidirectional) algorithm. This is > revision 29 to the > algorithm. (http://www.unicode.org/reports/tr9/tr9-29.html#Modifications) > Looking at the code I moved from

Re: [3/3] ntdll: Add support for FILE_APPEND_DATA to NtWriteFile. Take 2.

2013-10-04 Thread Alexandre Julliard
Dmitry Timoshkov writes: > @@ -979,6 +986,12 @@ NTSTATUS WINAPI NtWriteFile(HANDLE hFile, HANDLE hEvent, > goto done; > } > > +if (append_write) > +{ > +offset_eof.QuadPart = (LONGLONG)-1; /* FILE_WRITE_TO_END_OF_FILE > */ > +offset

Re: [PATCH 1/5] wined3d: Don't bother about client storage in wined3d_surface_set_mem.

2013-10-04 Thread Stefan Dösinger
Am 04.10.2013 um 17:15 schrieb Henri Verbeet : > I guess that makes it ok in practice, but I'd still feel happier about > this kind of patch if we actually enforced resource access flags > first. (At which point you could also just check the access flags > instead of the pool.) My plan is to enfor

Re: [PATCH 5/5] wininet: Added InternetLockRequestFile tests.

2013-10-04 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2625 Your paranoid andr

Re: [PATCH 1/5] wined3d: Don't bother about client storage in wined3d_surface_set_mem.

2013-10-04 Thread Henri Verbeet
On 4 October 2013 15:51, Stefan Dösinger wrote: > No codepath in wined3d_surface_blt will attempt to load a sysmem surface into > a texture. fbo_blit_supported returns FALSE if src or destination are in > sysmem, and so do arbfp_blit_supported and surface_blt_special. Color fills > will go to a

Re: [PATCH 2/2] advapi32: Don't cache HKCR if WOW64 redirection flags are set

2013-10-04 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2624 Your paranoid andr

Re: BiDi, Unicode 6.3 and Wine.

2013-10-04 Thread Kyle Auble
While I have no experience contributing code to wine itself so far, BiDi or not, I smell a high-level design choice here. If the new revision to the Unicode algorithm looks superior, my first idea would be to try rebasing the code on that and then explicitly overriding it for Windows quirks. I don

Re: [PATCH 1/5] wined3d: Don't bother about client storage in wined3d_surface_set_mem.

2013-10-04 Thread Stefan Dösinger
Am 04.10.2013 um 15:51 schrieb Stefan Dösinger : > No codepath in wined3d_surface_blt will attempt to load a sysmem surface into > a texture. fbo_blit_supported returns FALSE if src or destination are in > sysmem, and so do arbfp_blit_supported and surface_blt_special. Color fills > will go to a

Re: [PATCH 1/5] wined3d: Don't bother about client storage in wined3d_surface_set_mem.

2013-10-04 Thread Stefan Dösinger
Am 04.10.2013 um 15:28 schrieb Henri Verbeet : > On 4 October 2013 15:02, Stefan Dösinger wrote: >> Client storage only applies to GL textures, which won't be created for >> sysmem surfaces. >> > I don't think that's necessarily true at the moment. In particular, > ddraw blits can in principle

Re: [PATCH 1/5] wined3d: Don't bother about client storage in wined3d_surface_set_mem.

2013-10-04 Thread Henri Verbeet
On 4 October 2013 15:02, Stefan Dösinger wrote: > Client storage only applies to GL textures, which won't be created for sysmem > surfaces. > I don't think that's necessarily true at the moment. In particular, ddraw blits can in principle cause a texture to be created for sysmem surfaces. There m

Re: [PATCH 1/5] wined3d: Don't bother about client storage in wined3d_surface_set_mem.

2013-10-04 Thread Henri Verbeet
On 4 October 2013 00:03, Stefan Dösinger wrote: > @@ -2883,10 +2886,6 @@ HRESULT CDECL wined3d_surface_set_mem(struct > wined3d_surface *surface, void *mem > /* Now the surface memory is most up do date. Invalidate drawable > and texture. */ > surface_validate_location(surface,

Re: [PATCH 3/3] winemac: Tell Wine when Cocoa has brought a window to the front.

2013-10-04 Thread Ken Thomases
On Oct 4, 2013, at 12:17 AM, Ken Thomases wrote: > --- > dlls/winemac.drv/cocoa_app.m| 8 ++-- > dlls/winemac.drv/cocoa_window.h | 1 + > dlls/winemac.drv/cocoa_window.m | 16 +--- > dlls/winemac.drv/event.c| 5 + > dlls/winemac.drv/macdrv.h | 1 + > dlls/winem

Re: [PATCH 1/5] wined3d: Store valid locations in the resource.

2013-10-03 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-10-03 16:05, schrieb Henri Verbeet: > I don't think this patch makes sense before you actually unify the > location management. In particular, after this patch you'd have > location management in resources that really only does anything > for

Re: d3d9: update locked_rect only if wined3d_surface_map succeeded

2013-10-03 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-10-03 21:45, schrieb Henri Verbeet: > On 3 October 2013 21:16, Lasse Rasinen wrote: >> According to debugging output, Artemis Spaceship Bridge Simulator >> 2.0 calls LockRect twice on the same texture (for whatever >> reason) and crashes. >>

Re: d3d9: update locked_rect only if wined3d_surface_map succeeded

2013-10-03 Thread Henri Verbeet
On 3 October 2013 21:16, Lasse Rasinen wrote: > According to debugging output, Artemis Spaceship Bridge Simulator 2.0 > calls LockRect twice on the same texture (for whatever reason) and crashes. > > http://bugs.winehq.org/show_bug.cgi?id=34271 > > This change prevents the locked_rect being overwr

Re: kernel32: Add tests for job objects (try 4)

2013-10-03 Thread Alexandre Julliard
Andrew Cook writes: > +sprintf(buffer, "\"%s\" tests/process.c ignored \"%s\"", selfname, > "wait"); > + > +IOPort = CreateIoCompletionPort(INVALID_HANDLE_VALUE, NULL, 0, 1); > +ok(IOPort != INVALID_HANDLE_VALUE, "CreateIoCompletionPort (%d)", > GetLastError()); > + > +JobObject

Re: Looking for an icon for the Mac driver: generic program running under Wine

2013-10-03 Thread Jeremiah Flerchinger
The window for that icon was made from a screenshot of a window from my desktop. The Wine glass was from a png on the WineHQ website. So there should be no copyright issues there, so long as Wine agrees to letting itself use it. I made it in icon composer which only supports up to 512x512 which is

Re: [PATCH 1/5] wined3d: Store valid locations in the resource.

2013-10-03 Thread Henri Verbeet
On 3 October 2013 15:03, Stefan Dösinger wrote: > Am 2013-10-03 13:45, schrieb Henri Verbeet: >> It sounds like you have some ordering issues in that patch set. > Correct. Patches before patch 24 shouldn't be affected by that though. > I didn't get around to splitting and recombining patch 24 and

Re: [PATCH 1/5] wined3d: Store valid locations in the resource.

2013-10-03 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-10-03 13:45, schrieb Henri Verbeet: > On 3 October 2013 13:22, Stefan Dösinger > wrote: >> Will be updated as well. See >> http://www.winehq.org/pipermail/wine-devel/2013-October/101575.html >> >> for the surface part and more explanations.

Re: [PATCH 1/5] wined3d: Store valid locations in the resource.

2013-10-03 Thread Henri Verbeet
On 3 October 2013 13:22, Stefan Dösinger wrote: > Am 2013-10-03 13:14, schrieb Henri Verbeet: >> On 3 October 2013 13:08, Stefan Dösinger >> wrote: >>> --- dlls/wined3d/volume.c | 46 >>> +- >>> dlls/wined3d/wined3d_private.h | 6 -- 2 files cha

Re: [PATCH 1/5] wined3d: Store valid locations in the resource.

2013-10-03 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-10-03 13:14, schrieb Henri Verbeet: > On 3 October 2013 13:08, Stefan Dösinger > wrote: >> --- dlls/wined3d/volume.c | 46 >> +- >> dlls/wined3d/wined3d_private.h | 6 -- 2 files changed,

Re: [PATCH 1/5] wined3d: Store valid locations in the resource.

2013-10-03 Thread Henri Verbeet
On 3 October 2013 13:08, Stefan Dösinger wrote: > --- > dlls/wined3d/volume.c | 46 > +- > dlls/wined3d/wined3d_private.h | 6 -- > 2 files changed, 27 insertions(+), 25 deletions(-) > What about surfaces and buffers?

Re: rpcss: Convert to a service

2013-10-02 Thread Andrew Cook
Ignore this, for some reason this randomly forks a huge number of rpcss instances, and decided to not do so while i was testing it On 03/10/13 14:00, Andrew Cook wrote: > --- > dlls/rpcrt4/rpc_epmap.c | 40 --- > programs/rpcss/Makefile.in | 2 +- > programs/rpcss/rpcss_main

Re: server: Set the unix file write mode bit also for FILE_APPEND_DATA access.

2013-10-02 Thread Dmitry Timoshkov
Dmitry Timoshkov wrote: > diff --git a/server/file.c b/server/file.c > index 2ecf97c..94d3060 100644 > --- a/server/file.c > +++ b/server/file.c > @@ -459,7 +459,7 @@ static mode_t file_access_to_mode( unsigned int access ) > > access = generic_file_map_access( access ); > if (access

Re: [5/5] ws2_32: Always return the source address from WSAAccept.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2610 Your paranoid andr

Re: [4/5] ws2_32: Return an error from accept if the address buffer is too small.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2609 Your paranoid andr

Re: [3/5] ws2_32: Add some tests for getpeername.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2608 Your paranoid andr

  1   2   3   4   5   6   7   8   9   10   >