On Tue, 14 Jul 2026 08:35:00 GMT, Andreas Chmielewski <[email protected]> wrote:
>> https://bugs.openjdk.org/browse/JDK-8387124 >> >> The test times out. This change increases the timeout based on the relative >> execution time of DisabledAlgorithms.java. >> >> Execution times on my system: >> DisabledAlgorithms.java ~11 s (timeout = 480) >> BulkCipherDisabledAlgorithms.java ~53 s >> >> Using the same ratio would result in a timeout of approximately 2300 seconds. >> To avoid setting such a high value, the timeout was reduced and set to 1200, >> which should still provide sufficient margin. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Andreas Chmielewski has updated the pull request incrementally with one > additional commit since the last revision: > > Remove unused imports test/jdk/javax/net/ssl/ciphersuites/BulkCipherDisabledAlgorithms.java line 171: > 169: } > 170: > 171: private static void testCipherSuiteVisibility(String suite, boolean > expectedDisabled) The testCipherSuiteVisibility method was removed entirely. It verified that when a bulk cipher is disabled via jdk.tls.disabledAlgorithms, the corresponding cipher suites are not visible in getSupportedCipherSuites(). The new BulkCipherDecomposition test covers decomposition correctness but does not verify that disabling a bulk cipher makes suites invisible. Either confirm that other existing tests cover this visibility behavior, or add a targeted visibility check (perhaps with just 1-2 representative cipher suites to keep it fast). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31812#discussion_r3593369674
