On Thu, 16 Jul 2026 12:07:36 GMT, Andreas Chmielewski 
<[email protected]> wrote:

>> https://bugs.openjdk.org/browse/JDK-8387124
>> 
>> The test times out. This change increases the timeout based on the relative
>> execution time of DisabledAlgorithms.java.
>> 
>> Execution times on my system:
>>   DisabledAlgorithms.java            ~11 s (timeout = 480)
>>   BulkCipherDisabledAlgorithms.java  ~53 s
>> 
>> Using the same ratio would result in a timeout of approximately 2300 seconds.
>> To avoid setting such a high value, the timeout was reduced and set to 1200,
>> which should still provide sufficient margin.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Andreas Chmielewski has updated the pull request incrementally with two 
> additional commits since the last revision:
> 
>  - Added visibiliy checks; Reduced spanwed VMs
>  - Shorten spawned VMs

test/jdk/javax/net/ssl/ciphersuites/BulkCipherDisabledAlgorithms.java line 113:

> 111:         for (CipherSuite suite : suites) {
> 112:             String suiteName = suite.name();
> 113:             String bulkCipher = extractBulkCipher(suiteName);

We can further reduce the number of VMs by grouping the suites by `bulkCipher`, 
i.e. make `tests` a map with `bulkCipher` as a key and a list of suites as a 
value. Then change the rest of the code accordingly. We really need only a 
single VM per a bulk cipher.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31812#discussion_r3595473049

Reply via email to