On Thu, 16 Jul 2026 13:39:31 GMT, Artur Barashev <[email protected]> wrote:

>> Yes, that's certainly possible. However, I would prefer not to take that 
>> approach.
>> I see this test primarily as a black-box test that iterates over all enabled 
>> cipher suites and verifies that disabling their corresponding bulk cipher 
>> algorithm has the expected effect. The test intentionally does not depend on 
>> the details of the bulk cipher decomposition logic.
>> Grouping cipher suites by bulk cipher would introduce additional logic and 
>> assumptions into the test itself. It would also make the test more complex, 
>> fragile and potentially reduce coverage in the future. At that point, I 
>> think we would be optimizing the test beyond what is necessary.
>
> Hm.. we can do exactly the same with a single VM per a bulk cipher rather 
> than spawning multiple VMs per bulk cipher. I don't see any difference, just 
> run `testHandshake(suite, true);` in a loop from `main` for all suites for a 
> given bulk cipher.

5 spawned VMs now :) Actually you were right. Thx!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31812#discussion_r3603817213

Reply via email to