On Thu, 16 Jul 2026 07:17:47 GMT, sendaoYan <[email protected]> wrote:

>> Andreas Chmielewski has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Remove unused imports
>
> test/jdk/javax/net/ssl/ciphersuites/BulkCipherDisabledAlgorithms.java line 
> 171:
> 
>> 169:     }
>> 170: 
>> 171:     private static void testCipherSuiteVisibility(String suite, boolean 
>> expectedDisabled)
> 
> The testCipherSuiteVisibility method was removed entirely. It verified that 
> when a bulk cipher is disabled via jdk.tls.disabledAlgorithms, the 
> corresponding cipher suites are not visible in getSupportedCipherSuites(). 
> The new BulkCipherDecomposition test covers decomposition correctness but 
> does not verify that disabling a bulk cipher makes suites invisible.
> 
> Either confirm that other existing tests cover this visibility behavior, or 
> add a targeted visibility check (perhaps with just 1-2 representative cipher 
> suites to keep it fast).

Thx. I added this validation again!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31812#discussion_r3595080948

Reply via email to