On Fri, 15 May 2026 11:18:18 GMT, Kevin Walls <[email protected]> wrote:
>> This implements "jcmd on core files" for Linux, and for MiniDumps on Windows >> (MacOS is "future work"). >> jcmd "revives" the VM memory and .so/.dll from the core/minidump, and runs >> the existing native diagnostic command parser and command implementations. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last revision: > > include order src/jdk.attach/share/native/librevival_support/revival_support.c line 40: > 38: #endif > 39: > 40: #ifndef WINDOWS Can this code move to src/jdk.attach/unix/native so that you have a cleaner separate of Unix vs. Windows specific code. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3252407486
