On Fri, 15 May 2026 11:18:18 GMT, Kevin Walls <[email protected]> wrote:
>> This implements "jcmd on core files" for Linux, and for MiniDumps on Windows >> (MacOS is "future work"). >> jcmd "revives" the VM memory and .so/.dll from the core/minidump, and runs >> the existing native diagnostic command parser and command implementations. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last revision: > > include order src/jdk.attach/share/classes/com/sun/tools/attach/spi/AttachProvider.java line 182: > 180: throw new UnsupportedOperationException("Not implemented in base > AttachProvider class"); > 181: } > 182: I looked at the latest API docs for VirtualMachine and AttachProvider and I think it will need another round to improve how the overloads are specified. For the HotSpot provider we can implNote that invoking the 1-arg attach method with an integer id is the equivalent of invoking the 2-arg attach method with that id and an empty path. Same thing for AttachProvider. I'll do another pass over the docs/wording, which I think is mostly okay, and it's just the issues around the overloads to fix before the CSR is finalized. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3252420707
