On Sat, 16 May 2026 07:00:53 GMT, Alan Bateman <[email protected]> wrote:

>> Kevin Walls has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   include order
>
> src/jdk.attach/share/native/librevival_support/revival_support.c line 40:
> 
>> 38: #endif
>> 39: 
>> 40: #ifndef WINDOWS
> 
> Can this code move to src/jdk.attach/unix/native so that you have a cleaner 
> separation of Unix vs. Windows specific code.

Yes, doing that.
If Windows does need something similar, it will be different enough not be in 
the shared directory.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3252729640

Reply via email to