John,

Just one very minor comments ...

John Gu wrote:
> 
> I updated the webrev link and please help review it.

>>>     The below is the 2nd round for web review:
>>>     http://cr.opensolaris.org/~john.gu/libsigsegv/ 

1. usr/src/lib/libsigsegv/install-sfw-64
    I don't think you need the line below anymore ...
      34 typeset -r SHAREDIR=${PREFIX}/share
      35 typeset -r MAN3DIR=${SHAREDIR}/man/man3
    so you could remove them

And I can't remember if you have checked or not ...
you are using the default 'depend' did you check that there are no other 
dependencies?

Its looking good
Paul
-- 
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Business Unit

Reply via email to