Hi Paul,
I updated the webrev link and please help review it.
http://cr.opensolaris.org/~john.gu/libsigsegv/
<http://cr.opensolaris.org/%7Ejohn.gu/libsigsegv/>
I know that the Code Review should involve at least two people,
would you please forward the request to anyone else engaged in webrev?
Thanks,
-John G
John Gu wrote:
> Thanks for your fast reply.
> There is no other dependencies, I followed the below instruction and
> didn't find anything dependent.
>
> 1. edit your sfw-developer.sh script. At the bottom, set SFW_PKGDB
> to point to the package directory of a current Solaris install image.
> # SFW_PKGDB=/net/netinstall/export/nv/s/latest/Solaris_11/Product
> and use bldenv(1) or just set it in your env.
> 2. cd usr/src/pkgdefs
> 3. make check_deps.
>
> Thanks,
> -John G
>
> Paul Cunningham wrote:
>> John,
>>
>> Just one very minor comments ...
>>
>> John Gu wrote:
>>>
>>> I updated the webrev link and please help review it.
>>
>>>>> The below is the 2nd round for web review:
>>>>> http://cr.opensolaris.org/~john.gu/libsigsegv/
>>
>> 1. usr/src/lib/libsigsegv/install-sfw-64
>> I don't think you need the line below anymore ...
>> 34 typeset -r SHAREDIR=${PREFIX}/share
>> 35 typeset -r MAN3DIR=${SHAREDIR}/man/man3
>> so you could remove them
>>
>> And I can't remember if you have checked or not ...
>> you are using the default 'depend' did you check that there are no
>> other dependencies?
>>
>> Its looking good
>> Paul
>
