John, This mainly looks okay to me, but here are a few more comments ...
Paul John Gu wrote: > > According to Paul's comments, I made some code changes for > libsigsegv package porting. > The below is the 2nd round for web review: > http://cr.opensolaris.org/~john.gu/libsigsegv/ 1. usr/src/lib/libsigsegv/install-sfw & usr/src/lib/libsigsegv/install-sfw-64 Don't these install the 'man' pages twice, firstly in install-sfw and then again in install-sfw-64 2. 'man' pages Don't they need the 'Source for nnn is available on http://opensolaris.org' added. Shouldn't they have the CDDL header rather than the 'Free Software Foundation' header if you wrote these. Note, I haven't reviewed the main content of these. -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
