Vivek, Mainly looks good to me, just few minor comments ...
Paul Vivek Titarmare wrote: > > http://cr.opensolaris.org/~vivekrt/6816378-mvel/ 1. usr/src/pkgdefs/SUNWmvel/copyright You should probably add the source owner copyright lines (if there are any) somewhere at the top of this, something like the lines 11-18 in .. "http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/SUNWmeld/copyright"; 2. pkg depend You are using the default 'depend', but doesn't it have a dependency on java ? 3. usr/src/lib/mvel/METADATA I really still don't like them all being put under ... BUGTRAQ: solaris/utility/drools What happens if something else uses the mvel stuff, how do they work out how to report any bugs against mvel ? -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
