See below for my comments on jettison and jodatime ... Paul
Vivek Titarmare wrote: > > Webrev for all the packages are created separately and are uploaded to > cr.opensolaris.org. The url's are as follows: > > http://cr.opensolaris.org/~vivekrt/6816378-mvel/ > http://cr.opensolaris.org/~vivekrt/6816382-jettison/ > http://cr.opensolaris.org/~vivekrt/6816384-jodatime/ > http://cr.opensolaris.org/~vivekrt/6816385-staxapi/ > http://cr.opensolaris.org/~vivekrt/6816386-xpp3min/ > http://cr.opensolaris.org/~vivekrt/6816388-relaxngDatatype/ > http://cr.opensolaris.org/~vivekrt/6816392-jaxen-core/ > http://cr.opensolaris.org/~vivekrt/6816393-janino/ 1. usr/src/pkgdefs/SUNWjettison/pkginfo.tmpl Add pkg version at end of DESC= line 2. usr/src/lib/jettison/jettison-1.0-sources.jar Why a jar file ? 3. SUNWjettison/SUNWjodatime dependencies Does this have a dependency on the java runtime pkg? 4. usr/src/pkgdefs/Makefile Line ... 161 SUNWjoda-time but package dir is .. usr/src/pkgdefs/SUNWjodatime ? 5. usr/src/pkgdefs/SUNWjodatime/copyright & usr/src/pkgdefs/SUNWjettison/copyright Can you add the source code owner copyright lines? -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
