Vivek, This mainly looks okay to me, but see below ..
Paul Vivek Titarmare wrote: > I have posted a webrev for package "jdtcore" which I am porting to > OpenSolaris and would like to request a code review. > > Please see below link > http://cr.opensolaris.org/~vivekrt/6816375-jdtcore/ 1. usr/src/lib/jdtcore/METADATA The SUPPORT: line in missing, see.. "http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines"; 2. SUNWjdtcore pkg dependencies I can't remember if you answered this: Should there be a dependency on the java runtime package (rather than just using default 'depend') ? 3. usr/src/pkgdefs/SUNWjdtcore/prototype_com Should there be a symbolic link to the jar file so it's non-version specific ? eg. jdt-core.jar -> jdt-core-3.2.2.jar END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
