Vivek Titarmare wrote: > Hi Paul, > > No, we do not rename the version. Yes, you are right, the internal build.xml > creates 1.0.1 version jar file. We are not renaming anything. > So the question is do we need to rename it to 1.2.0 after the jar is created > or do we should we keep it as it is?
so to me that sounds like a bug in the stax-api build system; can that be patched the build system to correct it to 1.2.0? (I'm off home) Paul > > -----Original Message----- > From: Paul Cunningham [mailto:paul.cunningham at tadpole.com] > Sent: Wednesday, April 08, 2009 8:28 PM > To: Vivek Titarmare > Cc: sfwnv-discuss at opensolaris.org > Subject: Re: [sfwnv-discuss] Request code review for "janino", "jettison", > "jaxen-core", "jodatime", "mvel", "relaxngDatatype", "staxapi" & "xpp3min" > > Re: build of stax-api-1.2.0 ... > > Vivek Titarmare wrote: > ... cut .. >> For the versions conflict there are different versions and we have to keep >> those versions as it is. >> The versioning looks wrong here .. >> 71 _install N stax-api-1.0.1.jar ${JARDIR}/stax-api-1.2.0.jar 444 > --> >> build.xml itself created stax-api-1.0.1.jar, while the source folder > version >> is 1.2.0. The registered version is 1.2.0. Do we need to change this to >> 1.0.1 for all, let us know. >> 72 _install L stax-api-1.2.0.jar ${JARDIR}/stax-api.jar 444 >> >> The version in point 6 probably need to be changed. > > So now I am very confused! :-( > > Are you say that when you build from stax-src-1.2.0.zip it creates a jar > file with version 1.0.1 as its version (instead of 1.2.0) ? > This you then rename in your install-sfw script, as below ... > > You asked .. >> Do we need to change this to 1.0.1 for all, let us know. > > To me, if you are building version 1.2.0 and you end up with 1.0.1 then > something needs changing. > > Paul :-) > > ... cut ... > >>> 1. usr/src/lib/stax-api/install-sfw > ... cut .. >>> The versioning looks wrong here .. >>> 71 _install N stax-api-1.0.1.jar ${JARDIR}/stax-api-1.2.0.jar 444 >>> 72 _install L stax-api-1.2.0.jar ${JARDIR}/stax-api.jar 444 >>> You could also use a version var passed in from >>> Makefile.sfw instead of hard coding it. > > .. cut ... > >>> 6. usr/src/pkgdefs/SUNWstaxapi/prototype_com >>> Line .. >>> 156 s none usr/share/lib/java/stax-api.jar=stax-api-1.0.1.jar >>> is version number right ? > > -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
