Hi Paul, Almost all the points mentioned below are completed except points 4 & 5. No specific copyright owner was found for both the packages.
Point No 5: we were using junit as a reference. We did not find any dependency related to java in the depend file (all listed dependencies are the default dependencies). Do we need to mention java in the depend file for all the packages? Is there any example available for the same? This will help me add the dependency in all the packages. Let me know. Let me know. The links for both the packages are as follows: http://cr.opensolaris.org/~vivekrt/6816375-jdtcore http://cr.opensolaris.org/~vivekrt/6816387-objectasm Thanks, ~Vivek R. Titarmare -----Original Message----- From: Paul Cunningham [mailto:[email protected]] Sent: Tuesday, April 07, 2009 2:12 PM To: Vivek Titarmare Cc: sfwnv-discuss at opensolaris.org; Drools_team at sun.com Subject: Re: [sfwnv-discuss] Request code review for "objectasm" & "jdtcore" See below for my comments ... Paul :-) PS. I will look at your others as well Vivek Titarmare wrote: > I have posted a webrev for packages "objectasm" & "jdtcore" which I am > porting to OpenSolaris and would like to request a code review. > > Please see > http://cr.opensolaris.org/~vivekrt/6816375-jdtcore/ > http://cr.opensolaris.org/~vivekrt/6816387-asm/ > > and provide any comments as needed if there are any issues which I need > to correct. 1. usr/src/lib/jdtcore/METADATA & usr/src/lib/asm/METADATA Just my normal comment about the BUGTRAQ: for drools 2. usr/src/lib/jdtcore/Makefile.sfw Line ... 32 VAR=eclipse-sourceBuild-srcIncluded-3.2.2 could the '3.2.2' be got from $(COMPONENT_VERSION:sh) ? 3. usr/src/lib/jdtcore/install-sfw the lines with ... eclipse-sourceBuild-srcIncluded-3.2.2 on them; could you have used ${VERS} instead ? Line 66 ... 66 cd ${TOP}/eclipse-sourceBuild-srcIncluded-3.2.2 looks redundant. 4. usr/src/pkgdefs/SUNWjdtcore/copyright Add any source code owner copyright lines near top 5. depend (both packages) Should this pkg have a dependency on the java runtime pkg ? 6. usr/src/pkgdefs/SUNWasm/pkginfo.tmpl On the DESC= line put the pkg version number in brackets, eg. .. DESC="........... (3.1)" 7. package name SUNWasm I personally do not like this pkg name, could it be changed to something less confusing? (but what? - maybe SUNWobjectasm) 8. usr/src/pkgdefs/SUNWasm/prototype_com Cosmetic: add missing # on line 1 END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
