Hi Rick, Finally, when the code is putback all the packages would go in the single makefile as it is which is sent for the code review. I had sent a mail to Paul regarding the common Makefile for all the packages and he had agreed on the same. So that should not be a problem.
While the bugtraq is getting resolved, we have submitted the code for the code review with the options provided by you for the bug category. Let me know if you require any other inputs. Thanks, ~Vivek R. Titarmare -----Original Message----- From: Richard.Matthews at Sun.COM [mailto:[email protected]] Sent: Tuesday, April 07, 2009 7:22 PM To: Vivek Titarmare Cc: sfwnv-discuss at opensolaris.org; Drools_team at sun.com Subject: Re: Request code review for "objectasm" & "jdtcore" Vivek Titarmare wrote: > > Hi, > > > > I have posted a webrev for packages "objectasm" & "jdtcore" which I am > porting to OpenSolaris and would like to request a code review. > > Please see > > > > http://cr.opensolaris.org/~vivekrt/6816375-jdtcore/ > <http://cr.opensolaris.org/%7Evivekrt/6816375-jdtcore/> > > > > http://cr.opensolaris.org/~vivekrt/6816387-asm/ > <http://cr.opensolaris.org/%7Evivekrt/6816387-asm/> > > > > and provide any comments as needed if there are any issues which I > need to correct. > > > > Thanks, > > ~Vivek R. Titarmare > > > Changes look OK to me. Some obvious nits (so they are not forgotten). The makefiles are those of several reviews folded together (including both of these). Make sure to separate as needed for submittal. It looks like the issue of the bugtraq category has yet to be resolved. I like the suggestion that they not be Drools dependent, but be stand-alone packages. -- --------------------------------------------------------------------- Rick Matthews email: Rick.Matthews at sun.com Sun Microsystems, Inc. phone:+1(651) 554-1518 1270 Eagan Industrial Road phone(internal): 54418 Suite 160 fax: +1(651) 554-1540 Eagan, MN 55121-1231 USA main: +1(651) 554-1500 ---------------------------------------------------------------------
