See below for my comments ... Paul :-)
PS. I will look at your others as well Vivek Titarmare wrote: > I have posted a webrev for packages "objectasm" & "jdtcore" which I am > porting to OpenSolaris and would like to request a code review. > > Please see > http://cr.opensolaris.org/~vivekrt/6816375-jdtcore/ > http://cr.opensolaris.org/~vivekrt/6816387-asm/ > > and provide any comments as needed if there are any issues which I need > to correct. 1. usr/src/lib/jdtcore/METADATA & usr/src/lib/asm/METADATA Just my normal comment about the BUGTRAQ: for drools 2. usr/src/lib/jdtcore/Makefile.sfw Line ... 32 VAR=eclipse-sourceBuild-srcIncluded-3.2.2 could the '3.2.2' be got from $(COMPONENT_VERSION:sh) ? 3. usr/src/lib/jdtcore/install-sfw the lines with ... eclipse-sourceBuild-srcIncluded-3.2.2 on them; could you have used ${VERS} instead ? Line 66 ... 66 cd ${TOP}/eclipse-sourceBuild-srcIncluded-3.2.2 looks redundant. 4. usr/src/pkgdefs/SUNWjdtcore/copyright Add any source code owner copyright lines near top 5. depend (both packages) Should this pkg have a dependency on the java runtime pkg ? 6. usr/src/pkgdefs/SUNWasm/pkginfo.tmpl On the DESC= line put the pkg version number in brackets, eg. .. DESC="........... (3.1)" 7. package name SUNWasm I personally do not like this pkg name, could it be changed to something less confusing? (but what? - maybe SUNWobjectasm) 8. usr/src/pkgdefs/SUNWasm/prototype_com Cosmetic: add missing # on line 1 END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
