Vivek, See comments below ..
Paul Vivek Titarmare wrote: > I have posted a webrev for package "jaxen-core" which I am porting to > OpenSolaris and would like to request a code review. > > Please see below link > http://cr.opensolaris.org/~vivekrt/6816392-jaxen-core/ 1. usr/src/lib/jaxen-core/METADATA Why the reference to '-core' in the below .. 2 PROGRAM: jaxen-core 4 PACKAGE: SUNWjaxen-core (and through other files), when I don't think the package's home-page refers to it in that way ? 2. usr/src/lib/jaxen-core/install-sfw Pass in the version number from Malefile.sfw on ... 70 _install N jaxen-core-1.1.1.jar ${JARDIR}/jaxen-core-1.1.1.jar . 71 _install L jaxen-core-1.1.1.jar ${JARDIR}/jaxen-core.jar 444 3. usr/src/lib/jaxen-core/sunman/jaxen-core.3 Version number on ... /usr/share/lib/java/jaxen-core-1.1.1.jar 4. usr/src/pkgdefs/SUNWjaxen-core/Makefile Delete null .. 31 DATAFILES= 5. usr/src/pkgdefs/SUNWjaxen-core/depend Top of file format Copyright year 6. usr/src/pkgdefs/SUNWjaxen-core/copyright What is line 1 ? END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
